Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(12 errors, 36 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

local/assignsubmission_download/classes/local/filerenaming.php
(#316) Line indented incorrectly; expected at least 16 spaces, found 15
(#318) Line indented incorrectly; expected at least 16 spaces, found 15
(#319) Line indented incorrectly; expected at least 16 spaces, found 15
(#326) Expected "if (...) {\n"; found "if (...) {\n"
(#326) The use of function sizeof() is forbidden; use count() instead
(#326) Expected 1 space before ">"; 2 found
(#331) The use of function sizeof() is forbidden; use count() instead
(#337) Expected "if (...) {\n"; found "if (...) {\n"
(#382) Inline comments must start with a capital letter, digit or 3-dots sequence
(#382) Inline comments must end in full-stops, exclamation marks, or question marks
(#382) No space found before comment text; expected "// todo Kick out files out of the cut off date here if they have there own time stamp" but found "//todo Kick out files out of the cut off date here if they have there own time stamp"
(#383) Empty IF statement detected
local/assignsubmission_download/classes/local/printpreview.php
(#153) Line exceeds 132 characters; contains 133 characters
(#254) Line exceeds 132 characters; contains 163 characters
(#283) Line exceeds 132 characters; contains 133 characters
local/assignsubmission_download/filerenamingsettingsform.php
(#140) Line exceeds 132 characters; contains 136 characters
(#142) This comment is 63% valid code; is this commented out code?
(#144) Inline comments must end in full-stops, exclamation marks, or question marks
local/assignsubmission_download/lang/en/local_assignsubmission_download.php
(#34) Whitespace found at end of line within string
local/assignsubmission_download/locallib.php
(#30) Line exceeds 132 characters; contains 145 characters
(#45) Line exceeds 132 characters; contains 135 characters
(#49) Line exceeds 132 characters; contains 139 characters
(#84) Inline comments must end in full-stops, exclamation marks, or question marks
(#112) Commas (,) must be followed by white space.
local/assignsubmission_download/mtablepdf.php
(#28) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#126) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#175) This comment is 67% valid code; is this commented out code?
(#177) This comment is 67% valid code; is this commented out code?
(#178) This comment is 67% valid code; is this commented out code?
(#181) This comment is 67% valid code; is this commented out code?
(#185) This comment is 67% valid code; is this commented out code?
(#186) This comment is 67% valid code; is this commented out code?
(#189) This comment is 67% valid code; is this commented out code?
(#191) This comment is 67% valid code; is this commented out code?
(#202) This comment is 67% valid code; is this commented out code?
(#203) This comment is 67% valid code; is this commented out code?
(#206) This comment is 67% valid code; is this commented out code?
(#210) This comment is 67% valid code; is this commented out code?
(#212) This comment is 67% valid code; is this commented out code?
(#215) This comment is 67% valid code; is this commented out code?
(#217) This comment is 67% valid code; is this commented out code?
(#247) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#301) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#319) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#331) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#440) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#588) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
local/assignsubmission_download/printpreviewsettingsform.php
(#71) Line exceeds 132 characters; contains 152 characters

Javascript coding style problems

(0 errors, 20 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

local/assignsubmission_download/amd/src/filerenaming_groupingtoggle.js
(#33) Unexpected empty function. (no-empty-function)
(#56) Unexpected space before function parentheses. (space-before-function-paren)
(#58) Unexpected space before function parentheses. (space-before-function-paren)
(#60) Unexpected space before function parentheses. (space-before-function-paren)
local/assignsubmission_download/amd/src/filerenaming_grouptoggle.js
(#33) Unexpected empty function. (no-empty-function)
local/assignsubmission_download/amd/src/filerenaming_tagsupport.js
(#33) Unexpected empty function. (no-empty-function)
(#36) Identifier 'add_tag' is not in camel case. (camelcase)
local/assignsubmission_download/amd/src/printpreviewer.js
(#33) Unexpected empty function. (no-empty-function)
(#36) Identifier 'change_in_perpage' is not in camel case. (camelcase)
(#42) Expected space(s) after "if". (keyword-spacing)
(#54) Identifier 'change_in_optimum' is not in camel case. (camelcase)
(#60) Expected space(s) after "if". (keyword-spacing)
(#76) Requires a space after '{'. (block-spacing)
(#76) Statement inside of curly braces should be on next line. (brace-style)
(#76) Requires a space before '}'. (block-spacing)
(#76) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#81) Multiple spaces found before '='. (no-multi-spaces)
(#82) Multiple spaces found before '='. (no-multi-spaces)
(#86) Unexpected space before function parentheses. (space-before-function-paren)
(#129) Expected space(s) after "if". (keyword-spacing)

CSS problems

(29 errors, 3 warnings)

This section shows CSS problems detected by stylelint [More info]

local/assignsubmission_download/styles.css
(#59) Expected "#D9D9D9" to be "#d9d9d9" (color-hex-case)
(#99) Expected "#dddddd" to be "#ddd" (color-hex-length)
(#87) Expected a trailing semicolon (declaration-block-trailing-semicolon)
(#92) Expected a trailing semicolon (declaration-block-trailing-semicolon)
(#31) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#35) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#39) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#40) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#44) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#48) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#52) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#53) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#57) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#58) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#59) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#63) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#67) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#72) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#73) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#74) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#78) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#82) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#87) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#92) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#96) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#97) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#98) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#99) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#104) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#105) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#109) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#98) Unexpected unit (length-zero-no-unit)

PHPDocs style problems

(63 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

local/assignsubmission_download/classes/event/assignsubmission_download_table_downloaded.php
(#20) Package local is not valid
(#34) Package local is not valid
local/assignsubmission_download/classes/event/assignsubmission_download_table_viewed.php
(#20) Package local is not valid
(#40) Package local is not valid
local/assignsubmission_download/classes/local/filerenaming.php
(#20) Package local is not valid
(#46) Package local is not valid
(#275) Phpdocs for function filerenaming::download_submissions has incomplete parameters list
(#56) Not recommended phpdocs tag @global used
local/assignsubmission_download/classes/local/printpreview.php
(#20) Package local is not valid
(#47) Package local is not valid
(#57) Not recommended phpdocs tag @global used
local/assignsubmission_download/classes/privacy/provider.php
(#20) Package local is not valid
(#38) Package local is not valid
(#48) Function provider::get_metadata is not documented
local/assignsubmission_download/db/access.php
(#42) Package local is not valid
local/assignsubmission_download/filerenamingsettingsform.php
(#20) Package local is not valid
(#36) Package local is not valid
local/assignsubmission_download/groupsactivitymenu.php
(#20) Package local is not valid
(#33) Package local is not valid
(#45) Function moodlequickform_groupsactivitymenu::__construct is not documented
(#52) Function moodlequickform_groupsactivitymenu::getvalue is not documented
(#56) Function moodlequickform_groupsactivitymenu::set_data is not documented
(#81) Function moodlequickform_groupsactivitymenu::tohtml is not documented
(#132) Function moodlequickform_groupsactivitymenu::render_single_select is not documented
(#40) Variable moodlequickform_groupsactivitymenu::$cm is not documented
(#41) Variable moodlequickform_groupsactivitymenu::$url is not documented
(#42) Variable moodlequickform_groupsactivitymenu::$aag is not documented
(#43) Variable moodlequickform_groupsactivitymenu::$groupmode is not documented
local/assignsubmission_download/lang/en/local_assignsubmission_download.php
(#20) Package local is not valid
local/assignsubmission_download/lib.php
(#20) Package local is not valid
local/assignsubmission_download/locallib.php
(#20) Package local is not valid
(#30) Constant FILERENAMING_TAGS is not documented
(#36) Phpdocs for function filerenaming_rename_file has incomplete parameters list
(#172) Phpdocs for function replace_custom has incomplete parameters list
local/assignsubmission_download/mtablepdf.php
(#20) Package mtablepdf is not valid
(#35) Package mod_checkmark is not valid
local/assignsubmission_download/printpreviewsettingsform.php
(#20) Package local is not valid
(#35) Package local is not valid
local/assignsubmission_download/printpreviewtable.php
(#21) Package local is not valid
(#37) Package local is not valid
(#17) No one-line description found in phpdocs for file
(#73) Phpdocs for function printpreview_table::__construct has incomplete parameters list
(#832) Phpdocs for function printpreview_table::export_class_instance has incomplete parameters list
local/assignsubmission_download/ptablepdf.php
(#20) Package local is not valid
(#36) Package local is not valid
(#49) Function table_pdf_export_format::start_document is not documented
(#53) Function table_pdf_export_format::start_table is not documented
(#58) Function table_pdf_export_format::output_headers is not documented
(#62) Function table_pdf_export_format::add_seperator is not documented
(#66) Function table_pdf_export_format::setup_table is not documented
(#178) Function table_pdf_export_format::add_data is not documented
(#193) Function table_pdf_export_format::finish_table is not documented
(#197) Function table_pdf_export_format::finish_document is not documented
(#43) Variable table_pdf_export_format::$pdf is not documented
(#44) Variable table_pdf_export_format::$filename is not documented
(#45) Variable table_pdf_export_format::$columns is not documented
(#46) Variable table_pdf_export_format::$widths is not documented
(#47) Variable table_pdf_export_format::$rownum is not documented
local/assignsubmission_download/renderer.php
(#20) Package local is not valid
(#32) Package local is not valid
(#42) Phpdocs for function local_assignsubmission_download_renderer::render_printpreview_table has incomplete parameters list
local/assignsubmission_download/settings.php
(#20) Package local is not valid
local/assignsubmission_download/version.php
(#20) Package local is not valid
local/assignsubmission_download/view_filerenaming.php
(#20) Package local is not valid
local/assignsubmission_download/view_printpreview.php
(#20) Package local is not valid

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]