Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]

PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(0 errors, 29 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

course/format/topcoll/classes/activity.php: (#590) This comment is 50% valid code; is this commented out code?
course/format/topcoll/classes/output/renderer.php: (#724) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
course/format/topcoll/tests/courseformatlib_test.php: (#63) Test method test_set_up() is missing any coverage information, own or at class level; (#91) Test method test_reset_opacity() is missing any coverage information, own or at class level; (#116) Test method test_reset_all_opacity() is missing any coverage information, own or at class level; (#136) Test method test_showadditionalmoddata_default_yes() is missing any coverage information, own or at class level; (#154) Test method test_showadditionalmoddata_reset() is missing any coverage information, own or at class level
course/format/topcoll/tests/courseformatrenderer_test.php: (#136) Test method test_start_section_list() is missing any coverage information, own or at class level; (#148) Test method test_start_toggle_section_list() is missing any coverage information, own or at class level; (#161) Test method test_page_title() is missing any coverage information, own or at class level; (#170) Test method test_section_right_content() is missing any coverage information, own or at class level; (#196) Test method test_section_left_content() is missing any coverage information, own or at class level; (#218) Test method test_section_summary() is missing any coverage information, own or at class level; (#258) Test method test_topcoll_section() is missing any coverage information, own or at class level; (#283) Line exceeds 132 characters; contains 136 characters; (#331) Test method test_section_hidden() is missing any coverage information, own or at class level; (#359) Test method test_stealth_section() is missing any coverage information, own or at class level; (#387) This comment is 62% valid code; is this commented out code?; (#440) Test method test_multiple_section_page_horizontal() is missing any coverage information, own or at class level; (#463) Test method test_multiple_section_page_vertical() is missing any coverage information, own or at class level; (#488) Test method test_multiple_section_page_no_sections() is missing any coverage information, own or at class level; (#507) Test method test_toggle_all() is missing any coverage information, own or at class level; (#532) Test method test_display_instructions() is missing any coverage information, own or at class level
course/format/topcoll/tests/courseformattoolbox_test.php: (#40) Test method test_hex2rgba() is missing any coverage information, own or at class level
course/format/topcoll/tests/privacy_provider_test.php: (#103) Test method test_get_metadata() is missing any coverage information, own or at class level; (#113) Test method test_export_user_preferences_no_pref() is missing any coverage information, own or at class level; (#125) Test method test_export_user_preferences() is missing any coverage information, own or at class level
course/format/topcoll/tests/togglelib_test.php: (#34) Test method test_decode_toggle_state() is missing any coverage information, own or at class level
course/format/topcoll/version.php: (#35) This comment is 50% valid code; is this commented out code?

Javascript coding style problems

(17 errors, 78 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

course/format/topcoll/amd/src/local/content.js: (#144) Operator '+' must be spaced. (space-infix-ops)
course/format/topcoll/js/tc_colourpopup.js: (#34) Identifier 'init_tccolour_popup' is not in camel case. (camelcase); (#35) Missing space before opening brace. (space-before-blocks); (#40) Extra space after key 'box'. (key-spacing); (#41) Extra space after key 'input'. (key-spacing); (#42) Extra space after key 'swatch'. (key-spacing); (#43) Extra space after key 'image'. (key-spacing); (#44) Extra space after key 'preview'. (key-spacing); (#45) Extra space after key 'current'. (key-spacing); (#46) Extra space after key 'eventClick'. (key-spacing); (#47) Extra space after key 'eventFocus'. (key-spacing); (#48) Extra space after key 'eventMouseEnter'. (key-spacing); (#49) Extra space after key 'eventMouseLeave'. (key-spacing); (#50) Extra space after key 'eventMouseMove'. (key-spacing); (#51) Extra space after key 'width'. (key-spacing); (#52) Extra space after key 'height'. (key-spacing); (#53) Extra space after key 'factor'. (key-spacing); (#57) Extra space after key 'init'. (key-spacing); (#65) This line has a length of 139. Maximum allowed is 132. (max-len); (#67) This line has a length of 143. Maximum allowed is 132. (max-len); (#70) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops); (#71) 'e' is defined but never used. (no-unused-vars); (#71) Missing space before opening brace. (space-before-blocks); (#81) A space is required after ','. (comma-spacing); (#86) 'e' is defined but never used. (no-unused-vars); (#89) Extra space after key 'showColours'. (key-spacing); (#89) 'e' is defined but never used. (no-unused-vars); (#93) Extra space after key 'setColour'. (key-spacing); (#93) 'e' is defined but never used. (no-unused-vars); (#97) Extra space after key 'startFollow'. (key-spacing); (#97) 'e' is defined but never used. (no-unused-vars); (#100) Missing space before opening brace. (space-before-blocks); (#102) Comments should not begin with a lowercase character. (capitalized-comments); (#102) Expected space or tab after '//' in comment. (spaced-comment); (#109) Extra space after key 'endFollow'. (key-spacing); (#109) 'e' is defined but never used. (no-unused-vars); (#112) A space is required after ','. (comma-spacing); (#118) Extra space after key 'pickColour'. (key-spacing); (#129) Extra space after key 'determineColour'. (key-spacing); (#136) A space is required after ','. (comma-spacing); (#136) A space is required after ','. (comma-spacing); (#139) Multiple spaces found before '0'. (no-multi-spaces); (#139) There should be no space after '['. (array-bracket-spacing); (#139) Multiple spaces found before '1'. (no-multi-spaces); (#139) Multiple spaces found before '0'. (no-multi-spaces); (#140) There should be no space after '['. (array-bracket-spacing); (#140) Multiple spaces found before '0'. (no-multi-spaces); (#140) Multiple spaces found before '0'. (no-multi-spaces); (#141) Multiple spaces found before '0'. (no-multi-spaces); (#141) There should be no space after '['. (array-bracket-spacing); (#141) Multiple spaces found before '0'. (no-multi-spaces); (#141) Multiple spaces found before '1'. (no-multi-spaces); (#142) Multiple spaces found before '0'. (no-multi-spaces); (#142) There should be no space after '['. (array-bracket-spacing); (#142) Multiple spaces found before '0'. (no-multi-spaces); (#143) Multiple spaces found before '1'. (no-multi-spaces); (#143) There should be no space after '['. (array-bracket-spacing); (#143) Multiple spaces found before '0'. (no-multi-spaces); (#143) Multiple spaces found before '0'. (no-multi-spaces); (#144) Multiple spaces found before '0'. (no-multi-spaces); (#144) There should be no space after '['. (array-bracket-spacing); (#144) Multiple spaces found before '0'. (no-multi-spaces); (#180) Identifier 'convert_rgb_to_hex' is not in camel case. (camelcase); (#180) Extra space after key 'convert_rgb_to_hex'. (key-spacing)
course/format/topcoll/module.js: (#34) Identifier 'format_topcoll' is not in camel case. (camelcase); (#200) Identifier 'toggle_topic' is not in camel case. (camelcase); (#248) A space is required after ','. (comma-spacing); (#248) A space is required after ','. (comma-spacing); (#249) A space is required after ','. (comma-spacing); (#249) A space is required after ','. (comma-spacing); (#256) A space is required after ','. (comma-spacing); (#260) A space is required after ','. (comma-spacing); (#268) Identifier 'save_toggles' is not in camel case. (camelcase); (#276) Identifier 'is_old_preference' is not in camel case. (camelcase); (#288) Identifier 'convert_to_new_preference' is not in camel case. (camelcase); (#303) 'logbintext' is assigned a value but never used. (no-unused-vars); (#306) Unexpected use of '<<'. (no-bitwise); (#316) Identifier 'set_toggle_state' is not in camel case. (camelcase); (#323) Unexpected use of '|='. (no-bitwise); (#327) Unexpected use of '&='. (no-bitwise); (#327) Unexpected use of '~'. (no-bitwise); (#331) A space is required after ','. (comma-spacing); (#336) Identifier 'get_required_digits' is not in camel case. (camelcase); (#341) Identifier 'get_toggle_pos' is not in camel case. (camelcase); (#346) Identifier 'get_min_digit' is not in camel case. (camelcase); (#351) Identifier 'get_max_digit' is not in camel case. (camelcase); (#356) Identifier 'get_toggle_flag' is not in camel case. (camelcase); (#383) Identifier 'decode_character_to_value' is not in camel case. (camelcase); (#388) Identifier 'encode_value_to_character' is not in camel case. (camelcase); (#404) Identifier 'set_user_preference' is not in camel case. (camelcase); (#409) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap); (#409) 'YUI' is not defined. (no-undef); (#410) This line has a length of 185. Maximum allowed is 132. (max-len); (#419) This line has a length of 245. Maximum allowed is 132. (max-len); (#419) Unexpected console statement. (no-console)

CSS problems

(16 errors, 3 warnings)

This section shows CSS problems detected by stylelint [More info]

course/format/topcoll/styles.css: (#639) Expected single space before "{" (block-opening-brace-space-before); (#762) Expected single space before "{" (block-opening-brace-space-before); (#778) Expected single space after ":" with a single-line declaration (declaration-colon-space-after); (#658) Unexpected !important (declaration-no-important); (#82) Expected line length to be no more than 132 characters (max-line-length); (#602) Expected line length to be no more than 132 characters (max-line-length); (#636) Expected line length to be no more than 132 characters (max-line-length); (#852) Expected single space after ">" (selector-combinator-space-after); (#852) Expected single space before ">" (selector-combinator-space-before); (#586) Expected newline after "," (selector-list-comma-newline-after); (#587) Expected newline after "," (selector-list-comma-newline-after); (#593) Expected newline after "," (selector-list-comma-newline-after); (#1022) Expected newline after "," (selector-list-comma-newline-after); (#1022) Expected newline after "," (selector-list-comma-newline-after); (#407) Unexpected whitespace before "," (selector-list-comma-space-before); (#567) Expected indentation of 4 spaces (indentation)
course/format/topcoll/styles_adaptable.css: (#35) Unexpected shorthand "border-radius" after "border-bottom-right-radius" (declaration-block-no-shorthand-property-overrides); (#35) Unexpected shorthand "border-radius" after "border-bottom-left-radius" (declaration-block-no-shorthand-property-overrides)
course/format/topcoll/styles_boost.css: (#37) Expected indentation of 4 spaces (indentation)

PHPDocs style problems

(35 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

course/format/topcoll/backup/moodle2/restore_format_topcoll_plugin.class.php: (#70) Phpdocs for function restore_format_topcoll_plugin::process_topcoll has incomplete parameters list
course/format/topcoll/classes/activity.php: (#791) Phpdocs for function activity::userenrolmentcreated has incomplete parameters list; (#803) Phpdocs for function activity::userenrolmentupdated has incomplete parameters list; (#815) Phpdocs for function activity::userenrolmentdeleted has incomplete parameters list; (#878) Phpdocs for function activity::modulecreated has incomplete parameters list; (#888) Phpdocs for function activity::moduleupdated has incomplete parameters list; (#898) Phpdocs for function activity::modulechanged has incomplete parameters list; (#922) Phpdocs for function activity::moduledeleted has incomplete parameters list
course/format/topcoll/classes/output/renderer.php: (#576) Phpdocs for function renderer::section_heading has incomplete parameters list; (#713) Phpdocs for function renderer::single_section_page has incomplete parameters list; (#768) Phpdocs for function renderer::multiple_section_page has incomplete parameters list; (#1336) Phpdocs for function renderer::get_column_class has incomplete parameters list
course/format/topcoll/classes/privacy/provider.php: (#44) Phpdocs for function provider::get_metadata has incomplete parameters list
course/format/topcoll/classes/togglelib.php: (#60) Phpdocs for function togglelib::set_toggles has incomplete parameters list; (#78) Phpdocs for function togglelib::get_toggle_state has incomplete parameters list; (#89) Phpdocs for function togglelib::set_toggle_state has incomplete parameters list; (#106) Phpdocs for function togglelib::decode_toggle_state has incomplete parameters list; (#126) Phpdocs for function togglelib::is_old_preference has incomplete parameters list; (#142) Phpdocs for function togglelib::get_required_digits has incomplete parameters list; (#167) Phpdocs for function togglelib::get_toggle_pos has incomplete parameters list; (#176) Phpdocs for function togglelib::get_toggle_flag has incomplete parameters list; (#207) Phpdocs for function togglelib::decode_character_to_value has incomplete parameters list; (#216) Phpdocs for function togglelib::encode_value_to_character has incomplete parameters list
course/format/topcoll/db/upgrade.php: (#37) Phpdocs for function xmldb_format_topcoll_upgrade has incomplete parameters list
course/format/topcoll/js/tc_colourpopup.php: (#61) Phpdocs for function MoodleQuickForm_tccolourpopup::__construct has incomplete parameters list; (#72) Phpdocs for function MoodleQuickForm_tccolourpopup::setHiddenLabel has incomplete parameters list; (#136) Phpdocs for function MoodleQuickForm_tccolourpopup::setHelpButton has incomplete parameters list; (#167) Phpdocs for function MoodleQuickForm_tccolourpopup::export_for_template has incomplete parameters list
course/format/topcoll/lib.php: (#300) Phpdocs for function format_topcoll::get_section_dates has incomplete parameters list; (#47) Inline phpdocs tag {@link course_get_format($courseorid)} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}; (#1261) Inline phpdocs tag {@link course_edit_form::definition_after_data()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}; (#1451) Inline phpdocs tag {@link moodleform::get_data()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}; (#1452) Inline phpdocs tag {@link update_course()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}; (#1877) Inline phpdocs tag {@link course_can_delete_section()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
course/format/topcoll/tests/courseformatrenderer_test.php: (#90) Phpdocs for function courseformatrenderer_test::init has incomplete parameters list

Update savepoints problems

(1 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

course/format/topcoll/db/upgrade.php: 'return true;' not found

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

: Problems running grunt; Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(5 errors, 16 warnings)

This section shows problems detected in mustache templates [More info]

course/format/topcoll/templates/content.mustache: (#1) ESLint error [no-trailing-spaces]: Trailing spaces not allowed. ( '-course-format',
course/format/topcoll/templates/coursestyles.mustache: (#1) HTML Validation error, line 2: Element “style” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (ad><body><style type="text/css" media="screen"> /); (#1) HTML Validation info, line 2: The “type” attribute for the “style” element is not needed and should be omitted. (ad><body><style type="text/css" media="screen"> /)
course/format/topcoll/templates/displayinstructions.mustache: (#1) HTML Validation error, line 2: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (ad><body><li id="topcoll-display-instructions" class="tcsection main clearfix"> <)
course/format/topcoll/templates/local/content/cm.mustache: (#1) Example context missing.
course/format/topcoll/templates/local/content/section/cmitem.mustache: (#1) Example context missing.; (#1) HTML Validation error, line 9: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (><body><li class="activity activity-wrapper modtype_ " id="" data-for="cmitem" data-id=""></li>)
course/format/topcoll/templates/local/content/section/cmlist.mustache: (#1) HTML Validation error, line 15: Bad value “” for attribute “id” on element “li”: An ID must not be the empty string. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > ); (#1) HTML Validation error, line 53: Duplicate ID “”. ( <li class="activity activity-wrapper assign modtype_assign " id="" data-for="cmitem" data-id="4" > ); (#1) HTML Validation info, line 15: The first occurrence of ID “” was here. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > ); (#1) HTML Validation error, line 53: Bad value “” for attribute “id” on element “li”: An ID must not be the empty string. ( <li class="activity activity-wrapper assign modtype_assign " id="" data-for="cmitem" data-id="4" > ); (#1) HTML Validation error, line 62: Duplicate ID “cmCheckbox”. ( <input id="cmCheckbox" type="checkbox" data-id="" data-action="toggleSelectionCm" data-bulkcheckbox="1" > ); (#1) HTML Validation info, line 24: The first occurrence of ID “cmCheckbox” was here. ( <input id="cmCheckbox" type="checkbox" data-id="" data-action="toggleSelectionCm" data-bulkcheckbox="1" > )
course/format/topcoll/templates/section.mustache: (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
course/format/topcoll/templates/sectioncmmeta.mustache: (#1) HTML Validation error, line 3: No space between attributes. (ent"> <a href=""class=")
course/format/topcoll/templates/sectionhidden.mustache: (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
course/format/topcoll/templates/sectionsummary.mustache: (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
course/format/topcoll/templates/singlesection.mustache: (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
course/format/topcoll/templates/stealthsection.mustache: (#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Syntax error
course/format/topcoll/templates/toggleall.mustache: (#1) HTML Validation error, line 2: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (ad><body><li id="toggle-all" class="tcsection main clearfix"> <); (#1) HTML Validation error, line 5: The “aria-controls” attribute must point to an element in the same document. ( <span id="toggles-all-opened" class="toggle-all on medium" role="button" title="Open all" tabindex="0" aria-controls="toggledsection-1 toggledsection-2"> ); (#1) HTML Validation error, line 5: The “aria-controls” attribute must point to an element in the same document. ( <span id="toggles-all-opened" class="toggle-all on medium" role="button" title="Open all" tabindex="0" aria-controls="toggledsection-1 toggledsection-2"> ); (#1) HTML Validation error, line 8: The “aria-controls” attribute must point to an element in the same document. ( <span id="toggles-all-closed" class="toggle-all off medium" role="button" title="Close all" tabindex="0" aria-controls="toggledsection-1 toggledsection-2"> ); (#1) HTML Validation error, line 8: The “aria-controls” attribute must point to an element in the same document. ( <span id="toggles-all-closed" class="toggle-all off medium" role="button" title="Close all" tabindex="0" aria-controls="toggledsection-1 toggledsection-2"> )

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]