Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(15 errors, 28 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

course/format/topcoll/config.php
(#40) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
course/format/topcoll/db/upgrade.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
course/format/topcoll/format.php
(#124) Line exceeds 132 characters; contains 135 characters
course/format/topcoll/js/tc_colourpopup.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#50) Member variable "_hiddenLabel" must be all lower-case
(#52) Public method name "MoodleQuickForm_tccolourpopup::MoodleQuickForm_tccolourpopup" must be in lower-case letters only
(#52) PHP4 style constructors are not allowed; use "__construct()" instead
(#57) Public method name "MoodleQuickForm_tccolourpopup::setHiddenLabel" must be in lower-case letters only
(#57) Variable "hiddenLabel" must be all lower-case
(#58) Variable "hiddenLabel" must be all lower-case
(#61) Public method name "MoodleQuickForm_tccolourpopup::toHtml" must be in lower-case letters only
(#92) Public method name "MoodleQuickForm_tccolourpopup::_generateId" must be in lower-case letters only
(#106) Public method name "MoodleQuickForm_tccolourpopup::setHelpButton" must be in lower-case letters only
(#115) Public method name "MoodleQuickForm_tccolourpopup::getHelpButton" must be in lower-case letters only
(#126) Public method name "MoodleQuickForm_tccolourpopup::getElementTemplateType" must be in lower-case letters only
course/format/topcoll/lang/en/format_topcoll.php
(#81) This comment is 50% valid code; is this commented out code?
(#82) This comment is 50% valid code; is this commented out code?
(#83) This comment is 50% valid code; is this commented out code?
(#84) This comment is 50% valid code; is this commented out code?
(#85) This comment is 50% valid code; is this commented out code?
(#86) This comment is 50% valid code; is this commented out code?
(#89) This comment is 50% valid code; is this commented out code?
(#90) This comment is 50% valid code; is this commented out code?
(#91) This comment is 50% valid code; is this commented out code?
(#92) This comment is 50% valid code; is this commented out code?
(#93) This comment is 50% valid code; is this commented out code?
(#94) This comment is 50% valid code; is this commented out code?
(#95) This comment is 50% valid code; is this commented out code?
(#96) This comment is 50% valid code; is this commented out code?
course/format/topcoll/lang/en_ar/format_topcoll.php
(#54) This comment is 50% valid code; is this commented out code?
(#55) This comment is 50% valid code; is this commented out code?
(#56) This comment is 50% valid code; is this commented out code?
(#59) This comment is 50% valid code; is this commented out code?
(#60) This comment is 50% valid code; is this commented out code?
(#61) This comment is 50% valid code; is this commented out code?
(#62) This comment is 50% valid code; is this commented out code?
course/format/topcoll/lib.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
course/format/topcoll/renderer.php
(#901) Line exceeds 132 characters; contains 133 characters
(#928) Line exceeds 132 characters; contains 134 characters
course/format/topcoll/settopcollpref.php
(#32) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
course/format/topcoll/tests/courseformatrenderer_test.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion
course/format/topcoll/togglelib.php
(#35) Expected MOODLE_INTERNAL check or config.php inclusion
course/format/topcoll/version.php
(#39) This comment is 45% valid code; is this commented out code?

Javascript coding style problems

(16 errors, 116 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

course/format/topcoll/format.js
(#46) Identifier 'get_config' is not in camel case. (camelcase)
(#48) Identifier 'container_node' is not in camel case. (camelcase)
(#48) Extra space after key 'container_node'. (key-spacing)
(#49) Extra space after key 'container_class'. (key-spacing)
(#49) Identifier 'container_class' is not in camel case. (camelcase)
(#50) Identifier 'section_node' is not in camel case. (camelcase)
(#50) Extra space after key 'section_node'. (key-spacing)
(#51) Identifier 'section_class' is not in camel case. (camelcase)
(#51) Extra space after key 'section_class'. (key-spacing)
(#55) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#63) Identifier 'swap_sections' is not in camel case. (camelcase)
(#65) Extra space after key 'COURSECONTENT'. (key-spacing)
(#66) Extra space after key 'SECTIONADDMENUS'. (key-spacing)
(#74) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#74) Expected JSDoc for 'sectionlist' but found 'response'. (valid-jsdoc)
(#74) Expected JSDoc for 'response' but found 'sectionfrom'. (valid-jsdoc)
(#74) Expected JSDoc for 'sectionfrom' but found 'sectionto'. (valid-jsdoc)
(#83) Identifier 'process_sections' is not in camel case. (camelcase)
(#85) Extra space after key 'SECTIONNAME'. (key-spacing)
(#88) Extra space after key 'LEFTCONTENT'. (key-spacing)
(#89) Extra space after key 'SECTIONLEFTSIDE'. (key-spacing)
course/format/topcoll/js/tc_colourpopup.js
(#34) Identifier 'init_tccolour_popup' is not in camel case. (camelcase)
(#35) Missing space before opening brace. (space-before-blocks)
(#40) Extra space after key 'box'. (key-spacing)
(#41) Extra space after key 'input'. (key-spacing)
(#42) Extra space after key 'swatch'. (key-spacing)
(#43) Extra space after key 'image'. (key-spacing)
(#44) Extra space after key 'preview'. (key-spacing)
(#45) Extra space after key 'current'. (key-spacing)
(#46) Extra space after key 'eventClick'. (key-spacing)
(#47) Extra space after key 'eventFocus'. (key-spacing)
(#48) Extra space after key 'eventMouseEnter'. (key-spacing)
(#49) Extra space after key 'eventMouseLeave'. (key-spacing)
(#50) Extra space after key 'eventMouseMove'. (key-spacing)
(#51) Extra space after key 'width'. (key-spacing)
(#52) Extra space after key 'height'. (key-spacing)
(#53) Extra space after key 'factor'. (key-spacing)
(#57) Extra space after key 'init'. (key-spacing)
(#64) Line 64 exceeds the maximum line length of 132. (max-len)
(#66) Line 66 exceeds the maximum line length of 132. (max-len)
(#68) Expected space or tab after '//' in comment. (spaced-comment)
(#70) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops)
(#71) 'e' is defined but never used (no-unused-vars)
(#71) Missing space before opening brace. (space-before-blocks)
(#81) A space is required after ','. (comma-spacing)
(#81) A space is required after ','. (comma-spacing)
(#86) 'e' is defined but never used (no-unused-vars)
(#86) Missing space before opening brace. (space-before-blocks)
(#89) Extra space after key 'showColours'. (key-spacing)
(#89) 'e' is defined but never used (no-unused-vars)
(#89) Missing space before opening brace. (space-before-blocks)
(#93) Extra space after key 'setColour'. (key-spacing)
(#93) 'e' is defined but never used (no-unused-vars)
(#93) Missing space before opening brace. (space-before-blocks)
(#97) Extra space after key 'startFollow'. (key-spacing)
(#97) 'e' is defined but never used (no-unused-vars)
(#100) Missing space before opening brace. (space-before-blocks)
(#102) Expected space or tab after '//' in comment. (spaced-comment)
(#106) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#109) Extra space after key 'endFollow'. (key-spacing)
(#109) 'e' is defined but never used (no-unused-vars)
(#112) A space is required after ','. (comma-spacing)
(#115) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#118) Extra space after key 'pickColour'. (key-spacing)
(#126) Missing JSDoc for parameter 'e'. (valid-jsdoc)
(#126) Missing JSDoc @returns for function. (valid-jsdoc)
(#129) Extra space after key 'determineColour'. (key-spacing)
(#136) A space is required after ','. (comma-spacing)
(#136) A space is required after ','. (comma-spacing)
(#139) There should be no space after '[' (array-bracket-spacing)
(#139) Multiple spaces found before '0'. (no-multi-spaces)
(#139) Multiple spaces found before '1'. (no-multi-spaces)
(#139) Multiple spaces found before '0'. (no-multi-spaces)
(#140) There should be no space after '[' (array-bracket-spacing)
(#140) Multiple spaces found before '0'. (no-multi-spaces)
(#140) Multiple spaces found before '0'. (no-multi-spaces)
(#141) There should be no space after '[' (array-bracket-spacing)
(#141) Multiple spaces found before '0'. (no-multi-spaces)
(#141) Multiple spaces found before '0'. (no-multi-spaces)
(#141) Multiple spaces found before '1'. (no-multi-spaces)
(#142) There should be no space after '[' (array-bracket-spacing)
(#142) Multiple spaces found before '0'. (no-multi-spaces)
(#142) Multiple spaces found before '0'. (no-multi-spaces)
(#143) There should be no space after '[' (array-bracket-spacing)
(#143) Multiple spaces found before '1'. (no-multi-spaces)
(#143) Multiple spaces found before '0'. (no-multi-spaces)
(#143) Multiple spaces found before '0'. (no-multi-spaces)
(#144) There should be no space after '[' (array-bracket-spacing)
(#144) Multiple spaces found before '0'. (no-multi-spaces)
(#144) Multiple spaces found before '0'. (no-multi-spaces)
(#177) Missing JSDoc for parameter 'rgb'. (valid-jsdoc)
(#177) Missing JSDoc @returns for function. (valid-jsdoc)
(#180) Identifier 'convert_rgb_to_hex' is not in camel case. (camelcase)
(#180) Extra space after key 'convert_rgb_to_hex'. (key-spacing)
course/format/topcoll/module.js
(#35) Identifier 'format_topcoll' is not in camel case. (camelcase)
(#56) Missing JSDoc for parameter 'theUserIsEditing'. (valid-jsdoc)
(#166) Identifier 'toggle_topic' is not in camel case. (camelcase)
(#194) A space is required after ','. (comma-spacing)
(#194) A space is required after ','. (comma-spacing)
(#195) A space is required after ','. (comma-spacing)
(#195) A space is required after ','. (comma-spacing)
(#202) A space is required after ','. (comma-spacing)
(#206) A space is required after ','. (comma-spacing)
(#214) Identifier 'save_toggles' is not in camel case. (camelcase)
(#222) Identifier 'is_old_preference' is not in camel case. (camelcase)
(#234) Identifier 'convert_to_new_preference' is not in camel case. (camelcase)
(#252) Unexpected use of '<<'. (no-bitwise)
(#257) Missing JSDoc for parameter 'state'. (valid-jsdoc)
(#257) Missing JSDoc for parameter 'togglenum'. (valid-jsdoc)
(#262) Identifier 'set_toggle_state' is not in camel case. (camelcase)
(#269) Unexpected use of '|='. (no-bitwise)
(#273) Unexpected use of '&='. (no-bitwise)
(#273) Unexpected use of '~'. (no-bitwise)
(#277) A space is required after ','. (comma-spacing)
(#282) Identifier 'get_required_digits' is not in camel case. (camelcase)
(#287) Identifier 'get_toggle_pos' is not in camel case. (camelcase)
(#292) Identifier 'get_min_digit' is not in camel case. (camelcase)
(#297) Identifier 'get_max_digit' is not in camel case. (camelcase)
(#302) Identifier 'get_toggle_flag' is not in camel case. (camelcase)
(#329) Identifier 'decode_character_to_value' is not in camel case. (camelcase)
(#334) Identifier 'encode_value_to_character' is not in camel case. (camelcase)
(#339) Missing JSDoc parameter type for 'String'. (valid-jsdoc)
(#339) Duplicate JSDoc parameter 'String'. (valid-jsdoc)
(#339) Expected JSDoc for 'name' but found 'String'. (valid-jsdoc)
(#339) Missing JSDoc for parameter 'value'. (valid-jsdoc)
(#339) Missing JSDoc parameter type for 'String'. (valid-jsdoc)
(#350) Identifier 'set_user_preference' is not in camel case. (camelcase)
(#351) 'YUI' is not defined. (no-undef)
(#351) A function with a name starting with an uppercase letter should only be used as a constructor. (new-cap)
(#352) Line 352 exceeds the maximum line length of 132. (max-len)
(#361) Line 361 exceeds the maximum line length of 132. (max-len)
(#361) Unexpected console statement. (no-console)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by csslint [More info]


PHPDocs style problems

(83 errors, 17 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

course/format/topcoll/backup/moodle2/restore_format_topcoll_plugin.class.php
(#100) Function restore_format_topcoll_plugin::after_execute_structure is not documented
(#37) No one-line description found in phpdocs for class restore_format_topcoll_plugin
(#60) Phpdocs for function restore_format_topcoll_plugin::process_topcoll has incomplete parameters list
(#37) Class restore_format_topcoll_plugin does not have @copyright tag
(#37) Class restore_format_topcoll_plugin does not have @license tag
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/config.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/db/access.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/db/upgrade.php
(#37) Function xmldb_format_topcoll_upgrade is not documented
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/format.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/js/tc_colourpopup.php
(#52) Function MoodleQuickForm_tccolourpopup::MoodleQuickForm_tccolourpopup is not documented
(#57) Function MoodleQuickForm_tccolourpopup::setHiddenLabel is not documented
(#61) Function MoodleQuickForm_tccolourpopup::toHtml is not documented
(#49) Variable MoodleQuickForm_tccolourpopup::$_helpbutton is not documented
(#50) Variable MoodleQuickForm_tccolourpopup::$_hiddenLabel is not documented
(#103) Phpdocs for function MoodleQuickForm_tccolourpopup::setHelpButton has incomplete parameters list
(#36) Class MoodleQuickForm_tccolourpopup does not have @copyright tag
(#36) Class MoodleQuickForm_tccolourpopup does not have @license tag
(#27) Not recommended phpdocs tag @version used
(#40) Not recommended phpdocs tag @access used
(#25) Package course/format is not valid
course/format/topcoll/lang/en/format_topcoll.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/lang/en_ar/format_topcoll.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/lang/en_us/format_topcoll.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/lib.php
(#36) Class format_topcoll is not documented
(#170) Function format_topcoll::get_section_dates is not documented
(#295) Function format_topcoll::section_format_options is not documented
(#1231) Function format_topcoll::get_context is not documented
(#37) Variable format_topcoll::$settings is not documented
(#56) Phpdocs for function format_topcoll::get_settings has incomplete parameters list
(#1296) Phpdocs for function format_topcoll_delete_course has incomplete parameters list
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/renderer.php
(#39) Class format_topcoll_renderer is not documented
(#523) Function format_topcoll_renderer::section_summary_container is not documented
(#1064) Function format_topcoll_renderer::set_portable is not documented
(#1079) Function format_topcoll_renderer::set_user_preference is not documented
(#1083) Function format_topcoll_renderer::set_default_user_preference is not documented
(#1087) Function format_topcoll_renderer::get_row_class is not documented
(#1091) Function format_topcoll_renderer::get_column_class is not documented
(#1097) Function format_topcoll_renderer::get_format_responsive is not documented
(#41) Variable format_topcoll_renderer::$tccolumnwidth is not documented
(#42) Variable format_topcoll_renderer::$tccolumnpadding is not documented
(#43) Variable format_topcoll_renderer::$mobiletheme is not documented
(#44) Variable format_topcoll_renderer::$tablettheme is not documented
(#45) Variable format_topcoll_renderer::$courseformat is not documented
(#46) Variable format_topcoll_renderer::$tcsettings is not documented
(#47) Variable format_topcoll_renderer::$userpreference is not documented
(#48) Variable format_topcoll_renderer::$defaultuserpreference is not documented
(#49) Variable format_topcoll_renderer::$togglelib is not documented
(#50) Variable format_topcoll_renderer::$isoldtogglepreference is not documented
(#51) Variable format_topcoll_renderer::$userisediting is not documented
(#52) Variable format_topcoll_renderer::$tctoggleiconsize is not documented
(#53) Variable format_topcoll_renderer::$formatresponsive is not documented
(#54) Variable format_topcoll_renderer::$rtl is not documented
(#59) Phpdocs for function format_topcoll_renderer::__construct has incomplete parameters list
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/settings.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/settopcollpref.php
(#25) Not recommended phpdocs tag @version used
(#23) Package course/format is not valid
course/format/topcoll/tests/courseformatrenderer_test.php
(#36) Variable format_topcoll_courseformatrenderer_testcase::$outputus is not documented
(#37) Variable format_topcoll_courseformatrenderer_testcase::$course is not documented
(#38) Variable format_topcoll_courseformatrenderer_testcase::$courseformat is not documented
(#30) Class format_topcoll_courseformatrenderer_testcase does not have @copyright tag
(#30) Class format_topcoll_courseformatrenderer_testcase does not have @license tag
(#32) Invalid phpdocs tag @group used
(#22) Not recommended phpdocs tag @version used
(#20) Package course/format is not valid
course/format/topcoll/togglelib.php
(#35) Class topcoll_togglelib is not documented
(#48) Variable topcoll_togglelib::$toggles is not documented
(#41) Constant topcoll_togglelib::TOGGLE_6 is not documented
(#42) Constant topcoll_togglelib::TOGGLE_5 is not documented
(#43) Constant topcoll_togglelib::TOGGLE_4 is not documented
(#44) Constant topcoll_togglelib::TOGGLE_3 is not documented
(#45) Constant topcoll_togglelib::TOGGLE_2 is not documented
(#46) Constant topcoll_togglelib::TOGGLE_1 is not documented
(#50) Phpdocs for function topcoll_togglelib::set_toggles has incomplete parameters list
(#60) Phpdocs for function topcoll_togglelib::get_toggle_state has incomplete parameters list
(#71) Phpdocs for function topcoll_togglelib::set_toggle_state has incomplete parameters list
(#88) Phpdocs for function topcoll_togglelib::is_old_preference has incomplete parameters list
(#104) Phpdocs for function topcoll_togglelib::get_required_digits has incomplete parameters list
(#129) Phpdocs for function topcoll_togglelib::get_toggle_pos has incomplete parameters list
(#138) Phpdocs for function topcoll_togglelib::get_toggle_flag has incomplete parameters list
(#169) Phpdocs for function topcoll_togglelib::decode_character_to_value has incomplete parameters list
(#178) Phpdocs for function topcoll_togglelib::encode_value_to_character has incomplete parameters list
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/version.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid

Update savepoints problems

(2 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

course/format/topcoll/db/upgrade.php
Detected more 'if' blocks (1) than 'savepoint' calls (0)
version 2114052000 is missing corresponding savepoint call

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]