Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(110 errors, 56 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

course/format/topcoll/backup/moodle2/restore_format_topcoll_plugin.class.php
(#83) Whitespace found at end of line
(#87) Whitespace found at end of line
course/format/topcoll/config.php
(#40) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
course/format/topcoll/db/access.php
(#1) End of line character is invalid; expected "\n" but found "\r"
course/format/topcoll/db/upgrade.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
course/format/topcoll/format.php
(#116) Line indented incorrectly; expected 8 spaces, found 28
(#118) Line indented incorrectly; expected 8 spaces, found 28
(#120) Line indented incorrectly; expected 28 spaces, found 26
(#126) Line indented incorrectly; expected 8 spaces, found 16
(#128) Line indented incorrectly; expected 8 spaces, found 16
(#130) Line indented incorrectly; expected 16 spaces, found 15
(#132) Line indented incorrectly; expected 8 spaces, found 4
(#133) Line indented incorrectly; expected 12 spaces, found 8
(#134) Line indented incorrectly; expected at least 16 spaces, found 12
(#136) Line indented incorrectly; expected 12 spaces, found 8
(#137) Line indented incorrectly; expected at least 16 spaces, found 12
(#139) Line indented incorrectly; expected 12 spaces, found 8
(#140) Line indented incorrectly; expected at least 16 spaces, found 12
(#141) Line indented incorrectly; expected 8 spaces, found 4
(#148) Line indented incorrectly; expected 8 spaces, found 4
(#149) Line indented incorrectly; expected 12 spaces, found 8
(#150) Line indented incorrectly; expected at least 16 spaces, found 12
(#152) Line indented incorrectly; expected 12 spaces, found 8
(#153) Line indented incorrectly; expected at least 16 spaces, found 12
(#154) Line indented incorrectly; expected 8 spaces, found 4
(#162) Line indented incorrectly; expected 8 spaces, found 28
(#164) Line indented incorrectly; expected 8 spaces, found 28
(#166) Line indented incorrectly; expected 28 spaces, found 26
(#171) Line indented incorrectly; expected 0 spaces, found 4
(#176) Line indented incorrectly; expected 0 spaces, found 4
(#181) Line indented incorrectly; expected 0 spaces, found 4
(#184) Line indented incorrectly; expected 0 spaces, found 4
(#189) Line indented incorrectly; expected 0 spaces, found 4
(#192) Line indented incorrectly; expected 0 spaces, found 4
(#205) Line indented incorrectly; expected 0 spaces, found 4
course/format/topcoll/js/tc_colourpopup.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#50) Member variable "_hiddenLabel" must be all lower-case
(#52) Public method name "MoodleQuickForm_tccolourpopup::MoodleQuickForm_tccolourpopup" must be in lower-case letters only
(#52) PHP4 style constructors are not allowed; use "__construct()" instead
(#53) PHP4 style calls to parent constructors are not allowed; use "parent::__construct()" instead
(#56) Public method name "MoodleQuickForm_tccolourpopup::setHiddenLabel" must be in lower-case letters only
(#56) Variable "hiddenLabel" must be all lower-case
(#57) Variable "hiddenLabel" must be all lower-case
(#60) Public method name "MoodleQuickForm_tccolourpopup::toHtml" must be in lower-case letters only
(#91) Public method name "MoodleQuickForm_tccolourpopup::_generateId" must be in lower-case letters only
(#105) Public method name "MoodleQuickForm_tccolourpopup::setHelpButton" must be in lower-case letters only
(#114) Public method name "MoodleQuickForm_tccolourpopup::getHelpButton" must be in lower-case letters only
(#125) Public method name "MoodleQuickForm_tccolourpopup::getElementTemplateType" must be in lower-case letters only
course/format/topcoll/lang/en/format_topcoll.php
(#65) Inline comments must end in full-stops, exclamation marks, or question marks
(#75) This comment is 50% valid code; is this commented out code?
(#76) This comment is 50% valid code; is this commented out code?
(#77) This comment is 50% valid code; is this commented out code?
(#78) This comment is 50% valid code; is this commented out code?
(#79) This comment is 50% valid code; is this commented out code?
(#80) This comment is 50% valid code; is this commented out code?
(#83) This comment is 50% valid code; is this commented out code?
(#84) This comment is 50% valid code; is this commented out code?
(#85) This comment is 50% valid code; is this commented out code?
(#86) This comment is 50% valid code; is this commented out code?
(#87) This comment is 50% valid code; is this commented out code?
(#88) This comment is 50% valid code; is this commented out code?
(#89) This comment is 50% valid code; is this commented out code?
(#90) This comment is 50% valid code; is this commented out code?
(#149) Expected 1 space after "="; newline found
(#315) Inline comments must end in full-stops, exclamation marks, or question marks
course/format/topcoll/lang/en_ar/format_topcoll.php
(#38) Expected 1 space before "="; 0 found
(#38) Expected 1 space after "="; 0 found
(#45) Expected 1 space before "="; 0 found
(#45) Expected 1 space after "="; 0 found
(#46) Expected 1 space before "="; 0 found
(#46) Expected 1 space after "="; 0 found
(#54) This comment is 50% valid code; is this commented out code?
(#55) This comment is 50% valid code; is this commented out code?
(#56) This comment is 50% valid code; is this commented out code?
(#59) This comment is 50% valid code; is this commented out code?
(#60) This comment is 50% valid code; is this commented out code?
(#61) This comment is 50% valid code; is this commented out code?
(#62) This comment is 50% valid code; is this commented out code?
(#65) Expected 1 space before "="; 0 found
(#65) Expected 1 space after "="; 0 found
(#66) Expected 1 space before "="; 0 found
(#66) Expected 1 space after "="; 0 found
(#68) Expected 1 space before "="; 0 found
(#68) Expected 1 space after "="; 0 found
(#69) Expected 1 space before "="; 0 found
(#69) Expected 1 space after "="; 0 found
(#96) Expected 1 space before "="; 0 found
(#96) Expected 1 space after "="; 0 found
(#97) Expected 1 space before "="; 0 found
(#97) Expected 1 space after "="; 0 found
(#277) Inline comments must end in full-stops, exclamation marks, or question marks
course/format/topcoll/lang/en_us/format_topcoll.php
(#38) Expected 1 space before "="; 0 found
(#38) Expected 1 space after "="; 0 found
course/format/topcoll/lib.php
(#34) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#115) Whitespace found at end of line
(#118) Inline comments must start with a capital letter, digit or 3-dots sequence
(#442) Line exceeds 132 characters; contains 167 characters
(#443) Line exceeds 132 characters; contains 151 characters
(#444) Line exceeds 132 characters; contains 149 characters
(#445) Line exceeds 132 characters; contains 154 characters
(#447) Line exceeds 132 characters; contains 135 characters
(#448) Line exceeds 132 characters; contains 133 characters
(#498) Expected 1 space after "="; newline found
(#500) Expected 1 space after "="; newline found
(#502) Expected 1 space after "="; newline found
(#504) Expected 1 space after "="; newline found
(#506) Expected 1 space after "="; newline found
(#523) Expected 1 space after "="; newline found
(#560) Expected 1 space after "="; newline found
(#562) Expected 1 space after "="; newline found
(#595) Expected 1 space after "="; newline found
(#597) Expected 1 space after "="; newline found
(#599) Expected 1 space after "="; newline found
(#636) Expected 1 space before "+"; 0 found
(#636) Expected 1 space after "+"; 0 found
(#653) Line exceeds 132 characters; contains 150 characters
(#667) Line exceeds 132 characters; contains 146 characters
(#672) Line exceeds 132 characters; contains 142 characters
(#680) Line exceeds 132 characters; contains 160 characters
(#683) Line exceeds 132 characters; contains 134 characters
(#686) Line exceeds 132 characters; contains 134 characters
(#689) Line exceeds 132 characters; contains 152 characters
(#692) Line exceeds 132 characters; contains 148 characters
(#695) Line exceeds 132 characters; contains 141 characters
(#731) Whitespace found at end of line
(#736) Whitespace found at end of line
(#741) Whitespace found at end of line
(#743) Whitespace found at end of line
(#838) Line exceeds 132 characters; contains 144 characters
(#850) Line exceeds 132 characters; contains 145 characters
(#851) Line exceeds 132 characters; contains 158 characters
(#853) Line exceeds 132 characters; contains 137 characters
(#854) Line exceeds 132 characters; contains 157 characters
(#956) Line exceeds 132 characters; contains 143 characters
(#999) Line exceeds 132 characters; contains 143 characters
(#1021) Line exceeds 132 characters; contains 148 characters
course/format/topcoll/renderer.php
(#270) Expected 1 space before "=>"; 0 found
(#287) Expected 1 space before ".="; 0 found
(#288) Expected 1 space before ".="; 0 found
(#289) Expected 1 space before ".="; 0 found
(#290) Expected 1 space before ".="; 0 found
(#397) Expected 1 space before ".="; 0 found
(#420) Expected 1 space before ".="; 0 found
(#496) Possible useless method overriding detected
(#615) Inline comments must start with a capital letter, digit or 3-dots sequence
course/format/topcoll/settings.php
(#82) Line exceeds 132 characters; contains 155 characters
course/format/topcoll/settopcollpref.php
(#32) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
(#48) Inline comments must end in full-stops, exclamation marks, or question marks
course/format/topcoll/test/format_test.php
(#53) Commas (,) must be followed by white space.
(#54) Commas (,) must be followed by white space.
(#55) Commas (,) must be followed by white space.
(#56) Commas (,) must be followed by white space.
course/format/topcoll/togglelib.php
(#35) Expected MOODLE_INTERNAL check or config.php inclusion
(#39) Expected 1 space before comment text but found 7; use block comment if you need indentation
(#68) Expected 1 space before "-"; 0 found
(#68) Expected 1 space after "-"; 0 found
(#79) Expected 1 space before "-"; 0 found
(#79) Expected 1 space after "-"; 0 found
(#85) Expected 1 space before "-"; 0 found
(#85) Expected 1 space after "-"; 0 found
(#145) Expected 1 space before "-"; 0 found
(#145) Expected 1 space after "-"; 0 found
(#145) Expected 1 space before "*"; 0 found
(#145) Expected 1 space after "*"; 0 found
(#245) Line exceeds 132 characters; contains 133 characters
course/format/topcoll/version.php
(#38) This comment is 45% valid code; is this commented out code?

Javascript coding style problems

(0 errors, 37 warnings)

This section shows the coding style problems detected in the code by jshint [More info]

course/format/topcoll/format.js
(#54) Missing semicolon.
(#73) Missing semicolon.
(#94) Expected '===' and instead saw '=='.
(#133) Missing semicolon.
course/format/topcoll/js/tc_colourpopup.js
(#159) Expected '===' and instead saw '=='.
(#185) Expected '===' and instead saw '=='.
(#71) 'e' is defined but never used.
(#86) 'e' is defined but never used.
(#89) 'e' is defined but never used.
(#93) 'e' is defined but never used.
(#97) 'e' is defined but never used.
(#109) 'e' is defined but never used.
course/format/topcoll/module.js
(#38) Line is too long.
(#39) Expected an assignment or function call and instead saw an expression.
(#40) Expected an assignment or function call and instead saw an expression.
(#42) Expected an assignment or function call and instead saw an expression.
(#43) Expected an assignment or function call and instead saw an expression.
(#44) Expected an assignment or function call and instead saw an expression.
(#75) Expected '===' and instead saw '=='.
(#76) Expected '===' and instead saw '=='.
(#84) Expected '===' and instead saw '=='.
(#98) Expected '===' and instead saw '=='.
(#184) Line is too long.
(#207) Expected '===' and instead saw '=='.
(#218) Expected '===' and instead saw '=='.
(#218) Expected '===' and instead saw '=='.
(#242) Unexpected use of '<<'.
(#256) Expected '===' and instead saw '=='.
(#257) Unexpected use of '|='.
(#259) Unexpected use of '&='.
(#259) Unexpected use of '~'.
(#317) Missing semicolon.
(#347) Line is too long.
(#348) Missing semicolon.
(#346) 'args' is defined but never used.
(#346) 'o' is defined but never used.
(#346) 'id' is defined but never used.

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by csslint [More info]


PHPDocs style problems

(66 errors, 16 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

course/format/topcoll/backup/moodle2/restore_format_topcoll_plugin.class.php
(#100) Function restore_format_topcoll_plugin::after_execute_structure is not documented
(#37) No one-line description found in phpdocs for class restore_format_topcoll_plugin
(#60) Phpdocs for function restore_format_topcoll_plugin::process_topcoll has incomplete parameters list
(#37) Class restore_format_topcoll_plugin does not have @copyright tag
(#37) Class restore_format_topcoll_plugin does not have @license tag
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/config.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/db/upgrade.php
(#37) Function xmldb_format_topcoll_upgrade is not documented
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/format.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/js/tc_colourpopup.php
(#52) Function MoodleQuickForm_tccolourpopup::MoodleQuickForm_tccolourpopup is not documented
(#56) Function MoodleQuickForm_tccolourpopup::setHiddenLabel is not documented
(#60) Function MoodleQuickForm_tccolourpopup::toHtml is not documented
(#49) Variable MoodleQuickForm_tccolourpopup::$_helpbutton is not documented
(#50) Variable MoodleQuickForm_tccolourpopup::$_hiddenLabel is not documented
(#102) Phpdocs for function MoodleQuickForm_tccolourpopup::setHelpButton has incomplete parameters list
(#36) Class MoodleQuickForm_tccolourpopup does not have @copyright tag
(#36) Class MoodleQuickForm_tccolourpopup does not have @license tag
(#27) Not recommended phpdocs tag @version used
(#40) Not recommended phpdocs tag @access used
(#25) Package course/format is not valid
course/format/topcoll/lang/en/format_topcoll.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/lang/en_ar/format_topcoll.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/lang/en_us/format_topcoll.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/lib.php
(#36) Class format_topcoll is not documented
(#154) Function format_topcoll::get_section_dates is not documented
(#38) Variable format_topcoll::$settings is not documented
(#57) Phpdocs for function format_topcoll::get_settings has incomplete parameters list
(#1070) Phpdocs for function format_topcoll_delete_course has incomplete parameters list
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/renderer.php
(#40) Class format_topcoll_renderer is not documented
(#879) Function format_topcoll_renderer::set_portable is not documented
(#894) Function format_topcoll_renderer::set_user_preference is not documented
(#898) Function format_topcoll_renderer::set_default_user_preference is not documented
(#42) Variable format_topcoll_renderer::$tccolumnwidth is not documented
(#43) Variable format_topcoll_renderer::$tccolumnpadding is not documented
(#44) Variable format_topcoll_renderer::$mobiletheme is not documented
(#45) Variable format_topcoll_renderer::$tablettheme is not documented
(#46) Variable format_topcoll_renderer::$courseformat is not documented
(#47) Variable format_topcoll_renderer::$tcsettings is not documented
(#48) Variable format_topcoll_renderer::$userpreference is not documented
(#49) Variable format_topcoll_renderer::$defaultuserpreference is not documented
(#50) Variable format_topcoll_renderer::$togglelib is not documented
(#51) Variable format_topcoll_renderer::$isoldtogglepreference is not documented
(#446) Phpdocs for function format_topcoll_renderer::section_hidden has incomplete parameters list
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/settings.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/settopcollpref.php
(#25) Not recommended phpdocs tag @version used
(#23) Package course/format is not valid
course/format/topcoll/test/format_test.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/togglelib.php
(#35) Class topcoll_togglelib is not documented
(#48) Variable topcoll_togglelib::$toggles is not documented
(#41) Constant topcoll_togglelib::TOGGLE_6 is not documented
(#42) Constant topcoll_togglelib::TOGGLE_5 is not documented
(#43) Constant topcoll_togglelib::TOGGLE_4 is not documented
(#44) Constant topcoll_togglelib::TOGGLE_3 is not documented
(#45) Constant topcoll_togglelib::TOGGLE_2 is not documented
(#46) Constant topcoll_togglelib::TOGGLE_1 is not documented
(#50) Phpdocs for function topcoll_togglelib::set_toggles has incomplete parameters list
(#60) Phpdocs for function topcoll_togglelib::get_toggle_state has incomplete parameters list
(#71) Phpdocs for function topcoll_togglelib::set_toggle_state has incomplete parameters list
(#88) Phpdocs for function topcoll_togglelib::is_old_preference has incomplete parameters list
(#104) Phpdocs for function topcoll_togglelib::get_required_digits has incomplete parameters list
(#129) Phpdocs for function topcoll_togglelib::get_toggle_pos has incomplete parameters list
(#138) Phpdocs for function topcoll_togglelib::get_toggle_flag has incomplete parameters list
(#169) Phpdocs for function topcoll_togglelib::decode_character_to_value has incomplete parameters list
(#178) Phpdocs for function topcoll_togglelib::encode_value_to_character has incomplete parameters list
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid
course/format/topcoll/version.php
(#27) Not recommended phpdocs tag @version used
(#25) Package course/format is not valid

Update savepoints problems

(2 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

course/format/topcoll/db/upgrade.php
Detected more 'if' blocks (1) than 'savepoint' calls (0)
version 2114052000 is missing corresponding savepoint call

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]