Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(70 errors, 4 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

course/format/grid/backup/moodle2/restore_format_grid_plugin.class.php
(#147) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#148) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#168) Opening parenthesis of a multi-line function call must be the last content on the line
(#169) Multi-line function call not indented correctly; expected 24 spaces but found 28
(#169) Closing parenthesis of a multi-line function call must be on a line by itself
(#217) Opening parenthesis of a multi-line function call must be the last content on the line
(#217) Only one argument is allowed per line in a multi-line function call
(#217) Only one argument is allowed per line in a multi-line function call
course/format/grid/classes/output/courseformat/content.php
(#207) Parentheses must be used when instantiating a new class
(#224) Opening parenthesis of a multi-line function call must be the last content on the line
(#224) Only one argument is allowed per line in a multi-line function call
(#225) Multi-line function call not indented correctly; expected 28 spaces but found 32
(#225) Closing parenthesis of a multi-line function call must be on a line by itself
(#269) Line exceeds 132 characters; contains 134 characters
(#432) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#435) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#437) Multi-line function call not indented correctly; expected 16 spaces but found 20
(#437) Only one argument is allowed per line in a multi-line function call
(#437) Only one argument is allowed per line in a multi-line function call
(#437) Only one argument is allowed per line in a multi-line function call
(#437) Only one argument is allowed per line in a multi-line function call
(#437) Closing parenthesis of a multi-line function call must be on a line by itself
(#459) Multi-line function declarations must define one parameter per line
(#459) Multi-line function declarations must define one parameter per line
(#459) Multi-line function declarations must define one parameter per line
(#459) Multi-line function declarations must define one parameter per line
(#459) The closing parenthesis of a multi-line function declaration must be on a new line
(#476) Multi-line function call not indented correctly; expected 16 spaces but found 20
(#476) Only one argument is allowed per line in a multi-line function call
(#476) Only one argument is allowed per line in a multi-line function call
(#476) Only one argument is allowed per line in a multi-line function call
(#476) Only one argument is allowed per line in a multi-line function call
(#476) Only one argument is allowed per line in a multi-line function call
(#476) Closing parenthesis of a multi-line function call must be on a line by itself
(#481) Multi-line function call not indented correctly; expected 24 spaces but found 28
(#481) Only one argument is allowed per line in a multi-line function call
(#481) Only one argument is allowed per line in a multi-line function call
(#481) Only one argument is allowed per line in a multi-line function call
(#481) Only one argument is allowed per line in a multi-line function call
(#481) Only one argument is allowed per line in a multi-line function call
(#481) Closing parenthesis of a multi-line function call must be on a line by itself
(#557) Multi-line function declarations must define one parameter per line
(#557) Multi-line function declarations must define one parameter per line
(#557) Multi-line function declarations must define one parameter per line
(#557) Multi-line function declarations must define one parameter per line
(#557) Multi-line function declarations must define one parameter per line
(#557) The closing parenthesis of a multi-line function declaration must be on a new line
course/format/grid/classes/output/courseformat/content/section/cmsummary.php
(#53) Parentheses must be used when instantiating a new class
(#58) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#59) The closing parenthesis of a multi-line control structure must be on the line after the last expression
(#59) Line exceeds 132 characters; contains 134 characters
(#64) Long list syntax is not allowed
(#121) The first expression of a multi-line control structure must be on the line after the opening parenthesis
(#122) The closing parenthesis of a multi-line control structure must be on the line after the last expression
course/format/grid/classes/output/courseformat/state/course.php
(#42) Opening brace must not be followed by a blank line
course/format/grid/classes/toolbox.php
(#331) This comment is 56% valid code; is this commented out code?
(#723) Opening parenthesis of a multi-line function call must be the last content on the line
(#723) Only one argument is allowed per line in a multi-line function call
(#723) Only one argument is allowed per line in a multi-line function call
(#724) Multi-line function call not indented correctly; expected 28 spaces but found 32
(#724) Closing parenthesis of a multi-line function call must be on a line by itself
course/format/grid/form/sectionfilemanager.php
(#55) Incorrect spacing between argument "$elementName" and equals sign; expected 1 but found 0
(#55) Incorrect spacing between default value and equals sign for argument "$elementName"; expected 1 but found 0
(#55) Incorrect spacing between argument "$elementLabel" and equals sign; expected 1 but found 0
(#55) Incorrect spacing between default value and equals sign for argument "$elementLabel"; expected 1 but found 0
(#55) Incorrect spacing between argument "$attributes" and equals sign; expected 1 but found 0
(#55) Incorrect spacing between default value and equals sign for argument "$attributes"; expected 1 but found 0
course/format/grid/lib.php
(#480) Expected at least 1 space before "."; 0 found
(#480) Expected at least 1 space after "."; 0 found
course/format/grid/settings.php
(#191) Expected at least 1 space before "."; 0 found
(#191) Expected at least 1 space after "."; 0 found
(#191) Expected at least 1 space before "."; 0 found
(#191) Expected at least 1 space after "."; 0 found
course/format/grid/version.php
(#35) This comment is 50% valid code; is this commented out code?

Javascript coding style problems

(0 errors, 9 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

course/format/grid/amd/src/local/content/actions.js
(#50) Comments should not begin with a lowercase character. (capitalized-comments)
(#50) Expected space or tab after '//' in comment. (spaced-comment)
course/format/grid/amd/src/thegrid.js
(#79) Unexpected space before function parentheses. (space-before-function-paren)
(#99) Unexpected space before function parentheses. (space-before-function-paren)
(#109) Unexpected space before function parentheses. (space-before-function-paren)
(#125) Unexpected space before function parentheses. (space-before-function-paren)
(#135) Unexpected space before function parentheses. (space-before-function-paren)
(#149) Unexpected space before function parentheses. (space-before-function-paren)
(#159) Unexpected space before function parentheses. (space-before-function-paren)

CSS problems

(2 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

course/format/grid/styles.css
(#167) Expected single space before "{" (block-opening-brace-space-before)
(#97) Expected single space after "," in a single-line function (function-comma-space-after)

PHPDocs style problems

(14 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

course/format/grid/backup/moodle2/restore_format_grid_plugin.class.php
(#71) Phpdocs for function restore_format_grid_plugin::process_grid has incomplete parameters list
(#190) Phpdocs for function restore_format_grid_plugin::process_gridsection has incomplete parameters list
course/format/grid/classes/output/courseformat/content.php
(#67) Phpdocs for function content::get_template_name has incomplete parameters list
(#504) Phpdocs for function content::render_grid_completion has incomplete parameters list
course/format/grid/classes/task/update_displayed_images_adhoc.php
(#56) Phpdocs for function update_displayed_images_adhoc::do_update_displayed_images_task has incomplete parameters list
course/format/grid/classes/toolbox.php
(#138) Phpdocs for function toolbox::check_displayed_image has incomplete parameters list
course/format/grid/db/upgrade.php
(#28) Phpdocs for function xmldb_format_grid_upgrade has incomplete parameters list
course/format/grid/lib.php
(#45) Inline phpdocs tag {@link course_get_format($courseorid)} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#364) Inline phpdocs tag {@link ajaxenabled()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#757) Inline phpdocs tag {@link course_edit_form::definition_after_data()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#798) Inline phpdocs tag {@link moodleform::get_data()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#799) Inline phpdocs tag {@link update_course()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#956) Inline phpdocs tag {@link course_delete_section()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#993) Inline phpdocs tag {@link course_can_delete_section()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 15 warnings)

This section shows problems detected in mustache templates [More info]

course/format/grid/templates/coursestyles.mustache
(#1) Template produced no content
course/format/grid/templates/local/content.mustache
(#1) HTML Validation error, line 43: Bad value “” for attribute “id” on element “li”: An ID must not be the empty string. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 106: Element “h” not allowed as child of element “div” in this context. (Suppressing further errors from this subtree.) ( <h class="h4 sectionname course-content-item d-flex align-self-stretch align-items-center mb-0" id="sectionid-35-title" data-for="section_title" data-id="35" data-number="1"> )
(#1) HTML Validation error, line 127: Duplicate ID “”. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation info, line 43: The first occurrence of ID “” was here. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 127: Bad value “” for attribute “id” on element “li”: An ID must not be the empty string. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 190: Element “h” not allowed as child of element “div” in this context. (Suppressing further errors from this subtree.) ( <h class="h4 sectionname course-content-item d-flex align-self-stretch align-items-center mb-0" id="sectionid-36-title" data-for="section_title" data-id="36" data-number="4"> )
(#1) HTML Validation error, line 211: Duplicate ID “”. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="5" > )
(#1) HTML Validation info, line 43: The first occurrence of ID “” was here. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 211: Bad value “” for attribute “id” on element “li”: An ID must not be the empty string. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="5" > )
(#1) HTML Validation error, line 260: Duplicate ID “section-1”. ( <li id="section-1" class="section course-section main clearfix current " data-sectionid="1" data-sectionreturnnum="" data-for="section" data-id="35" data-number="1" data-sectionname="" > )
(#1) HTML Validation info, line 77: The first occurrence of ID “section-1” was here. ( <li id="section-1" class="section course-section main clearfix current " data-sectionid="1" data-sectionreturnnum="" data-for="section" data-id="35" data-number="1" data-sectionname="" > )
(#1) HTML Validation error, line 277: Duplicate ID “collapsesectionid35”. ( <a role="button" data-toggle="collapse" data-for="sectiontoggler" href="#coursecontentcollapseid35" id="collapsesectionid35" aria-expanded="true" aria-controls="coursecontentcollapseid35" class="btn btn-icon me-3 icons-collapse-expand justify-content-center " aria-label="Single Section Example"> )
(#1) HTML Validation info, line 94: The first occurrence of ID “collapsesectionid35” was here. ( <a role="button" data-toggle="collapse" data-for="sectiontoggler" href="#coursecontentcollapseid35" id="collapsesectionid35" aria-expanded="true" aria-controls="coursecontentcollapseid35" class="btn btn-icon me-3 icons-collapse-expand justify-content-center " aria-label="Section title"> )
(#1) HTML Validation error, line 289: Duplicate ID “sectionid-35-title”. ( <h class="h4 sectionname course-content-item d-flex align-self-stretch align-items-center mb-0" id="sectionid-35-title" data-for="section_title" data-id="35" data-number="1"> )
(#1) HTML Validation info, line 106: The first occurrence of ID “sectionid-35-title” was here. ( <h class="h4 sectionname course-content-item d-flex align-self-stretch align-items-center mb-0" id="sectionid-35-title" data-for="section_title" data-id="35" data-number="1"> )
(#1) HTML Validation error, line 289: Element “h” not allowed as child of element “div” in this context. (Suppressing further errors from this subtree.) ( <h class="h4 sectionname course-content-item d-flex align-self-stretch align-items-center mb-0" id="sectionid-35-title" data-for="section_title" data-id="35" data-number="1"> )
(#1) HTML Validation error, line 298: Duplicate ID “coursecontentcollapseid35”. (> <div id="coursecontentcollapseid35" class="content course-content-item-content collapse show"> )
(#1) HTML Validation info, line 115: The first occurrence of ID “coursecontentcollapseid35” was here. (> <div id="coursecontentcollapseid35" class="content course-content-item-content collapse show"> )
(#1) HTML Validation error, line 310: Duplicate ID “”. ( <li class="activity activity-wrapper assign modtype_assign " id="" data-for="cmitem" data-id="4" > )
(#1) HTML Validation info, line 43: The first occurrence of ID “” was here. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 310: Bad value “” for attribute “id” on element “li”: An ID must not be the empty string. ( <li class="activity activity-wrapper assign modtype_assign " id="" data-for="cmitem" data-id="4" > )
course/format/grid/templates/local/content/section.mustache
(#1) HTML Validation error, line 14: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (d><body><li id="section-3" class="section course-section main clearfix current " data-sectionid="3" data-sectionreturnnum="" data-for="section" data-id="35" data-number="3" data-sectionname="" > <)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]