Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(7 errors, 53 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

course/format/grid/backup/moodle2/restore_format_grid_plugin.class.php
(#101) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#150) Line exceeds 132 characters; contains 142 characters
(#196) Inline comments must start with a capital letter, digit or 3-dots sequence
(#219) Inline comments must start with a capital letter, digit or 3-dots sequence
course/format/grid/classes/admin_setting_information.php
(#133) Line exceeds 132 characters; contains 151 characters
course/format/grid/classes/output/courseformat/content.php
(#130) Line exceeds 132 characters; contains 166 characters
(#146) Line exceeds 132 characters; contains 151 characters
(#157) Line exceeds 132 characters; contains 147 characters
(#196) Inline comments must end in full-stops, exclamation marks, or question marks
(#203) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
course/format/grid/classes/output/courseformat/content/section/summary.php
(#114) Line exceeds 132 characters; contains 134 characters
(#134) Line exceeds 132 characters; contains 159 characters
course/format/grid/classes/toolbox.php
(#42) This comment is 44% valid code; is this commented out code?
(#153) Inline comments must start with a capital letter, digit or 3-dots sequence
(#153) This comment is 59% valid code; is this commented out code?
(#154) Inline comments must end in full-stops, exclamation marks, or question marks
(#182) Line exceeds 132 characters; contains 145 characters
(#225) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#254) This comment is 56% valid code; is this commented out code?
(#274) This comment is 56% valid code; is this commented out code?
(#312) Logical operator "or" is prohibited; use "||" instead
(#312) Logical operator "or" is prohibited; use "||" instead
(#317) Inline comments must start with a capital letter, digit or 3-dots sequence
(#317) Inline comments must end in full-stops, exclamation marks, or question marks
(#317) This comment is 64% valid code; is this commented out code?
(#324) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#333) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#338) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#355) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#355) Line exceeds 132 characters; contains 135 characters
(#365) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#365) Line exceeds 132 characters; contains 135 characters
(#377) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#377) Line exceeds 132 characters; contains 136 characters
(#386) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#386) Line exceeds 132 characters; contains 135 characters
(#392) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#392) Line exceeds 132 characters; contains 136 characters
(#486) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#560) Line exceeds 132 characters; contains 166 characters
course/format/grid/form/sectionfilemanager.php
(#48) Variable "elementName" must be all lower-case
(#48) Variable "elementLabel" must be all lower-case
(#49) Variable "elementName" must be all lower-case
(#49) Variable "elementLabel" must be all lower-case
(#58) Public method name "MoodleQuickForm_sectionfilemanager::validateSubmitValue" must be in lower-case letters only
(#76) Line exceeds 132 characters; contains 164 characters
(#94) Line exceeds 132 characters; contains 137 characters
(#140) Public method name "MoodleQuickForm_sectionfilemanager::toHtml" must be in lower-case letters only
(#153) Line exceeds 132 characters; contains 149 characters
(#155) Whitespace found at end of line
course/format/grid/lib.php
(#68) Line exceeds 132 characters; contains 136 characters
(#652) Inline comments must start with a capital letter, digit or 3-dots sequence
(#652) This comment is 71% valid code; is this commented out code?
(#768) Inline comments must end in full-stops, exclamation marks, or question marks
(#786) Inline comments must start with a capital letter, digit or 3-dots sequence
(#786) Inline comments must end in full-stops, exclamation marks, or question marks
(#786) This comment is 70% valid code; is this commented out code?
(#804) Logical operator "or" is prohibited; use "||" instead
(#804) Line exceeds 132 characters; contains 140 characters
course/format/grid/version.php
(#35) This comment is 50% valid code; is this commented out code?

Javascript coding style problems

(0 errors, 7 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

course/format/grid/format.js
(#43) Identifier 'get_config' is not in camel case. (camelcase)
(#45) Identifier 'container_node' is not in camel case. (camelcase)
(#46) Identifier 'container_class' is not in camel case. (camelcase)
(#47) Identifier 'section_node' is not in camel case. (camelcase)
(#48) Identifier 'section_class' is not in camel case. (camelcase)
(#59) Identifier 'swap_sections' is not in camel case. (camelcase)
(#81) Identifier 'process_sections' is not in camel case. (camelcase)

CSS problems

(1 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

course/format/grid/styles.css
(#47) Expected single space after "," in a single-line function (function-comma-space-after)

PHPDocs style problems

(36 errors, 17 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

course/format/grid/backup/moodle2/backup_format_grid_plugin.class.php
(#21) Not recommended phpdocs tag @version used
course/format/grid/backup/moodle2/restore_format_grid_plugin.class.php
(#106) Function restore_format_grid_plugin::after_execute_structure is not documented
(#31) No one-line description found in phpdocs for class restore_format_grid_plugin
(#81) Phpdocs for function restore_format_grid_plugin::process_grid has incomplete parameters list
(#202) Phpdocs for function restore_format_grid_plugin::process_gridsection has incomplete parameters list
(#21) Not recommended phpdocs tag @version used
course/format/grid/classes/admin_setting_information.php
(#17) No one-line description found in phpdocs for file
(#22) Not recommended phpdocs tag @version used
course/format/grid/classes/admin_setting_markdown.php
(#17) No one-line description found in phpdocs for file
(#22) Not recommended phpdocs tag @version used
course/format/grid/classes/observer.php
(#66) Function format_grid_observer::delete_images is not documented
(#22) Not recommended phpdocs tag @version used
course/format/grid/classes/output/courseformat/content.php
(#48) Function content::get_template_name is not documented
course/format/grid/classes/output/courseformat/content/section/controlmenu.php
(#17) No one-line description found in phpdocs for file
(#22) Not recommended phpdocs tag @version used
course/format/grid/classes/output/courseformat/content/section/summary.php
(#43) Package core_courseformat is not valid
(#17) No one-line description found in phpdocs for file
(#22) Not recommended phpdocs tag @version used
course/format/grid/classes/output/renderer.php
(#21) Not recommended phpdocs tag @version used
course/format/grid/classes/privacy/provider.php
(#22) Not recommended phpdocs tag @version used
course/format/grid/classes/toolbox.php
(#497) Function toolbox::debugdata_decode is not documented
(#578) Function toolbox::delete_images is not documented
(#43) Variable toolbox::$imagecontainerwidths is not documented
(#46) Variable toolbox::$imagecontainerratios is not documented
(#101) Phpdocs for function toolbox::check_displayed_image has incomplete parameters list
(#21) Not recommended phpdocs tag @version used
course/format/grid/db/events.php
(#22) Not recommended phpdocs tag @version used
course/format/grid/db/upgrade.php
(#29) Function xmldb_format_grid_upgrade is not documented
(#21) Not recommended phpdocs tag @version used
course/format/grid/form/sectionfilemanager.php
(#31) Class MoodleQuickForm_sectionfilemanager is not documented
(#33) Variable MoodleQuickForm_sectionfilemanager::$options is not documented
course/format/grid/format.php
(#21) Not recommended phpdocs tag @version used
course/format/grid/lang/en/format_grid.php
(#21) Not recommended phpdocs tag @version used
course/format/grid/lib.php
(#774) Package block_html is not valid
(#33) Class format_grid is not documented
(#100) Function format_grid::uses_course_index is not documented
(#104) Function format_grid::uses_indentation is not documented
(#216) Function format_grid::supports_components is not documented
(#557) Function format_grid::section_format_options is not documented
(#714) Function format_grid::section_action is not documented
(#35) Variable format_grid::$coursedisplay is not documented
(#37) Variable format_grid::$settings is not documented
(#21) Not recommended phpdocs tag @version used
(#42) Inline phpdocs tag {@link course_get_format($courseorid)} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#206) Inline phpdocs tag {@link ajaxenabled()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#448) Inline phpdocs tag {@link course_edit_form::definition_after_data()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#490) Inline phpdocs tag {@link moodleform::get_data()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#491) Inline phpdocs tag {@link update_course()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#627) Inline phpdocs tag {@link course_delete_section()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#661) Inline phpdocs tag {@link course_can_delete_section()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
course/format/grid/settings.php
(#17) No one-line description found in phpdocs for file
(#22) Not recommended phpdocs tag @version used
course/format/grid/version.php
(#21) Not recommended phpdocs tag @version used

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 18 warnings)

This section shows problems detected in mustache templates [More info]

course/format/grid/templates/coursestyles.mustache
(#1) Template produced no content
course/format/grid/templates/local/content.mustache
(#1) HTML Validation error, line 43: Bad value “” for attribute “id” on element “li”: An ID must not be the empty string. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 121: Duplicate ID “”. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation info, line 43: The first occurrence of ID “” was here. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 121: Bad value “” for attribute “id” on element “li”: An ID must not be the empty string. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 199: Duplicate ID “”. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="5" > )
(#1) HTML Validation info, line 43: The first occurrence of ID “” was here. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 199: Bad value “” for attribute “id” on element “li”: An ID must not be the empty string. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="5" > )
(#1) HTML Validation error, line 241: Duplicate ID “section-1”. ( <li id="section-1" class="section course-section main clearfix current " data-sectionid="1" data-sectionreturnid="" data-for="section" data-id="35" data-number="1" > )
(#1) HTML Validation info, line 70: The first occurrence of ID “section-1” was here. ( <li id="section-1" class="section course-section main clearfix current " data-sectionid="1" data-sectionreturnid="" data-for="section" data-id="35" data-number="1" > )
(#1) HTML Validation error, line 257: Duplicate ID “collapssesection1”. ( <a role="button" data-toggle="collapse" href="#coursecontentcollapse1" id="collapssesection1" aria-expanded="true" aria-controls="coursecontentcollapse1" class="btn btn-icon mr-1 icons-collapse-expand justify-content-center stretched-link " aria-label="Single Section Example"> )
(#1) HTML Validation info, line 86: The first occurrence of ID “collapssesection1” was here. ( <a role="button" data-toggle="collapse" href="#coursecontentcollapse1" id="collapssesection1" aria-expanded="true" aria-controls="coursecontentcollapse1" class="btn btn-icon mr-1 icons-collapse-expand justify-content-center stretched-link " aria-label="Section title"> )
(#1) HTML Validation error, line 267: Duplicate ID “coursecontentsection1”. ( <h3 class="sectionid-35-title sectionname course-content-item d-flex align-self-stretch align-items-center mb-0" id="coursecontentsection1" data-for="section_title" data-id="35" data-number="1"> )
(#1) HTML Validation info, line 96: The first occurrence of ID “coursecontentsection1” was here. ( <h3 class="sectionid-35-title sectionname course-content-item d-flex align-self-stretch align-items-center mb-0" id="coursecontentsection1" data-for="section_title" data-id="35" data-number="1"> )
(#1) HTML Validation error, line 278: Duplicate ID “coursecontentcollapse1”. ( <div id="coursecontentcollapse1" class="content course-content-item-content collapse show "> )
(#1) HTML Validation info, line 107: The first occurrence of ID “coursecontentcollapse1” was here. ( <div id="coursecontentcollapse1" class="content course-content-item-content collapse show "> )
(#1) HTML Validation error, line 292: Duplicate ID “”. ( <li class="activity activity-wrapper assign modtype_assign " id="" data-for="cmitem" data-id="4" > )
(#1) HTML Validation info, line 43: The first occurrence of ID “” was here. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 292: Bad value “” for attribute “id” on element “li”: An ID must not be the empty string. ( <li class="activity activity-wrapper assign modtype_assign " id="" data-for="cmitem" data-id="4" > )

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]