PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(84 errors, 30 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- course/format/grid/backup/moodle2/restore_format_grid_plugin.class.php
- (#142) Line exceeds 132 characters; contains 147 characters
- (#146) Line exceeds 132 characters; contains 143 characters
- (#152) Line exceeds 132 characters; contains 152 characters
- course/format/grid/config.php
- (#32) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
- course/format/grid/format.php
- (#89) Line indented incorrectly; expected 8 spaces, found 0
- (#90) Line indented incorrectly; expected at least 12 spaces, found 4
- (#91) Line indented incorrectly; expected 8 spaces, found 0
- (#92) Line indented incorrectly; expected at least 8 spaces, found 0
- (#95) Line indented incorrectly; expected 8 spaces, found 0
- (#96) Line indented incorrectly; expected at least 12 spaces, found 4
- (#97) Line indented incorrectly; expected 8 spaces, found 0
- (#98) Line indented incorrectly; expected at least 8 spaces, found 0
- (#102) Line indented incorrectly; expected 8 spaces, found 0
- (#103) Line indented incorrectly; expected at least 12 spaces, found 4
- (#104) Line indented incorrectly; expected 8 spaces, found 0
- (#123) Line indented incorrectly; expected 8 spaces, found 0
- (#124) Line indented incorrectly; expected at least 12 spaces, found 4
- (#125) Line indented incorrectly; expected 8 spaces, found 0
- (#126) Line indented incorrectly; expected at least 8 spaces, found 0
- (#132) Line indented incorrectly; expected 8 spaces, found 0
- (#133) Line indented incorrectly; expected at least 12 spaces, found 4
- (#134) Line indented incorrectly; expected 8 spaces, found 0
- (#135) Line indented incorrectly; expected at least 8 spaces, found 0
- course/format/grid/js/gf_colourpopup.php
- (#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
- (#42) Member variable "_hiddenLabel" must be all lower-case
- (#44) Public method name "MoodleQuickForm_gfcolourpopup::MoodleQuickForm_gfcolourpopup" must be in lower-case letters only
- (#44) PHP4 style constructors are not allowed; use "__construct()" instead
- (#44) Variable "elementName" must be all lower-case
- (#44) Variable "elementLabel" must be all lower-case
- (#45) PHP4 style calls to parent constructors are not allowed; use "parent::__construct()" instead
- (#45) Variable "elementName" must be all lower-case
- (#45) Variable "elementLabel" must be all lower-case
- (#49) Public method name "MoodleQuickForm_gfcolourpopup::setHiddenLabel" must be in lower-case letters only
- (#49) Variable "hiddenLabel" must be all lower-case
- (#50) Variable "hiddenLabel" must be all lower-case
- (#53) Public method name "MoodleQuickForm_gfcolourpopup::toHtml" must be in lower-case letters only
- (#84) Public method name "MoodleQuickForm_gfcolourpopup::_generateId" must be in lower-case letters only
- (#98) Public method name "MoodleQuickForm_gfcolourpopup::setHelpButton" must be in lower-case letters only
- (#107) Public method name "MoodleQuickForm_gfcolourpopup::getHelpButton" must be in lower-case letters only
- (#118) Public method name "MoodleQuickForm_gfcolourpopup::getElementTemplateType" must be in lower-case letters only
- course/format/grid/lib.php
- (#33) This comment is 43% valid code; is this commented out code?
- (#34) This comment is 57% valid code; is this commented out code?
- (#37) This comment is 52% valid code; is this commented out code?
- (#46) This comment is 50% valid code; is this commented out code?
- (#1252) This comment is 53% valid code; is this commented out code?
- (#1253) This comment is 50% valid code; is this commented out code?
- (#1254) This comment is 50% valid code; is this commented out code?
- (#1255) This comment is 50% valid code; is this commented out code?
- (#1256) This comment is 50% valid code; is this commented out code?
- (#1259) This comment is 50% valid code; is this commented out code?
- (#1262) This comment is 50% valid code; is this commented out code?
- (#1265) This comment is 50% valid code; is this commented out code?
- (#1272) This comment is 53% valid code; is this commented out code?
- (#1273) This comment is 50% valid code; is this commented out code?
- (#1276) This comment is 50% valid code; is this commented out code?
- (#1279) This comment is 50% valid code; is this commented out code?
- (#1280) This comment is 50% valid code; is this commented out code?
- (#1281) This comment is 50% valid code; is this commented out code?
- (#1282) This comment is 50% valid code; is this commented out code?
- (#1285) This comment is 50% valid code; is this commented out code?
- course/format/grid/renderer.php
- (#538) This comment is 50% valid code; is this commented out code?
- course/format/grid/test/test_footer.php
- (#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
- course/format/grid/test/test_header.php
- (#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
- course/format/grid/test/test_image.php
- (#31) Expected 1 space before comment text but found 5; use block comment if you need indentation
- (#35) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
- (#100) The use of function print_r() is forbidden
- (#129) Line exceeds maximum limit of 180 characters; contains 182 characters
- (#134) The use of function print_r() is forbidden
- course/format/grid/upgrade/convert_legacy_image.php
- (#2) The opening <?php tag must be followed by exactly one newline.
- (#28) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
- (#81) The use of function print_r() is forbidden
- (#91) The use of function print_r() is forbidden
- (#92) The use of function error_log() is forbidden
- (#92) The use of function print_r() is forbidden
- (#110) The use of function print_r() is forbidden
- (#115) The use of function print_r() is forbidden
- (#116) The use of function error_log() is forbidden
- (#116) The use of function print_r() is forbidden
- (#122) The use of function error_log() is forbidden
- (#124) Variable "temp_file" must not contain underscores.
- (#126) The use of function print_r() is forbidden
- (#126) Variable "temp_file" must not contain underscores.
- (#127) The use of function error_log() is forbidden
- (#127) The use of function print_r() is forbidden
- (#127) Variable "temp_file" must not contain underscores.
- (#141) Variable "convert_success" must not contain underscores.
- (#142) Variable "temp_file" must not contain underscores.
- (#147) Variable "temp_file" must not contain underscores.
- (#148) Variable "temp_file" must not contain underscores.
- (#154) Variable "convert_success" must not contain underscores.
- (#158) Variable "convert_success" must not contain underscores.
- (#160) The use of function error_log() is forbidden
- (#163) The use of function error_log() is forbidden
- (#166) Variable "temp_file" must not contain underscores.
- (#167) Variable "temp_file" must not contain underscores.
- (#168) Variable "temp_file" must not contain underscores.
- (#168) Line exceeds 132 characters; contains 148 characters
- (#170) Variable "temp_file" must not contain underscores.
- (#171) Variable "temp_file" must not contain underscores.
- (#175) Variable "temp_file" must not contain underscores.
- (#176) Variable "temp_file" must not contain underscores.
- (#177) Variable "temp_file" must not contain underscores.
- (#184) The use of function error_log() is forbidden
- (#187) Line exceeds 132 characters; contains 143 characters
- (#188) The use of function error_log() is forbidden
- (#188) Line exceeds 132 characters; contains 141 characters
- (#193) The use of function error_log() is forbidden
- (#197) The use of function error_log() is forbidden
- (#201) The use of function error_log() is forbidden
- (#207) The use of function print_r() is forbidden
- (#208) The use of function error_log() is forbidden
- (#208) The use of function print_r() is forbidden
- (#213) The use of function error_log() is forbidden
- course/format/grid/version.php
- (#35) This comment is 45% valid code; is this commented out code?
Javascript coding style problems
(0 errors, 40 warnings)
This section shows the coding style problems detected in the code by jshint [More info]
- course/format/grid/js/gf_colourpopup.js
- (#56) Line is too long.
- (#58) Line is too long.
- (#176) Use '===' to compare with '0'.
- (#63) 'e' is defined but never used.
- (#78) 'e' is defined but never used.
- (#81) 'e' is defined but never used.
- (#85) 'e' is defined but never used.
- (#89) 'e' is defined but never used.
- (#100) 'e' is defined but never used.
- course/format/grid/yui/gridkeys/gridkeys.js
- (#1) Line is too long.
- (#1) Expected an assignment or function call and instead saw an expression.
- (#1) Missing semicolon.
- (#1) Missing semicolon.
- (#1) Missing semicolon.
- (#1) Missing semicolon.
- (#1) Missing semicolon.
- (#1) Missing semicolon.
- (#1) Missing semicolon.
- (#1) Missing semicolon.
- (#1) Expected an assignment or function call and instead saw an expression.
- (#1) Missing semicolon.
- (#1) Confusing use of '!'.
- (#1) Expected an assignment or function call and instead saw an expression.
- (#1) Missing semicolon.
- (#1) Expected an assignment or function call and instead saw an expression.
- (#1) Missing semicolon.
- (#1) Missing semicolon.
- (#1) Expected an assignment or function call and instead saw an expression.
- (#1) Missing semicolon.
- (#1) Expected an assignment or function call and instead saw an expression.
- (#1) Missing semicolon.
- (#1) Expected an assignment or function call and instead saw an expression.
- (#1) Missing semicolon.
- (#1) Expected an assignment or function call and instead saw an expression.
- (#1) Missing semicolon.
- (#1) Expected an assignment or function call and instead saw an expression.
- (#1) Missing semicolon.
- (#1) Expected an assignment or function call and instead saw an expression.
- (#1) 't' is defined but never used.
- course/format/grid/yui/src/gridkeys/js/event-nav-keys-min.js
- (#1) Line is too long.
CSS problems
(0 errors, 1 warnings)
This section shows CSS problems detected by csslint [More info]
- course/format/grid/styles.css
- (#50) Use of !important
PHPDocs style problems
(89 errors, 5 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- course/format/grid/backup/moodle2/backup_format_grid_plugin.class.php
- (#61) Function backup_format_grid_plugin::delete_displayed_images is not documented
- (#30) Class backup_format_grid_plugin does not have @copyright tag
- (#30) Class backup_format_grid_plugin does not have @license tag
- (#22) Not recommended phpdocs tag @version used
- (#20) Package course/format is not valid
- course/format/grid/backup/moodle2/restore_format_grid_plugin.class.php
- (#85) Function restore_format_grid_plugin::after_execute_structure is not documented
- (#31) No one-line description found in phpdocs for class restore_format_grid_plugin
- (#56) Phpdocs for function restore_format_grid_plugin::process_grid has incomplete parameters list
- (#106) Phpdocs for function restore_format_grid_plugin::process_gridsection has incomplete parameters list
- (#31) Class restore_format_grid_plugin does not have @copyright tag
- (#31) Class restore_format_grid_plugin does not have @license tag
- (#22) Not recommended phpdocs tag @version used
- (#20) Package course/format is not valid
- course/format/grid/config.php
- (#22) Not recommended phpdocs tag @version used
- (#20) Package course/format is not valid
- course/format/grid/db/access.php
- (#20) Package course/format is not valid
- course/format/grid/db/upgrade.php
- (#31) Function xmldb_format_grid_upgrade is not documented
- (#20) Package course/format is not valid
- course/format/grid/editimage.php
- (#20) Package course/format is not valid
- course/format/grid/editimage_form.php
- (#31) Class grid_image_form is not documented
- (#33) Function grid_image_form::definition is not documented
- (#20) Package course/format is not valid
- course/format/grid/format.php
- (#20) Package course/format is not valid
- course/format/grid/js/gf_colourpopup.php
- (#44) Function MoodleQuickForm_gfcolourpopup::MoodleQuickForm_gfcolourpopup is not documented
- (#49) Function MoodleQuickForm_gfcolourpopup::setHiddenLabel is not documented
- (#53) Function MoodleQuickForm_gfcolourpopup::toHtml is not documented
- (#41) Variable MoodleQuickForm_gfcolourpopup::$_helpbutton is not documented
- (#42) Variable MoodleQuickForm_gfcolourpopup::$_hiddenLabel is not documented
- (#95) Phpdocs for function MoodleQuickForm_gfcolourpopup::setHelpButton has incomplete parameters list
- (#28) Class MoodleQuickForm_gfcolourpopup does not have @copyright tag
- (#28) Class MoodleQuickForm_gfcolourpopup does not have @license tag
- (#32) Not recommended phpdocs tag @access used
- (#20) Package course/format is not valid
- course/format/grid/lang/en/format_grid.php
- (#20) Package course/format is not valid
- course/format/grid/lang/en_ar/format_grid.php
- (#20) Package course/format is not valid
- course/format/grid/lang/en_us/format_grid.php
- (#20) Package course/format is not valid
- course/format/grid/lang/es/format_grid.php
- (#20) Package course/format is not valid
- course/format/grid/lang/fr/format_grid.php
- (#20) Package course/format is not valid
- course/format/grid/lang/ru/format_grid.php
- (#20) Package course/format is not valid
- course/format/grid/lib.php
- (#31) Class format_grid is not documented
- (#174) Function format_grid::get_maximum_image_width is not documented
- (#1293) Function format_grid::create_original_image_record is not documented
- (#1309) Function format_grid::create_section_image is not documented
- (#1457) Function format_grid::delete_image is not documented
- (#1479) Function format_grid::delete_images is not documented
- (#1504) Function format_grid::delete_displayed_images is not documented
- (#35) Variable format_grid::$imagecontainerwidths is not documented
- (#38) Variable format_grid::$imagecontainerratios is not documented
- (#41) Variable format_grid::$borderwidths is not documented
- (#45) Variable format_grid::$currentwidth is not documented
- (#46) Variable format_grid::$currentratio is not documented
- (#47) Variable format_grid::$currentborderwidth is not documented
- (#48) Variable format_grid::$currentheight is not documented
- (#49) Variable format_grid::$activitymargintop is not documented
- (#50) Variable format_grid::$activitymarginleft is not documented
- (#51) Variable format_grid::$settings is not documented
- (#985) Phpdocs for function format_grid::reset_grid_setting has incomplete parameters list
- (#1244) Phpdocs for function format_grid::calculate_height has incomplete parameters list
- (#1561) Phpdocs for function format_grid::generate_image has incomplete parameters list
- (#1729) Phpdocs for function callback_grid_load_content has incomplete parameters list
- (#1747) Phpdocs for function format_grid_delete_course has incomplete parameters list
- (#1106) Invalid phpdocs tag @returns used
- (#1128) Invalid phpdocs tag @returns used
- (#20) Package course/format is not valid
- course/format/grid/mod_summary.php
- (#20) Package course/format is not valid
- course/format/grid/renderer.php
- (#31) Class format_grid_renderer is not documented
- (#690) Function format_grid_renderer::make_block_icon_topics_editing is not documented
- (#960) Function format_grid_renderer::set_portable is not documented
- (#33) Variable format_grid_renderer::$topic0attop is not documented
- (#34) Variable format_grid_renderer::$courseformat is not documented
- (#35) Variable format_grid_renderer::$settings is not documented
- (#36) Variable format_grid_renderer::$shadeboxshownarray is not documented
- (#37) Variable format_grid_renderer::$portable is not documented
- (#135) Phpdocs for function format_grid_renderer::section_nav_selection has incomplete parameters list
- (#443) Phpdocs for function format_grid_renderer::make_block_topic0 has incomplete parameters list
- (#517) Phpdocs for function format_grid_renderer::make_block_icon_topics has incomplete parameters list
- (#734) Phpdocs for function format_grid_renderer::make_block_show_clipboard_if_file_moving has incomplete parameters list
- (#754) Phpdocs for function format_grid_renderer::make_block_topics has incomplete parameters list
- (#871) Phpdocs for function format_grid_renderer::get_title has incomplete parameters list
- (#909) Phpdocs for function format_grid_renderer::is_empty_text has incomplete parameters list
- (#917) Phpdocs for function format_grid_renderer::text_limit has incomplete parameters list
- (#932) Phpdocs for function format_grid_renderer::new_activity has incomplete parameters list
- (#20) Package course/format is not valid
- course/format/grid/settings.php
- (#20) Package course/format is not valid
- course/format/grid/test/test_footer.php
- (#20) Package course/format is not valid
- course/format/grid/test/test_header.php
- (#20) Package course/format is not valid
- course/format/grid/test/test_image.php
- (#20) Package course/format is not valid
- course/format/grid/upgrade/convert_legacy_image.php
- (#2) Empty line found after PHP open tag
- (#39) Function grid_get_courseids is not documented
- (#48) Function course_get_courseids is not documented
- (#57) Function grid_get_icons is not documented
- (#70) Function grid_files is not documented
- (#21) Package course/format is not valid
- course/format/grid/version.php
- (#20) Package course/format is not valid
Update savepoints problems
(6 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
- course/format/grid/db/upgrade.php
- Detected more 'if' blocks (5) than 'savepoint' calls (0)
- version 2011041802 is missing corresponding savepoint call
- version 2012011701 is missing corresponding savepoint call
- version 2012071500 is missing corresponding savepoint call
- version 2013110400 is missing corresponding savepoint call
- version 2114052000 is missing corresponding savepoint call
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
grunt changes
(1 errors, 0 warnings)
This section shows files built by grunt and not commited [More info]
- Problems running grunt shifter
shifter problems
(3 errors, 0 warnings)
This section shows problems detected by shifter [More info]
- course/format/grid/yui/src/gridkeys/js/gridkeys.js
- contains 3 lint errors
- stderr output from "/usr/bin/nodejs" ./scripts/backport.js moodle-format_grid-gridkeys
- stderr output from "/usr/bin/nodejs" ./scripts/backport.js moodle-format_grid-gridkeys
Mustache template problems
(0 errors, 0 warnings)
This section shows problems detected in mustache templates [More info]