PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(25 errors, 60 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

course/format/flexible/backup/moodle2/restore_format_flexible_plugin.class.php: (#129) Line exceeds 132 characters; contains 135 characters
course/format/flexible/js/ff_colourpopup.php: (#50) Member variable "_hiddenLabel" must be all lower-case; (#52) Variable "elementName" must be all lower-case; (#52) Variable "elementLabel" must be all lower-case; (#53) Variable "elementName" must be all lower-case; (#53) Variable "elementLabel" must be all lower-case; (#63) Public method name "MoodleQuickForm_ffcolourpopup::MoodleQuickForm_gfcolourpopup" must be in lower-case letters only; (#63) Variable "elementName" must be all lower-case; (#63) Variable "elementLabel" must be all lower-case; (#64) Variable "elementName" must be all lower-case; (#64) Variable "elementLabel" must be all lower-case; (#67) Public method name "MoodleQuickForm_ffcolourpopup::setHiddenLabel" must be in lower-case letters only; (#67) Variable "hiddenLabel" must be all lower-case; (#68) Variable "hiddenLabel" must be all lower-case; (#71) Public method name "MoodleQuickForm_ffcolourpopup::toHtml" must be in lower-case letters only; (#102) Public method name "MoodleQuickForm_ffcolourpopup::_generateId" must be in lower-case letters only; (#116) Public method name "MoodleQuickForm_ffcolourpopup::setHelpButton" must be in lower-case letters only; (#125) Public method name "MoodleQuickForm_ffcolourpopup::getHelpButton" must be in lower-case letters only; (#136) Public method name "MoodleQuickForm_ffcolourpopup::getElementTemplateType" must be in lower-case letters only
course/format/flexible/lang/en/format_flexible.php: (#51) Inline comments must start with a capital letter, digit or 3-dots sequence; (#51) Inline comments must end in full-stops, exclamation marks, or question marks; (#51) This comment is 67% valid code; is this commented out code?; (#51) No space found before comment text; expected "// $string['closeshadebox'] = 'Close shade box';" but found "//$string['closeshadebox'] = 'Close shade box';"
course/format/flexible/lib.php: (#38) This comment is 53% valid code; is this commented out code?; (#45) This comment is 50% valid code; is this commented out code?; (#915) Line exceeds 132 characters; contains 137 characters; (#917) Line exceeds 132 characters; contains 175 characters; (#919) Line exceeds 132 characters; contains 151 characters; (#1156) Line exceeds 132 characters; contains 142 characters; (#1168) Line exceeds 132 characters; contains 140 characters; (#1180) Line exceeds 132 characters; contains 137 characters; (#1192) Line exceeds 132 characters; contains 136 characters; (#1204) Line exceeds 132 characters; contains 138 characters; (#1216) Line exceeds 132 characters; contains 138 characters; (#1278) Line exceeds 132 characters; contains 144 characters; (#1282) Line exceeds 132 characters; contains 142 characters; (#1286) Line exceeds 132 characters; contains 139 characters; (#1290) Line exceeds 132 characters; contains 138 characters; (#1294) Line exceeds 132 characters; contains 140 characters; (#1298) Line exceeds 132 characters; contains 140 characters; (#1717) Line exceeds 132 characters; contains 139 characters; (#1721) Line exceeds 132 characters; contains 135 characters; (#1743) Line exceeds 132 characters; contains 141 characters; (#1814) Inline comments must start with a capital letter, digit or 3-dots sequence; (#1939) This comment is 54% valid code; is this commented out code?; (#1940) This comment is 50% valid code; is this commented out code?; (#1941) This comment is 50% valid code; is this commented out code?; (#1942) This comment is 50% valid code; is this commented out code?; (#1943) This comment is 50% valid code; is this commented out code?; (#1946) This comment is 50% valid code; is this commented out code?; (#1949) This comment is 50% valid code; is this commented out code?; (#1952) This comment is 50% valid code; is this commented out code?; (#1955) This comment is 50% valid code; is this commented out code?; (#1962) This comment is 54% valid code; is this commented out code?; (#1963) This comment is 50% valid code; is this commented out code?; (#1966) This comment is 50% valid code; is this commented out code?; (#1969) This comment is 50% valid code; is this commented out code?; (#1970) This comment is 50% valid code; is this commented out code?; (#1971) This comment is 50% valid code; is this commented out code?; (#1972) This comment is 50% valid code; is this commented out code?; (#1973) This comment is 50% valid code; is this commented out code?; (#1976) This comment is 50% valid code; is this commented out code?; (#2102) Line exceeds 132 characters; contains 140 characters; (#2122) Line exceeds 132 characters; contains 135 characters; (#2365) Line exceeds 132 characters; contains 134 characters
course/format/flexible/mod_summary.php: (#30) Inline comments must start with a capital letter, digit or 3-dots sequence; (#30) Inline comments must end in full-stops, exclamation marks, or question marks; (#30) This comment is 64% valid code; is this commented out code?; (#30) No space found before comment text; expected "// require_once($CFG->dirroot . '/course/format/flexible/lib.php');" but found "//require_once($CFG->dirroot . '/course/format/flexible/lib.php');"
course/format/flexible/renderer.php: (#707) Line exceeds 132 characters; contains 134 characters; (#746) This comment is 50% valid code; is this commented out code?; (#839) Line exceeds 132 characters; contains 146 characters; (#1069) Line exceeds 132 characters; contains 178 characters; (#1082) Line exceeds 132 characters; contains 146 characters; (#1237) Line exceeds 132 characters; contains 135 characters; (#1364) Inline comments must end in full-stops, exclamation marks, or question marks; (#1395) Inline comments must end in full-stops, exclamation marks, or question marks; (#1433) Expected 1 space before ".="; 0 found; (#1434) Expected 1 space before "=>"; 0 found; (#1434) Expected 1 space after "=>"; 0 found; (#1435) Expected 1 space before "=>"; 0 found; (#1437) Expected 1 space before ".="; 0 found; (#1535) Inline comments must start with a capital letter, digit or 3-dots sequence; (#1535) Inline comments must end in full-stops, exclamation marks, or question marks
course/format/flexible/version.php: (#35) This comment is 42% valid code; is this commented out code?

Javascript coding style problems

(15 errors, 94 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

course/format/flexible/amd/src/sectionexpandable.js: (#41) Missing semicolon. (semi)
course/format/flexible/amd/src/sectionsummary.js: (#29) Missing semicolon. (semi)
course/format/flexible/format.js: (#43) Identifier 'get_config' is not in camel case. (camelcase); (#45) Identifier 'container_node' is not in camel case. (camelcase); (#45) Extra space after key 'container_node'. (key-spacing); (#46) Extra space after key 'container_class'. (key-spacing); (#46) Identifier 'container_class' is not in camel case. (camelcase); (#47) Identifier 'section_node' is not in camel case. (camelcase); (#47) Extra space after key 'section_node'. (key-spacing); (#48) Identifier 'section_class' is not in camel case. (camelcase); (#48) Extra space after key 'section_class'. (key-spacing); (#52) Unexpected @return tag; function has no return statement. (valid-jsdoc); (#60) Identifier 'swap_sections' is not in camel case. (camelcase); (#62) Extra space after key 'COURSECONTENT'. (key-spacing); (#63) Extra space after key 'SECTIONADDMENUS'. (key-spacing); (#71) Unexpected @return tag; function has no return statement. (valid-jsdoc); (#71) Expected JSDoc for 'sectionlist' but found 'response'. (valid-jsdoc); (#71) Expected JSDoc for 'response' but found 'sectionfrom'. (valid-jsdoc); (#71) Expected JSDoc for 'sectionfrom' but found 'sectionto'. (valid-jsdoc); (#80) Identifier 'process_sections' is not in camel case. (camelcase); (#82) Extra space after key 'SECTIONNAME'. (key-spacing); (#83) Extra space after key 'SECTIONLEFTSIDE'. (key-spacing)
course/format/flexible/Gruntfile.js: (#44) 'module' is not defined. (no-undef); (#54) Unexpected console statement. (no-console); (#55) Unexpected console statement. (no-console); (#62) 'process' is not defined. (no-undef); (#69) 'process' is not defined. (no-undef); (#81) Comments should not begin with a lowercase character (capitalized-comments); (#97) Identifier 'dynamic_mappings' is not in camel case. (camelcase)
course/format/flexible/js/ff_colourpopup.js: (#29) Identifier 'init_ffcolour_popup' is not in camel case. (camelcase); (#30) Missing space before opening brace. (space-before-blocks); (#35) Extra space after key 'box'. (key-spacing); (#36) Extra space after key 'input'. (key-spacing); (#37) Extra space after key 'swatch'. (key-spacing); (#38) Extra space after key 'image'. (key-spacing); (#39) Extra space after key 'preview'. (key-spacing); (#40) Extra space after key 'current'. (key-spacing); (#41) Extra space after key 'eventClick'. (key-spacing); (#42) Extra space after key 'eventFocus'. (key-spacing); (#43) Extra space after key 'eventMouseEnter'. (key-spacing); (#44) Extra space after key 'eventMouseLeave'. (key-spacing); (#45) Extra space after key 'eventMouseMove'. (key-spacing); (#46) Extra space after key 'width'. (key-spacing); (#47) Extra space after key 'height'. (key-spacing); (#48) Extra space after key 'factor'. (key-spacing); (#52) Extra space after key 'init'. (key-spacing); (#59) Line 59 exceeds the maximum line length of 132. (max-len); (#61) Line 61 exceeds the maximum line length of 132. (max-len); (#61) Infix operators must be spaced. (space-infix-ops); (#63) Comments should not begin with a lowercase character (capitalized-comments); (#63) Expected space or tab after '//' in comment. (spaced-comment); (#65) Unary word operator 'typeof' must be followed by whitespace. (space-unary-ops); (#66) 'e' is defined but never used. (no-unused-vars); (#66) Missing space before opening brace. (space-before-blocks); (#76) A space is required after ','. (comma-spacing); (#76) A space is required after ','. (comma-spacing); (#81) 'e' is defined but never used. (no-unused-vars); (#81) Missing space before opening brace. (space-before-blocks); (#82) A space is required after ','. (comma-spacing); (#84) Extra space after key 'showColours'. (key-spacing); (#84) 'e' is defined but never used. (no-unused-vars); (#84) Missing space before opening brace. (space-before-blocks); (#88) Extra space after key 'setColour'. (key-spacing); (#88) 'e' is defined but never used. (no-unused-vars); (#88) Missing space before opening brace. (space-before-blocks); (#92) Extra space after key 'startFollow'. (key-spacing); (#92) 'e' is defined but never used. (no-unused-vars); (#95) Missing space before opening brace. (space-before-blocks); (#100) Missing JSDoc for parameter 'e'. (valid-jsdoc); (#103) Extra space after key 'endFollow'. (key-spacing); (#103) 'e' is defined but never used. (no-unused-vars); (#106) A space is required after ','. (comma-spacing); (#109) Missing JSDoc for parameter 'e'. (valid-jsdoc); (#112) Extra space after key 'pickColour'. (key-spacing); (#118) A space is required after ','. (comma-spacing); (#120) Missing JSDoc @returns for function. (valid-jsdoc); (#120) Missing JSDoc for parameter 'e'. (valid-jsdoc); (#123) Extra space after key 'determineColour'. (key-spacing); (#130) A space is required after ','. (comma-spacing); (#130) A space is required after ','. (comma-spacing); (#133) There should be no space after '['. (array-bracket-spacing); (#133) Multiple spaces found before '0'. (no-multi-spaces); (#133) Multiple spaces found before '1'. (no-multi-spaces); (#133) Multiple spaces found before '0'. (no-multi-spaces); (#134) There should be no space after '['. (array-bracket-spacing); (#134) Multiple spaces found before '0'. (no-multi-spaces); (#134) Multiple spaces found before '0'. (no-multi-spaces); (#135) There should be no space after '['. (array-bracket-spacing); (#135) Multiple spaces found before '0'. (no-multi-spaces); (#135) Multiple spaces found before '0'. (no-multi-spaces); (#135) Multiple spaces found before '1'. (no-multi-spaces); (#136) There should be no space after '['. (array-bracket-spacing); (#136) Multiple spaces found before '0'. (no-multi-spaces); (#136) Multiple spaces found before '0'. (no-multi-spaces); (#137) There should be no space after '['. (array-bracket-spacing); (#137) Multiple spaces found before '1'. (no-multi-spaces); (#137) Multiple spaces found before '0'. (no-multi-spaces); (#137) Multiple spaces found before '0'. (no-multi-spaces); (#138) There should be no space after '['. (array-bracket-spacing); (#138) Multiple spaces found before '0'. (no-multi-spaces); (#138) Multiple spaces found before '0'. (no-multi-spaces); (#149) Infix operators must be spaced. (space-infix-ops); (#150) Infix operators must be spaced. (space-infix-ops); (#151) Infix operators must be spaced. (space-infix-ops); (#171) Missing JSDoc @returns for function. (valid-jsdoc); (#171) Missing JSDoc for parameter 'rgb'. (valid-jsdoc); (#174) Identifier 'convert_rgb_to_hex' is not in camel case. (camelcase); (#174) Extra space after key 'convert_rgb_to_hex'. (key-spacing); (#182) Infix operators must be spaced. (space-infix-ops)

CSS problems

(8 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

course/format/flexible/styles.css: (#217) Invalid value for `-ms-filter` (csstree/validator); (#220) Invalid value for `filter` (csstree/validator); (#220) Unexpected duplicate "filter" (declaration-block-no-duplicate-properties); (#221) Unexpected duplicate "filter" (declaration-block-no-duplicate-properties); (#57) Expected single space after ":" with a single-line declaration (declaration-colon-space-after); (#61) Expected single space after ":" with a single-line declaration (declaration-colon-space-after); (#188) Expected indentation of 4 spaces (indentation); (#189) Expected indentation of 4 spaces (indentation)

PHPDocs style problems

(75 errors, 22 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

course/format/flexible/backup/moodle2/backup_format_flexible_plugin.class.php: (#50) Function backup_format_flexible_plugin::delete_displayed_images is not documented; (#21) Not recommended phpdocs tag @version used
course/format/flexible/backup/moodle2/restore_format_flexible_plugin.class.php: (#117) Function restore_format_flexible_plugin::after_execute_structure is not documented; (#31) No one-line description found in phpdocs for class restore_format_flexible_plugin; (#93) Phpdocs for function restore_format_flexible_plugin::process_flexible has incomplete parameters list; (#138) Phpdocs for function restore_format_flexible_plugin::process_flexiblesection has incomplete parameters list; (#21) Not recommended phpdocs tag @version used
course/format/flexible/classes/geopattern.php: (#36) Phpdocs for function geopattern::formaturi has incomplete parameters list; (#21) Not recommended phpdocs tag @version used
course/format/flexible/classes/observer.php: (#66) Function format_flexible_observer::delete_images is not documented; (#21) Not recommended phpdocs tag @version used
course/format/flexible/classes/privacy/provider.php: (#21) Not recommended phpdocs tag @version used
course/format/flexible/config.php: (#21) Not recommended phpdocs tag @version used
course/format/flexible/db/access.php: (#21) Not recommended phpdocs tag @version used
course/format/flexible/db/events.php: (#21) Not recommended phpdocs tag @version used
course/format/flexible/db/upgrade.php: (#31) Function xmldb_format_flexible_upgrade is not documented; (#21) Not recommended phpdocs tag @version used
course/format/flexible/editimage.php: (#21) Not recommended phpdocs tag @version used
course/format/flexible/editimage_form.php: (#32) Class flexible_image_form is not documented; (#34) Function flexible_image_form::definition is not documented; (#21) Not recommended phpdocs tag @version used
course/format/flexible/flexible_admin_setting_sectioncolours.php: (#30) Class flexible_admin_setting_sectioncolours is not documented; (#34) Phpdocs for function flexible_admin_setting_sectioncolours::validate has incomplete parameters list; (#21) Not recommended phpdocs tag @version used
course/format/flexible/format.php: (#21) Not recommended phpdocs tag @version used
course/format/flexible/js/ff_colourpopup.php: (#52) Function MoodleQuickForm_ffcolourpopup::__construct is not documented; (#63) Function MoodleQuickForm_ffcolourpopup::MoodleQuickForm_gfcolourpopup is not documented; (#67) Function MoodleQuickForm_ffcolourpopup::setHiddenLabel is not documented; (#71) Function MoodleQuickForm_ffcolourpopup::toHtml is not documented; (#144) Function MoodleQuickForm_ffcolourpopup::export_for_template is not documented; (#49) Variable MoodleQuickForm_ffcolourpopup::$_helpbutton is not documented; (#50) Variable MoodleQuickForm_ffcolourpopup::$_hiddenLabel is not documented; (#113) Phpdocs for function MoodleQuickForm_ffcolourpopup::setHelpButton has incomplete parameters list; (#21) Not recommended phpdocs tag @version used; (#37) Not recommended phpdocs tag @access used
course/format/flexible/lang/en/format_flexible.php: (#21) Not recommended phpdocs tag @version used
course/format/flexible/lib.php: (#33) Class format_flexible is not documented; (#355) Function format_flexible::get_maximum_image_width is not documented; (#1065) Function format_flexible::get_course_format_colour_defaults is not documented; (#1984) Function format_flexible::create_original_image_record is not documented; (#2000) Function format_flexible::create_section_image is not documented; (#2154) Function format_flexible::remove_existing_new_displayed_image is not documented; (#2189) Function format_flexible::output_section_image is not documented; (#2249) Function format_flexible::delete_image is not documented; (#2277) Function format_flexible::delete_images is not documented; (#2308) Function format_flexible::delete_displayed_images is not documented; (#2326) Function format_flexible::delete_displayed_image is not documented; (#2587) Function format_flexible::bstwothreetwo is not documented; (#2657) Function format_flexible::section_action is not documented; (#2674) Function format_flexible::get_context is not documented; (#2740) Function flexible_format_update_displayed_images is not documented; (#36) Variable format_flexible::$numcolumns is not documented; (#39) Variable format_flexible::$imagecontainerratios is not documented; (#42) Variable format_flexible::$borderwidths is not documented; (#44) Variable format_flexible::$imagecontainerwidth is not documented; (#45) Variable format_flexible::$currentratio is not documented; (#46) Variable format_flexible::$currentborderwidth is not documented; (#47) Variable format_flexible::$currentheight is not documented; (#48) Variable format_flexible::$activitymargintop is not documented; (#49) Variable format_flexible::$activitymarginleft is not documented; (#51) Variable format_flexible::$opacities is not documented; (#53) Variable format_flexible::$sectiontitlefontsizes is not documented; (#55) Variable format_flexible::$settings is not documented; (#1931) Phpdocs for function format_flexible::calculate_height has incomplete parameters list; (#2722) Phpdocs for function callback_flexible_load_content has incomplete parameters list; (#1828) Invalid phpdocs tag @returns used; (#1850) Invalid phpdocs tag @returns used; (#21) Not recommended phpdocs tag @version used
course/format/flexible/mod_summary.php: (#21) Not recommended phpdocs tag @version used
course/format/flexible/renderer.php: (#34) Class format_flexible_renderer is not documented; (#816) Function format_flexible_renderer::bs232_break_grid is not documented; (#825) Function format_flexible_renderer::make_icon_only is not documented; (#1069) Function format_flexible_renderer::make_icon_content is not documented; (#1444) Function format_flexible_renderer::make_block_icon_topics_editing is not documented; (#1467) Function format_flexible_renderer::make_block_icon_topic0_editing is not documented; (#1692) Function format_flexible_renderer::set_initialsection is not documented; (#1696) Function format_flexible_renderer::getfontawesomemarkup is not documented; (#36) Variable format_flexible_renderer::$courseformat is not documented; (#37) Variable format_flexible_renderer::$settings is not documented; (#38) Variable format_flexible_renderer::$initialsection is not documented; (#157) Phpdocs for function format_flexible_renderer::section_nav_selection has incomplete parameters list; (#623) Phpdocs for function format_flexible_renderer::make_block_topic0 has incomplete parameters list; (#725) Phpdocs for function format_flexible_renderer::make_block_icon_topics has incomplete parameters list; (#1488) Phpdocs for function format_flexible_renderer::make_block_show_clipboard_if_file_moving has incomplete parameters list; (#1508) Phpdocs for function format_flexible_renderer::make_block_topics has incomplete parameters list; (#1603) Phpdocs for function format_flexible_renderer::get_title has incomplete parameters list; (#1641) Phpdocs for function format_flexible_renderer::is_empty_text has incomplete parameters list; (#1649) Phpdocs for function format_flexible_renderer::text_limit has incomplete parameters list; (#1664) Phpdocs for function format_flexible_renderer::new_activity has incomplete parameters list; (#21) Not recommended phpdocs tag @version used
course/format/flexible/settings.php: (#21) Not recommended phpdocs tag @version used
course/format/flexible/tests/courseformatlib_test.php: (#36) Variable format_flexible_courseformatlib_testcase::$courseone is not documented; (#37) Variable format_flexible_courseformatlib_testcase::$coursetwo is not documented; (#38) Variable format_flexible_courseformatlib_testcase::$courseformatone is not documented; (#39) Variable format_flexible_courseformatlib_testcase::$courseformattwo is not documented; (#21) Not recommended phpdocs tag @version used
course/format/flexible/version.php: (#21) Not recommended phpdocs tag @version used

Update savepoints problems

(3 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

course/format/flexible/db/upgrade.php: Detected more 'if' blocks (1) than 'savepoint' calls (0); version 2114052000 is missing corresponding savepoint call; version 2114052000 is higher than that defined in /var/lib/jenkins/git_repositories/prechecker/course/format/flexible/version.php file

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

: Problems running grunt; Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]