Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(115 errors, 28 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

course/format/cards/backup/moodle2/backup_format_cards_plugin.class.php
(#37) Inline comments must end in full-stops, exclamation marks, or question marks
(#42) Inline comments must end in full-stops, exclamation marks, or question marks
(#53) File must end with a newline character
course/format/cards/backup/moodle2/restore_format_cards_plugin.class.php
(#44) Inline comments must start with a capital letter, digit or 3-dots sequence
(#44) Inline comments must end in full-stops, exclamation marks, or question marks
(#62) Inline control structures are not allowed
(#67) Variable "oldSectionId" must be all lower-case
(#68) Variable "oldSectionNum" must be all lower-case
(#70) Variable "newCourseId" must be all lower-case
(#71) Variable "newSectionId" must be all lower-case
(#72) Variable "newCourseId" must be all lower-case
(#73) Variable "oldSectionNum" must be all lower-case
(#76) Inline control structures are not allowed
(#76) Variable "newSectionId" must be all lower-case
(#79) Variable "newCourseId" must be all lower-case
(#79) Variable "oldSectionId" must be all lower-case
(#79) Variable "newSectionId" must be all lower-case
(#90) Variable "newCourseId" must be all lower-case
(#90) Variable "oldSectionId" must be all lower-case
(#90) Variable "newSectionId" must be all lower-case
(#91) Variable "fileStorage" must be all lower-case
(#92) Variable "newCourseId" must be all lower-case
(#95) Variable "restoredImage" must be all lower-case
(#95) Variable "fileStorage" must be all lower-case
(#99) Variable "oldSectionId" must be all lower-case
(#107) Inline comments must end in full-stops, exclamation marks, or question marks
(#108) Inline control structures are not allowed
(#108) Variable "restoredImage" must be all lower-case
(#111) Variable "restoredImage" must be all lower-case
(#111) Variable "restoredImage" must be all lower-case
(#114) Variable "existingImage" must be all lower-case
(#114) Variable "fileStorage" must be all lower-case
(#118) Variable "newSectionId" must be all lower-case
(#126) Inline comments must end in full-stops, exclamation marks, or question marks
(#127) Expected "if (...) {\n"; found "if(...) {\n"
(#127) Variable "existingImage" must be all lower-case
(#128) Variable "existingImage" must be all lower-case
(#128) Variable "existingImage" must be all lower-case
(#131) Inline comments must end in full-stops, exclamation marks, or question marks
(#132) Inline control structures are not allowed
(#132) Variable "restoredImage" must be all lower-case
(#132) Variable "existingImage" must be all lower-case
(#136) Inline comments must end in full-stops, exclamation marks, or question marks
(#137) Expected "if (...) {\n"; found "if(...) {\n"
(#137) Variable "restoredImage" must be all lower-case
(#137) Variable "existingImage" must be all lower-case
(#138) Variable "fileStorage" must be all lower-case
(#141) Variable "oldSectionId" must be all lower-case
(#146) Variable "existingImage" must be all lower-case
(#149) Variable "movedImage" must be all lower-case
(#149) Variable "fileStorage" must be all lower-case
(#151) Variable "newSectionId" must be all lower-case
(#153) Variable "restoredImage" must be all lower-case
(#156) Inline comments must end in full-stops, exclamation marks, or question marks
(#157) Expected "if (...) {\n"; found "if(...) {\n"
(#157) Variable "oldSectionId" must be all lower-case
(#157) Variable "newSectionId" must be all lower-case
(#158) Variable "restoredImage" must be all lower-case
(#161) Inline comments must end in full-stops, exclamation marks, or question marks
(#162) Expected "} else {\n"; found "}\n // Otherwise, delete all file records for the old section we restored to\n // keep things tidy\n else {\n"
(#163) Variable "fileStorage" must be all lower-case
(#166) Variable "oldSectionId" must be all lower-case
(#170) File must end with a newline character
course/format/cards/classes/forms/editcard_form.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#31) "require_once" must be immediately followed by an open parenthesis
(#46) Whitespace found at end of line
(#64) File must end with a newline character
course/format/cards/classes/output/courseformat/content.php
(#53) Inline control structures are not allowed
(#68) Variable "singleSection" must be all lower-case
(#75) Inline comments must end in full-stops, exclamation marks, or question marks
(#78) Inline control structures are not allowed
(#78) Variable "singleSection" must be all lower-case
(#81) Inline control structures are not allowed
(#87) File must end with a newline character
course/format/cards/classes/output/courseformat/content/cm.php
(#38) Expected "if (...) {\n"; found "if(...) {\n"
(#47) File must end with a newline character
course/format/cards/classes/output/courseformat/content/section.php
(#51) Scope modifier not specified for member variable "$images"
(#62) Inline comments must end in full-stops, exclamation marks, or question marks
(#67) Inline control structures are not allowed
(#72) Inline comments must end in full-stops, exclamation marks, or question marks
(#82) Inline comments must end in full-stops, exclamation marks, or question marks
(#91) Inline comments must end in full-stops, exclamation marks, or question marks
(#93) Inline control structures are not allowed
(#96) Inline comments must end in full-stops, exclamation marks, or question marks
(#99) Expected "if (...) {\n"; found "if(...) {\n"
(#100) Inline control structures are not allowed
(#104) Inline control structures are not allowed
(#107) Inline comments must end in full-stops, exclamation marks, or question marks
(#108) Expected "if (...) {\n"; found "if(...) {\n"
(#116) Inline comments must end in full-stops, exclamation marks, or question marks
(#118) Expected "if (...) {\n"; found "if(...) {\n"
(#140) Line exceeds 132 characters; contains 134 characters
(#154) Expected "if (...) {\n"; found "if(...) {\n"
(#172) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#189) Inline control structures are not allowed
course/format/cards/classes/output/renderer.php
(#54) File must end with a newline character
course/format/cards/format.php
(#30) "require_once" must be immediately followed by an open parenthesis
(#31) "require_once" must be immediately followed by an open parenthesis
course/format/cards/lang/en/format_cards.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#41) File must end with a newline character
course/format/cards/lib.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#30) "require_once" must be immediately followed by an open parenthesis
(#75) Inline comments must end in full-stops, exclamation marks, or question marks
(#92) Line exceeds 132 characters; contains 148 characters
(#110) Line exceeds 132 characters; contains 158 characters
(#166) Inline comments must end in full-stops, exclamation marks, or question marks
(#193) Expected "if (...) {\n"; found "if(...) {\n"
(#194) Line exceeds 132 characters; contains 137 characters
(#216) Inline control structures are not allowed
(#219) Inline comments must end in full-stops, exclamation marks, or question marks
(#238) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#239) Inline control structures are not allowed
(#251) Expected "if (...) {\n"; found "if(...) {\n"
(#271) Expected "if (...) {\n"; found "if(...) {\n"
(#283) Expected "if (...) {\n"; found "if(...) {\n"
(#289) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#314) Whitespace found at end of line
(#317) Inline control structures are not allowed
(#320) Inline control structures are not allowed
(#337) Inline control structures are not allowed
(#355) Inline control structures are not allowed
(#360) Inline control structures are not allowed
(#363) Inline control structures are not allowed
(#381) Inline comments must end in full-stops, exclamation marks, or question marks
(#382) Inline control structures are not allowed
(#386) Inline control structures are not allowed
(#389) Inline control structures are not allowed
(#428) "require_once" must be immediately followed by an open parenthesis
(#430) Inline control structures are not allowed
(#437) Inline comments must end in full-stops, exclamation marks, or question marks
(#450) Inline control structures are not allowed
(#460) Inline control structures are not allowed
(#494) "require_once" must be immediately followed by an open parenthesis
(#496) Expected "if (...) {\n"; found "if(...) {\n"
(#518) Inline control structures are not allowed
(#521) Inline control structures are not allowed
(#527) Inline control structures are not allowed
(#529) Inline control structures are not allowed
(#535) File must end with a newline character
course/format/cards/renderer.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
course/format/cards/settings.php
(#28) "require_once" must be immediately followed by an open parenthesis
(#30) Expected "if (...) {\n"; found "if(...) {\n"
(#60) File must end with a newline character

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(42 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

course/format/cards/styles.css
(#40) Unexpected duplicate "display" (declaration-block-no-duplicate-properties)
(#35) Unexpected !important (declaration-no-important)
(#2) Unexpected unknown property "aspect-ratio" (property-no-unknown)
(#6) Unexpected unknown property "aspect-ratio" (property-no-unknown)
(#2) Expected indentation of 4 spaces (indentation)
(#3) Expected indentation of 4 spaces (indentation)
(#6) Expected indentation of 4 spaces (indentation)
(#10) Expected indentation of 4 spaces (indentation)
(#14) Expected indentation of 4 spaces (indentation)
(#15) Expected indentation of 4 spaces (indentation)
(#16) Expected indentation of 4 spaces (indentation)
(#20) Expected indentation of 4 spaces (indentation)
(#21) Expected indentation of 4 spaces (indentation)
(#22) Expected indentation of 4 spaces (indentation)
(#23) Expected indentation of 4 spaces (indentation)
(#24) Expected indentation of 4 spaces (indentation)
(#25) Expected indentation of 4 spaces (indentation)
(#29) Expected indentation of 4 spaces (indentation)
(#35) Expected indentation of 4 spaces (indentation)
(#39) Expected indentation of 4 spaces (indentation)
(#40) Expected indentation of 4 spaces (indentation)
(#41) Expected indentation of 4 spaces (indentation)
(#42) Expected indentation of 4 spaces (indentation)
(#43) Expected indentation of 4 spaces (indentation)
(#44) Expected indentation of 4 spaces (indentation)
(#45) Expected indentation of 4 spaces (indentation)
(#46) Expected indentation of 4 spaces (indentation)
(#47) Expected indentation of 4 spaces (indentation)
(#51) Expected indentation of 4 spaces (indentation)
(#52) Expected indentation of 4 spaces (indentation)
(#56) Expected indentation of 4 spaces (indentation)
(#57) Expected indentation of 4 spaces (indentation)
(#58) Expected indentation of 4 spaces (indentation)
(#59) Expected indentation of 4 spaces (indentation)
(#60) Expected indentation of 4 spaces (indentation)
(#64) Expected indentation of 4 spaces (indentation)
(#68) Expected indentation of 4 spaces (indentation)
(#72) Expected indentation of 4 spaces (indentation)
(#76) Expected indentation of 4 spaces (indentation)
(#80) Expected indentation of 4 spaces (indentation)
(#83) Expected indentation of 4 spaces (indentation)
(#86) Expected indentation of 4 spaces (indentation)

PHPDocs style problems

(19 errors, 1 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

course/format/cards/backup/moodle2/restore_format_cards_plugin.class.php
(#39) There is no description in phpdocs for function process_cards
(#82) Phpdocs for function restore_format_cards_plugin::move_section_image has incomplete parameters list
course/format/cards/classes/forms/editcard_form.php
(#43) Function editcard_form::definition is not documented
(#17) No one-line description found in phpdocs for file
course/format/cards/classes/output/courseformat/content.php
(#17) No one-line description found in phpdocs for file
course/format/cards/classes/output/courseformat/content/cm.php
(#23) No one-line description found in phpdocs for class cm
(#31) Phpdocs for function cm::add_format_data has incomplete parameters list
course/format/cards/classes/output/courseformat/content/section.php
(#138) Function section::get_course_colour is not documented
(#17) No one-line description found in phpdocs for file
course/format/cards/lang/en/format_cards.php
(#2) Empty line found after PHP open tag
(#3) File-level phpdocs block is not found
course/format/cards/lib.php
(#17) No one-line description found in phpdocs for file
(#395) There is no description in phpdocs for function course_has_card_images
(#123) Phpdocs for function format_cards::editsection_form has incomplete parameters list
(#148) Phpdocs for function format_cards::update_section_format_options has incomplete parameters list
(#205) Phpdocs for function format_cards::update_course_format_options has incomplete parameters list
(#486) Phpdocs for function format_cards_inplace_editable has incomplete parameters list
(#507) Phpdocs for function format_cards_pluginfile has incomplete parameters list
course/format/cards/renderer.php
(#21) Package format_topics is not valid
course/format/cards/settings.php
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 22 warnings)

This section shows problems detected in mustache templates [More info]

course/format/cards/templates/local/content.mustache
(#1) HTML Validation error, line 42: Bad value “” for attribute “id” on element “li”: An ID must not be the empty string. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 71: Element “li” not allowed as child of element “div” in this context. (Suppressing further errors from this subtree.) ( <li id="section-1" class="section course-section main clearfix current " data-sectionid="1" data-sectionreturnid="" data-for="section" data-id="35" data-number="1" > )
(#1) HTML Validation error, line 122: Duplicate ID “”. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation info, line 42: The first occurrence of ID “” was here. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 149: Element “li” not allowed as child of element “div” in this context. (Suppressing further errors from this subtree.) ( <li id="section-4" class="section course-section main clearfix current " data-sectionid="4" data-sectionreturnid="" data-for="section" data-id="36" data-number="4" > )
(#1) HTML Validation error, line 200: Duplicate ID “”. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="5" > )
(#1) HTML Validation info, line 42: The first occurrence of ID “” was here. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 242: Duplicate ID “section-1”. ( <li id="section-1" class="section course-section main clearfix current " data-sectionid="1" data-sectionreturnid="" data-for="section" data-id="35" data-number="1" > )
(#1) HTML Validation info, line 71: The first occurrence of ID “section-1” was here. ( <li id="section-1" class="section course-section main clearfix current " data-sectionid="1" data-sectionreturnid="" data-for="section" data-id="35" data-number="1" > )
(#1) HTML Validation error, line 258: Duplicate ID “collapssesection1”. ( <a role="button" data-toggle="collapse" href="#coursecontentcollapse1" id="collapssesection1" aria-expanded="true" aria-controls="coursecontentcollapse1" class="btn btn-icon mr-1 icons-collapse-expand justify-content-center stretched-link " aria-label="Single Section Example"> )
(#1) HTML Validation info, line 87: The first occurrence of ID “collapssesection1” was here. ( <a role="button" data-toggle="collapse" href="#coursecontentcollapse1" id="collapssesection1" aria-expanded="true" aria-controls="coursecontentcollapse1" class="btn btn-icon mr-1 icons-collapse-expand justify-content-center stretched-link " aria-label="Section title"> )
(#1) HTML Validation error, line 268: Duplicate ID “coursecontentsection1”. ( <h3 class="sectionid-35-title sectionname course-content-item d-flex align-self-stretch align-items-center mb-0" id="coursecontentsection1" data-for="section_title" data-id="35" data-number="1"> )
(#1) HTML Validation info, line 97: The first occurrence of ID “coursecontentsection1” was here. ( <h3 class="sectionid-35-title sectionname course-content-item d-flex align-self-stretch align-items-center mb-0" id="coursecontentsection1" data-for="section_title" data-id="35" data-number="1"> )
(#1) HTML Validation error, line 279: Duplicate ID “coursecontentcollapse1”. ( <div id="coursecontentcollapse1" class="content course-content-item-content collapse show "> )
(#1) HTML Validation info, line 108: The first occurrence of ID “coursecontentcollapse1” was here. ( <div id="coursecontentcollapse1" class="content course-content-item-content collapse show "> )
(#1) HTML Validation error, line 293: Duplicate ID “”. ( <li class="activity activity-wrapper assign modtype_assign " id="" data-for="cmitem" data-id="4" > )
(#1) HTML Validation info, line 42: The first occurrence of ID “” was here. ( <li class="activity activity-wrapper forum modtype_forum newmessages " id="" data-for="cmitem" data-id="3" > )
(#1) HTML Validation error, line 293: Bad value “” for attribute “id” on element “li”: An ID must not be the empty string. ( <li class="activity activity-wrapper assign modtype_assign " id="" data-for="cmitem" data-id="4" > )
(#1) HTML Validation error, line 311: Element “div” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.) ( <div class="text-xs-center text-center mt-3" data-region="empty-message"> <)
course/format/cards/templates/local/content/section-card.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 9: An element with “role=listitem” must be contained in, or owned by, an element with “role=list” or “role=group”. (ad><body><div class="card dashboard-card" role="listitem" aria-labelledby="section--title" data-sectionid="" data-sectionreturnid="" data-for="section" data-id="" data-number=""> )
(#1) HTML Validation error, line 9: The “aria-labelledby” attribute must point to an element in the same document. (ad><body><div class="card dashboard-card" role="listitem" aria-labelledby="section--title" data-sectionid="" data-sectionreturnid="" data-for="section" data-id="" data-number=""> )

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]