Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 31 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

filter/embedquestion/tests/attempt_test.php
(#29) Test method test_start_new_attempt_at_question_will_select_an_unused_question() is missing any coverage information, own or at class level
(#73) Test method test_start_new_attempt_at_question_will_select_an_unused_variant() is missing any coverage information, own or at class level
(#112) Test method test_start_new_attempt_at_question_reports_errors() is missing any coverage information, own or at class level
(#159) Test method test_discard_broken_attempt_no_usage() is missing any coverage information, own or at class level
(#181) Test method test_discard_broken_attempt_one_qa() is missing any coverage information, own or at class level
(#214) Test method test_discard_broken_attempt_two_qas() is missing any coverage information, own or at class level
(#247) Test method test_question_rendering() is missing any coverage information, own or at class level
filter/embedquestion/tests/cleanup_task_test.php
(#30) Test method test_cleanup_task() is missing any coverage information, own or at class level
filter/embedquestion/tests/external_test.php
(#28) Test method test_get_sharable_question_choices_working() is missing any coverage information, own or at class level
(#56) Test method test_get_sharable_question_choices_no_permissions() is missing any coverage information, own or at class level
(#64) Test method test_get_sharable_question_choices_only_user() is missing any coverage information, own or at class level
(#115) Test method test_get_embed_code_working() is missing any coverage information, own or at class level
(#162) Test method test_get_embed_code_working_with_random_questions() is missing any coverage information, own or at class level
(#235) Test method test_is_authorized_secret_token() is missing any coverage information, own or at class level
filter/embedquestion/tests/filter_test.php
(#91) Test method test_filter() is missing any coverage information, own or at class level
(#114) Test method test_no_guests() is missing any coverage information, own or at class level
filter/embedquestion/tests/token_test.php
(#28) Test method test_is_authorized_secret_token() is missing any coverage information, own or at class level
filter/embedquestion/tests/utils_test.php
(#36) Test method test_get_category_by_idnumber() is missing any coverage information, own or at class level
(#50) Test method test_get_category_by_idnumber_not_existing() is missing any coverage information, own or at class level
(#57) Test method test_get_question_by_idnumber() is missing any coverage information, own or at class level
(#74) Test method test_get_question_by_idnumber_not_existing() is missing any coverage information, own or at class level
(#87) Test method test_get_categories_with_sharable_question_choices() is missing any coverage information, own or at class level
(#108) Test method test_get_categories_with_sharable_question_choices_only_user() is missing any coverage information, own or at class level
(#135) Test method test_get_sharable_question_choices() is missing any coverage information, own or at class level
(#159) Test method test_get_sharable_question_choices_only_user() is missing any coverage information, own or at class level
(#185) Test method test_get_sharable_question_choices_should_not_include_random() is missing any coverage information, own or at class level
(#218) Test method test_get_categories_with_sharable_question_choices_should_not_include_random() is missing any coverage information, own or at class level
(#278) Test method test_get_sharable_question_choices_should_not_include_hidden() is missing any coverage information, own or at class level
(#299) Test method test_get_categories_with_sharable_question_choices_should_not_include_hidden() is missing any coverage information, own or at class level
(#323) Test method test_behaviour_choices() is missing any coverage information, own or at class level
(#337) Test method test_create_attempt_at_embedded_question() is missing any coverage information, own or at class level

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(54 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

filter/embedquestion/classes/admin/question_behaviour_setting.php
(#32) Function question_behaviour_setting::load_choices is not documented
filter/embedquestion/classes/attempt.php
(#202) There is no description in phpdocs for function start_new_attempt_at_question
(#415) Phpdocs for function attempt::render_question has incomplete parameters list
filter/embedquestion/classes/attempt_storage.php
(#33) Inline phpdocs tag {@link instance()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#80) Inline phpdocs tag {@link new_usage_saved()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#97) Inline phpdocs tag {@link make_new_usage()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
filter/embedquestion/classes/custom_string_manager.php
(#33) Function custom_string_manager::force_page_language is not documented
(#40) Function custom_string_manager::get_string is not documented
filter/embedquestion/classes/embed_id.php
(#27) Constant embed_id::TO_ESCAPE is not documented
(#28) Constant embed_id::ESCAPED is not documented
filter/embedquestion/classes/embed_location.php
(#91) Inline phpdocs tag not enclosed with curly brackets @link found
filter/embedquestion/classes/event/category_token_created.php
(#32) Function category_token_created::init is not documented
(#38) Function category_token_created::get_description is not documented
(#43) Function category_token_created::get_objectid_mapping is not documented
filter/embedquestion/classes/event/question_attempted.php
(#32) Function question_attempted::init is not documented
(#38) Function question_attempted::get_description is not documented
(#43) Function question_attempted::get_legacy_logdata is not documented
(#47) Function question_attempted::get_objectid_mapping is not documented
filter/embedquestion/classes/event/question_started.php
(#32) Function question_started::init is not documented
(#38) Function question_started::get_description is not documented
(#43) Function question_started::get_legacy_logdata is not documented
(#47) Function question_started::get_objectid_mapping is not documented
filter/embedquestion/classes/event/question_viewed.php
(#32) Function question_viewed::init is not documented
(#38) Function question_viewed::get_description is not documented
(#43) Function question_viewed::get_legacy_logdata is not documented
(#47) Function question_viewed::get_objectid_mapping is not documented
filter/embedquestion/classes/event/token_created.php
(#32) Function token_created::init is not documented
(#38) Function token_created::get_description is not documented
(#43) Function token_created::get_objectid_mapping is not documented
filter/embedquestion/classes/form/embed_options_form.php
(#41) Function embed_options_form::definition is not documented
(#150) Function embed_options_form::definition_after_data is not documented
(#191) Function embed_options_form::validation is not documented
(#227) Function embed_options_form::get_data is not documented
filter/embedquestion/classes/output/embed_iframe.php
(#42) Function embed_iframe::export_for_template is not documented
filter/embedquestion/classes/output/error_message.php
(#41) Function error_message::export_for_template is not documented
filter/embedquestion/classes/output/renderer.php
(#28) Not recommended phpdocs tag @method used
(#28) Not recommended phpdocs tag @method used
filter/embedquestion/classes/task/cleanup_task.php
(#40) Function cleanup_task::get_name is not documented
(#44) Function cleanup_task::execute is not documented
filter/embedquestion/classes/token.php
(#53) Phpdocs for function token::add_iframe_token_to_url has incomplete parameters list
(#62) Phpdocs for function token::is_authorized_secret_token has incomplete parameters list
(#40) Inline phpdocs tag not enclosed with curly brackets @link found
(#51) Inline phpdocs tag not enclosed with curly brackets @link found
filter/embedquestion/filter.php
(#57) Function filter_embedquestion::setup is not documented
(#72) Function filter_embedquestion::filter is not documented
filter/embedquestion/tests/behat/behat_filter_embedquestion.php
(#249) Phpdocs for function behat_filter_embedquestion::check_question_type_installed has incomplete parameters list
(#99) Inline phpdocs tag {@link core_question_generator::get_simulated_post_data_for_question_attempt()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
filter/embedquestion/tests/external_test.php
(#97) There is no description in phpdocs for function get_embed_code_cases
filter/embedquestion/tests/filter_test.php
(#29) Package \filter_embedquestion is not valid
(#36) Inline phpdocs tag {@link test_filter()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
filter/embedquestion/tests/generator/lib.php
(#42) Function filter_embedquestion_generator::__construct is not documented
(#56) Inline phpdocs tag {@link core_question_generator::create_question()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#56) Inline phpdocs tag {@link core_question_generator::create_question()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#56) Inline phpdocs tag {@link core_question_generator::create_question()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
(#59) Inline phpdocs tag {@link core_question_generator::create_question_category()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
filter/embedquestion/tests/utils_test.php
(#257) Inline phpdocs tag {@link question_test_helper::get_question_form_data} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]