Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(40 errors, 11 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

filter/edusharing/db/install.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
(#40) Variable "edusharingPos" must be all lower-case
(#42) Variable "edusharingPos" must be all lower-case
(#44) Variable "edusharingPos" must be all lower-case
filter/edusharing/filter.php
(#54) Possible useless method overriding detected
(#58) Inline comments must end in full-stops, exclamation marks, or question marks
(#74) Variable "edusharing_filter_loaded" must not contain underscores.
(#88) Inline comments must end in full-stops, exclamation marks, or question marks
(#88) No space found before comment text; expected "// if ( isloggedin() && has_capability('moodle/course:view', $context) ) {" but found "//if ( isloggedin() && has_capability('moodle/course:view', $context) ) {"
(#92) Expected "} else {\n"; found "}else{\n"
(#93) The use of function error_log() is forbidden; use debugging() instead
(#99) Variable "matchesimg_atto" must not contain underscores.
(#101) Variable "matchesa_atto" must not contain underscores.
(#103) Variable "matches_atto" must not contain underscores.
(#103) Variable "matchesimg_atto" must not contain underscores.
(#103) Variable "matchesa_atto" must not contain underscores.
(#104) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#106) Variable "matchesimg_tinymce" must not contain underscores.
(#108) Variable "matchesa_tinymce" must not contain underscores.
(#110) Variable "matches_tinymce" must not contain underscores.
(#110) Variable "matchesimg_tinymce" must not contain underscores.
(#110) Variable "matchesa_tinymce" must not contain underscores.
(#112) Variable "matches_atto" must not contain underscores.
(#112) Variable "matches_tinymce" must not contain underscores.
(#115) Expected "if (...) {\n"; found "if(...) {\n"
(#115) Variable "edusharing_filter_loaded" must not contain underscores.
(#117) Variable "edusharing_filter_loaded" must not contain underscores.
(#120) Variable "matches_atto" must not contain underscores.
(#124) Variable "matches_tinymce" must not contain underscores.
(#147) Expected "if (...) {\n"; found "if(...) {\n"
(#162) Functions must not contain multiple empty lines in a row; found 3 empty lines
(#260) Expected 1 space after ".="; 2 found
(#268) Space found before object operator
(#268) Space found after object operator
(#274) Inline comments must start with a capital letter, digit or 3-dots sequence
(#274) Inline comments must end in full-stops, exclamation marks, or question marks
(#275) Expected "if (...) {\n"; found "if (...){\n"
filter/edusharing/inlineHelper.php
(#31) Inline comments must start with a capital letter, digit or 3-dots sequence
(#31) Inline comments must end in full-stops, exclamation marks, or question marks
(#32) Variable "childobject_id" must not contain underscores.
(#50) Space found before object operator
(#50) Space found after object operator
(#50) Line exceeds 132 characters; contains 141 characters
(#52) Inline control structures are not allowed
(#52) Variable "childobject_id" must not contain underscores.
(#53) Variable "childobject_id" must not contain underscores.
filter/edusharing/lang/zh/filter_edusharing.php
(#35) File must end with a newline character
filter/edusharing/proxy.php
(#77) This comment is 67% valid code; is this commented out code?
(#85) Expected "if (...) {\n"; found "if (...){\n"
(#92) Inline control structures are not allowed

Javascript coding style problems

(5 errors, 8 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

filter/edusharing/amd/src/edu.js
(#17) @package should be empty. (jsdoc/empty-tags)
(#28) Expected an assignment or function call and instead saw an expression. (babel/no-unused-expressions)
(#29) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#29) Missing JSDoc comment. (require-jsdoc)
(#58) Missing JSDoc comment. (jsdoc/require-jsdoc)
(#58) Missing JSDoc comment. (require-jsdoc)
(#60) 'wrapper' used outside of binding context. (block-scoped-var)
(#61) 'wrapper' is already defined. (no-redeclare)
(#64) 'wrapper' used outside of binding context. (block-scoped-var)
(#67) 'wrapper' used outside of binding context. (block-scoped-var)
(#89) Identifier 'toggle_button' is not in camel case. (camelcase)
(#90) Identifier 'toggle_button' is not in camel case. (camelcase)
filter/edusharing/fallback.js
(#78) Parsing error: Unexpected token toggle_button

CSS problems

(95 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

filter/edusharing/styles.css
(#7) Expected single space after ">" (selector-combinator-space-after)
(#7) Expected single space before ">" (selector-combinator-space-before)
(#8) Expected indentation of 4 spaces (indentation)
(#12) Expected indentation of 4 spaces (indentation)
(#13) Expected indentation of 4 spaces (indentation)
(#17) Expected indentation of 4 spaces (indentation)
(#18) Expected indentation of 4 spaces (indentation)
(#19) Expected indentation of 4 spaces (indentation)
(#22) Expected indentation of 4 spaces (indentation)
(#23) Expected indentation of 4 spaces (indentation)
(#24) Expected indentation of 4 spaces (indentation)
(#25) Expected indentation of 4 spaces (indentation)
(#26) Expected indentation of 4 spaces (indentation)
(#27) Expected indentation of 4 spaces (indentation)
(#28) Expected indentation of 4 spaces (indentation)
(#29) Expected indentation of 4 spaces (indentation)
(#30) Expected indentation of 4 spaces (indentation)
(#31) Expected indentation of 4 spaces (indentation)
(#32) Expected indentation of 4 spaces (indentation)
(#33) Expected indentation of 4 spaces (indentation)
(#34) Expected indentation of 4 spaces (indentation)
(#35) Expected indentation of 4 spaces (indentation)
(#39) Expected indentation of 4 spaces (indentation)
(#40) Expected indentation of 4 spaces (indentation)
(#41) Expected indentation of 4 spaces (indentation)
(#42) Expected indentation of 4 spaces (indentation)
(#43) Expected indentation of 4 spaces (indentation)
(#44) Expected indentation of 4 spaces (indentation)
(#45) Expected indentation of 4 spaces (indentation)
(#46) Expected indentation of 4 spaces (indentation)
(#47) Expected indentation of 4 spaces (indentation)
(#48) Expected indentation of 4 spaces (indentation)
(#49) Expected indentation of 4 spaces (indentation)
(#50) Expected indentation of 4 spaces (indentation)
(#51) Expected indentation of 4 spaces (indentation)
(#52) Expected indentation of 4 spaces (indentation)
(#56) Expected indentation of 4 spaces (indentation)
(#57) Expected indentation of 4 spaces (indentation)
(#58) Expected indentation of 4 spaces (indentation)
(#59) Expected indentation of 4 spaces (indentation)
(#60) Expected indentation of 4 spaces (indentation)
(#61) Expected indentation of 4 spaces (indentation)
(#62) Expected indentation of 4 spaces (indentation)
(#63) Expected indentation of 4 spaces (indentation)
(#64) Expected indentation of 4 spaces (indentation)
(#65) Expected indentation of 4 spaces (indentation)
(#66) Expected indentation of 4 spaces (indentation)
(#67) Expected indentation of 4 spaces (indentation)
(#68) Expected indentation of 4 spaces (indentation)
(#69) Expected indentation of 4 spaces (indentation)
(#73) Expected indentation of 4 spaces (indentation)
(#75) Expected indentation of 4 spaces (indentation)
(#74) Expected indentation of 8 spaces (indentation)
(#77) Expected indentation of 4 spaces (indentation)
(#79) Expected indentation of 4 spaces (indentation)
(#78) Expected indentation of 8 spaces (indentation)
(#81) Expected indentation of 4 spaces (indentation)
(#83) Expected indentation of 4 spaces (indentation)
(#82) Expected indentation of 8 spaces (indentation)
(#87) Expected indentation of 4 spaces (indentation)
(#89) Expected indentation of 4 spaces (indentation)
(#88) Expected indentation of 8 spaces (indentation)
(#91) Expected indentation of 4 spaces (indentation)
(#93) Expected indentation of 4 spaces (indentation)
(#92) Expected indentation of 8 spaces (indentation)
(#95) Expected indentation of 4 spaces (indentation)
(#97) Expected indentation of 4 spaces (indentation)
(#96) Expected indentation of 8 spaces (indentation)
(#101) Expected indentation of 4 spaces (indentation)
(#103) Expected indentation of 4 spaces (indentation)
(#102) Expected indentation of 8 spaces (indentation)
(#105) Expected indentation of 4 spaces (indentation)
(#107) Expected indentation of 4 spaces (indentation)
(#106) Expected indentation of 8 spaces (indentation)
(#109) Expected indentation of 4 spaces (indentation)
(#111) Expected indentation of 4 spaces (indentation)
(#110) Expected indentation of 8 spaces (indentation)
(#115) Expected indentation of 4 spaces (indentation)
(#117) Expected indentation of 4 spaces (indentation)
(#116) Expected indentation of 8 spaces (indentation)
(#119) Expected indentation of 4 spaces (indentation)
(#121) Expected indentation of 4 spaces (indentation)
(#120) Expected indentation of 8 spaces (indentation)
(#123) Expected indentation of 4 spaces (indentation)
(#125) Expected indentation of 4 spaces (indentation)
(#124) Expected indentation of 8 spaces (indentation)
(#129) Expected indentation of 4 spaces (indentation)
(#131) Expected indentation of 4 spaces (indentation)
(#130) Expected indentation of 8 spaces (indentation)
(#133) Expected indentation of 4 spaces (indentation)
(#135) Expected indentation of 4 spaces (indentation)
(#134) Expected indentation of 8 spaces (indentation)
(#137) Expected indentation of 4 spaces (indentation)
(#139) Expected indentation of 4 spaces (indentation)
(#138) Expected indentation of 8 spaces (indentation)

PHPDocs style problems

(3 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

filter/edusharing/db/install.php
(#27) Function xmldb_filter_edusharing_install is not documented
(#34) Function filter_edusharing_reorder is not documented
filter/edusharing/filter.php
(#138) Phpdocs for function filter_edusharing::filter_edusharing_convert_object has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:amd" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]