Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]


Javascript coding style problems

(1 errors, 75 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

filter/ally/amd/src/ally.js
(#26) Missing '()' invoking a constructor. (new-parens)
filter/ally/amd/src/imagecover.js
(#26) Missing '()' invoking a constructor. (new-parens)
(#29) Missing space before opening brace. (space-before-blocks)
filter/ally/amd/src/main.js
(#27) Missing '()' invoking a constructor. (new-parens)
(#35) Missing JSDoc for parameter 'pathHash'. (valid-jsdoc)
(#35) Missing JSDoc for parameter 'data'. (valid-jsdoc)
(#35) Missing JSDoc for parameter 'targetEl'. (valid-jsdoc)
(#123) 'path' used outside of binding context. (block-scoped-var)
(#124) 'path' used outside of binding context. (block-scoped-var)
(#124) 'path' used outside of binding context. (block-scoped-var)
(#125) 'path' used outside of binding context. (block-scoped-var)
(#144) Missing space before opening brace. (space-before-blocks)
(#152) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#152) Expected JSDoc for 'forumFileMapping' but found 'array'. (valid-jsdoc)
(#160) Missing space before opening brace. (space-before-blocks)
(#166) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#166) Expected JSDoc for 'assignFileMapping' but found 'array'. (valid-jsdoc)
(#183) Expected JSDoc for 'folderFileMapping' but found 'array'. (valid-jsdoc)
(#183) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#203) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#203) Expected JSDoc for 'glossaryFileMapping' but found 'array'. (valid-jsdoc)
(#232) Missing JSDoc parameter type for 'moduleFileMapping'. (valid-jsdoc)
(#255) 'moduleEl' used outside of binding context. (block-scoped-var)
(#258) 'moduleEl' used outside of binding context. (block-scoped-var)
(#258) 'moduleEl' is already defined. (no-redeclare)
(#260) 'moduleEl' used outside of binding context. (block-scoped-var)
(#260) 'moduleEl' used outside of binding context. (block-scoped-var)
(#268) 'moduleEl' used outside of binding context. (block-scoped-var)
(#268) 'moduleEl' used outside of binding context. (block-scoped-var)
(#270) 'moduleEl' used outside of binding context. (block-scoped-var)
(#270) 'moduleEl' used outside of binding context. (block-scoped-var)
(#280) Missing JSDoc for parameter 'sectionMapping'. (valid-jsdoc)
(#280) Missing JSDoc @returns for function. (valid-jsdoc)
(#302) Missing JSDoc for parameter 'module'. (valid-jsdoc)
(#302) Missing JSDoc parameter type for 'introMapping'. (valid-jsdoc)
(#322) Expected JSDoc for 'forumMapping' but found 'array'. (valid-jsdoc)
(#322) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#329) ["intros"] is better written in dot notation. (dot-notation)
(#333) ["posts"] is better written in dot notation. (dot-notation)
(#345) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#345) Expected JSDoc for 'forumMapping' but found 'array'. (valid-jsdoc)
(#352) ["intros"] is better written in dot notation. (dot-notation)
(#355) ["posts"] is better written in dot notation. (dot-notation)
(#363) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#363) Expected JSDoc for 'mapping' but found 'array'. (valid-jsdoc)
(#369) ["intros"] is better written in dot notation. (dot-notation)
(#373) ["entries"] is better written in dot notation. (dot-notation)
(#382) Missing JSDoc @returns for function. (valid-jsdoc)
(#382) Missing JSDoc parameter type for 'moduleMapping'. (valid-jsdoc)
(#388) ["mod_forum"] is better written in dot notation. (dot-notation)
(#389) ["mod_forum"] is better written in dot notation. (dot-notation)
(#391) ["mod_hsuforum"] is better written in dot notation. (dot-notation)
(#392) ["mod_hsuforum"] is better written in dot notation. (dot-notation)
(#394) ["mod_glossary"] is better written in dot notation. (dot-notation)
(#395) ["mod_glossary"] is better written in dot notation. (dot-notation)
(#401) Missing JSDoc parameter type for 'mapping'. (valid-jsdoc)
(#401) Missing JSDoc @returns for function. (valid-jsdoc)
(#423) Identifier 'ally_module_maps' is not in camel case. (camelcase)
(#423) Identifier 'ally_section_maps' is not in camel case. (camelcase)
(#429) Identifier 'ally_module_maps' is not in camel case. (camelcase)
(#433) Identifier 'ally_module_maps' is not in camel case. (camelcase)
(#437) Identifier 'ally_module_maps' is not in camel case. (camelcase)
(#441) Identifier 'ally_module_maps' is not in camel case. (camelcase)
(#445) Identifier 'ally_module_maps' is not in camel case. (camelcase)
(#449) Identifier 'ally_section_maps' is not in camel case. (camelcase)
(#453) Identifier 'ally_annotation_maps' is not in camel case. (camelcase)
(#489) Missing JSDoc parameter type for 'jwt'. (valid-jsdoc)
(#507) Identifier 'ally_module_maps' is not in camel case. (camelcase)
filter/ally/amd/src/util.js
(#25) Missing '()' invoking a constructor. (new-parens)
(#27) Missing JSDoc parameter type for 'evaluateFunction'. (valid-jsdoc)
(#27) Missing JSDoc parameter type for 'maxIterations'. (valid-jsdoc)
(#74) Expected space or tab after '/*' in comment. (spaced-comment)
(#105) Function expected no return value. (consistent-return)
(#116) Missing JSDoc parameter type for 'url'. (valid-jsdoc)
(#124) Unexpected space before function parentheses. (space-before-function-paren)
filter/ally/Gruntfile.js
(#25) 'module' is not defined. (no-undef)

CSS problems

(2 errors, 1 warnings)

This section shows CSS problems detected by stylelint [More info]

filter/ally/styles_snap.css
(#6) Expected single space before "{" (block-opening-brace-space-before)
(#7) Unexpected !important (declaration-no-important)
filter/ally/styles.css
(#65) Expected "#FFF" to be "#fff" (color-hex-case)

PHPDocs style problems

(75 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

filter/ally/classes/local/jwthelper.php
(#34) Constant jwthelper::ALGO is not documented
(#29) Class jwthelper does not have @copyright tag
(#29) Class jwthelper does not have @license tag
(#71) Invalid phpdocs tag @noinspection used
(#76) Invalid phpdocs tag @noinspection used
filter/ally/classes/privacy/provider.php
(#42) Function provider::_get_metadata is not documented
(#53) Function provider::_get_contexts_for_userid is not documented
(#57) Function provider::_export_user_data is not documented
(#60) Function provider::_delete_data_for_all_users_in_context is not documented
(#63) Function provider::_delete_data_for_user is not documented
filter/ally/classes/renderables/wrapper.php
(#28) Class wrapper is not documented
(#29) Variable wrapper::$html is not documented
(#30) Variable wrapper::$fileid is not documented
(#31) Variable wrapper::$url is not documented
(#32) Variable wrapper::$canviewfeedback is not documented
(#33) Variable wrapper::$isimage is not documented
(#28) Package is not specified for class wrapper. It is also not specified in file-level phpdocs
filter/ally/filter.php
(#51) Constant filter_ally::IMAGE is not documented
(#239) Phpdocs for function filter_ally::map_resource_file_paths_to_pathhash has incomplete parameters list
(#560) Phpdocs for function filter_ally::filter has incomplete parameters list
filter/ally/renderer.php
(#28) Class filter_ally_renderer is not documented
(#28) Package is not specified for class filter_ally_renderer. It is also not specified in file-level phpdocs
filter/ally/tests/behat/behat_filter_ally.php
(#639) Function behat_filter_ally::assert_element_in_viewport_or_not is not documented
(#41) There is no description in phpdocs for function the_ally_filter_is_enabled
(#72) There is no description in phpdocs for function i_create_label_with_sample_images
(#127) There is no description in phpdocs for function i_create_a_label_with_random_text_files
(#176) There is no description in phpdocs for function i_create_a_label_with_html_content
(#197) There is no description in phpdocs for function i_create_file_resources_using_fixtures
(#235) There is no description in phpdocs for function i_create_assign_with_additional_files
(#277) There is no description in phpdocs for function i_should_see_feedback_for_image_x
(#289) There is no description in phpdocs for function i_should_not_see_feedback_for_image_x
(#300) There is no description in phpdocs for function the_ally_image_cover_area_should_exist_for_image_x
(#345) There is no description in phpdocs for function i_should_not_see_any_placeholders_in_the_submissions_area
(#356) There is no description in phpdocs for function i_should_not_see_any_placeholders_in_the_grading_submissions_column
(#367) There is no description in phpdocs for function i_should_see_feedback_for_anchor_x
(#379) There is no description in phpdocs for function i_should_not_see_feedback_for_anchor_x
(#389) There is no description in phpdocs for function i_should_see_download_for_anchor_x
(#400) There is no description in phpdocs for function i_should_not_see_download_for_anchor_x
(#429) There is no description in phpdocs for function i_should_see_feedback_for_forum_post
(#441) There is no description in phpdocs for function i_should_not_see_feedback_for_forum_post
(#452) There is no description in phpdocs for function i_should_see_download_for_forum_post
(#464) There is no description in phpdocs for function i_should_not_see_download_for_forum_post
(#475) There is no description in phpdocs for function i_allow_guest_access_for_current_course
(#493) There is no description in phpdocs for function i_view_all_submissions
(#501) There is no description in phpdocs for function section_has_summary
(#517) There is no description in phpdocs for function section_has_html_summary
(#528) There is no description in phpdocs for function section_has_text_summary
(#539) There is no description in phpdocs for function section_is_annotated
(#556) There is no description in phpdocs for function section_is_not_annotated
(#587) There is no description in phpdocs for function label_is_annotated
(#628) There is no description in phpdocs for function follow_label_ws_url
(#707) There is no description in phpdocs for function ensure_element_is_visible_and_in_viewport
(#717) There is no description in phpdocs for function ensure_element_is_not_visible_or_not_in_viewport
(#727) There is no description in phpdocs for function ensure_label_with_content_visible_and_in_viewport
(#741) There is no description in phpdocs for function ensure_label_with_content_not_visible_or_not_in_viewport
(#770) There is no description in phpdocs for function module_element_is_annotated
(#178) Phpdocs for function behat_filter_ally::i_create_a_label_with_html_content has incomplete parameters list
(#237) Phpdocs for function behat_filter_ally::i_create_assign_with_additional_files has incomplete parameters list
(#382) Phpdocs for function behat_filter_ally::i_should_not_see_feedback_for_anchor_x has incomplete parameters list
(#392) Phpdocs for function behat_filter_ally::i_should_see_download_for_anchor_x has incomplete parameters list
(#403) Phpdocs for function behat_filter_ally::i_should_not_see_download_for_anchor_x has incomplete parameters list
(#539) Phpdocs for function behat_filter_ally::section_is_annotated has incomplete parameters list
(#556) Phpdocs for function behat_filter_ally::section_is_not_annotated has incomplete parameters list
filter/ally/tests/filter_test.php
(#27) Class filter_ally_testcase is not documented
(#162) Function filter_ally_testcase::map_resource_file_paths_to_pathhash is not documented
(#29) Variable filter_ally_testcase::$filter is not documented
(#226) There is no description in phpdocs for function test_process_url
(#27) Package is not specified for class filter_ally_testcase. It is also not specified in file-level phpdocs
filter/ally/tests/jwthelper_test.php
(#17) File-level phpdocs block is not found
(#19) Class filter_ally_jwthelper_testcase is not documented
(#21) Function filter_ally_jwthelper_testcase::config_set_ok is not documented
(#28) Phpdocs for function filter_ally_jwthelper_testcase::validate_token has incomplete parameters list
(#43) Invalid phpdocs tag @noinspection used
(#49) Invalid phpdocs tag @noinspection used
(#19) Package is not specified for class filter_ally_jwthelper_testcase. It is also not specified in file-level phpdocs

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(1 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

filter/ally/templates/wrapper.mustache
(#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Control character error, possibly incorrectly encoded