Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]


Javascript coding style problems

(1 errors, 42 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

filter/ally/amd/src/imagecover.js
(#29) Missing space before opening brace. (space-before-blocks)
filter/ally/amd/src/main.js
(#34) Missing JSDoc for parameter 'data'. (valid-jsdoc)
(#34) Missing JSDoc for parameter 'pathHash'. (valid-jsdoc)
(#34) Missing JSDoc for parameter 'targetEl'. (valid-jsdoc)
(#116) 'path' used outside of binding context. (block-scoped-var)
(#117) 'path' used outside of binding context. (block-scoped-var)
(#117) 'path' used outside of binding context. (block-scoped-var)
(#118) 'path' used outside of binding context. (block-scoped-var)
(#137) Missing space before opening brace. (space-before-blocks)
(#145) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#145) Expected JSDoc for 'forumFileMapping' but found 'array'. (valid-jsdoc)
(#153) Missing space before opening brace. (space-before-blocks)
(#159) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#159) Expected JSDoc for 'assignFileMapping' but found 'array'. (valid-jsdoc)
(#176) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#176) Expected JSDoc for 'folderFileMapping' but found 'array'. (valid-jsdoc)
(#196) Missing JSDoc parameter type for 'array'. (valid-jsdoc)
(#196) Expected JSDoc for 'glossaryFileMapping' but found 'array'. (valid-jsdoc)
(#225) Missing JSDoc parameter type for 'moduleFileMapping'. (valid-jsdoc)
(#248) 'moduleEl' used outside of binding context. (block-scoped-var)
(#251) 'moduleEl' is already defined (no-redeclare)
(#251) 'moduleEl' used outside of binding context. (block-scoped-var)
(#253) 'moduleEl' used outside of binding context. (block-scoped-var)
(#253) 'moduleEl' used outside of binding context. (block-scoped-var)
(#261) 'moduleEl' used outside of binding context. (block-scoped-var)
(#261) 'moduleEl' used outside of binding context. (block-scoped-var)
(#263) 'moduleEl' used outside of binding context. (block-scoped-var)
(#263) 'moduleEl' used outside of binding context. (block-scoped-var)
(#276) Identifier 'ally_module_maps' is not in camel case. (camelcase)
(#283) Identifier 'ally_module_maps' is not in camel case. (camelcase)
(#287) Identifier 'ally_module_maps' is not in camel case. (camelcase)
(#291) Identifier 'ally_module_maps' is not in camel case. (camelcase)
(#295) Identifier 'ally_module_maps' is not in camel case. (camelcase)
(#299) Identifier 'ally_module_maps' is not in camel case. (camelcase)
(#331) Missing JSDoc parameter type for 'jwt'. (valid-jsdoc)
(#347) Identifier 'ally_module_maps' is not in camel case. (camelcase)
filter/ally/amd/src/util.js
(#27) Missing JSDoc parameter type for 'evaluateFunction'. (valid-jsdoc)
(#27) Missing JSDoc parameter type for 'maxIterations'. (valid-jsdoc)
(#74) Expected space or tab after '/*' in comment. (spaced-comment)
(#105) Expected no return value. (consistent-return)
(#116) Missing JSDoc parameter type for 'url'. (valid-jsdoc)
(#124) Unexpected space before function parentheses. (space-before-function-paren)
filter/ally/Gruntfile.js
(#25) 'module' is not defined. (no-undef)

CSS problems

(0 errors, 1 warnings)

This section shows CSS problems detected by csslint [More info]

filter/ally/styles_snap.css
(#7) Use of !important

PHPDocs style problems

(54 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

filter/ally/classes/local/jwthelper.php
(#34) Constant jwthelper::ALGO is not documented
(#29) Class jwthelper does not have @copyright tag
(#29) Class jwthelper does not have @license tag
(#70) Invalid phpdocs tag @noinspection used
(#74) Invalid phpdocs tag @noinspection used
filter/ally/classes/renderables/wrapper.php
(#28) Package is not specified for class wrapper. It is also not specified in file-level phpdocs
(#28) Class wrapper is not documented
(#29) Variable wrapper::$html is not documented
(#30) Variable wrapper::$fileid is not documented
(#31) Variable wrapper::$url is not documented
(#32) Variable wrapper::$canviewfeedback is not documented
(#33) Variable wrapper::$isimage is not documented
filter/ally/filter.php
(#49) Constant filter_ally::IMAGE is not documented
(#237) Phpdocs for function filter_ally::map_resource_file_paths_to_pathhash has incomplete parameters list
(#475) Phpdocs for function filter_ally::filter has incomplete parameters list
filter/ally/renderer.php
(#28) Package is not specified for class filter_ally_renderer. It is also not specified in file-level phpdocs
(#28) Class filter_ally_renderer is not documented
filter/ally/tests/behat/behat_filter_ally.php
(#27) Package is not specified for class behat_filter_ally. It is also not specified in file-level phpdocs
(#34) There is no description in phpdocs for function the_ally_filter_is_enabled
(#65) There is no description in phpdocs for function i_create_label_with_sample_images
(#120) There is no description in phpdocs for function i_create_a_label_with_random_text_files
(#169) There is no description in phpdocs for function i_create_file_resources_using_fixtures
(#207) There is no description in phpdocs for function i_create_assign_with_additional_files
(#249) There is no description in phpdocs for function i_should_see_feedback_for_image_x
(#261) There is no description in phpdocs for function i_should_not_see_feedback_for_image_x
(#272) There is no description in phpdocs for function the_ally_image_cover_area_should_exist_for_image_x
(#317) There is no description in phpdocs for function i_should_not_see_any_placeholders_in_the_submissions_area
(#328) There is no description in phpdocs for function i_should_not_see_any_placeholders_in_the_grading_submissions_column
(#339) There is no description in phpdocs for function i_should_see_feedback_for_anchor_x
(#351) There is no description in phpdocs for function i_should_not_see_feedback_for_anchor_x
(#361) There is no description in phpdocs for function i_should_see_download_for_anchor_x
(#372) There is no description in phpdocs for function i_should_not_see_download_for_anchor_x
(#401) There is no description in phpdocs for function i_should_see_feedback_for_forum_post
(#413) There is no description in phpdocs for function i_should_not_see_feedback_for_forum_post
(#424) There is no description in phpdocs for function i_should_see_download_for_forum_post
(#436) There is no description in phpdocs for function i_should_not_see_download_for_forum_post
(#447) There is no description in phpdocs for function i_allow_guest_access_for_current_course
(#465) There is no description in phpdocs for function i_view_all_submissions
(#209) Phpdocs for function behat_filter_ally::i_create_assign_with_additional_files has incomplete parameters list
(#354) Phpdocs for function behat_filter_ally::i_should_not_see_feedback_for_anchor_x has incomplete parameters list
(#364) Phpdocs for function behat_filter_ally::i_should_see_download_for_anchor_x has incomplete parameters list
(#375) Phpdocs for function behat_filter_ally::i_should_not_see_download_for_anchor_x has incomplete parameters list
filter/ally/tests/filter_test.php
(#27) Package is not specified for class filter_ally_testcase. It is also not specified in file-level phpdocs
(#27) Class filter_ally_testcase is not documented
(#162) Function filter_ally_testcase::map_resource_file_paths_to_pathhash is not documented
(#29) Variable filter_ally_testcase::$filter is not documented
(#226) There is no description in phpdocs for function test_process_url
filter/ally/tests/jwthelper_test.php
(#19) Package is not specified for class filter_ally_jwthelper_testcase. It is also not specified in file-level phpdocs
(#17) File-level phpdocs block is not found
(#19) Class filter_ally_jwthelper_testcase is not documented
(#21) Function filter_ally_jwthelper_testcase::config_set_ok is not documented
(#28) Phpdocs for function filter_ally_jwthelper_testcase::validate_token has incomplete parameters list
(#42) Invalid phpdocs tag @noinspection used
(#47) Invalid phpdocs tag @noinspection used

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Task "jshint:amd" failed. Use --force to continue.
Problems running grunt

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(1 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

filter/ally/templates/wrapper.mustache
(#1) Mustache syntax exception: Example context JSON is unparsable, fails with: Control character error, possibly incorrectly encoded