Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(49 errors, 143 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

files/converter/librelambda/classes/converter.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#28) Import statements must not begin with a leading backslash
(#64) There should be a comma after the last array item in a multi-line array.
(#82) Expected "int" but found "integer" for @var tag in member variable comment
(#100) Short array syntax must be used to define arrays
(#104) Short array syntax must be used to define arrays
(#192) Short array syntax must be used to define arrays
(#216) Short array syntax must be used to define arrays
(#219) Short array syntax must be used to define arrays
(#230) Short array syntax must be used to define arrays
(#244) Short array syntax must be used to define arrays
(#269) Short array syntax must be used to define arrays
(#307) Short array syntax must be used to define arrays
(#311) Short array syntax must be used to define arrays
(#315) There should be a comma after the last array item in a multi-line array.
(#332) Short array syntax must be used to define arrays
(#335) Short array syntax must be used to define arrays
(#341) There should be a comma after the last array item in a multi-line array.
(#367) Short array syntax must be used to define arrays
(#370) There should be a comma after the last array item in a multi-line array.
(#397) Short array syntax must be used to define arrays
(#400) Short array syntax must be used to define arrays
(#406) There should be a comma after the last array item in a multi-line array.
(#439) Short array syntax must be used to define arrays
(#440) There should be a comma after the last array item in a multi-line array.
files/converter/librelambda/classes/privacy/provider.php
(#27) Import statements must not begin with a leading backslash
(#28) Import statements must not begin with a leading backslash
(#29) Import statements must not begin with a leading backslash
(#30) Import statements must not begin with a leading backslash
(#31) Import statements must not begin with a leading backslash
(#51) There must not be a space before the colon in a return type declaration
(#66) There must not be a space before the colon in a return type declaration
files/converter/librelambda/classes/provision.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#164) Short array syntax must be used to define arrays
(#169) There should be a comma after the last array item in a multi-line array.
(#223) There should be a comma after the last array item in a multi-line array.
(#251) There should be a comma after the last array item in a multi-line array.
(#264) Short array syntax must be used to define arrays
(#281) Short array syntax must be used to define arrays
(#286) There should be a comma after the last array item in a multi-line array.
(#382) There should be a comma after the last array item in a multi-line array.
(#429) There should be a comma after the last array item in a multi-line array.
files/converter/librelambda/classes/task/convert_submissions.php
(#52) Short array syntax must be used to define arrays
(#54) There should be a comma after the last array item in a multi-line array.
files/converter/librelambda/classes/tester.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#123) Short array syntax must be used to define arrays
(#143) Short array syntax must be used to define arrays
(#146) Short array syntax must be used to define arrays
(#230) Short array syntax must be used to define arrays
files/converter/librelambda/cli/get_files.php
(#36) Short array syntax must be used to define arrays
(#43) Short array syntax must be used to define arrays
(#44) There should be a comma after the last array item in a multi-line array.
files/converter/librelambda/cli/provision.php
(#72) No one-line description found in phpdocs for docblock of function abort
(#80) No one-line description found in phpdocs for docblock of function os_exec
(#91) Short array syntax must be used to define arrays
(#101) Short array syntax must be used to define arrays
(#102) There should be a comma after the last array item in a multi-line array.
(#154) Inline comments must start with a capital letter, digit or 3-dots sequence
(#154) Inline comments must end in full-stops, exclamation marks, or question marks
files/converter/librelambda/cli/test.php
(#33) Short array syntax must be used to define arrays
(#41) There should be a comma after the last array item in a multi-line array.
(#43) Short array syntax must be used to define arrays
(#44) There should be a comma after the last array item in a multi-line array.
files/converter/librelambda/db/tasks.php
(#30) Short array syntax must be used to define arrays
(#31) Short array syntax must be used to define arrays
(#38) There should be a comma after the last array item in a multi-line array.
files/converter/librelambda/lang/en/fileconverter_librelambda.php
(#33) The string key "event:poll_conversion_status" is not in the correct order, it should be before "privacy:metadata:fileconverter_librelambda:params"
(#36) The string key "settings:aws:header" is not in the correct order, it should be before "settings:generalheader"
(#41) The string key "settings:aws:input_bucket" is not in the correct order, it should be before "settings:aws:secret_help"
(#48) The string key "settings:aws:sdkcredsok" is not in the correct order, it should be before "settings:aws:usesdkcreds"
(#49) The string key "settings:aws:sdkcredserror" is not in the correct order, it should be before "settings:aws:sdkcredsok"
(#51) The string key "settings:connectionfailure" is not in the correct order, it should be before "settings:connectionsuccess"
(#53) The string key "settings:readfailure" is not in the correct order, it should be before "settings:writefailure"
(#54) The string key "settings:deletesuccess" is not in the correct order, it should be before "settings:readfailure"
(#55) The string key "settings:deleteerror" is not in the correct order, it should be before "settings:deletesuccess"
(#57) The string key "settings:conversion_timeout" is not in the correct order, it should be before "settings:permissioncheckpassed"
(#61) The string key "settings:confignotset" is not in the correct order, it should be before "settings:useproxy_help"
(#62) The string key "preparesubmissionsforannotation" is not in the correct order, it should be before "settings:confignotset"
(#67) The string key "provision:lambdaparams" is not in the correct order, it should be before "provision:stack"
files/converter/librelambda/settings.php
(#85) Short array syntax must be used to define arrays
(#106) There should be a comma after the last array item in a multi-line array.
files/converter/librelambda/tests/converter_test.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) Import statements must not begin with a leading backslash
(#36) Import statements must not begin with a leading backslash
(#37) Import statements must not begin with a leading backslash
(#46) Unit test converter_test should be declared as final.
(#51) Test method test_is_config_set_false() is missing any coverage information, own or at class level
(#51) Test method test_is_config_set_false() is missing a return type
(#65) Test method test_is_config_set_true() is missing any coverage information, own or at class level
(#65) Test method test_is_config_set_true() is missing a return type
(#88) Test method test_is_bucket_accessible_false() is missing any coverage information, own or at class level
(#88) Test method test_is_bucket_accessible_false() is missing a return type
(#110) Test method test_is_bucket_accessible_true() is missing any coverage information, own or at class level
(#110) Test method test_is_bucket_accessible_true() is missing a return type
(#113) Short array syntax must be used to define arrays
(#129) Test method test_have_bucket_permissions_false() is missing any coverage information, own or at class level
(#129) Test method test_have_bucket_permissions_false() is missing a return type
(#156) Test method test_have_bucket_permissions_true() is missing any coverage information, own or at class level
(#156) Test method test_have_bucket_permissions_true() is missing a return type
(#159) Short array syntax must be used to define arrays
(#160) Short array syntax must be used to define arrays
(#161) Short array syntax must be used to define arrays
(#177) Test method test_are_requirements_met_false() is missing any coverage information, own or at class level
(#177) Test method test_are_requirements_met_false() is missing a return type
(#191) Test method test_start_document_conversion() is missing any coverage information, own or at class level
(#191) Test method test_start_document_conversion() is missing a return type
(#198) Short array syntax must be used to define arrays
(#203) Short array syntax must be used to define arrays
(#221) Short array syntax must be used to define arrays
(#234) Test method test_poll_document_conversion_already_complete() is missing any coverage information, own or at class level
(#234) Test method test_poll_document_conversion_already_complete() is missing a return type
(#240) Short array syntax must be used to define arrays
(#245) Short array syntax must be used to define arrays
(#263) Short array syntax must be used to define arrays
(#281) Test method test_poll_document_conversion_already_progress() is missing any coverage information, own or at class level
(#281) Test method test_poll_document_conversion_already_progress() is missing a return type
(#289) Short array syntax must be used to define arrays
(#294) Short array syntax must be used to define arrays
(#312) Short array syntax must be used to define arrays
(#314) Short array syntax must be used to define arrays
(#331) Test method test_execute_conversion_task_progress() is missing any coverage information, own or at class level
(#331) Test method test_execute_conversion_task_progress() is missing a return type
(#339) Short array syntax must be used to define arrays
(#344) Short array syntax must be used to define arrays
(#363) Short array syntax must be used to define arrays
(#365) Short array syntax must be used to define arrays
(#387) Test method test_execute_conversion_task_failed() is missing any coverage information, own or at class level
(#387) Test method test_execute_conversion_task_failed() is missing a return type
(#393) Short array syntax must be used to define arrays
(#398) Short array syntax must be used to define arrays
(#417) Short array syntax must be used to define arrays
(#419) Short array syntax must be used to define arrays
(#440) Test method test_client_uses_proxy() is missing any coverage information, own or at class level
(#440) Test method test_client_uses_proxy() is missing a return type
(#474) Test method test_conversion_record_deduplication() is missing any coverage information, own or at class level
(#474) Test method test_conversion_record_deduplication() is missing a return type
(#483) Short array syntax must be used to define arrays
(#488) Short array syntax must be used to define arrays
(#517) Short array syntax must be used to define arrays
(#519) Short array syntax must be used to define arrays
(#552) Data provider method "supports_provider" will need to be converted to static in future.
(#552) Data provider method "supports_provider" must return an array, a Generator or an Iterable.
(#592) Test method test_supports() is missing a return type
files/converter/librelambda/tests/events_test.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#35) Import statements must not begin with a leading backslash
(#36) Import statements must not begin with a leading backslash
(#45) Unit test events_test should be declared as final.
(#50) Test method test_start_document_conversion_event() is missing any coverage information, own or at class level
(#50) Test method test_start_document_conversion_event() is missing a return type
(#56) Short array syntax must be used to define arrays
(#61) Short array syntax must be used to define arrays
(#78) Short array syntax must be used to define arrays
(#81) Short array syntax must be used to define arrays
(#87) Duplicate array key found. The value will be overwritten. The string array key "sourcefileid" was first seen on line 82
(#88) There should be a comma after the last array item in a multi-line array.
(#106) Test method test_poll_conversion_status_event() is missing any coverage information, own or at class level
(#106) Test method test_poll_conversion_status_event() is missing a return type
(#112) Short array syntax must be used to define arrays
(#117) Short array syntax must be used to define arrays
(#134) Short array syntax must be used to define arrays
(#137) Short array syntax must be used to define arrays
(#143) Duplicate array key found. The value will be overwritten. The string array key "sourcefileid" was first seen on line 138
(#144) There should be a comma after the last array item in a multi-line array.
files/converter/librelambda/tests/provision_test.php
(#16) Boilerplate comment must be followed by a single blank line or end of file
(#95) Possible useless method overriding detected
(#105) Possible useless method overriding detected
(#118) Unit test provision_test should be declared as final.
(#124) Test method test_create_resource_bucket_exists_false() is missing any coverage information, own or at class level
(#124) Test method test_create_resource_bucket_exists_false() is missing a return type
(#146) Test method test_create_resource_bucket_exists_true() is missing any coverage information, own or at class level
(#146) Test method test_create_resource_bucket_exists_true() is missing a return type
(#163) Test method test_create_resource_bucket_exists_forbidden() is missing any coverage information, own or at class level
(#163) Test method test_create_resource_bucket_exists_forbidden() is missing a return type
(#179) Test method test_provision_stack_exists_no_replace() is missing any coverage information, own or at class level
(#179) Test method test_provision_stack_exists_no_replace() is missing a return type
(#221) There should be a comma after the last array item in a multi-line array.
(#231) Test method test_provision_stack_exists_replace() is missing any coverage information, own or at class level
(#231) Test method test_provision_stack_exists_replace() is missing a return type
(#250) There should be a comma after the last array item in a multi-line array.
(#254) There should be a comma after the last array item in a multi-line array.
(#285) Test method test_provision_stack_not_exists() is missing any coverage information, own or at class level
(#285) Test method test_provision_stack_not_exists() is missing a return type
(#305) There should be a comma after the last array item in a multi-line array.
(#309) There should be a comma after the last array item in a multi-line array.
(#340) Test method test_remove_stack_remove_objects_ok() is missing any coverage information, own or at class level
(#340) Test method test_remove_stack_remove_objects_ok() is missing a return type
(#353) Inline comments must start with a capital letter, digit or 3-dots sequence
(#356) There should be a comma after the last array item in a multi-line array.
(#358) Inline comments must start with a capital letter, digit or 3-dots sequence
(#364) Inline comments must start with a capital letter, digit or 3-dots sequence

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]