Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(287 errors, 186 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

enrol/attributes/classes/privacy/provider.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#29) Missing docblock for class provider
(#37) There must not be a space before the colon in a return type declaration
enrol/attributes/classes/task/invalidatecache_task.php
(#1) No one-line description found in phpdocs for docblock of file invalidatecache_task.php
(#26) Missing docblock for class invalidatecache_task
enrol/attributes/classes/task/processenrolments_task.php
(#1) No one-line description found in phpdocs for docblock of file processenrolments_task.php
(#26) Missing docblock for class processenrolments_task
(#42) "require_once" must be immediately followed by an open parenthesis
enrol/attributes/cli/sync.php
(#1) No one-line description found in phpdocs for docblock of file sync.php
(#31) Short array syntax must be used to define arrays
(#31) Short array syntax must be used to define arrays
enrol/attributes/db/access.php
(#1) No one-line description found in phpdocs for docblock of file access.php
(#26) Short array syntax must be used to define arrays
(#28) Short array syntax must be used to define arrays
(#31) Short array syntax must be used to define arrays
(#33) There should be a comma after the last array item in a multi-line array.
(#35) Short array syntax must be used to define arrays
(#38) Short array syntax must be used to define arrays
(#41) There should be a comma after the last array item in a multi-line array.
enrol/attributes/db/caches.php
(#1) No one-line description found in phpdocs for docblock of file caches.php
(#26) Short array syntax must be used to define arrays
(#27) Short array syntax must be used to define arrays
(#28) There should be a comma after the last array item in a multi-line array.
enrol/attributes/db/events.php
(#1) No one-line description found in phpdocs for docblock of file events.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#24) Short array syntax must be used to define arrays
(#25) Short array syntax must be used to define arrays
(#32) Short array syntax must be used to define arrays
(#39) Short array syntax must be used to define arrays
(#46) Short array syntax must be used to define arrays
enrol/attributes/db/install.php
(#1) No one-line description found in phpdocs for docblock of file install.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#26) Missing docblock for function xmldb_enrol_attributes_install
enrol/attributes/db/tasks.php
(#1) No one-line description found in phpdocs for docblock of file tasks.php
(#34) There should be a comma after the last array item in a multi-line array.
(#43) There should be a comma after the last array item in a multi-line array.
enrol/attributes/db/upgrade.php
(#1) No one-line description found in phpdocs for docblock of file upgrade.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#26) Missing docblock for function xmldb_enrol_attributes_upgrade
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
(#36) Inline comments must end in full-stops, exclamation marks, or question marks
(#41) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#57) File must end with a newline character
enrol/attributes/edit.php
(#1) No one-line description found in phpdocs for docblock of file edit.php
(#28) Inline comments must start with a capital letter, digit or 3-dots sequence
(#28) Inline comments must end in full-stops, exclamation marks, or question marks
(#30) Short array syntax must be used to define arrays
(#36) Short array syntax must be used to define arrays
(#38) There should be a comma after the last array item in a multi-line array.
(#42) Short array syntax must be used to define arrays
(#48) Expected "if (...) {\n"; found "if(...){\n"
(#49) Commas (,) must be followed by white space.
(#56) Short array syntax must be used to define arrays
(#59) There should be a comma after the last array item in a multi-line array.
(#62) Expected "} else {\n"; found "}\nelse {\n"
(#64) Inline comments must start with a capital letter, digit or 3-dots sequence
(#64) Inline comments must end in full-stops, exclamation marks, or question marks
(#65) Short array syntax must be used to define arrays
(#71) Short array syntax must be used to define arrays
(#74) There should be a comma after the last array item in a multi-line array.
(#80) Usage of ELSEIF not allowed; use ELSE IF instead
(#88) Inline comments must end in full-stops, exclamation marks, or question marks
(#90) Inline comments must end in full-stops, exclamation marks, or question marks
(#92) Expected "} else {\n"; found "}\n else {\n"
(#93) Short array syntax must be used to define arrays
(#97) There should be a comma after the last array item in a multi-line array.
(#111) function name "getRulesWithGroups" must be lower-case letters only
(#111) Expected 1 space before opening brace; found 0
(#123) Short array syntax must be used to define arrays
(#130) Inline comments must end in full-stops, exclamation marks, or question marks
(#132) The use of function print_r() is forbidden
(#133) Variable "debug_fieldsandrules" must not contain underscores.
(#134) The use of function print_r() is forbidden
(#134) Variable "debug_fieldsandrules" must not contain underscores.
(#135) Variable "debug_arraysql" must not contain underscores.
(#135) Variable "debug_fieldsandrules" must not contain underscores.
(#136) The use of function print_r() is forbidden
(#136) Variable "debug_arraysql" must not contain underscores.
(#137) Variable "debug_sqlquery" must not contain underscores.
(#138) Variable "debug_arraysql" must not contain underscores.
(#138) Variable "debug_arraysql" must not contain underscores.
(#139) The use of function print_r() is forbidden
(#139) Variable "debug_sqlquery" must not contain underscores.
(#140) Variable "debug_users" must not contain underscores.
(#140) Variable "debug_sqlquery" must not contain underscores.
(#140) Variable "debug_arraysql" must not contain underscores.
(#141) The use of function print_r() is forbidden
(#141) Variable "debug_users" must not contain underscores.
(#142) Inline comments must start with a capital letter, digit or 3-dots sequence
(#142) This comment is 55% valid code; is this commented out code?
(#142) Expected 1 space before comment text but found 4; use block comment if you need indentation
(#143) Expected 1 space before comment text but found 4; use block comment if you need indentation
(#144) Inline comments must end in full-stops, exclamation marks, or question marks
(#144) Expected 1 space before comment text but found 4; use block comment if you need indentation
(#146) Inline comments must end in full-stops, exclamation marks, or question marks
enrol/attributes/edit_form.php
(#1) No one-line description found in phpdocs for docblock of file edit_form.php
(#27) "require_once" must be immediately followed by an open parenthesis
(#29) Missing docblock for class enrol_attributes_edit_form
(#31) Missing docblock for function definition
(#31) Visibility must be declared on method "definition"
(#34) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#46) Expected "} else {\n"; found "}\n else {\n"
(#52) Inline comments must end in full-stops, exclamation marks, or question marks
(#57) Short array syntax must be used to define arrays
(#68) Line exceeds maximum limit of 180 characters; contains 181 characters
(#71) Expected "} else {\n"; found "}\n else {\n"
(#72) Line exceeds maximum limit of 180 characters; contains 185 characters
(#75) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#77) Inline comments must end in full-stops, exclamation marks, or question marks
(#78) Short array syntax must be used to define arrays
(#80) There should be a comma after the last array item in a multi-line array.
(#84) Line exceeds maximum limit of 180 characters; contains 200 characters
(#105) Missing docblock for function add_action_buttons
(#105) Visibility must be declared on method "add_action_buttons"
(#111) Inline comments must start with a capital letter, digit or 3-dots sequence
(#111) Inline comments must end in full-stops, exclamation marks, or question marks
(#111) No space found before comment text; expected "// when two elements we need a group" but found "//when two elements we need a group"
(#112) Short array syntax must be used to define arrays
(#115) Short array syntax must be used to define arrays
(#117) There should be a comma after the last array item in a multi-line array.
(#119) Short array syntax must be used to define arrays
(#121) There should be a comma after the last array item in a multi-line array.
(#123) Short array syntax must be used to define arrays
enrol/attributes/force.php
(#1) No one-line description found in phpdocs for docblock of file force.php
(#34) Short array syntax must be used to define arrays
(#52) Expected "} else {\n"; found "}\nelse {\n"
enrol/attributes/jsparams.php
(#1) No one-line description found in phpdocs for docblock of file jsparams.php
(#24) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#30) Short array syntax must be used to define arrays
(#35) Short array syntax must be used to define arrays
(#41) Short array syntax must be used to define arrays
(#43) There should be a comma after the last array item in a multi-line array.
enrol/attributes/lang/en/enrol_attributes.php
(#1) No one-line description found in phpdocs for docblock of file enrol_attributes.php
(#25) The string key "defaultrole" is not in the correct order, it should be before "pluginname"
(#27) The string key "attrsyntax" is not in the correct order, it should be before "defaultrole_desc"
(#29) The string key "attributes:config" is not in the correct order, it should be before "attrsyntax_help"
(#33) The string key "ajax-error" is not in the correct order, it should be before "attributes:unenrolself"
(#35) The string key "ajax-okforced" is not in the correct order, it should be before "ajax-okpurged"
(#37) The string key "force" is not in the correct order, it should be before "purge"
(#38) The string key "confirmforce" is not in the correct order, it should be before "force"
(#49) The string key "addcondition" is not in the correct order, it should be before "removewhenexpired_help"
(#53) The string key "defaultwhenexpired" is not in the correct order, it should be before "privacy:metadata"
(#60) The string key "observelogins" is not in the correct order, it should be before "whenexpiredsuspend"
(#62) The string key "cachedef_dbquerycache" is not in the correct order, it should be before "observelogins_desc"
(#67) The string key "listitem_description" is not in the correct order, it should be before "no_profile_field_selected"
enrol/attributes/lang/fr/enrol_attributes.php
(#1) Missing @copyright tag
(#1) Missing @license tag
(#1) Missing docblock for file enrol_attributes.php
enrol/attributes/lib.php
(#1) No one-line description found in phpdocs for docblock of file lib.php
(#25) "require_once" must be immediately followed by an open parenthesis
(#26) "require_once" must be immediately followed by an open parenthesis
(#43) Whitespace found at end of line
(#44) Inline comments must end in full-stops, exclamation marks, or question marks
(#47) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) Inline comments must end in full-stops, exclamation marks, or question marks
(#53) Whitespace found at end of line
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
(#55) Variable "enrol_instances" must not contain underscores.
(#55) Short array syntax must be used to define arrays
(#57) There should be a comma after the last array item in a multi-line array.
(#59) Whitespace found at end of line
(#60) Variable "enrol_instances" must not contain underscores.
(#61) Inline comments must end in full-stops, exclamation marks, or question marks
(#62) Variable "user_enrolment" must not contain underscores.
(#62) Short array syntax must be used to define arrays
(#65) There should be a comma after the last array item in a multi-line array.
(#67) Whitespace found at end of line
(#68) Variable "user_enrolment" must not contain underscores.
(#69) Inline comments must end in full-stops, exclamation marks, or question marks
(#71) Whitespace found at end of line
(#72) Inline comments must end in full-stops, exclamation marks, or question marks
(#75) Whitespace found at end of line
(#78) Whitespace found at end of line
(#80) Short array syntax must be used to define arrays
(#81) Whitespace found at end of line
(#82) Variable "still_valid" must not contain underscores.
(#83) Whitespace found at end of line
(#84) Variable "still_valid" must not contain underscores.
(#85) Inline comments must end in full-stops, exclamation marks, or question marks
(#86) Variable "enrol_plugin" must not contain underscores.
(#87) Whitespace found at end of line
(#90) Inline comments must end in full-stops, exclamation marks, or question marks
(#91) Variable "enrol_plugin" must not contain underscores.
(#92) Whitespace found at end of line
(#93) Inline comments must end in full-stops, exclamation marks, or question marks
(#95) Short array syntax must be used to define arrays
(#96) Variable "user_enrolment" must not contain underscores.
(#100) Short array syntax must be used to define arrays
(#100) There should be a comma after the last array item in a multi-line array.
(#104) Whitespace found at end of line
(#106) Inline comments must end in full-stops, exclamation marks, or question marks
(#107) Variable "enrol_plugin" must not contain underscores.
(#108) Whitespace found at end of line
(#109) Inline comments must end in full-stops, exclamation marks, or question marks
(#111) Short array syntax must be used to define arrays
(#112) Variable "user_enrolment" must not contain underscores.
(#116) Short array syntax must be used to define arrays
(#118) There should be a comma after the last array item in a multi-line array.
(#119) There should be a comma after the last array item in a multi-line array.
(#124) Whitespace found at end of line
(#125) Inline comments must end in full-stops, exclamation marks, or question marks
(#126) Short array syntax must be used to define arrays
(#142) Inline comments must start with a capital letter, digit or 3-dots sequence
(#142) Inline comments must end in full-stops, exclamation marks, or question marks
(#144) Inline comments must start with a capital letter, digit or 3-dots sequence
(#144) Inline comments must end in full-stops, exclamation marks, or question marks
(#149) Inline comments must start with a capital letter, digit or 3-dots sequence
(#150) Line exceeds 132 characters; contains 143 characters
(#150) Inline comments must end in full-stops, exclamation marks, or question marks
(#152) Short array syntax must be used to define arrays
(#156) Short array syntax must be used to define arrays
(#157) Variable "mappings_str" must not contain underscores.
(#158) Variable "mappings_str" must not contain underscores.
(#158) Variable "mapping_str" must not contain underscores.
(#159) Variable "mapping_str" must not contain underscores.
(#166) Inline comments must start with a capital letter, digit or 3-dots sequence
(#166) Inline comments must end in full-stops, exclamation marks, or question marks
(#178) Inline comments must start with a capital letter, digit or 3-dots sequence
(#178) Inline comments must end in full-stops, exclamation marks, or question marks
(#187) No one-line description found in phpdocs for docblock of function process_enrolments
(#195) Variable "possible_unenrolments" must not contain underscores.
(#195) Short array syntax must be used to define arrays
(#200) Inline comments must end in full-stops, exclamation marks, or question marks
(#201) Variable "enrol_attributes_records" must not contain underscores.
(#201) Short array syntax must be used to define arrays
(#204) There should be a comma after the last array item in a multi-line array.
(#207) Expected "} else {\n"; found "}\n else {\n"
(#210) Inline comments must end in full-stops, exclamation marks, or question marks
(#211) Variable "enrol_attributes_records" must not contain underscores.
(#211) Short array syntax must be used to define arrays
(#213) There should be a comma after the last array item in a multi-line array.
(#216) Inline comments must end in full-stops, exclamation marks, or question marks
(#221) Inline comments must end in full-stops, exclamation marks, or question marks
(#223) Variable "possible_unenrolments" must not contain underscores.
(#224) Line exceeds maximum limit of 180 characters; contains 203 characters
(#225) Short array syntax must be used to define arrays
(#227) Variable "possible_unenrolments" must not contain underscores.
(#228) Line exceeds maximum limit of 180 characters; contains 188 characters
(#229) Short array syntax must be used to define arrays
(#233) Inline comments must start with a capital letter, digit or 3-dots sequence
(#234) Variable "possible_unenrolments" must not contain underscores.
(#234) Variable "user_enrolment" must not contain underscores.
(#236) Inline comments must start with a capital letter, digit or 3-dots sequence
(#236) Inline comments must end in full-stops, exclamation marks, or question marks
(#237) TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
(#237) Line exceeds maximum limit of 180 characters; contains 189 characters
(#241) Variable "unenrol_attributes_record" must not contain underscores.
(#241) Short array syntax must be used to define arrays
(#244) Variable "user_enrolment" must not contain underscores.
(#244) There should be a comma after the last array item in a multi-line array.
(#247) Variable "unenrol_attributes_record" must not contain underscores.
(#251) Variable "unenrol_attributes_record" must not contain underscores.
(#256) Variable "user_enrolment" must not contain underscores.
(#257) Variable "unenrol_attributes_record" must not contain underscores.
(#260) Variable "users_cache" must not contain underscores.
(#261) Variable "users_cache" must not contain underscores.
(#262) Variable "users_cache" must not contain underscores.
(#265) Expected "} else {\n"; found "}\n else {\n"
(#272) Variable "user_enrolment" must not contain underscores.
(#273) Inline comments must end in full-stops, exclamation marks, or question marks
(#274) Variable "enrol_attributes_instance" must not contain underscores.
(#275) Variable "unenrol_attributes_record" must not contain underscores.
(#276) Variable "enrol_attributes_instance" must not contain underscores.
(#276) Variable "unenrol_attributes_record" must not contain underscores.
(#276) Variable "user_enrolment" must not contain underscores.
(#277) Usage of ELSEIF not allowed; use ELSE IF instead
(#277) Variable "unenrol_attributes_record" must not contain underscores.
(#278) Variable "enrol_attributes_instance" must not contain underscores.
(#278) Variable "unenrol_attributes_record" must not contain underscores.
(#278) Variable "user_enrolment" must not contain underscores.
(#285) Inline comments must start with a capital letter, digit or 3-dots sequence
(#286) Variable "enrol_attributes_records" must not contain underscores.
(#286) Variable "enrol_attributes_record" must not contain underscores.
(#288) TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
(#288) Line exceeds 132 characters; contains 158 characters
(#289) Inline comments must start with a capital letter, digit or 3-dots sequence
(#289) Inline comments must end in full-stops, exclamation marks, or question marks
(#293) Variable "enrol_attributes_record" must not contain underscores.
(#297) Inline comments must start with a capital letter, digit or 3-dots sequence
(#297) Inline comments must end in full-stops, exclamation marks, or question marks
(#300) Variable "configured_profilefields" must not contain underscores.
(#305) Variable "configured_profilefields" must not contain underscores.
(#309) Variable "enrol_attributes_instance" must not contain underscores.
(#310) Variable "enrol_attributes_instance" must not contain underscores.
(#310) Variable "enrol_attributes_record" must not contain underscores.
(#313) Inline comments must start with a capital letter, digit or 3-dots sequence
(#313) Inline comments must end in full-stops, exclamation marks, or question marks
(#317) Expected "} else {\n"; found "}\n else { // called by scheduled task or by construct\n"
(#317) Inline comments must start with a capital letter, digit or 3-dots sequence
(#317) Inline comments must end in full-stops, exclamation marks, or question marks
(#321) Variable "enrol_attributes_record" must not contain underscores.
(#325) Inline comments must end in full-stops, exclamation marks, or question marks
(#325) No space found before comment text; expected "// TODO fix bug related to cache : users are not unenrolled" but found "//TODO fix bug related to cache : users are not unenrolled"
(#326) Variable "users_cache" must not contain underscores.
(#327) Variable "users_cache" must not contain underscores.
(#328) Variable "users_cache" must not contain underscores.
(#338) Variable "enrol_attributes_record" must not contain underscores.
(#339) Inline comments must start with a capital letter, digit or 3-dots sequence
(#339) Inline comments must end in full-stops, exclamation marks, or question marks
(#341) Variable "enrol_attributes_instance" must not contain underscores.
(#341) Variable "enrol_attributes_record" must not contain underscores.
(#342) Variable "enrol_attributes_record" must not contain underscores.
(#344) Whitespace found at end of line
(#345) Inline comments must end in full-stops, exclamation marks, or question marks
(#346) Variable "enrol_attributes_record" must not contain underscores.
(#350) Inline comments must end in full-stops, exclamation marks, or question marks
(#354) TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
(#354) Line exceeds 132 characters; contains 154 characters
(#355) Inline comments must start with a capital letter, digit or 3-dots sequence
(#355) Inline comments must end in full-stops, exclamation marks, or question marks
(#374) No one-line description found in phpdocs for docblock of function restore_group_member
(#380) Missing docblock for function attrsyntax_toarray
(#380) Opening brace must be the last content on the line
(#380) Inline comments must end in full-stops, exclamation marks, or question marks
(#383) Variable "attrsyntax_object" must not contain underscores.
(#384) Variable "attrsyntax_object" must not contain underscores.
(#386) Short array syntax must be used to define arrays
(#391) Short array syntax must be used to define arrays
(#393) There should be a comma after the last array item in a multi-line array.
(#397) Missing docblock for function arraysyntax_tosql
(#397) Variable "join_id" must not contain underscores.
(#401) Short array syntax must be used to define arrays
(#407) Expected "} else {\n"; found "}\n else {\n"
(#410) Inline comments must start with a capital letter, digit or 3-dots sequence
(#410) Inline comments must end in full-stops, exclamation marks, or question marks
(#416) Variable "sub_arraysyntax" must not contain underscores.
(#416) Short array syntax must be used to define arrays
(#418) There should be a comma after the last array item in a multi-line array.
(#420) Variable "sub_sql" must not contain underscores.
(#420) Variable "sub_arraysyntax" must not contain underscores.
(#420) Variable "join_id" must not contain underscores.
(#421) Variable "sub_sql" must not contain underscores.
(#422) Variable "sub_sql" must not contain underscores.
(#423) Variable "sub_sql" must not contain underscores.
(#424) Usage of ELSEIF not allowed; use ELSE IF instead
(#425) Inline comments must start with a capital letter, digit or 3-dots sequence
(#425) Inline comments must end in full-stops, exclamation marks, or question marks
(#426) Variable "join_id" must not contain underscores.
(#427) Variable "join_id" must not contain underscores.
(#428) Variable "join_id" must not contain underscores.
(#428) Variable "join_id" must not contain underscores.
(#428) Variable "join_id" must not contain underscores.
(#428) Line exceeds 132 characters; contains 157 characters
(#434) Line exceeds 132 characters; contains 146 characters
(#464) Expected "if (...) {\n"; found "if(...) {\n"
(#465) Inline comments must end in full-stops, exclamation marks, or question marks
(#471) Short array syntax must be used to define arrays
(#474) There should be a comma after the last array item in a multi-line array.
(#478) Missing docblock for function purge_instance
(#482) Expected "if (...) {\n"; found "if(...) {\n"
(#483) Variable "enrol_attributes_record" must not contain underscores.
(#484) Variable "enrolment_records" must not contain underscores.
(#484) Variable "enrol_attributes_record" must not contain underscores.
(#485) Variable "enrolment_records" must not contain underscores.
(#486) Variable "enrol_attributes_record" must not contain underscores.
(#516) Logical operator "or" is prohibited; use "||" instead
(#520) Variable "configured_profilefields" must not contain underscores.
(#521) Variable "configured_profilefields" must not contain underscores.
(#522) Inline comments must start with a capital letter, digit or 3-dots sequence
(#522) Inline comments must end in full-stops, exclamation marks, or question marks
(#526) Inline comments must start with a capital letter, digit or 3-dots sequence
(#526) Inline comments must end in full-stops, exclamation marks, or question marks
(#527) Short array syntax must be used to define arrays
(#587) Short array syntax must be used to define arrays
(#590) Short array syntax must be used to define arrays
(#592) There should be a comma after the last array item in a multi-line array.
(#595) Short array syntax must be used to define arrays
(#601) Line indented incorrectly; expected at least 4 spaces, found 3
(#631) Short array syntax must be used to define arrays
(#633) There should be a comma after the last array item in a multi-line array.
enrol/attributes/locallib.php
(#1) No one-line description found in phpdocs for docblock of file locallib.php
(#24) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#26) Missing docblock for constant ENROL_ATTRIBUTES_WHENEXPIREDDONOTHING
(#27) Missing docblock for constant ENROL_ATTRIBUTES_WHENEXPIREDREMOVE
(#28) Missing docblock for constant ENROL_ATTRIBUTES_WHENEXPIREDSUSPEND
enrol/attributes/purge.php
(#1) No one-line description found in phpdocs for docblock of file purge.php
(#34) Short array syntax must be used to define arrays
(#43) Expected "} else {\n"; found "}\nelse {\n"
enrol/attributes/settings.php
(#1) No one-line description found in phpdocs for docblock of file settings.php
(#26) "require_once" must be immediately followed by an open parenthesis
(#30) Inline comments must end in full-stops, exclamation marks, or question marks
(#34) Variable "student_role" must not contain underscores.
(#38) Variable "student_role" must not contain underscores.
(#50) Inline comments must end in full-stops, exclamation marks, or question marks
(#81) Commas (,) must be followed by white space.
(#85) Inline comments must end in full-stops, exclamation marks, or question marks
(#86) Line exceeds maximum limit of 180 characters; contains 193 characters
(#88) Inline comments must end in full-stops, exclamation marks, or question marks
enrol/attributes/tests/attributes_test.php
(#1) Moodle boilerplate not found
(#3) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#6) Inline comments must end in full-stops, exclamation marks, or question marks
(#6) Expected 1 space before comment text but found 2; use block comment if you need indentation
(#9) "require_once" must be immediately followed by an open parenthesis
(#11) Unit test attributes_test should be declared as final.
(#11) Missing @copyright tag
(#11) Missing @license tag
(#11) Missing docblock for class attributes_test
(#11) PHPUnit test file missing any valid testcase class declaration
(#12) Opening brace should be on the same line as the declaration for class attributes_test
(#30) The setUp() method in unit tests must always call to parent::setUp().
(#31) Opening brace should be on the same line as the declaration
(#38) Variable "new_rec" must not contain underscores.
(#38) Short array syntax must be used to define arrays
(#41) There should be a comma after the last array item in a multi-line array.
(#43) Variable "new_rec" must not contain underscores.
(#45) Inline comments must start with a capital letter, digit or 3-dots sequence
(#46) Variable "new_rec" must not contain underscores.
(#47) Variable "new_rec" must not contain underscores.
(#61) Variable "user_info_data" must not contain underscores.
(#64) There should be a comma after the last array item in a multi-line array.
(#66) Variable "user_info_data" must not contain underscores.
(#73) There should be a comma after the last array item in a multi-line array.
(#81) Missing docblock for function testAddUserEnrolByGroup in testcase
(#81) Public method name "attributes_test::testAddUserEnrolByGroup" must be in lower-case letters only
(#82) Opening brace should be on the same line as the declaration
(#87) Missing docblock for function testEnrolUser in testcase
(#87) Public method name "attributes_test::testEnrolUser" must be in lower-case letters only
(#87) Expected 1 space before opening brace; found 0
(#92) Missing docblock for function testUnenrolUser in testcase
(#92) Public method name "attributes_test::testUnenrolUser" must be in lower-case letters only
(#92) Expected 1 space before opening brace; found 0
(#93) Inline comments must end in full-stops, exclamation marks, or question marks
(#93) No space found before comment text; expected "// Simulating the invalidatecache task run by the cron" but found "//Simulating the invalidatecache task run by the cron"
(#102) Missing docblock for function testDeleteUserFromGroupAfterUnenrolment in testcase
(#102) Visibility must be declared on method "testDeleteUserFromGroupAfterUnenrolment"
(#102) method name "attributes_test::testDeleteUserFromGroupAfterUnenrolment" must be in lower-case letters only
(#103) Opening brace should be on the same line as the declaration
(#104) Inline comments must end in full-stops, exclamation marks, or question marks
(#104) No space found before comment text; expected "// Simulating the invalidatecache task run by the cron" but found "//Simulating the invalidatecache task run by the cron"
(#114) Missing docblock for function testWhenExpiredRemoveBehavior in testcase
(#114) Visibility must be declared on method "testWhenExpiredRemoveBehavior"
(#114) method name "attributes_test::testWhenExpiredRemoveBehavior" must be in lower-case letters only
(#115) Opening brace should be on the same line as the declaration
(#118) Whitespace found at end of line
(#119) Inline comments must end in full-stops, exclamation marks, or question marks
(#120) Variable "user_info_data" must not contain underscores.
(#123) There should be a comma after the last array item in a multi-line array.
(#125) Variable "user_info_data" must not contain underscores.
(#127) Inline comments must end in full-stops, exclamation marks, or question marks
(#133) Missing docblock for function testWhenExpiredSuspendBehavior in testcase
(#133) Visibility must be declared on method "testWhenExpiredSuspendBehavior"
(#133) method name "attributes_test::testWhenExpiredSuspendBehavior" must be in lower-case letters only
(#134) Opening brace should be on the same line as the declaration
(#143) There should be a comma after the last array item in a multi-line array.
(#147) Inline comments must end in full-stops, exclamation marks, or question marks
(#148) Variable "user_info_data" must not contain underscores.
(#151) There should be a comma after the last array item in a multi-line array.
(#153) Variable "user_info_data" must not contain underscores.
(#155) Inline comments must end in full-stops, exclamation marks, or question marks
(#158) Inline comments must end in full-stops, exclamation marks, or question marks
(#159) Short array syntax must be used to define arrays
(#161) There should be a comma after the last array item in a multi-line array.
(#167) Missing docblock for function testWhenExpiredDoNothingBehavior in testcase
(#167) Visibility must be declared on method "testWhenExpiredDoNothingBehavior"
(#167) method name "attributes_test::testWhenExpiredDoNothingBehavior" must be in lower-case letters only
(#168) Opening brace should be on the same line as the declaration
(#177) There should be a comma after the last array item in a multi-line array.
(#181) Inline comments must end in full-stops, exclamation marks, or question marks
(#182) Variable "user_info_data" must not contain underscores.
(#185) There should be a comma after the last array item in a multi-line array.
(#187) Variable "user_info_data" must not contain underscores.
(#189) Inline comments must end in full-stops, exclamation marks, or question marks
(#192) Inline comments must end in full-stops, exclamation marks, or question marks
(#193) Short array syntax must be used to define arrays
(#195) There should be a comma after the last array item in a multi-line array.
(#201) Missing docblock for function unenrolUser in testcase
(#201) Visibility must be declared on method "unenrolUser"
(#201) method name "attributes_test::unenrolUser" must be in lower-case letters only
(#202) Opening brace should be on the same line as the declaration
(#210) File must end with a newline character
enrol/attributes/version.php
(#1) No one-line description found in phpdocs for docblock of file version.php
(#27) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(56 errors, 115 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

enrol/attributes/js/javascript.js
(#23) Identifier 'enrol_attributes_purge' is not in camel case. (camelcase)
(#23) 'enrol_attributes_purge' is assigned a value but never used. (no-unused-vars)
(#23) Identifier 'enrol_attributes_force' is not in camel case. (camelcase)
(#23) 'enrol_attributes_force' is not defined. (no-undef)
(#23) Unexpected space before function parentheses. (space-before-function-paren)
(#24) Unexpected alert. (no-alert)
(#27) Unexpected space before function parentheses. (space-before-function-paren)
(#29) Unexpected space before function parentheses. (space-before-function-paren)
(#31) Identifier '$shib_rules' is not in camel case. (camelcase)
(#35) Identifier 'shib_boolconfig' is not in camel case. (camelcase)
(#35) 'shib_boolconfig' declared on line 38 column 17 is used outside of binding context. (block-scoped-var)
(#35) eval can be harmful. (no-eval)
(#36) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#38) 'shib_boolconfig' is already defined. (no-redeclare)
(#38) 'shib_boolconfig' declared on line 35 column 17 is used outside of binding context. (block-scoped-var)
(#45) Identifier '$shib_rules' is not in camel case. (camelcase)
(#46) 'shib_boolconfig' declared on line 35 column 17 is used outside of binding context. (block-scoped-var)
(#46) Identifier 'shib_boolconfig' is not in camel case. (camelcase)
(#46) 'shib_boolconfig' declared on line 38 column 17 is used outside of binding context. (block-scoped-var)
(#47) Identifier 'enrol_attributes_updateExpr' is not in camel case. (camelcase)
(#52) Identifier 'enrol_attributes_purge' is not in camel case. (camelcase)
(#52) Unexpected space before function parentheses. (space-before-function-paren)
(#53) Unexpected confirm. (no-alert)
(#54) This line has a length of 156. Maximum allowed is 132. (max-len)
(#55) Unexpected space before function parentheses. (space-before-function-paren)
(#56) Unexpected alert. (no-alert)
(#59) Missing semicolon. (semi)
(#61) Identifier 'enrol_attributes_force' is not in camel case. (camelcase)
(#61) 'enrol_attributes_force' is not defined. (no-undef)
(#61) Unexpected space before function parentheses. (space-before-function-paren)
(#62) Unexpected confirm. (no-alert)
(#63) This line has a length of 156. Maximum allowed is 132. (max-len)
(#64) Unexpected space before function parentheses. (space-before-function-paren)
(#65) Unexpected alert. (no-alert)
(#68) Missing semicolon. (semi)
(#69) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#77) Identifier 'enrol_attributes_updateExpr' is not in camel case. (camelcase)
(#78) 'expressionStr' is assigned a value but never used. (no-unused-vars)
(#79) 'serializedObj' is assigned a value but never used. (no-unused-vars)
(#85) 'jQuery' is not defined. (no-undef)
(#85) Missing semicolon. (semi)
enrol/attributes/js/jquery.booleanEditor.js
(#23) Unnecessary semicolon. (no-extra-semi)
(#24) Unexpected space before function parentheses. (space-before-function-paren)
(#46) Unexpected space before function parentheses. (space-before-function-paren)
(#47) Comments should not begin with a lowercase character. (capitalized-comments)
(#51) Expected { after 'if' condition. (curly)
(#53) There should be no space after this paren. (space-in-parens)
(#53) There should be no space before this paren. (space-in-parens)
(#54) Identifier 'ser_obj' is not in camel case. (camelcase)
(#59) Unreachable code. (no-unreachable)
(#63) Identifier 'ser_obj' is not in camel case. (camelcase)
(#65) Unreachable code. (no-unreachable)
(#68) Unreachable code. (no-unreachable)
(#70) Method 'booleanEditor' expected a return value. (consistent-return)
(#73) 'settings' is not defined. (no-undef)
(#75) Unexpected space before function parentheses. (space-before-function-paren)
(#76) 'settings' is not defined. (no-undef)
(#77) 'settings' is not defined. (no-undef)
(#77) Missing semicolon. (semi)
(#81) 'settings' is not defined. (no-undef)
(#89) Identifier 'root_elem' is not in camel case. (camelcase)
(#90) Identifier 'ser_obj' is not in camel case. (camelcase)
(#91) Identifier 'group_c_op' is not in camel case. (camelcase)
(#92) Identifier 'group_c_op' is not in camel case. (camelcase)
(#93) Identifier 'ser_obj' is not in camel case. (camelcase)
(#93) Expected { after 'if' condition. (curly)
(#93) Identifier 'cond_op' is not in camel case. (camelcase)
(#93) Identifier 'group_c_op' is not in camel case. (camelcase)
(#95) Unexpected space before function parentheses. (space-before-function-paren)
(#96) 'r' is not defined. (no-undef)
(#97) 'r' is not defined. (no-undef)
(#98) Identifier 'ser_obj' is not in camel case. (camelcase)
(#98) ["rules"] is better written in dot notation. (dot-notation)
(#100) Identifier 'cond_obj' is not in camel case. (camelcase)
(#101) 'r' is not defined. (no-undef)
(#102) Identifier 'comp_op' is not in camel case. (camelcase)
(#102) 'r' is not defined. (no-undef)
(#103) 'r' is not defined. (no-undef)
(#105) Identifier 'cond_op' is not in camel case. (camelcase)
(#105) 'r' is not defined. (no-undef)
(#106) Identifier 'cond_op' is not in camel case. (camelcase)
(#107) Identifier 'cond_obj' is not in camel case. (camelcase)
(#107) Expected { after 'if' condition. (curly)
(#107) Identifier 'cond_op' is not in camel case. (camelcase)
(#107) Identifier 'cond_op' is not in camel case. (camelcase)
(#108) Identifier 'ser_obj' is not in camel case. (camelcase)
(#108) ["rules"] is better written in dot notation. (dot-notation)
(#111) Identifier 'ser_obj' is not in camel case. (camelcase)
(#117) Unexpected space before function parentheses. (space-before-function-paren)
(#118) 'r' is not defined. (no-undef)
(#119) Identifier 'c_op' is not in camel case. (camelcase)
(#119) 'r' is not defined. (no-undef)
(#120) Identifier 'c_op' is not in camel case. (camelcase)
(#120) Identifier 'c_op' is not in camel case. (camelcase)
(#120) Expected { after 'if' condition. (curly)
(#120) Identifier 'c_op' is not in camel case. (camelcase)
(#122) 'r' is not defined. (no-undef)
(#123) This line has a length of 160. Maximum allowed is 132. (max-len)
(#123) Identifier 'c_op' is not in camel case. (camelcase)
(#126) Identifier 'c_op' is not in camel case. (camelcase)
(#128) 'r' is not defined. (no-undef)
(#129) 'r' is not defined. (no-undef)
(#130) 'r' is not defined. (no-undef)
(#140) '$o' is not defined. (no-undef)
(#141) '$o' is not defined. (no-undef)
(#142) '$o' is not defined. (no-undef)
(#142) '$o' is not defined. (no-undef)
(#144) '$o' is not defined. (no-undef)
(#145) '$o' is not defined. (no-undef)
(#145) '$o' is not defined. (no-undef)
(#150) Identifier 'list_elem' is not in camel case. (camelcase)
(#152) Identifier 'list_elem' is not in camel case. (camelcase)
(#153) Unexpected console statement. (no-console)
(#159) Identifier 'list_elem' is not in camel case. (camelcase)
(#163) Identifier 'r_idx' is not in camel case. (camelcase)
(#163) Identifier 'r_idx' is not in camel case. (camelcase)
(#163) Identifier 'r_idx' is not in camel case. (camelcase)
(#164) Identifier 'r_idx' is not in camel case. (camelcase)
(#165) ["first"] is better written in dot notation. (dot-notation)
(#165) Identifier 'r_idx' is not in camel case. (camelcase)
(#171) Identifier 'list_elem' is not in camel case. (camelcase)
(#173) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#175) Identifier 'list_elem' is not in camel case. (camelcase)
(#180) Function 'createRuleList' expected no return value. (consistent-return)
(#180) Identifier 'list_elem' is not in camel case. (camelcase)
(#181) Unnecessary semicolon. (no-extra-semi)
(#193) Identifier 'cond_op' is not in camel case. (camelcase)
(#195) Identifier 'comp_op' is not in camel case. (camelcase)
(#204) Identifier 'cond_block_content' is not in camel case. (camelcase)
(#206) Identifier 'cond_block_content' is not in camel case. (camelcase)
(#208) Identifier 'cond_block_content' is not in camel case. (camelcase)
(#209) Multiple spaces found before '// The list of...'. (no-multi-spaces)
(#212) Identifier 'selected_value' is not in camel case. (camelcase)
(#214) Comments should not begin with a lowercase character. (capitalized-comments)
(#214) Expected space or tab after '//' in comment. (spaced-comment)
(#218) Identifier 'selected_value' is not in camel case. (camelcase)
(#222) Unexpected space before function parentheses. (space-before-function-paren)
(#223) Missing semicolon. (semi)
(#225) Multiple spaces found before '// The value o...'. (no-multi-spaces)
(#232) Missing semicolon. (semi)
(#236) Unnecessary semicolon. (no-extra-semi)
(#247) Identifier 'selected_value' is not in camel case. (camelcase)
(#254) This line has a length of 139. Maximum allowed is 132. (max-len)
(#254) Operator '+' must be spaced. (space-infix-ops)
(#254) Operator '+' must be spaced. (space-infix-ops)
(#255) Unexpected space before function parentheses. (space-before-function-paren)
(#259) This line has a length of 136. Maximum allowed is 132. (max-len)
(#259) Operator '+' must be spaced. (space-infix-ops)
(#259) Operator '+' must be spaced. (space-infix-ops)
(#260) Unexpected space before function parentheses. (space-before-function-paren)
(#264) This line has a length of 142. Maximum allowed is 132. (max-len)
(#264) Operator '+' must be spaced. (space-infix-ops)
(#264) Operator '+' must be spaced. (space-infix-ops)
(#265) Unexpected space before function parentheses. (space-before-function-paren)
(#269) Unexpected space before function parentheses. (space-before-function-paren)
(#271) Unexpected space before function parentheses. (space-before-function-paren)
(#272) Missing semicolon. (semi)
(#286) Identifier 'selected_value' is not in camel case. (camelcase)
(#291) Unexpected space before function parentheses. (space-before-function-paren)
(#294) Unexpected space before function parentheses. (space-before-function-paren)
(#295) Identifier 'p_obj' is not in camel case. (camelcase)
(#299) Identifier 'p_obj' is not in camel case. (camelcase)
(#301) Identifier 'p_obj' is not in camel case. (camelcase)
(#315) Unexpected space before function parentheses. (space-before-function-paren)
(#316) Missing semicolon. (semi)
(#328) Unexpected space before function parentheses. (space-before-function-paren)
(#329) Missing semicolon. (semi)
(#353) 'p' is not defined. (no-undef)
(#354) Unexpected space before function parentheses. (space-before-function-paren)
(#357) 'p' is not defined. (no-undef)
(#362) 'jQuery' is not defined. (no-undef)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]