Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(46 errors, 35 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

enrol/apply/apply_form.php
(#58) Line exceeds maximum limit of 180 characters; contains 221 characters
(#63) Variable "comment_title" must not contain underscores.
(#64) Expected "if (...) {\n"; found "if(...){\n"
(#65) Variable "comment_title" must not contain underscores.
(#67) Variable "comment_title" must not contain underscores.
(#72) Whitespace found at end of line
enrol/apply/backup/backup_enrol_apply_plugin.class.php
(#32) Inline comments must end in full-stops, exclamation marks, or question marks
(#35) Inline comments must end in full-stops, exclamation marks, or question marks
(#38) Inline comments must start with a capital letter, digit or 3-dots sequence
(#38) Inline comments must end in full-stops, exclamation marks, or question marks
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
(#45) Line exceeds maximum limit of 180 characters; contains 480 characters
(#47) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) Inline comments must start with a capital letter, digit or 3-dots sequence
(#51) Inline comments must end in full-stops, exclamation marks, or question marks
enrol/apply/backup/restore_enrol_apply_plugin.class.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
(#31) Expected 1 space before "=>"; 0 found
(#31) Expected 1 space after "=>"; 0 found
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
enrol/apply/edit.php
(#66) Inline comments must end in full-stops, exclamation marks, or question marks
(#66) No space found before comment text; expected "// $notify = array('$@NONE@$');" but found "//$notify = array('$@NONE@$');"
(#67) This comment is 57% valid code; is this commented out code?
(#72) Inline comments must start with a capital letter, digit or 3-dots sequence
(#72) This comment is 63% valid code; is this commented out code?
(#72) No space found before comment text; expected "// $instance->notify = $notify;" but found "//$instance->notify = $notify;"
(#92) Inline comments must end in full-stops, exclamation marks, or question marks
(#92) No space found before comment text; expected "// $data->customtext2 = implode(',', $notify);" but found "//$data->customtext2 = implode(',', $notify);"
enrol/apply/edit_form.php
(#45) Inline comments must start with a capital letter, digit or 3-dots sequence
(#45) This comment is 77% valid code; is this commented out code?
(#64) Inline comments must start with a capital letter, digit or 3-dots sequence
(#64) This comment is 60% valid code; is this commented out code?
(#64) No space found before comment text; expected "// new added requirement_20190110" but found "//new added requirement_20190110"
(#65) Inline comments must end in full-stops, exclamation marks, or question marks
(#65) No space found before comment text; expected "// $title_customtext2 = str_replace("{replace_title}",$instance->customtext2,get_string('custom_label', 'enrol_apply'));" but found "//$title_customtext2 = str_replace("{replace_title}",$instance->customtext2,get_string('custom_label', 'enrol_apply'));"
(#66) Variable "title_customtext2" must not contain underscores.
(#67) Variable "title_customtext2" must not contain underscores.
(#89) Expected "if (...) {\n"; found "if(...) {\n"
(#90) Expected "if (...) {\n"; found "if(...) {\n"
(#93) Expected "} else if (...) {\n"; found "}\n else if(...) {\n"
(#93) Expected "if (...) {\n"; found "if(...) {\n"
(#96) Expected "} else {\n"; found "}\n else {\n"
(#117) Inline comments must start with a capital letter, digit or 3-dots sequence
(#117) Inline comments must end in full-stops, exclamation marks, or question marks
(#117) This comment is 82% valid code; is this commented out code?
(#117) No space found before comment text; expected "// echo "<pre>";print_r($instance);exit;" but found "//echo "<pre>";print_r($instance);exit;"
enrol/apply/info.php
(#25) Whitespace found at end of line
(#67) Commas (,) must be followed by white space.
enrol/apply/info_table.php
(#30) Member variable "is_collapsible" must not contain underscores.
(#58) Inline comments must start with a capital letter, digit or 3-dots sequence
(#58) This comment is 86% valid code; is this commented out code?
(#58) No space found before comment text; expected "// $this->no_sorting('checkboxcolumn');" but found "//$this->no_sorting('checkboxcolumn');"
(#72) This comment is 59% valid code; is this commented out code?
enrol/apply/lang/en/enrol_apply.php
(#104) Inline comments must start with a capital letter, digit or 3-dots sequence
(#104) This comment is 78% valid code; is this commented out code?
(#104) No space found before comment text; expected "// $string['custom_label'] = 'Custom label "{replace_title}"';" but found "//$string['custom_label'] = 'Custom label "{replace_title}"';"
enrol/apply/lang/ja/enrol_apply.php
(#2) The opening <?php tag must be followed by exactly one newline.
enrol/apply/lib.php
(#68) This comment is 65% valid code; is this commented out code?
(#116) Line exceeds maximum limit of 180 characters; contains 190 characters
(#248) Expected 1 space before "=>"; 0 found
(#248) Expected 1 space after "=>"; 0 found
(#248) Expected 1 space before "=>"; 0 found
(#248) Expected 1 space after "=>"; 0 found
(#248) Line exceeds 132 characters; contains 154 characters
(#301) Line exceeds 132 characters; contains 143 characters
(#380) Whitespace found at end of line
(#404) Whitespace found at end of line
(#540) Inline comments must start with a capital letter, digit or 3-dots sequence
(#540) Inline comments must end in full-stops, exclamation marks, or question marks
(#552) Inline comments must start with a capital letter, digit or 3-dots sequence
(#552) This comment is 85% valid code; is this commented out code?
(#552) No space found before comment text; expected "// $this->sync_enrols($DB->get_record('enrol', array('id'=>$instanceid)));" but found "//$this->sync_enrols($DB->get_record('enrol', array('id'=>$instanceid)));"
enrol/apply/manage_table.php
(#31) Member variable "is_collapsible" must not contain underscores.
enrol/apply/notification.php
(#27) Commas (,) must be followed by white space.
enrol/apply/renderer.php
(#72) Commas (,) must be followed by white space.
(#76) Commas (,) must be followed by white space.
(#104) Commas (,) must be followed by white space.
(#110) Commas (,) must be followed by white space.
(#115) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#124) Commas (,) must be followed by white space.
(#152) Expected "if (...) {\n"; found "if(...){\n"

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(73 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

enrol/apply/apply_form.php
(#31) Class enrol_apply_apply_form is not documented
(#44) Function enrol_apply_apply_form::definition is not documented
(#32) Variable enrol_apply_apply_form::$instance is not documented
(#17) No one-line description found in phpdocs for file
enrol/apply/backup/backup_enrol_apply_plugin.class.php
(#19) Package enrol_lti is not valid
(#30) Function backup_enrol_apply_plugin::define_enrol_plugin_structure is not documented
enrol/apply/backup/restore_enrol_apply_plugin.class.php
(#7) Package is not specified for class restore_enrol_apply_plugin. It is also not specified in file-level phpdocs
(#2) Empty line found after PHP open tag
(#12) Function restore_enrol_apply_plugin::define_enrol_plugin_structure is not documented
(#18) Phpdocs for function restore_enrol_apply_plugin::process_applymap has incomplete parameters list
enrol/apply/db/access.php
(#17) No one-line description found in phpdocs for file
enrol/apply/db/messages.php
(#17) No one-line description found in phpdocs for file
enrol/apply/db/upgrade.php
(#26) Function xmldb_enrol_apply_upgrade is not documented
(#17) No one-line description found in phpdocs for file
enrol/apply/edit.php
(#17) No one-line description found in phpdocs for file
enrol/apply/edit_form.php
(#29) Class enrol_apply_edit_form is not documented
(#31) Function enrol_apply_edit_form::definition is not documented
(#17) No one-line description found in phpdocs for file
enrol/apply/info.php
(#17) No one-line description found in phpdocs for file
enrol/apply/info_table.php
(#28) Class enrol_apply_info_table is not documented
(#32) Function enrol_apply_info_table::__construct is not documented
(#30) Variable enrol_apply_info_table::$is_collapsible is not documented
(#17) No one-line description found in phpdocs for file
(#63) Phpdocs for function enrol_apply_info_table::get_row_class has incomplete parameters list
enrol/apply/lang/ca/enrol_apply.php
(#17) No one-line description found in phpdocs for file
enrol/apply/lang/de/enrol_apply.php
(#17) No one-line description found in phpdocs for file
enrol/apply/lang/en/enrol_apply.php
(#17) No one-line description found in phpdocs for file
enrol/apply/lang/en_us/en_us_enrol_apply.php
(#17) No one-line description found in phpdocs for file
enrol/apply/lang/es/enrol_apply.php
(#17) No one-line description found in phpdocs for file
enrol/apply/lang/it/enrol_apply.php
(#17) No one-line description found in phpdocs for file
enrol/apply/lang/ja/enrol_apply.php
(#2) Empty line found after PHP open tag
enrol/apply/lang/pt_br/enrol_apply.php
(#17) No one-line description found in phpdocs for file
enrol/apply/lang/zh_cn/enrol_apply.php
(#17) No one-line description found in phpdocs for file
enrol/apply/lib.php
(#28) Class enrol_apply_plugin is not documented
(#40) Function enrol_apply_plugin::allow_unenrol is not documented
(#44) Function enrol_apply_plugin::roles_protected is not documented
(#49) Function enrol_apply_plugin::allow_apply is not documented
(#75) Function enrol_apply_plugin::allow_manage is not documented
(#94) Function enrol_apply_plugin::enrol_page_hook is not documented
(#154) Function enrol_apply_plugin::get_action_icons is not documented
(#232) Function enrol_apply_plugin::get_user_enrolment_actions is not documented
(#273) Function enrol_apply_plugin::confirm_enrolment is not documented
(#313) Function enrol_apply_plugin::wait_enrolment is not documented
(#342) Function enrol_apply_plugin::cancel_enrolment is not documented
(#375) Function enrol_apply_plugin::notify_applicant is not documented
(#397) Function enrol_apply_plugin::send_application_notification is not documented
(#519) Function enrol_apply_plugin::update_mail_content is not documented
(#544) Function enrol_apply_plugin::restore_instance is not documented
(#555) Function enrol_apply_plugin::restore_user_enrolment is not documented
(#17) No one-line description found in phpdocs for file
enrol/apply/manage.php
(#17) No one-line description found in phpdocs for file
enrol/apply/manage_table.php
(#29) Class enrol_apply_manage_table is not documented
(#33) Function enrol_apply_manage_table::__construct is not documented
(#74) Function enrol_apply_manage_table::col_checkboxcolumn is not documented
(#78) Function enrol_apply_manage_table::col_fullname is not documented
(#86) Function enrol_apply_manage_table::col_applydate is not documented
(#31) Variable enrol_apply_manage_table::$is_collapsible is not documented
(#17) No one-line description found in phpdocs for file
(#64) Phpdocs for function enrol_apply_manage_table::get_row_class has incomplete parameters list
enrol/apply/notification.php
(#26) Class enrol_apply_notification is not documented
(#27) Function enrol_apply_notification::__construct is not documented
(#17) No one-line description found in phpdocs for file
enrol/apply/renderer.php
(#27) Class enrol_apply_renderer is not documented
(#28) Function enrol_apply_renderer::manage_page is not documented
(#36) Function enrol_apply_renderer::edit_page is not documented
(#43) Function enrol_apply_renderer::manage_form is not documented
(#72) Function enrol_apply_renderer::info_page is not documented
(#80) Function enrol_apply_renderer::manage_table is not documented
(#104) Function enrol_apply_renderer::info_form is not documented
(#124) Function enrol_apply_renderer::info_table is not documented
(#139) Function enrol_apply_renderer::application_notification_mail_body is not documented
(#17) No one-line description found in phpdocs for file
enrol/apply/settings.php
(#17) No one-line description found in phpdocs for file
enrol/apply/unenrolself.php
(#17) No one-line description found in phpdocs for file
enrol/apply/version.php
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(5 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

enrol/apply/db/upgrade.php
Detected more 'if' blocks (5) than 'savepoint' calls (1)
version 2016042202 is missing corresponding savepoint call
version 2016060803 is missing corresponding savepoint call
version 2017032400 is missing corresponding savepoint call
version 2018112603 is missing corresponding savepoint call

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

enrol/apply/amd/build/manage.min.js
Uncommitted change detected.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]