Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]


Javascript coding style problems

(7 errors, 22 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/xp/amd/src/course-resource-selector.js
(#42) There should be no space after '{'. (babel/object-curly-spacing)
(#42) There should be no space before '}'. (babel/object-curly-spacing)
blocks/xp/amd/src/dialogue-base.js
(#39) Expected catch,fail() or return (promise/catch-or-return)
(#39) Each then() should return a value or throw (promise/always-return)
(#92) Expected catch,fail() or return (promise/catch-or-return)
(#153) Expected catch,fail() or return (promise/catch-or-return)
blocks/xp/amd/src/popup-notification-queue.js
(#29) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
(#38) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
(#63) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
(#73) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
blocks/xp/amd/src/popup-notification.js
(#34) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
blocks/xp/amd/src/resource-selector.js
(#31) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
(#91) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
blocks/xp/amd/src/role-button.js
(#26) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
(#65) Expected JSDoc block to be aligned. (jsdoc/check-alignment)
blocks/xp/postcss.config.js
(#2) Expected indentation of 4 spaces but found 2. (indent)
(#3) Expected indentation of 8 spaces but found 4. (indent)
(#4) Expected indentation of 8 spaces but found 4. (indent)
(#5) Expected indentation of 8 spaces but found 4. (indent)
(#6) Expected indentation of 8 spaces but found 4. (indent)
(#7) Expected indentation of 4 spaces but found 2. (indent)
(#8) Missing semicolon. (semi)
blocks/xp/yui/src/filters/js/dnd.js
(#93) Identifier 'global_drop_over' is not in camel case. (camelcase)
(#120) Identifier 'drag_end' is not in camel case. (camelcase)
(#129) Identifier 'drop_hit' is not in camel case. (camelcase)
(#138) Identifier 'drop_over' is not in camel case. (camelcase)
blocks/xp/yui/src/filters/js/filters.js
(#274) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#280) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#285) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)

CSS problems

(21 errors, 13 warnings)

This section shows CSS problems detected by stylelint [More info]

blocks/xp/styles.css
(#1036) Expected empty line before at-rule (at-rule-empty-line-before)
(#1046) Expected empty line before at-rule (at-rule-empty-line-before)
(#1072) Expected empty line before at-rule (at-rule-empty-line-before)
(#762) Expected single space before "{" (block-opening-brace-space-before)
(#43) Unexpected !important (declaration-no-important)
(#626) Unexpected !important (declaration-no-important)
(#750) Unexpected !important (declaration-no-important)
(#30) Unexpected unit (length-zero-no-unit)
(#258) Unexpected unit (length-zero-no-unit)
(#291) Unexpected unit (length-zero-no-unit)
(#308) Unexpected unit (length-zero-no-unit)
(#309) Unexpected unit (length-zero-no-unit)
(#431) Unexpected unit (length-zero-no-unit)
(#558) Unexpected unit (length-zero-no-unit)
(#565) Unexpected unit (length-zero-no-unit)
(#575) Unexpected unit (length-zero-no-unit)
(#1095) Unexpected unit (length-zero-no-unit)
(#1099) Unexpected unit (length-zero-no-unit)
(#1103) Unexpected unit (length-zero-no-unit)
(#1117) Expected single space after ">" (selector-combinator-space-after)
(#1117) Expected single space before ">" (selector-combinator-space-before)
(#775) Expected newline after "," (selector-list-comma-newline-after)
(#456) Expected indentation of 4 spaces (indentation)
(#458) Expected indentation of 4 spaces (indentation)
(#512) Expected indentation of 4 spaces (indentation)
(#513) Expected indentation of 4 spaces (indentation)
(#776) Expected indentation of 0 spaces (indentation)
blocks/xp/css/styles.css
(#331) Expected single space before "{" (block-opening-brace-space-before)
(#132) Unexpected duplicate "display" (declaration-block-no-duplicate-properties)
(#133) Unexpected duplicate "display" (declaration-block-no-duplicate-properties)
(#319) Unexpected !important (declaration-no-important)
(#126) Expected line length to be no more than 132 characters (max-line-length)
(#344) Expected newline after "," (selector-list-comma-newline-after)
(#345) Expected indentation of 0 spaces (indentation)

PHPDocs style problems

(78 errors, 104 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/xp/backup/moodle2/backup_xp_block_task.class.php
(#67) Phpdocs for function backup_xp_block_task::encode_content_links has incomplete parameters list
blocks/xp/backup/moodle2/restore_xp_stepslib.php
(#72) Phpdocs for function restore_xp_block_structure_step::process_block has incomplete parameters list
(#104) Phpdocs for function restore_xp_block_structure_step::process_config has incomplete parameters list
(#123) Phpdocs for function restore_xp_block_structure_step::process_filter has incomplete parameters list
(#169) Phpdocs for function restore_xp_block_structure_step::process_log has incomplete parameters list
(#179) Phpdocs for function restore_xp_block_structure_step::process_xp has incomplete parameters list
blocks/xp/classes/external.php
(#385) Function external::clean_levels_info_data is not documented
(#229) Phpdocs for function external::set_default_levels_info has incomplete parameters list
(#294) Phpdocs for function external::set_levels_info has incomplete parameters list
blocks/xp/classes/filter.php
(#377) Phpdocs for function block_xp_filter::validate_ruledata has incomplete parameters list
(#100) Inline phpdocs tag {@link self::load_from_data()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#236) Inline phpdocs tag {@link self::$ruledata} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/xp/classes/form/config.php
(#246) Phpdocs for function config::set_data has incomplete parameters list
blocks/xp/classes/local/config/config.php
(#54) Phpdocs for function config::has has incomplete parameters list
blocks/xp/classes/local/config/table_row_config.php
(#63) Phpdocs for function table_row_config::__construct has incomplete parameters list
blocks/xp/classes/local/controller/admin_levels_controller.php
(#51) Function admin_levels_controller::post_login is not documented
(#56) Function admin_levels_controller::content is not documented
(#63) Function admin_levels_controller::get_react_module is not documented
blocks/xp/classes/local/controller/admin_rules_controller.php
(#49) Function admin_rules_controller::define_optional_params is not documented
(#57) Function admin_rules_controller::pre_content is not documented
(#205) Function admin_rules_controller::page_plus_promo_content is not documented
(#213) Function admin_rules_controller::page_rules_content is not documented
(#101) Phpdocs for function admin_rules_controller::save_filters has incomplete parameters list
blocks/xp/classes/local/controller/admin_visuals_controller.php
(#106) Function admin_visuals_controller::pre_content is not documented
blocks/xp/classes/local/controller/config_controller.php
(#81) Function config_controller::pre_content is not documented
(#96) Function config_controller::get_page_html_head_title is not documented
(#100) Function config_controller::get_page_heading is not documented
(#104) Function config_controller::page_content is not documented
(#110) Function config_controller::page_note is not documented
blocks/xp/classes/local/controller/infos_controller.php
(#51) Function infos_controller::permissions_checks is not documented
(#58) Function infos_controller::define_optional_params is not documented
(#64) Function infos_controller::pre_content is not documented
(#78) Function infos_controller::get_form is not documented
(#85) Function infos_controller::get_page_html_head_title is not documented
(#89) Function infos_controller::get_page_heading is not documented
(#93) Function infos_controller::page_content is not documented
(#47) Variable infos_controller::$requiremanage is not documented
(#48) Variable infos_controller::$routename is not documented
(#49) Variable infos_controller::$form is not documented
blocks/xp/classes/local/controller/ladder_controller.php
(#46) Function ladder_controller::permissions_checks is not documented
(#53) Function ladder_controller::page_setup is not documented
(#102) Function ladder_controller::get_page_html_head_title is not documented
(#106) Function ladder_controller::get_page_heading is not documented
(#149) Function ladder_controller::page_content is not documented
(#42) Variable ladder_controller::$requiremanage is not documented
(#43) Variable ladder_controller::$supportsgroups is not documented
(#44) Variable ladder_controller::$routename is not documented
(#40) Constant ladder_controller::PAGE_SIZE_FLAG is not documented
blocks/xp/classes/local/controller/levels_controller.php
(#47) Function levels_controller::get_page_html_head_title is not documented
(#51) Function levels_controller::get_page_heading is not documented
(#55) Function levels_controller::get_react_module is not documented
(#74) Function levels_controller::page_content is not documented
blocks/xp/classes/local/controller/log_controller.php
(#50) Function log_controller::permissions_checks is not documented
(#58) Function log_controller::define_optional_params is not documented
(#64) Function log_controller::get_table is not documented
(#74) Function log_controller::get_page_html_head_title is not documented
(#78) Function log_controller::get_page_heading is not documented
(#98) Function log_controller::page_content is not documented
(#42) Variable log_controller::$navname is not documented
(#43) Variable log_controller::$routename is not documented
(#44) Variable log_controller::$iswideview is not documented
(#45) Variable log_controller::$supportsgroups is not documented
(#47) Inline phpdocs tag {@link self::get_user_id} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/xp/classes/local/controller/page_controller.php
(#141) Inline phpdocs tag {@link self::page_content} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/xp/classes/local/controller/promo_controller.php
(#61) Function promo_controller::define_optional_params is not documented
(#77) Function promo_controller::require_login is not documented
(#101) Function promo_controller::post_login is not documented
(#137) Function promo_controller::content is not documented
(#322) Function promo_controller::content_installed is not documented
blocks/xp/classes/local/controller/report_controller.php
(#55) Function report_controller::define_optional_params is not documented
(#66) Function report_controller::permissions_checks is not documented
(#74) Function report_controller::pre_content is not documented
(#120) Function report_controller::get_page_html_head_title is not documented
(#124) Function report_controller::get_page_heading is not documented
(#128) Function report_controller::get_form is not documented
(#138) Function report_controller::get_table is not documented
(#184) Function report_controller::page_content is not documented
blocks/xp/classes/local/controller/route_controller.php
(#199) Phpdocs for function route_controller::handle has incomplete parameters list
(#158) Inline phpdocs tag {@link self::get_param} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/xp/classes/local/controller/rules_controller.php
(#57) Function rules_controller::define_optional_params is not documented
(#64) Function rules_controller::post_login is not documented
(#70) Function rules_controller::pre_content is not documented
(#92) Function rules_controller::handle_save is not documented
(#97) Function rules_controller::save_filters is not documented
(#138) Function rules_controller::get_page_html_head_title is not documented
(#142) Function rules_controller::get_page_heading is not documented
(#212) Function rules_controller::page_content is not documented
(#232) Function rules_controller::page_plus_promo_content is not documented
(#243) Function rules_controller::page_rules_content is not documented
(#248) Function rules_controller::page_danger_zone_content is not documented
(#42) Phpdocs for variable rules_controller::$navname does not contain @var or incorrect
(#42) Invalid phpdocs tag @inheritDoc used
blocks/xp/classes/local/controller/visuals_controller.php
(#96) Function visuals_controller::pre_content is not documented
(#151) Function visuals_controller::get_page_html_head_title is not documented
(#155) Function visuals_controller::get_page_heading is not documented
(#168) Function visuals_controller::page_content is not documented
(#47) Phpdocs for variable visuals_controller::$navname does not contain @var or incorrect
(#47) Invalid phpdocs tag @inheritDoc used
blocks/xp/classes/local/course_world.php
(#95) Function course_world::get_access_permissions is not documented
(#99) Function course_world::get_config is not documented
(#103) Function course_world::get_collection_strategy is not documented
(#166) Function course_world::get_levels_info is not documented
(#221) Function course_world::get_store is not documented
(#74) Phpdocs for function course_world::__construct has incomplete parameters list
blocks/xp/classes/local/factory/default_course_world_factory.php
(#61) Phpdocs for function default_course_world_factory::__construct has incomplete parameters list
blocks/xp/classes/local/factory/default_course_world_leaderboard_factory.php
(#106) Phpdocs for function default_course_world_leaderboard_factory::get_course_leaderboard_with_config has incomplete parameters list
(#109) Invalid phpdocs tag @inheritDoc used
blocks/xp/classes/local/factory/default_course_world_navigation_factory.php
(#55) Phpdocs for function default_course_world_navigation_factory::__construct has incomplete parameters list
blocks/xp/classes/local/indicator/prefs_user_indicator.php
(#124) Phpdocs for function prefs_user_indicator::user_has_flag has incomplete parameters list
blocks/xp/classes/local/indicator/proxy_user_indicator.php
(#99) Phpdocs for function proxy_user_indicator::user_has_flag has incomplete parameters list
blocks/xp/classes/local/indicator/user_indicator.php
(#76) Phpdocs for function user_indicator::user_has_flag has incomplete parameters list
blocks/xp/classes/local/leaderboard/anonymisable_leaderboard.php
(#63) Phpdocs for function anonymisable_leaderboard::anonymise_rank has incomplete parameters list
blocks/xp/classes/local/leaderboard/anonymised_leaderboard.php
(#85) Phpdocs for function anonymised_leaderboard::anonymise_rank has incomplete parameters list
blocks/xp/classes/local/leaderboard/empty_leaderboard.php
(#46) Phpdocs for function empty_leaderboard::__construct has incomplete parameters list
blocks/xp/classes/local/leaderboard/neighboured_leaderboard.php
(#52) Phpdocs for function neighboured_leaderboard::__construct has incomplete parameters list
blocks/xp/classes/local/observer/default_observer_rules_maker.php
(#38) Function default_observer_rules_maker::get_observer_rules is not documented
blocks/xp/classes/local/observer/default_state_store_observer.php
(#54) Phpdocs for function default_state_store_observer::__construct has incomplete parameters list
blocks/xp/classes/local/plugin/usage_report_maker.php
(#150) Phpdocs for function usage_report_maker::get_rules_usage has incomplete parameters list
blocks/xp/classes/local/serializer/level_serializer.php
(#47) Phpdocs for function level_serializer::__construct has incomplete parameters list
blocks/xp/classes/local/serializer/levels_info_serializer.php
(#46) Phpdocs for function levels_info_serializer::__construct has incomplete parameters list
blocks/xp/classes/local/serializer/url_serializer.php
(#43) Function url_serializer::__construct is not documented
blocks/xp/classes/local/setting/default_settings_maker.php
(#64) Phpdocs for function default_settings_maker::__construct has incomplete parameters list
blocks/xp/classes/local/task/default_tasks_definition_maker.php
(#38) Function default_tasks_definition_maker::get_tasks_definition is not documented
blocks/xp/classes/local/utils/external_utils.php
(#45) Phpdocs for function external_utils::format_string has incomplete parameters list
blocks/xp/classes/local/xp/algo_levels_info.php
(#179) Function algo_levels_info::load is not documented
(#205) Phpdocs for function algo_levels_info::make_from_defaults has incomplete parameters list
blocks/xp/classes/local/xp/anonymised_user_state.php
(#58) Function anonymised_user_state::get_id is not documented
(#62) Function anonymised_user_state::get_link is not documented
(#66) Function anonymised_user_state::get_name is not documented
(#70) Function anonymised_user_state::get_picture is not documented
(#74) Function anonymised_user_state::get_level is not documented
(#78) Function anonymised_user_state::get_ratio_in_level is not documented
(#82) Function anonymised_user_state::get_total_xp_in_level is not documented
(#86) Function anonymised_user_state::get_user is not documented
(#90) Function anonymised_user_state::get_xp is not documented
(#94) Function anonymised_user_state::get_xp_in_level is not documented
(#49) Phpdocs for function anonymised_user_state::__construct has incomplete parameters list
blocks/xp/classes/local/xp/course_filter_manager.php
(#211) Phpdocs for function course_filter_manager::invalidate_filters_cache has incomplete parameters list
blocks/xp/classes/local/xp/course_user_state_store.php
(#72) Phpdocs for function course_user_state_store::__construct has incomplete parameters list
blocks/xp/classes/local/xp/full_anonymiser.php
(#64) Phpdocs for function full_anonymiser::anonymise_state has incomplete parameters list
blocks/xp/classes/local/xp/state_anonymiser.php
(#38) Phpdocs for function state_anonymiser::anonymise_state has incomplete parameters list
blocks/xp/classes/local/xp/user_state.php
(#71) Function user_state::get_id is not documented
(#75) Function user_state::get_level is not documented
(#82) Function user_state::get_link is not documented
(#91) Function user_state::get_name is not documented
(#95) Function user_state::get_picture is not documented
(#99) Function user_state::get_ratio_in_level is not documented
(#107) Function user_state::get_total_xp_in_level is not documented
(#126) Function user_state::get_xp is not documented
(#130) Function user_state::get_xp_in_level is not documented
blocks/xp/classes/output/filters_widget.php
(#57) Phpdocs for function filters_widget::__construct has incomplete parameters list
blocks/xp/classes/output/notice.php
(#42) Invalid phpdocs tag @const used
(#44) Invalid phpdocs tag @const used
(#46) Invalid phpdocs tag @const used
(#48) Invalid phpdocs tag @const used
blocks/xp/classes/rule.php
(#93) Inline phpdocs tag {@link self::import()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
(#107) Inline phpdocs tag {@link self::create()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/xp/classes/tests/base_testcase.php
(#36) Function base_testcase::setUp is not documented
(#41) Function base_testcase::get_world is not documented
(#45) Function base_testcase::reset_container is not documented
blocks/xp/lang/en/block_xp.php
(#23) Invalid phpdocs tag @codingStandardsIgnoreFile used
blocks/xp/renderer.php
(#108) Phpdocs for function block_xp_renderer::get_user_picture has incomplete parameters list
(#150) Phpdocs for function block_xp_renderer::level_badge_with_options has incomplete parameters list
(#742) Phpdocs for function block_xp_renderer::render_filters_widget has incomplete parameters list
(#797) Phpdocs for function block_xp_renderer::render_filters_widget_element has incomplete parameters list
(#814) Phpdocs for function block_xp_renderer::render_filters_widget_group has incomplete parameters list
(#865) Phpdocs for function block_xp_renderer::get_progress_bar_context has incomplete parameters list
(#899) Phpdocs for function block_xp_renderer::progress_bar has incomplete parameters list
(#967) Phpdocs for function block_xp_renderer::render_xp_widget has incomplete parameters list
(#992) Phpdocs for function block_xp_renderer::sub_navigation has incomplete parameters list
(#43) Invalid phpdocs tag @const used
blocks/xp/tests/filters_test.php
(#48) Function filters_test::get_filter_manager is not documented
blocks/xp/tests/fixtures/events.php
(#20) Package core is not valid
(#27) Class something_happened is not documented
(#28) Function something_happened::init is not documented
(#31) Function something_happened::mock is not documented
blocks/xp/tests/leaderboard_factory_test.php
(#335) Function leaderboard_factory_test::assert_ranking is not documented
blocks/xp/tests/leaderboard_test.php
(#48) Function leaderboard_test::get_leaderboard is not documented
(#820) Function leaderboard_test::assert_ranking is not documented
blocks/xp/tests/privacy_provider_test.php
(#65) Function privacy_provider_test::get_world is not documented
(#458) Function privacy_provider_test::assert_contextlist_equals is not documented
(#465) Function privacy_provider_test::assert_userlist_equals is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]