Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(27 errors, 7 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/xp/classes/filter.php
(#96) Closing brace must be on a line by itself
blocks/xp/classes/helper.php
(#74) Empty IF statement detected
(#76) Empty IF statement detected
(#78) Empty IF statement detected
(#80) Empty IF statement detected
(#82) Empty IF statement detected
(#84) Empty IF statement detected
blocks/xp/classes/ladder_table.php
(#190) Visibility must be declared on method "build_table"
(#221) Line indented incorrectly; expected at least 20 spaces, found 16
(#343) Line indented incorrectly; expected at least 12 spaces, found 8
(#407) Visibility must be declared on method "query_db"
(#418) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
blocks/xp/classes/levels_form.php
(#87) Line exceeds 132 characters; contains 134 characters
blocks/xp/classes/manager.php
(#462) Must use "self::" for local static member reference
(#463) Must use "self::" for local static member reference
(#599) Empty CATCH statement detected
(#738) Usage of ELSEIF not allowed; use ELSE IF instead
blocks/xp/classes/report_table.php
(#92) Expected 1 space after "="; 0 found
(#95) Expected 1 space after "="; 0 found
blocks/xp/classes/rule.php
(#62) Visibility must be declared on method "get_description"
(#73) Line exceeds 132 characters; contains 137 characters
(#131) Must use "self::" for local static member reference
blocks/xp/classes/rule_base.php
(#106) Must use "self::" for local static member reference
(#106) Must use "self::" for local static member reference
(#107) Must use "self::" for local static member reference
(#107) Must use "self::" for local static member reference
blocks/xp/classes/rule_event.php
(#179) Line exceeds 132 characters; contains 139 characters
blocks/xp/db/upgrade.php
(#159) Line exceeds 132 characters; contains 139 characters
(#174) Line exceeds 132 characters; contains 140 characters
(#189) Line exceeds 132 characters; contains 134 characters
(#204) Line exceeds 132 characters; contains 140 characters
blocks/xp/infos.php
(#66) Space found before second semicolon of FOR loop
(#66) Space found before semicolon; expected "$levels;" but found "$levels ;"
blocks/xp/rules.php
(#143) Expected 1 space before ".="; 0 found

Javascript coding style problems

(32 errors, 21 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/xp/yui/src/filters/js/constants.js
(#30) 'COMPONENT' is defined but never used. (no-unused-vars)
(#31) 'CSS' is defined but never used. (no-unused-vars)
(#39) 'SELECTORS' is defined but never used. (no-unused-vars)
blocks/xp/yui/src/filters/js/dnd.js
(#49) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#95) Identifier 'global_drop_over' is not in camel case. (camelcase)
(#121) Identifier 'drag_end' is not in camel case. (camelcase)
(#130) Identifier 'drop_hit' is not in camel case. (camelcase)
(#139) Identifier 'drop_over' is not in camel case. (camelcase)
(#143) Unexpected @return tag; function has no return statement. (valid-jsdoc)
blocks/xp/yui/src/filters/js/filters.js
(#84) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#90) 'SELECTORS' is not defined. (no-undef)
(#91) 'SELECTORS' is not defined. (no-undef)
(#92) 'SELECTORS' is not defined. (no-undef)
(#93) 'SELECTORS' is not defined. (no-undef)
(#94) 'SELECTORS' is not defined. (no-undef)
(#95) 'SELECTORS' is not defined. (no-undef)
(#101) 'SELECTORS' is not defined. (no-undef)
(#103) 'SELECTORS' is not defined. (no-undef)
(#105) 'SELECTORS' is not defined. (no-undef)
(#117) 'SELECTORS' is not defined. (no-undef)
(#122) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#142) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#155) 'SELECTORS' is not defined. (no-undef)
(#159) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#168) 'SELECTORS' is not defined. (no-undef)
(#179) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#188) 'SELECTORS' is not defined. (no-undef)
(#189) 'SELECTORS' is not defined. (no-undef)
(#201) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#207) 'SELECTORS' is not defined. (no-undef)
(#216) Infix operators must be spaced. (space-infix-ops)
(#229) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#235) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#240) Closing curly brace does not appear on the same line as the subsequent block. (brace-style)
(#249) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#255) 'SELECTORS' is not defined. (no-undef)
(#299) 'SELECTORS' is not defined. (no-undef)
(#332) 'SELECTORS' is not defined. (no-undef)
(#345) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#355) 'SELECTORS' is not defined. (no-undef)
(#359) 'SELECTORS' is not defined. (no-undef)
(#361) 'SELECTORS' is not defined. (no-undef)
(#364) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#383) Unexpected @return tag; function has no return statement. (valid-jsdoc)
(#383) Missing JSDoc for parameter 'filterNode'. (valid-jsdoc)
(#390) 'SELECTORS' is not defined. (no-undef)
(#391) 'SELECTORS' is not defined. (no-undef)
(#393) 'SELECTORS' is not defined. (no-undef)
(#395) 'SELECTORS' is not defined. (no-undef)
(#397) 'SELECTORS' is not defined. (no-undef)
(#403) 'SELECTORS' is not defined. (no-undef)
(#404) 'SELECTORS' is not defined. (no-undef)
(#405) 'SELECTORS' is not defined. (no-undef)

CSS problems

(4 errors, 1 warnings)

This section shows CSS problems detected by stylelint [More info]

blocks/xp/styles.css
(#86) Expected single space before "{" (block-opening-brace-space-before)
(#87) Expected "#D9EDF7" to be "#d9edf7" (color-hex-case)
(#87) Unexpected !important (declaration-no-important)
(#112) Unexpected !important (declaration-no-important)
(#144) Expected newline after "," (selector-list-comma-newline-after)

PHPDocs style problems

(36 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/xp/backup/moodle2/backup_xp_block_task.class.php
(#67) Phpdocs for function backup_xp_block_task::encode_content_links has incomplete parameters list
blocks/xp/backup/moodle2/restore_xp_stepslib.php
(#74) Phpdocs for function restore_xp_block_structure_step::process_block has incomplete parameters list
(#81) Phpdocs for function restore_xp_block_structure_step::process_config has incomplete parameters list
(#94) Phpdocs for function restore_xp_block_structure_step::process_filter has incomplete parameters list
(#103) Phpdocs for function restore_xp_block_structure_step::process_log has incomplete parameters list
(#113) Phpdocs for function restore_xp_block_structure_step::process_xp has incomplete parameters list
blocks/xp/classes/filter.php
(#301) Phpdocs for function block_xp_filter::validate_ruledata has incomplete parameters list
blocks/xp/classes/ladder_table.php
(#88) Phpdocs for function block_xp_ladder_table::__construct has incomplete parameters list
blocks/xp/classes/manager.php
(#129) Phpdocs for function block_xp_manager::can_capture_event has incomplete parameters list
(#640) Phpdocs for function block_xp_manager::recalculate_levels has incomplete parameters list
blocks/xp/classes/progress.php
(#27) Class block_xp_progress is not documented
blocks/xp/classes/rule.php
(#90) Phpdocs for function block_xp_rule::import has incomplete parameters list
(#20) Package core is not valid
(#30) Package core is not valid
blocks/xp/classes/rule_base.php
(#151) Phpdocs for function block_xp_rule_base::match_contains has incomplete parameters list
(#162) Phpdocs for function block_xp_rule_base::match_eq has incomplete parameters list
(#173) Phpdocs for function block_xp_rule_base::match_eqs has incomplete parameters list
(#184) Phpdocs for function block_xp_rule_base::match_gt has incomplete parameters list
(#195) Phpdocs for function block_xp_rule_base::match_gte has incomplete parameters list
(#206) Phpdocs for function block_xp_rule_base::match_lt has incomplete parameters list
(#217) Phpdocs for function block_xp_rule_base::match_lte has incomplete parameters list
(#228) Phpdocs for function block_xp_rule_base::match_regex has incomplete parameters list
blocks/xp/classes/rule_cm.php
(#54) Phpdocs for function block_xp_rule_cm::__construct has incomplete parameters list
blocks/xp/classes/rule_event.php
(#38) Phpdocs for function block_xp_rule_event::__construct has incomplete parameters list
blocks/xp/classes/rule_property.php
(#52) Phpdocs for function block_xp_rule_property::__construct has incomplete parameters list
blocks/xp/classes/ruleset.php
(#70) Phpdocs for function block_xp_ruleset::__construct has incomplete parameters list
blocks/xp/classes/visuals_form.php
(#37) Function block_xp_visuals_form::definition is not documented
(#52) Function block_xp_visuals_form::validation is not documented
blocks/xp/renderer.php
(#203) Phpdocs for function block_xp_renderer::render has incomplete parameters list
(#217) Phpdocs for function block_xp_renderer::render_block_xp_filter has incomplete parameters list
(#270) Phpdocs for function block_xp_renderer::render_block_xp_rule has incomplete parameters list
(#296) Phpdocs for function block_xp_renderer::render_block_xp_ruleset has incomplete parameters list
blocks/xp/tests/fixtures/events.php
(#28) Class something_happened is not documented
(#29) Function something_happened::init is not documented
(#32) Function something_happened::mock is not documented
(#20) Package core is not valid

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Task "stylelint:css" failed. Use --force to continue.
Problems running grunt

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]