Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(23 errors, 4 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/weather/block_weather.php
(#81) Visibility must be declared on method "has_config"
blocks/weather/classes/output/renderer.php
(#35) Opening brace should be on the same line as the declaration
(#36) global $PAGE cannot be used in renderers. Use $this->page.
(#37) global $PAGE cannot be used in renderers. Use $this->page.
(#48) Variable "weatherKey" must be all lower-case
(#49) Variable "enabledOption" must be all lower-case
(#51) Variable "enabledOption" must be all lower-case
(#52) Variable "weatherKey" must be all lower-case
(#54) Variable "enabledOption" must be all lower-case
(#55) Variable "weatherKey" must be all lower-case
(#57) Variable "enabledOption" must be all lower-case
(#58) Variable "weatherKey" must be all lower-case
(#61) Variable "enabledOption" must be all lower-case
(#61) Variable "weatherKey" must be all lower-case
blocks/weather/classes/privacy/provider.php
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
blocks/weather/lang/en/block_weather.php
(#34) Inline comments must start with a capital letter, digit or 3-dots sequence
(#34) Inline comments must end in full-stops, exclamation marks, or question marks
(#34) No space found before comment text; expected "// settings" but found "//settings"
(#50) Inline comments must start with a capital letter, digit or 3-dots sequence
(#50) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) No space found before comment text; expected "// climacell" but found "//climacell"
blocks/weather/settings.php
(#29) Variable "openWeather" must be all lower-case
(#30) Variable "accuWeather" must be all lower-case
(#32) Variable "weatherDropdown" must be all lower-case
(#32) Variable "openWeather" must be all lower-case
(#32) Variable "accuWeather" must be all lower-case
(#37) Variable "weatherDropdown" must be all lower-case

Javascript coding style problems

(11 errors, 25 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/weather/amd/src/block_weather.js
(#68) 'temp' used outside of binding context. (block-scoped-var)
(#69) 'tempData' used outside of binding context. (block-scoped-var)
(#71) 'temp' used outside of binding context. (block-scoped-var)
(#71) 'tempData' used outside of binding context. (block-scoped-var)
(#74) 'temp' is already defined. (no-redeclare)
(#74) 'temp' used outside of binding context. (block-scoped-var)
(#75) 'tempData' is already defined. (no-redeclare)
(#75) 'tempData' used outside of binding context. (block-scoped-var)
(#77) 'temp' used outside of binding context. (block-scoped-var)
(#77) 'tempData' used outside of binding context. (block-scoped-var)
(#92) Missing JSDoc comment. (require-jsdoc)
(#109) Missing JSDoc comment. (require-jsdoc)
(#121) Avoid using promises inside of callbacks. (promise/no-promise-in-callback)
(#121) Avoid using promises inside of callbacks. (promise/no-promise-in-callback)
(#121) Each then() should return a value or throw (promise/always-return)
(#121) 'js' is defined but never used. (no-unused-vars)
(#133) Each then() should return a value or throw (promise/always-return)
(#141) Each then() should return a value or throw (promise/always-return)
(#141) 'js' is defined but never used. (no-unused-vars)
(#149) 'error' is defined but never used. (no-unused-vars)
(#155) This line has a length of 205. Maximum allowed is 132. (max-len)
(#161) Each then() should return a value or throw (promise/always-return)
(#162) This line has a length of 159. Maximum allowed is 132. (max-len)
(#163) Expected catch,fail() or return (promise/catch-or-return)
(#168) Each then() should return a value or throw (promise/always-return)
(#176) Each then() should return a value or throw (promise/always-return)
(#176) 'js' is defined but never used. (no-unused-vars)
(#189) 'error' is defined but never used. (no-unused-vars)
(#196) This line has a length of 169. Maximum allowed is 132. (max-len)
(#202) Each then() should return a value or throw (promise/always-return)
(#216) This line has a length of 166. Maximum allowed is 132. (max-len)
(#217) Expected catch,fail() or return (promise/catch-or-return)
(#223) Each then() should return a value or throw (promise/always-return)
(#233) Each then() should return a value or throw (promise/always-return)
(#233) 'js' is defined but never used. (no-unused-vars)
(#239) 'error' is defined but never used. (no-unused-vars)

CSS problems

(36 errors, 2 warnings)

This section shows CSS problems detected by stylelint [More info]

blocks/weather/assets/css/block_weather.css
(#4) Expected "#FFF" to be "#fff" (color-hex-case)
(#3) Expected indentation of 4 spaces (indentation)
(#4) Expected indentation of 4 spaces (indentation)
(#5) Expected indentation of 4 spaces (indentation)
(#6) Expected indentation of 4 spaces (indentation)
(#10) Expected indentation of 4 spaces (indentation)
(#14) Expected indentation of 4 spaces (indentation)
(#18) Expected indentation of 4 spaces (indentation)
(#19) Expected indentation of 4 spaces (indentation)
(#20) Expected indentation of 4 spaces (indentation)
(#21) Expected indentation of 4 spaces (indentation)
(#22) Expected indentation of 4 spaces (indentation)
(#26) Expected indentation of 4 spaces (indentation)
(#27) Expected indentation of 4 spaces (indentation)
(#31) Expected indentation of 4 spaces (indentation)
(#32) Expected indentation of 4 spaces (indentation)
(#36) Expected indentation of 4 spaces (indentation)
(#37) Expected indentation of 4 spaces (indentation)
(#41) Expected indentation of 4 spaces (indentation)
(#42) Expected indentation of 4 spaces (indentation)
(#43) Expected indentation of 4 spaces (indentation)
(#44) Expected indentation of 4 spaces (indentation)
(#45) Expected indentation of 4 spaces (indentation)
(#46) Expected indentation of 4 spaces (indentation)
(#50) Expected indentation of 4 spaces (indentation)
(#51) Expected indentation of 4 spaces (indentation)
(#55) Expected indentation of 4 spaces (indentation)
(#56) Expected indentation of 4 spaces (indentation)
(#57) Expected indentation of 4 spaces (indentation)
(#58) Expected indentation of 4 spaces (indentation)
(#59) Expected indentation of 4 spaces (indentation)
(#63) Expected indentation of 4 spaces (indentation)
(#64) Expected indentation of 4 spaces (indentation)
(#65) Expected indentation of 4 spaces (indentation)
(#66) Expected indentation of 4 spaces (indentation)
(#67) Expected indentation of 4 spaces (indentation)
(#71) Expected indentation of 4 spaces (indentation)
blocks/weather/assets/css/block_weather.scss
(#5) Expected "#FFF" to be "#fff" (color-hex-case)

PHPDocs style problems

(4 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/weather/block_weather.php
(#24) Class block_weather is not documented
blocks/weather/classes/output/renderer.php
(#28) Class renderer is not documented
(#40) Function renderer::render_weather is not documented
(#45) Function renderer::render_weather_info is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 3 warnings)

This section shows problems detected in mustache templates [More info]

blocks/weather/templates/weather.mustache
(#1) Example context missing.
blocks/weather/templates/weather_info.mustache
(#1) Example context missing.
(#1) HTML Validation error, line 7: Bad value “” for attribute “src” on element “img”: Must be non-empty. (con"> <img src="" alt=""></div)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]