Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(11 errors, 29 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/todo/block_todo.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#88) There should be a comma after the last array item in a multi-line array.
blocks/todo/classes/external/item_exporter.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#30) Import statements must not begin with a leading backslash
(#31) Import statements must not begin with a leading backslash
blocks/todo/classes/external/list_exporter.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#142) Expected "if (...) {\n"; found "if(...){\n"
(#228) Space found before semicolon; expected ");" but found ") ;"
blocks/todo/classes/item.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#30) Import statements must not begin with a leading backslash
blocks/todo/classes/privacy/provider.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#55) Method name "_get_metadata" should not be prefixed with an underscore to indicate visibility
(#74) Method name "_get_contexts_for_userid" should not be prefixed with an underscore to indicate visibility
(#85) There should be a comma after the last array item in a multi-line array.
(#98) Method name "_export_user_data" should not be prefixed with an underscore to indicate visibility
(#133) Method name "_delete_data_for_all_users_in_context" should not be prefixed with an underscore to indicate visibility
(#146) Method name "_delete_data_for_user" should not be prefixed with an underscore to indicate visibility
blocks/todo/db/upgrade.php
(#38) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/todo/lang/en/block_todo.php
(#37) The string key "overdue" is not in the correct order, it should be before "pluginname"
(#43) The string key "privacy:metadata:db:blocktodo" is not in the correct order, it should be before "unpin"
(#48) The string key "privacy:metadata:db:blocktodo:duedate" is not in the correct order, it should be before "privacy:metadata:db:blocktodo:todotext"
blocks/todo/tests/external_test.php
(#36) Testcase block_todo_external_testcase should be declared as abstract.
(#36) PHPUnit testcase name "block_todo_external_testcase" does not match file name "external_test"
(#36) PHPUnit class "block_todo_external_testcase" does not have any namespace. It is recommended to add it to the "block_todo" namespace, using more levels if needed, in order to match the code being tested
(#47) The setUp() method in unit tests must always call to parent::setUp().
(#60) Invalid docblock tag "@expectedException".
(#62) Test method test_add_item_no_permission() is missing any coverage information, own or at class level
(#62) Test method test_add_item_no_permission() is missing a return type
(#76) Test method test_add_item() is missing any coverage information, own or at class level
(#76) Test method test_add_item() is missing a return type
(#96) Test method test_toggle_item() is missing any coverage information, own or at class level
(#96) Test method test_toggle_item() is missing a return type
(#115) Invalid docblock tag "@expectedException".
(#117) Test method test_toggle_item_by_another_user() is missing any coverage information, own or at class level
(#117) Test method test_toggle_item_by_another_user() is missing a return type
(#130) Test method test_delete_item() is missing any coverage information, own or at class level
(#130) Test method test_delete_item() is missing a return type
(#147) Invalid docblock tag "@expectedException".
(#149) Test method test_delete_item_by_another_user() is missing any coverage information, own or at class level
(#149) Test method test_delete_item_by_another_user() is missing a return type

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(15 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/todo/classes/external/add_item.php
(#18) Inline phpdocs tag {@link block_todo\external\add_item} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/todo/classes/external/api.php
(#18) Inline phpdocs tag {@link block_todo\external\api} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/todo/classes/external/delete_item.php
(#60) Phpdocs for function delete_item::delete_item has incomplete parameters list
(#18) Inline phpdocs tag {@link block_todo\external\delete_item} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/todo/classes/external/edit_item.php
(#18) Inline phpdocs tag {@link block_todo\external\edit_item} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/todo/classes/external/hide_done_items.php
(#18) Inline phpdocs tag {@link block_todo\external\hide_done_items} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/todo/classes/external/item_exporter.php
(#18) Inline phpdocs tag {@link block_todo\external\item_exporter} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/todo/classes/external/list_exporter.php
(#175) Phpdocs for function list_exporter::format_due_date_data has incomplete parameters list
(#18) Inline phpdocs tag {@link block_todo\external\list_exporter} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/todo/classes/external/pin_item.php
(#18) Inline phpdocs tag {@link block_todo\external\pin_item} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/todo/classes/external/toggle_item.php
(#61) Phpdocs for function toggle_item::toggle_item has incomplete parameters list
(#18) Inline phpdocs tag {@link block_todo\external\toggle_item} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/todo/classes/item.php
(#18) Inline phpdocs tag {@link block_todo\item} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/todo/classes/privacy/provider.php
(#18) Inline phpdocs tag {@link \block_todo\privacy\provider} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/todo/tests/external_test.php
(#18) Inline phpdocs tag {@link block_todo_external_testcase} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 7 warnings)

This section shows problems detected in mustache templates [More info]

blocks/todo/templates/add.mustache
(#1) Example context missing.
blocks/todo/templates/edit.mustache
(#1) Example context missing.
blocks/todo/templates/item.mustache
(#1) Example context missing.
(#1) HTML Validation error, line 2: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (> <li class="list-group-item d-flex " data-item="" data-done="" data-text="" data-duedate=""> )
blocks/todo/templates/list.mustache
(#1) Example context missing.
blocks/todo/templates/pin.mustache
(#1) Example context missing.
(#1) HTML Validation error, line 3: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (d><body><li class="list-group-item d-flex border-warning" style="background-color:#fff3e1" data-item="" data-done="" data-text="" data-duedate=""> <)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]