PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(22 errors, 55 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- blocks/stash/backup/moodle2/backup_stash_stepslib.php
- (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#55) Line exceeds 132 characters; contains 139 characters
- blocks/stash/backup/moodle2/restore_stash_stepslib.php
- (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/block_stash.php
- (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/drop.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/drop_pickup.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/drop_snippet_restore_decode_rule.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/event/item_acquired.php
- (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/external/drop_exporter.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/external/item_exporter.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/external/items_exporter.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/external/persistent_exporter.php
- (#51) The final declaration must precede the visibility declaration
- (#72) The final declaration must precede the visibility declaration
- blocks/stash/classes/external/trade_exporter.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/external/trade_items_exporter.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#87) Expected 1 space after "!=="; 2 found
- blocks/stash/classes/external/trade_summary_exporter.php
- (#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/external/user_item_exporter.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/external/user_item_summary_exporter.php
- (#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/form/integer.php
- (#63) Inline comments must end in full-stops, exclamation marks, or question marks
- (#79) Method name "_createElements" should not be prefixed with an underscore to indicate visibility
- (#79) Visibility must be declared on method "_createElements"
- (#79) method name "block_stash_form_integer::_createElements" must be in lower-case letters only
- (#111) Visibility must be declared on method "exportValue"
- (#111) method name "block_stash_form_integer::exportValue" must be in lower-case letters only
- (#111) Variable "submitValues" must be all lower-case
- (#113) Variable "submitValues" must be all lower-case
- (#117) Variable "submitValues" must be all lower-case
- (#128) Visibility must be declared on method "onQuickFormEvent"
- (#128) method name "block_stash_form_integer::onQuickFormEvent" must be in lower-case letters only
- blocks/stash/classes/form/item.php
- (#61) Line exceeds 132 characters; contains 149 characters
- blocks/stash/classes/form/persistent.php
- (#245) The final declaration must precede the visibility declaration
- blocks/stash/classes/helper.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/item.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/manager.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#673) Functions must not contain multiple empty lines in a row; found 2 empty lines
- blocks/stash/classes/output/block_content.php
- (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#51) Functions must not contain multiple empty lines in a row; found 2 empty lines
- blocks/stash/classes/output/drop.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/output/drop_image.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/output/drop_text.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/output/fulltrade.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/output/item.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/output/renderer.php
- (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/output/trade.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#92) File must end with a newline character
- blocks/stash/classes/page_helper.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#213) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#213) This comment is 75% valid code; is this commented out code?
- blocks/stash/classes/persistent.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/privacy/provider.php
- (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#61) Method name "_get_metadata" should not be prefixed with an underscore to indicate visibility
- (#89) Method name "_get_contexts_for_userid" should not be prefixed with an underscore to indicate visibility
- (#133) Method name "_export_user_data" should not be prefixed with an underscore to indicate visibility
- (#212) Method name "_delete_data_for_all_users_in_context" should not be prefixed with an underscore to indicate visibility
- (#244) Method name "_delete_data_for_user" should not be prefixed with an underscore to indicate visibility
- blocks/stash/classes/shortcodes.php
- (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/stash.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/trade.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/tradeitems.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/classes/user_item.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#133) Expected "foreach (...) {\n"; found "foreach(...) {\n"
- blocks/stash/db/upgrade.php
- (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#200) Line indented incorrectly; expected 4 spaces, found 5
- (#226) Closing brace indented incorrectly; expected 5 spaces, found 4
- (#392) Commas (,) must be followed by white space.
- blocks/stash/edit_form.php
- (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/item_reset.php
- (#98) File must end with a newline character
- blocks/stash/lib.php
- (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#99) File must end with a newline character
- blocks/stash/tests/generator/lib.php
- (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- blocks/stash/tests/privacy_test.php
- (#47) PHPUnit testcase name "block_stash_privacy_testcase" does not match file name "privacy_test"
- (#47) PHPUnit class "block_stash_privacy_testcase" does not have any namespace. It is recommended to add it to the "block_stash" namespace, using more levels if needed, in order to match the code being tested
- (#59) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level
- (#91) Test method test_delete_data_for_user() is missing any coverage information, own or at class level
- (#139) Test method test_delete_data_for_all_users_in_context() is missing any coverage information, own or at class level
- (#187) Test method test_export_data_for_user() is missing any coverage information, own or at class level
Javascript coding style problems
(28 errors, 37 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
- blocks/stash/amd/src/base.js
- (#21) @package should be empty. (jsdoc/empty-tags)
- blocks/stash/amd/src/counselor.js
- (#21) @package should be empty. (jsdoc/empty-tags)
- blocks/stash/amd/src/dialogue-base.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- (#39) Expected catch,fail() or return (promise/catch-or-return)
- (#39) Each then() should return a value or throw (promise/always-return)
- (#89) Expected catch,fail() or return (promise/catch-or-return)
- (#135) Expected catch,fail() or return (promise/catch-or-return)
- blocks/stash/amd/src/drop-snippet-dialogue.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- blocks/stash/amd/src/drop-snippet-maker.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- blocks/stash/amd/src/drop-snippet-shortcode-maker.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- blocks/stash/amd/src/drop-snippet-ui.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- (#54) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#93) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#118) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- (#123) Statement inside of curly braces should be on next line. (brace-style)
- (#123) This line has 3 statements. Maximum allowed is 2. (max-statements-per-line)
- (#123) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
- (#132) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- blocks/stash/amd/src/drop.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- blocks/stash/amd/src/item-dialogue.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- (#53) Expected catch,fail() or return (promise/catch-or-return)
- blocks/stash/amd/src/item-selector-dialogue.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- (#71) Each then() should return a value or throw (promise/always-return)
- (#79) Expected catch,fail() or return (promise/catch-or-return)
- (#79) Each then() should return a value or throw (promise/always-return)
- blocks/stash/amd/src/item.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- blocks/stash/amd/src/stash-area.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- (#65) Multiple spaces found before '// A hacky sep...'. (no-multi-spaces)
- (#92) Expected catch,fail() or return (promise/catch-or-return)
- blocks/stash/amd/src/trade-area.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- (#135) Unexpected @return tag; function has no return statement. (valid-jsdoc)
- blocks/stash/amd/src/trade-dialogue.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- (#32) @param "itemId" does not match an existing function parameter. (jsdoc/check-param-names)
- blocks/stash/amd/src/trade-item-dialogue.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- (#30) Missing JSDoc @param "courseid" declaration. (jsdoc/require-param)
- (#30) Missing JSDoc @param "type" declaration. (jsdoc/require-param)
- (#30) Missing JSDoc @param "title" declaration. (jsdoc/require-param)
- (#30) Missing JSDoc for parameter 'type'. (valid-jsdoc)
- (#30) Missing JSDoc for parameter 'title'. (valid-jsdoc)
- (#33) Expected @param names to be "courseid, type, title". Got "itemId". (jsdoc/check-param-names)
- (#33) Expected JSDoc for 'courseid' but found 'itemId'. (valid-jsdoc)
- (#62) Expected catch,fail() or return (promise/catch-or-return)
- blocks/stash/amd/src/trade-snippet-dialogue.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- (#72) Expected catch,fail() or return (promise/catch-or-return)
- blocks/stash/amd/src/trade-snippet-maker.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- blocks/stash/amd/src/trade-snippet-shortcode-maker.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- blocks/stash/amd/src/trade.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- (#35) Missing JSDoc @param "tradedata" declaration. (jsdoc/require-param)
- (#38) Expected @param names to be "tradedata". Got "dropdata". (jsdoc/check-param-names)
- (#38) Expected JSDoc for 'tradedata' but found 'dropdata'. (valid-jsdoc)
- (#63) 'index' used outside of binding context. (block-scoped-var)
- (#65) 'userItem' used outside of binding context. (block-scoped-var)
- (#65) 'index' used outside of binding context. (block-scoped-var)
- (#65) 'index' used outside of binding context. (block-scoped-var)
- (#69) 'userItem' used outside of binding context. (block-scoped-var)
- (#73) 'index' is already defined. (no-redeclare)
- (#73) 'index' used outside of binding context. (block-scoped-var)
- (#74) 'userItem' is already defined. (no-redeclare)
- (#74) 'userItem' used outside of binding context. (block-scoped-var)
- (#74) 'index' used outside of binding context. (block-scoped-var)
- (#74) 'index' used outside of binding context. (block-scoped-var)
- (#78) 'userItem' used outside of binding context. (block-scoped-var)
- blocks/stash/amd/src/user-item.js
- (#19) @package should be empty. (jsdoc/empty-tags)
- (#28) Missing JSDoc @param "item" declaration. (jsdoc/require-param)
- (#28) Missing JSDoc for parameter 'item'. (valid-jsdoc)
CSS problems
(2 errors, 0 warnings)
This section shows CSS problems detected by stylelint [More info]
- blocks/stash/styles.css
- (#4) Unexpected duplicate "display" (declaration-block-no-duplicate-properties)
- (#5) Unexpected duplicate "display" (declaration-block-no-duplicate-properties)
PHPDocs style problems
(143 errors, 0 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- blocks/stash/backup/moodle2/backup_stash_block_task.class.php
- (#67) Phpdocs for function backup_stash_block_task::encode_content_links has incomplete parameters list
- blocks/stash/backup/moodle2/restore_stash_stepslib.php
- (#85) Phpdocs for function restore_stash_block_structure_step::process_block has incomplete parameters list
- (#92) Phpdocs for function restore_stash_block_structure_step::process_block_stash has incomplete parameters list
- (#110) Phpdocs for function restore_stash_block_structure_step::process_block_stash_item has incomplete parameters list
- (#123) Phpdocs for function restore_stash_block_structure_step::process_block_stash_drop has incomplete parameters list
- (#142) Phpdocs for function restore_stash_block_structure_step::process_pickup has incomplete parameters list
- (#154) Phpdocs for function restore_stash_block_structure_step::process_useritem has incomplete parameters list
- (#166) Phpdocs for function restore_stash_block_structure_step::process_block_stash_trade has incomplete parameters list
- (#185) Phpdocs for function restore_stash_block_structure_step::process_block_stash_tradeitems has incomplete parameters list
- blocks/stash/block_stash.php
- (#78) Function block_stash::specialization is not documented
- blocks/stash/classes/drop.php
- (#48) Function drop::define_properties is not documented
- (#46) Constant drop::TABLE is not documented
- (#80) Inline phpdocs tag {@link drop_pickup::get_relation()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- blocks/stash/classes/drop_pickup.php
- (#41) Function drop_pickup::define_properties is not documented
- (#81) Function drop_pickup::detele_drop_for_user_item is not documented
- (#39) Constant drop_pickup::TABLE is not documented
- blocks/stash/classes/drop_snippet_restore_decode_rule.php
- (#40) Phpdocs for function drop_snippet_restore_decode_rule::__construct has incomplete parameters list
- blocks/stash/classes/external.php
- (#52) Package core_competency is not valid
- blocks/stash/classes/external/drop_exporter.php
- (#41) Function drop_exporter::define_class is not documented
- (#45) Function drop_exporter::define_related is not documented
- (#49) Function drop_exporter::define_other_properties is not documented
- (#63) Function drop_exporter::get_other_values is not documented
- blocks/stash/classes/external/exporter.php
- (#50) Class exporter is not documented
- (#208) Inline phpdocs tag {@link self::export()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#211) Inline phpdocs tag {@link self::define_other_properties()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#223) Inline phpdocs tag {@link self::define_other_properties()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#242) Inline phpdocs tag {@link self::read_properties_definition()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#264) Inline phpdocs tag {@link \core_competency\persistent::define_properties()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#286) Inline phpdocs tag {@link self::get_other_values()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#304) Inline phpdocs tag {@link \core_competency\persistent::define_properties()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- blocks/stash/classes/external/item_exporter.php
- (#40) Function item_exporter::define_class is not documented
- (#44) Function item_exporter::define_related is not documented
- (#48) Function item_exporter::define_other_properties is not documented
- (#59) Function item_exporter::update_values is not documented
- (#67) Function item_exporter::get_other_values is not documented
- blocks/stash/classes/external/items_exporter.php
- (#42) Function items_exporter::define_related is not documented
- (#48) Function items_exporter::define_properties is not documented
- (#57) Function items_exporter::get_other_values is not documented
- blocks/stash/classes/external/trade_exporter.php
- (#40) Function trade_exporter::define_class is not documented
- (#44) Function trade_exporter::define_related is not documented
- blocks/stash/classes/external/trade_items_exporter.php
- (#42) Function trade_items_exporter::define_class is not documented
- (#46) Function trade_items_exporter::define_related is not documented
- (#54) Function trade_items_exporter::define_other_properties is not documented
- (#77) Function trade_items_exporter::get_other_values is not documented
- blocks/stash/classes/external/trade_summary_exporter.php
- (#45) Function trade_summary_exporter::define_related is not documented
- (#53) Function trade_summary_exporter::define_properties is not documented
- (#66) Function trade_summary_exporter::get_other_values is not documented
- blocks/stash/classes/external/user_item_exporter.php
- (#40) Function user_item_exporter::define_class is not documented
- blocks/stash/classes/external/user_item_summary_exporter.php
- (#45) Function user_item_summary_exporter::define_related is not documented
- (#53) Function user_item_summary_exporter::define_properties is not documented
- (#64) Function user_item_summary_exporter::get_other_values is not documented
- blocks/stash/classes/form/drop.php
- (#49) Function drop::definition is not documented
- (#43) Variable drop::$persistentclass is not documented
- (#45) Variable drop::$fieldstoremove is not documented
- (#47) Variable drop::$foreignfields is not documented
- blocks/stash/classes/form/integer.php
- (#66) Phpdocs for function block_stash_form_integer::block_stash_form_integer has incomplete parameters list
- (#107) Phpdocs for function block_stash_form_integer::exportValue has incomplete parameters list
- blocks/stash/classes/form/item.php
- (#28) Package is not specified for class item. It is also not specified in file-level phpdocs
- (#28) Class item is not documented
- (#30) Variable item::$persistentclass is not documented
- (#32) Variable item::$fieldstoremove is not documented
- (#34) Variable item::$foreignfields is not documented
- blocks/stash/classes/form/persistent.php
- (#20) Package tool_lp is not valid
- (#127) Inline phpdocs tag {@link self::$fieldstoremove} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#128) Inline phpdocs tag {@link self::$foreignfields} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#239) Inline phpdocs tag {@link self::extra_validation()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- blocks/stash/classes/form/trade.php
- (#26) Package is not specified for class trade. It is also not specified in file-level phpdocs
- (#26) Class trade is not documented
- (#28) Variable trade::$persistentclass is not documented
- (#30) Variable trade::$fieldstoremove is not documented
- (#32) Variable trade::$foreignfields is not documented
- blocks/stash/classes/form/tradeitem.php
- (#26) Package is not specified for class tradeitem. It is also not specified in file-level phpdocs
- (#26) Class tradeitem is not documented
- (#28) Variable tradeitem::$persistentclass is not documented
- (#30) Variable tradeitem::$fieldstoremove is not documented
- blocks/stash/classes/item.php
- (#41) Function item::define_properties is not documented
- (#39) Constant item::TABLE is not documented
- blocks/stash/classes/manager.php
- (#1008) Function manager::get_trade_item is not documented
- (#1014) Function manager::get_trade_items is not documented
- (#1020) Function manager::get_full_trade_items_data is not documented
- (#1053) Function manager::do_trade is not documented
- (#1091) Function manager::user_has_item_to_trade is not documented
- (#431) Phpdocs for function manager::get_drop has incomplete parameters list
- blocks/stash/classes/output/block_content.php
- (#35) Class block_content is not documented
- (#41) Function block_content::__construct is not documented
- (#46) Function block_content::export_for_template is not documented
- (#37) Variable block_content::$manager is not documented
- (#39) Variable block_content::$userid is not documented
- blocks/stash/classes/output/drop.php
- (#59) Phpdocs for function drop::__construct has incomplete parameters list
- blocks/stash/classes/output/drop_image.php
- (#55) Phpdocs for function drop_image::__construct has incomplete parameters list
- blocks/stash/classes/output/drops_table.php
- (#59) Phpdocs for function drops_table::__construct has incomplete parameters list
- blocks/stash/classes/output/fulltrade.php
- (#50) Variable fulltrade::$tradeitems is not documented
- (#52) Variable fulltrade::$courseid is not documented
- (#54) Variable fulltrade::$stashid is not documented
- (#56) Variable fulltrade::$gainhelp is not documented
- (#58) Variable fulltrade::$losshelp is not documented
- (#60) Variable fulltrade::$titlehelp is not documented
- (#65) Phpdocs for function fulltrade::__construct has incomplete parameters list
- blocks/stash/classes/output/item.php
- (#54) Phpdocs for function item::__construct has incomplete parameters list
- blocks/stash/classes/output/items_table.php
- (#59) Phpdocs for function items_table::__construct has incomplete parameters list
- blocks/stash/classes/output/renderer.php
- (#179) Function renderer::render_block_content is not documented
- (#184) Function renderer::render_profile_content is not documented
- (#189) Function renderer::render_drop_image is not documented
- (#194) Function renderer::render_drop_text is not documented
- (#199) Function renderer::render_item_xsmall is not documented
- (#204) Function renderer::render_trade is not documented
- (#209) Function renderer::render_settings_page is not documented
- (#214) Function renderer::render_user_inventory is not documented
- (#219) Function renderer::render_trade_form is not documented
- (#51) Phpdocs for function renderer::drop_snippet_ui has incomplete parameters list
- blocks/stash/classes/output/report_table.php
- (#62) Phpdocs for function report_table::__construct has incomplete parameters list
- blocks/stash/classes/output/trade.php
- (#58) Phpdocs for function trade::__construct has incomplete parameters list
- blocks/stash/classes/output/trades_table.php
- (#58) Phpdocs for function trades_table::__construct has incomplete parameters list
- blocks/stash/classes/page_helper.php
- (#39) Function page_helper::setup_for_drop is not documented
- (#76) Function page_helper::setup_for_item is not documented
- (#106) Function page_helper::setup_for_trade is not documented
- (#136) Function page_helper::setup_for_trade_item is not documented
- (#166) Function page_helper::setup_for_report is not documented
- (#196) Function page_helper::setup_for_reset is not documented
- blocks/stash/classes/persistent.php
- (#64) Inline phpdocs tag {@link self::from_record()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#96) Inline phpdocs tag {@link self::get()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#98) Inline phpdocs tag {@link self::to_record()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#99) Inline phpdocs tag {@link self::from_record()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#121) Inline phpdocs tag {@link self::set()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#123) Inline phpdocs tag {@link self::to_record()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#124) Inline phpdocs tag {@link self::from_record()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#683) Inline phpdocs tag {@link self::get_sql_fields()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- (#781) Inline phpdocs tag {@link self::extract_record()} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
- blocks/stash/classes/shortcodes.php
- (#50) Phpdocs for function shortcodes::drop has incomplete parameters list
- (#111) Phpdocs for function shortcodes::trade has incomplete parameters list
- blocks/stash/classes/stash.php
- (#41) Function stash::define_properties is not documented
- (#39) Constant stash::TABLE is not documented
- (#152) Phpdocs for function stash::get_by_tradeid has incomplete parameters list
- blocks/stash/classes/trade.php
- (#48) Function trade::define_properties is not documented
- (#163) Function trade::get_full_trade_items_list is not documented
- (#46) Constant trade::TABLE is not documented
- (#112) Phpdocs for function trade::is_trade_in_stash has incomplete parameters list
- blocks/stash/classes/tradeitems.php
- (#41) Function tradeitems::define_properties is not documented
- (#39) Constant tradeitems::TABLE is not documented
- blocks/stash/classes/user_item.php
- (#41) Function user_item::define_properties is not documented
- (#39) Constant user_item::TABLE is not documented
- blocks/stash/edit_form.php
- (#34) Function block_stash_edit_form::specific_definition is not documented
- (#45) Function block_stash_edit_form::set_data is not documented
Update savepoints problems
(0 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
Missing changes in external functions or backup support for new detected tables or columns
(0 errors, 0 warnings)
This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]
grunt changes
(1 errors, 1 warnings)
This section shows files built by grunt and not commited [More info]
- Problems running grunt
- Task "eslint:amd" failed. Use --force to continue.
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(0 errors, 59 warnings)
This section shows problems detected in mustache templates [More info]
- blocks/stash/templates/drop_image.mustache
- (#1) Example context missing (@template section not found.)
- (#1) HTML Validation error, line 2: Bad value “” for attribute “id” on element “div”: An ID must not be the empty string. (ad><body><div id="" style="display: inline;"> <)
- blocks/stash/templates/drop_snippet_dialogue.mustache
- (#1) Example context missing (@template section not found.)
- blocks/stash/templates/drop_snippet_ui.mustache
- (#1) Example context missing (@template section not found.)
- blocks/stash/templates/drop_text.mustache
- (#1) Example context missing (@template section not found.)
- (#1) HTML Validation error, line 2: Bad value “” for attribute “id” on element “div”: An ID must not be the empty string. (ad><body><div id="" style="display: inline;"> <)
- blocks/stash/templates/fullpage_help.mustache
- (#1) Example context missing (@template section not found.)
- (#1) HTML Validation info, line 4: Empty heading. (> <h3></h3>)
- blocks/stash/templates/item.mustache
- (#1) Example context missing (@template section not found.)
- blocks/stash/templates/item_detail.mustache
- (#1) Example context missing (@template section not found.)
- blocks/stash/templates/item_select_dialogue.mustache
- (#1) Example context missing (@template section not found.)
- blocks/stash/templates/item_small.mustache
- (#1) Example context missing (@template section not found.)
- blocks/stash/templates/item_xsmall.mustache
- (#1) Example context missing (@template section not found.)
- blocks/stash/templates/main_content.mustache
- (#1) Example context missing (@template section not found.)
- (#1) ESLint error [no-unused-vars]: 'Area' is assigned a value but never used. ( ), Line: 6 Column: 9
- blocks/stash/templates/profile_content.mustache
- (#1) Example context missing (@template section not found.)
- blocks/stash/templates/trade.mustache
- (#1) Example context missing (@template section not found.)
- (#1) HTML Validation error, line 2: Bad value “” for attribute “id” on element “div”: An ID must not be the empty string. (ad><body><div id="" style="display: inline;"> <)
- (#1) HTML Validation error, line 17: The “center” element is obsolete. Use CSS instead. ( <center><butto)
- blocks/stash/templates/trade_add_item_detail.mustache
- (#1) Example context missing (@template section not found.)
- (#1) HTML Validation error, line 3: Stray start tag “tr”. (d><body><tr class="block-stash-trade-item" data-id=""> <)
- (#1) HTML Validation error, line 4: Stray start tag “td”. (d=""> <td style="width: 70%;"><div c)
- (#1) HTML Validation error, line 9: Stray end tag “td”. (></div> </td> <)
- (#1) HTML Validation error, line 10: Stray start tag “td”. (</td> <td style="width: 20%;"> )
- (#1) HTML Validation error, line 12: Stray end tag “td”. ("" /> </td> <)
- (#1) HTML Validation error, line 13: Stray start tag “td”. (</td> <td style="width: 10%;"> )
- (#1) HTML Validation error, line 15: Stray end tag “td”. (span> </td></tr>)
- (#1) HTML Validation error, line 16: Stray end tag “tr”. ( </td></tr></bo)
- blocks/stash/templates/trade_form.mustache
- (#1) Example context missing (@template section not found.)
- (#1) HTML Validation error, line 11: No space between attributes. ( <input type="text" class="form-control" name="title" value="" placeholder="[[tradename, block_stash]]"" /> )
- (#1) HTML Validation error, line 11: Saw “"” when expecting an attribute name. Probable cause: “=” missing immediately before. ( <input type="text" class="form-control" name="title" value="" placeholder="[[tradename, block_stash]]"" /> )
- (#1) HTML Validation info, line 11: Attribute “"” is not serializable as XML 1.0. (_stash]]"" /> )
- (#1) HTML Validation error, line 11: Attribute “"” not allowed on element “input” at this point. (_stash]]"" /> )
- (#1) HTML Validation error, line 19: Element “legend” not allowed as child of element “div” in this context. (Suppressing further errors from this subtree.) ( <legend>[[gain)
- (#1) HTML Validation error, line 51: Element “legend” not allowed as child of element “div” in this context. (Suppressing further errors from this subtree.) ( <legend>[[loss)
- blocks/stash/templates/trade_item_picker.mustache
- (#1) Example context missing (@template section not found.)
- (#1) ESLint warning [promise/catch-or-return]: Expected catch,fail() or return ( ), Line: 34 Column: 9
- (#1) ESLint warning [promise/always-return]: Each then() should return a value or throw ( ), Line: 34 Column: 51
- (#1) ESLint error [no-unused-vars]: 'js' is defined but never used. ( ), Line: 34 Column: 66
- blocks/stash/templates/trade_loss_item_detail.mustache
- (#1) Example context missing (@template section not found.)
- (#1) HTML Validation error, line 3: Stray start tag “tr”. (d><body><tr class="block-stash-trade-item" data-id=""> <)
- (#1) HTML Validation error, line 4: Stray start tag “td”. (d=""> <td style="width: 70%;"><div c)
- (#1) HTML Validation error, line 9: Stray end tag “td”. (></div> </td> <)
- (#1) HTML Validation error, line 10: Stray start tag “td”. (</td> <td style="width: 20%;"> )
- (#1) HTML Validation error, line 12: Stray end tag “td”. ("" /> </td> <)
- (#1) HTML Validation error, line 13: Stray start tag “td”. (</td> <td style="width: 10%;"> )
- (#1) HTML Validation error, line 15: Stray end tag “td”. (span> </td></tr>)
- (#1) HTML Validation error, line 16: Stray end tag “tr”. ( </td></tr></bo)
- blocks/stash/templates/trade_snippet_dialogue.mustache
- (#1) Example context missing (@template section not found.)
- (#1) HTML Validation error, line 3: Bad value “” for attribute “id” on element “div”: An ID must not be the empty string. (gue"> <div id="" style="display: inline;"> )
- (#1) HTML Validation error, line 19: Stray end tag “div”. ( </div></div> <)
- (#1) HTML Validation error, line 29: Stray end tag “div”. ( </div></div></b)
- (#1) ESLint error [no-trailing-spaces]: Trailing spaces not allowed. ( ), Line: 5 Column: 1
- blocks/stash/templates/trade_success.mustache
- (#1) Example context missing (@template section not found.)
- blocks/stash/templates/tradeitem_detail.mustache
- (#1) Example context missing (@template section not found.)
- blocks/stash/templates/user_item.mustache
- (#1) Example context missing (@template section not found.)
- (#1) Template produced no content
- blocks/stash/templates/user_item_reset.mustache
- (#1) Example context missing (@template section not found.)
- (#1) ESLint error [no-unused-vars]: 'targetnode' is assigned a value but never used. ( ), Line: 8 Column: 9
- blocks/stash/templates/user_item_small.mustache
- (#1) Example context missing (@template section not found.)
Gherkin .feature problems
(0 errors, 0 warnings)
This section shows problems detected in behat .feature files [More info]