Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(9 errors, 11 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/semester_sortierung/ajax_modinfo.php
(#28) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/semester_sortierung/db/services.php
(#63) Line exceeds 132 characters; contains 160 characters
(#65) Expected 1 space before "=>"; 0 found
(#65) Expected 1 space after "=>"; 0 found
blocks/semester_sortierung/externallib.php
(#64) Line exceeds 132 characters; contains 169 characters
(#64) Inline comments must start with a capital letter, digit or 3-dots sequence
(#64) Inline comments must end in full-stops, exclamation marks, or question marks
(#64) This comment is 45% valid code; is this commented out code?
(#64) No space found before comment text; expected "// $CFG->dirroot . '/mod/' . $module->name . '/pix/icon.png'));" but found "//$CFG->dirroot . '/mod/' . $module->name . '/pix/icon.png'));"
(#188) Variable "GLOBALS" must be all lower-case
(#205) Variable "GLOBALS" must be all lower-case
blocks/semester_sortierung/locallib.php
(#195) This comment is 50% valid code; is this commented out code?
(#196) This comment is 50% valid code; is this commented out code?
blocks/semester_sortierung/renderer.php
(#189) Line indented incorrectly; expected at least 16 spaces, found 12
(#296) Functions must not contain multiple empty lines in a row; found 2 empty lines
blocks/semester_sortierung/settings.php
(#43) Line exceeds 132 characters; contains 151 characters
(#43) Inline comments must start with a capital letter, digit or 3-dots sequence
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
(#43) This comment is 50% valid code; is this commented out code?
(#43) No space found before comment text; expected "// strftime('%B', ($i * 3600 * 24 * 31));" but found "//strftime('%B', ($i * 3600 * 24 * 31));"

Javascript coding style problems

(17 errors, 78 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/semester_sortierung/yui/semester_sortierung/semester_sortierung.js
(#26) 'YUI' is not defined. (no-undef)
(#26) Missing space before opening brace. (space-before-blocks)
(#27) 'config' is defined but never used (no-unused-vars)
(#34) Extra space after key 'id'. (key-spacing)
(#35) Missing JSDoc for parameter 'config'. (valid-jsdoc)
(#38) Extra space after key 'initializer'. (key-spacing)
(#40) Infix operators must be spaced. (space-infix-ops)
(#44) Script URL is a form of eval. (no-script-url)
(#46) Missing space before opening brace. (space-before-blocks)
(#46) Requires a space after '{'. (block-spacing)
(#46) Statement inside of curly braces should be on next line. (brace-style)
(#46) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#46) Requires a space before '}'. (block-spacing)
(#47) Line 47 exceeds the maximum line length of 132. (max-len)
(#47) Missing space before opening brace. (space-before-blocks)
(#47) Requires a space after '{'. (block-spacing)
(#47) Statement inside of curly braces should be on next line. (brace-style)
(#47) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#47) Requires a space before '}'. (block-spacing)
(#49) Trailing spaces not allowed. (no-trailing-spaces)
(#50) Extra space after key 'toggleFavorites'. (key-spacing)
(#89) Infix operators must be spaced. (space-infix-ops)
(#90) Missing space before value for key 'method'. (key-spacing)
(#91) 'build_querystring' is not defined. (no-undef)
(#92) Missing space before value for key 'context'. (key-spacing)
(#95) Trailing spaces not allowed. (no-trailing-spaces)
(#96) Extra space after key 'sortFavorites'. (key-spacing)
(#102) Missing space before opening brace. (space-before-blocks)
(#102) Requires a space after '{'. (block-spacing)
(#102) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#102) Statement inside of curly braces should be on next line. (brace-style)
(#102) Requires a space before '}'. (block-spacing)
(#104) 'i' used outside of binding context. (block-scoped-var)
(#104) 'i' used outside of binding context. (block-scoped-var)
(#104) 'i' used outside of binding context. (block-scoped-var)
(#105) 'i' used outside of binding context. (block-scoped-var)
(#107) 'i' is already defined (no-redeclare)
(#107) 'i' used outside of binding context. (block-scoped-var)
(#107) 'i' used outside of binding context. (block-scoped-var)
(#107) 'i' used outside of binding context. (block-scoped-var)
(#108) 'i' used outside of binding context. (block-scoped-var)
(#111) Trailing spaces not allowed. (no-trailing-spaces)
(#112) Extra space after key 'customSorting'. (key-spacing)
(#113) 'a' is already defined (no-redeclare)
(#114) 'b' is already defined (no-redeclare)
(#115) Do not nest ternary expressions (no-nested-ternary)
(#118) Extra space after key 'setNewStatus'. (key-spacing)
(#120) Expected space or tab after '//' in comment. (spaced-comment)
(#120) Trailing spaces not allowed. (no-trailing-spaces)
(#124) Trailing spaces not allowed. (no-trailing-spaces)
(#128) Multiple spaces found before '&&'. (no-multi-spaces)
(#129) Trailing spaces not allowed. (no-trailing-spaces)
(#139) Infix operators must be spaced. (space-infix-ops)
(#140) Missing space before value for key 'method'. (key-spacing)
(#141) 'build_querystring' is not defined. (no-undef)
(#142) Missing space before value for key 'context'. (key-spacing)
(#142) Trailing spaces not allowed. (no-trailing-spaces)
(#156) More than 2 blank lines not allowed. (no-multiple-empty-lines)
(#157) 'k' is defined but never used (no-unused-vars)
(#162) Use ‘===’ to compare with ‘null’. (no-eq-null)
(#186) More than 2 blank lines not allowed. (no-multiple-empty-lines)
(#187) Expected space or tab after '//' in comment. (spaced-comment)
(#188) Expected variable declaration to be on a new line. (one-var-declaration-per-line)
(#194) Expected space or tab after '//' in comment. (spaced-comment)
(#196) Expected space or tab after '//' in comment. (spaced-comment)
(#211) Expected space or tab after '//' in comment. (spaced-comment)
(#223) Infix operators must be spaced. (space-infix-ops)
(#224) Missing space before value for key 'method'. (key-spacing)
(#225) 'build_querystring' is not defined. (no-undef)
(#226) Missing space before value for key 'context'. (key-spacing)
(#233) Expected space or tab after '//' in comment. (spaced-comment)
(#235) Expected space or tab after '//' in comment. (spaced-comment)
(#236) Expected space or tab after '//' in comment. (spaced-comment)
(#237) Expected space or tab after '//' in comment. (spaced-comment)
(#242) Expected space or tab after '//' in comment. (spaced-comment)
(#247) Expected space or tab after '//' in comment. (spaced-comment)
(#248) Infix operators must be spaced. (space-infix-ops)
(#249) Expected space or tab after '//' in comment. (spaced-comment)
(#253) Expected space or tab after '//' in comment. (spaced-comment)
(#255) Expected space or tab after '//' in comment. (spaced-comment)
(#284) More than 2 blank lines not allowed. (no-multiple-empty-lines)
(#287) Extra space after key 'NAME'. (key-spacing)
(#288) Extra space after key 'ATTRS'. (key-spacing)
(#289) Extra space after key 'instance'. (key-spacing)
(#290) Extra space after key 'value'. (key-spacing)
(#296) More than 2 blank lines not allowed. (no-multiple-empty-lines)
(#302) Identifier 'block_semester_sortierung' is not in camel case. (camelcase)
(#304) Extra space after key 'instance'. (key-spacing)
(#305) Missing JSDoc for parameter 'properties'. (valid-jsdoc)
(#308) Identifier 'init_add_semsort' is not in camel case. (camelcase)
(#308) Missing space before value for key 'init_add_semsort'. (key-spacing)
(#309) Expected space or tab after '/*' in comment. (spaced-comment)
(#316) Line 316 exceeds the maximum line length of 132. (max-len)
(#316) Missing space before value for key 'requires'. (key-spacing)
(#316) A space is required after ','. (comma-spacing)

CSS problems

(4 errors, 12 warnings)

This section shows CSS problems detected by csslint [More info]

blocks/semester_sortierung/styles.css
(#34) Use of !important
(#52) Use of !important
(#53) Use of !important
(#62) width can't be used with display: inline.
(#63) Duplicate property '*display' found.
(#63) Duplicate property '*height' found.
(#63) height can't be used with display: inline.
(#76) width can't be used with display: inline.
(#77) margin can't be used with display: inline.
(#78) height can't be used with display: inline.
(#78) Duplicate property '*display' found.
(#78) Duplicate property '*height' found.
(#132) Use of !important
(#152) Use of !important
(#169) Use of !important
(#185) Rule is empty.

PHPDocs style problems

(22 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/semester_sortierung/block_semester_sortierung.php
(#31) Class block_semester_sortierung is not documented
(#17) No one-line description found in phpdocs for file
blocks/semester_sortierung/db/upgrade.php
(#31) Function xmldb_block_semester_sortierung_upgrade is not documented
blocks/semester_sortierung/externallib.php
(#33) Class block_semester_sortierung_external is not documented
(#101) Phpdocs for function block_semester_sortierung_external::get_courses has incomplete parameters list
(#172) Phpdocs for function block_semester_sortierung_external::get_coursedetails has incomplete parameters list
blocks/semester_sortierung/locallib.php
(#30) Function block_sememster_sortierung_usort is not documented
(#34) Function block_semester_sortierung_toggle_fav is not documented
(#55) Function block_semester_sortierung_update_personal_sort is not documented
(#175) Function block_semester_sortierung_sort_user_personal_sort is not documented
(#117) Phpdocs for function block_semester_sortierung_fill_course_semester has incomplete parameters list
(#231) Phpdocs for function block_semester_sortierung_get_semester has incomplete parameters list
blocks/semester_sortierung/renderer.php
(#195) Function block_semester_sortierung_renderer::start_semester is not documented
(#218) Function block_semester_sortierung_renderer::end_semester is not documented
(#225) Function block_semester_sortierung_renderer::course_html is not documented
(#280) Function block_semester_sortierung_renderer::get_personalsort_icons is not documented
(#301) Function block_semester_sortierung_renderer::get_favorites_icon is not documented
(#317) Function block_semester_sortierung_renderer::get_move_target is not documented
(#39) Phpdocs for function block_semester_sortierung_renderer::semester_sortierung has incomplete parameters list
(#331) Phpdocs for function block_semester_sortierung_renderer::get_expand_image_button_html has incomplete parameters list
(#30) Class block_semester_sortierung_renderer does not have @copyright tag
(#30) Class block_semester_sortierung_renderer does not have @license tag

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]