Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(251 errors, 37 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/rss_plus/block_rss_plus.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#20) Whitespace found at end of line
(#23) Whitespace found at end of line
(#28) Expected MOODLE_INTERNAL check or config.php inclusion
(#28) Line indented incorrectly; expected 0 spaces, found 1
(#30) Visibility must be declared on method "init"
(#34) Visibility must be declared on method "preferred_width"
(#38) Visibility must be declared on method "applicable_formats"
(#39) Inline comments must end in full-stops, exclamation marks, or question marks
(#42) Spaces must be used to indent lines; tabs are not allowed
(#42) Tab found within whitespace
(#42) Whitespace found at end of line
(#43) Spaces must be used to indent lines; tabs are not allowed
(#43) Tab found within whitespace
(#43) Line indented incorrectly; expected 4 spaces, found 1
(#43) Visibility must be declared on method "specialization"
(#44) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#49) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) Line indented incorrectly; expected 12 spaces, found 8
(#52) Closing brace indented incorrectly; expected 1 spaces, found 4
(#54) Visibility must be declared on method "get_content"
(#57) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
(#61) Inline comments must start with a capital letter, digit or 3-dots sequence
(#61) Inline comments must end in full-stops, exclamation marks, or question marks
(#72) Inline comments must end in full-stops, exclamation marks, or question marks
(#85) Usage of ELSEIF not allowed; use ELSE IF instead
(#88) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#95) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#98) Variable "rss_ids_sql" must not contain underscores.
(#100) Variable "rss_feeds" must not contain underscores.
(#100) Variable "rss_ids_sql" must not contain underscores.
(#103) Variable "rss_feeds" must not contain underscores.
(#104) Inline comments must start with a capital letter, digit or 3-dots sequence
(#104) Inline comments must end in full-stops, exclamation marks, or question marks
(#108) Expected "foreach (...) {\n"; found "foreach(...){\n"
(#108) Variable "rss_feeds" must not contain underscores.
(#109) Expected 1 space before ".="; 0 found
(#119) Visibility must be declared on method "instance_allow_multiple"
(#123) Visibility must be declared on method "has_config"
(#127) Visibility must be declared on method "instance_allow_config"
(#139) Visibility must be declared on method "get_feed_html"
(#139) Expected 1 space after closing parenthesis; found 0
(#145) Expected "if (...) {\n"; found "if(...){\n"
(#146) Expected 1 space before "*"; 0 found
(#146) Expected 1 space after "*"; 0 found
(#149) Expected "if (...) {\n"; found "if(...){\n"
(#153) Inline comments must start with a capital letter, digit or 3-dots sequence
(#153) Inline comments must end in full-stops, exclamation marks, or question marks
(#154) Spaces must be used to indent lines; tabs are not allowed
(#154) Tab found within whitespace
(#154) Whitespace found at end of line
(#154) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#155) Spaces must be used to indent lines; tabs are not allowed
(#155) Tab found within whitespace
(#155) Whitespace found at end of line
(#156) Expected "if (...) {\n"; found "if(...){\n"
(#158) Expected "} else {\n"; found "}else{\n"
(#162) Expected 1 space before ".="; 0 found
(#162) Expected 1 space after ".="; 0 found
(#163) Spaces must be used to indent lines; tabs are not allowed
(#163) Tab found within whitespace
(#163) Line indented incorrectly; expected at least 8 spaces, found 3
(#163) Expected 1 space before ".="; 0 found
(#163) Expected 1 space after ".="; 0 found
(#166) Expected "foreach (...) {\n"; found "foreach(...){\n"
(#167) Expected 1 space before ".="; 0 found
(#167) Whitespace found at end of line
(#168) Spaces must be used to indent lines; tabs are not allowed
(#168) Tab found within whitespace
(#168) Whitespace found at end of line
(#168) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#169) Spaces must be used to indent lines; tabs are not allowed
(#169) Tab found within whitespace
(#169) Whitespace found at end of line
(#171) Spaces must be used to indent lines; tabs are not allowed
(#171) Tab found within whitespace
(#171) Whitespace found at end of line
(#171) Functions must not contain multiple empty lines in a row; found 4 empty lines
(#172) Spaces must be used to indent lines; tabs are not allowed
(#172) Tab found within whitespace
(#172) Whitespace found at end of line
(#173) Spaces must be used to indent lines; tabs are not allowed
(#173) Tab found within whitespace
(#173) Whitespace found at end of line
(#175) Expected 1 space before ".="; 0 found
(#175) Expected 1 space after ".="; 0 found
(#176) Expected 1 space before ".="; 0 found
(#176) Expected 1 space after ".="; 0 found
(#177) Functions must not contain multiple empty lines in a row; found 5 empty lines
(#192) Whitespace found at end of line
(#193) Spaces must be used to indent lines; tabs are not allowed
(#193) Tab found within whitespace
(#193) Line indented incorrectly; expected 4 spaces, found 1
(#193) Visibility must be declared on method "get_item_html"
(#193) Expected 1 space after closing parenthesis; found 0
(#198) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#200) Expected "if (...) {\n"; found "if(...){\n"
(#201) Inline comments must start with a capital letter, digit or 3-dots sequence
(#201) Inline comments must end in full-stops, exclamation marks, or question marks
(#203) Expected "} else {\n"; found "}else{\n"
(#205) Line indented incorrectly; expected 12 spaces, found 8
(#207) Line indented incorrectly; expected 12 spaces, found 8
(#207) Expected "if (...) {\n"; found "if(...){\n"
(#208) Line indented incorrectly; expected at least 16 spaces, found 12
(#209) Line indented incorrectly; expected 12 spaces, found 8
(#210) Line indented incorrectly; expected at least 16 spaces, found 12
(#210) No space found before comment text; expected "// URLs in our RSS cache will be escaped (correctly as theyre store in XML)" but found "//URLs in our RSS cache will be escaped (correctly as theyre store in XML)"
(#211) Line indented incorrectly; expected at least 16 spaces, found 12
(#211) No space found before comment text; expected "// html_writer::link() will re-escape them. To prevent double escaping unescape here." but found "//html_writer::link() will re-escape them. To prevent double escaping unescape here."
(#212) Inline comments must end in full-stops, exclamation marks, or question marks
(#212) Line indented incorrectly; expected at least 16 spaces, found 12
(#212) No space found before comment text; expected "// This can by done using htmlspecialchars_decode() but moodle_url also has that effect" but found "//This can by done using htmlspecialchars_decode() but moodle_url also has that effect"
(#213) Line indented incorrectly; expected at least 16 spaces, found 12
(#214) Line indented incorrectly; expected 12 spaces, found 8
(#216) Line indented incorrectly; expected at least 12 spaces, found 8
(#217) Spaces must be used to indent lines; tabs are not allowed
(#217) Tab found within whitespace
(#217) Whitespace found at end of line
(#217) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#218) Spaces must be used to indent lines; tabs are not allowed
(#218) Tab found within whitespace
(#218) Whitespace found at end of line
(#219) Expected 1 space before ".="; 0 found
(#219) Commas (,) must be followed by white space.
(#219) Expected 1 space before "=>"; 0 found
(#219) Expected 1 space after "=>"; 0 found
(#220) Expected 1 space before ".="; 0 found
(#220) Commas (,) must be followed by white space.
(#220) Expected 1 space before "=>"; 0 found
(#220) Expected 1 space after "=>"; 0 found
(#221) Expected 1 space before ".="; 0 found
(#222) Functions must not contain multiple empty lines in a row; found 3 empty lines
(#226) Spaces must be used to indent lines; tabs are not allowed
(#226) Tab found within whitespace
(#226) Line indented incorrectly; expected at least 12 spaces, found 4
(#231) Expected 1 space before ".="; 0 found
(#231) Commas (,) must be followed by white space.
(#231) Expected 1 space before "=>"; 0 found
(#231) Expected 1 space after "=>"; 0 found
(#232) Expected 1 space before ".="; 0 found
(#233) Expected 1 space before ".="; 0 found
(#234) Spaces must be used to indent lines; tabs are not allowed
(#234) Tab found within whitespace
(#234) Whitespace found at end of line
(#235) Expected 1 space before ".="; 0 found
(#235) Commas (,) must be followed by white space.
(#235) Expected 1 space before "=>"; 0 found
(#235) Expected 1 space after "=>"; 0 found
(#236) Spaces must be used to indent lines; tabs are not allowed
(#236) Tab found within whitespace
(#236) Whitespace found at end of line
(#236) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#238) Line indented incorrectly; expected at least 12 spaces, found 4
(#238) Inline doc block comments are not allowed; use "// Comment." instead
(#239) Whitespace found at end of line
(#243) Whitespace found at end of line
(#245) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#246) Spaces must be used to indent lines; tabs are not allowed
(#246) Tab found within whitespace
(#246) Whitespace found at end of line
(#247) Spaces must be used to indent lines; tabs are not allowed
(#247) Tab found within whitespace
(#247) Line indented incorrectly; expected 12 spaces, found 1
(#247) Expected "if (...) {\n"; found "if (...)\n\t{\n"
(#248) Spaces must be used to indent lines; tabs are not allowed
(#248) Tab found within whitespace
(#248) Line indented incorrectly; expected at least 12 spaces, found 1
(#249) Spaces must be used to indent lines; tabs are not allowed
(#249) Tab found within whitespace
(#249) Line indented incorrectly; expected at least 16 spaces, found 1
(#249) Inline control structures are not allowed
(#250) Spaces must be used to indent lines; tabs are not allowed
(#250) Tab found within whitespace
(#250) Line indented incorrectly; expected at least 16 spaces, found 2
(#250) Expected 1 space before ".="; 0 found
(#250) Expected 1 space after ".="; 0 found
(#251) Spaces must be used to indent lines; tabs are not allowed
(#251) Tab found within whitespace
(#251) Whitespace found at end of line
(#252) Spaces must be used to indent lines; tabs are not allowed
(#252) Tab found within whitespace
(#252) Line indented incorrectly; expected 12 spaces, found 1
(#252) Whitespace found at end of line
(#253) Spaces must be used to indent lines; tabs are not allowed
(#253) Tab found within whitespace
(#253) Whitespace found at end of line
(#253) Functions must not contain multiple empty lines in a row; found 3 empty lines
(#254) Spaces must be used to indent lines; tabs are not allowed
(#254) Tab found within whitespace
(#254) Whitespace found at end of line
(#255) Spaces must be used to indent lines; tabs are not allowed
(#255) Tab found within whitespace
(#255) Whitespace found at end of line
(#256) Expected 1 space before ".="; 0 found
(#257) Whitespace found at end of line
(#258) Line indented incorrectly; expected at least 12 spaces, found 8
(#258) Expected 1 space before ".="; 0 found
(#260) Line indented incorrectly; expected at least 12 spaces, found 8
(#261) Closing brace indented incorrectly; expected 1 spaces, found 4
(#270) Visibility must be declared on method "format_title"
(#270) Commas (,) must be followed by white space.
(#278) Commas (,) must be followed by white space.
(#278) Commas (,) must be followed by white space.
(#278) Expected 1 space before "-"; 0 found
(#278) Expected 1 space after "-"; 0 found
(#289) Visibility must be declared on method "cron"
(#293) Inline comments must end in full-stops, exclamation marks, or question marks
(#294) Expected 1 space after "="; 2 found
(#296) Inline comments must end in full-stops, exclamation marks, or question marks
(#307) Inline comments must end in full-stops, exclamation marks, or question marks
(#307) This comment is 84% valid code; is this commented out code?
(#307) No space found before comment text; expected "// @set_time_limit(60);//" but found "//@set_time_limit(60);//"
(#308) Spaces must be used to indent lines; tabs are not allowed
(#308) Tab found within whitespace
(#308) Line indented incorrectly; expected at least 12 spaces, found 3
(#310) Expected 1 space after "="; 2 found
(#311) Inline comments must start with a capital letter, digit or 3-dots sequence
(#329) Inline comments must end in full-stops, exclamation marks, or question marks
(#332) Inline comments must end in full-stops, exclamation marks, or question marks
(#332) This comment is 50% valid code; is this commented out code?
(#335) Closing brace indented incorrectly; expected 1 spaces, found 0
blocks/rss_plus/db/access.php
(#2) Line 1 of the opening comment must start "// This file is part of".
(#4) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".
(#5) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".
(#6) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".
(#7) Line 6 of the opening comment must start "// (at your option) any later version.".
(#9) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".
(#10) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".
(#11) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".
(#12) Line 11 of the opening comment must start "// GNU General Public License for more details.".
(#14) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".
(#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
(#17) Expected 1 space before comment text but found 3; use block comment if you need indentation
(#22) Expected 1 space before comment text but found 4; use block comment if you need indentation
(#25) Expected 1 space before comment text but found 11; use block comment if you need indentation
(#26) Expected 1 space before comment text but found 11; use block comment if you need indentation
(#28) Inline comments must end in full-stops, exclamation marks, or question marks
(#31) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/rss_plus/edit_form.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#29) Spaces must be used for alignment; tabs are not allowed
(#30) Spaces must be used for alignment; tabs are not allowed
(#33) Expected MOODLE_INTERNAL check or config.php inclusion
(#41) Whitespace found at end of line
(#42) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#44) Spaces must be used for alignment; tabs are not allowed
(#44) Tab found within whitespace
(#44) Line indented incorrectly; expected at least 8 spaces, found 5
(#71) Line exceeds 132 characters; contains 180 characters
(#74) Functions must not contain multiple empty lines in a row; found 2 empty lines
blocks/rss_plus/editfeed.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#27) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
(#37) Visibility must be declared on method "__construct"
(#40) PHP4 style calls to parent constructors are not allowed; use "parent::__construct()" instead
(#43) Visibility must be declared on method "definition"
(#66) Inline comments must end in full-stops, exclamation marks, or question marks
(#66) This comment is 50% valid code; is this commented out code?
(#73) Visibility must be declared on method "definition_after_data"
(#73) Expected 1 space after closing parenthesis; found 0
(#76) Expected "if (...) {\n"; found "if(...){\n"
(#81) Visibility must be declared on method "validation"
(#84) Expected 1 space after "="; 2 found
(#85) Inline comments must start with a capital letter, digit or 3-dots sequence
(#85) Inline comments must end in full-stops, exclamation marks, or question marks
(#102) Visibility must be declared on method "get_data"
(#108) Expected "if (...) {\n"; found "if(...){\n"
(#112) Expected "if (...) {\n"; found "if(...){\n"
(#130) Expected 1 space after closing parenthesis; found 0
(#131) Expected 1 space after "="; 2 found
(#135) Inline comments must end in full-stops, exclamation marks, or question marks
(#139) Line indented incorrectly; expected 8 spaces, found 12
(#139) Expected "if (...) {\n"; found "if(...){\n"
(#141) Line indented incorrectly; expected 8 spaces, found 12
(#143) Inline comments must start with a capital letter, digit or 3-dots sequence
blocks/rss_plus/lang/en/block_rss_plus.php
(#2) The opening <?php tag must be followed by exactly one newline.
blocks/rss_plus/managefeeds.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#65) Inline comments must end in full-stops, exclamation marks, or question marks
(#67) Expected 1 space before "=>"; 0 found
(#67) Expected 1 space after "=>"; 0 found
(#107) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#111) Expected 1 space after "="; 2 found
(#123) Line exceeds 132 characters; contains 134 characters
(#125) Line exceeds 132 characters; contains 137 characters
blocks/rss_plus/settings.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#12) Expected 1 space after "="; 0 found
blocks/rss_plus/version.php
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
blocks/rss_plus/viewfeed.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#85) Expected 1 space after "="; 2 found

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by jshint [More info]


CSS problems

(0 errors, 8 warnings)

This section shows CSS problems detected by csslint [More info]

blocks/rss_plus/styles.css
(#2) Use of !important
(#3) Use of !important
(#8) Use of !important
(#18) Use of !important
(#21) Use of !important
(#22) Use of !important
(#43) Use of !important
(#44) Use of !important

PHPDocs style problems

(36 errors, 7 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/rss_plus/block_rss_plus.php
(#2) Empty line found after PHP open tag
(#28) Class block_rss_plus is not documented
(#30) Function block_rss_plus::init is not documented
(#34) Function block_rss_plus::preferred_width is not documented
(#38) Function block_rss_plus::applicable_formats is not documented
(#43) Function block_rss_plus::specialization is not documented
(#54) Function block_rss_plus::get_content is not documented
(#119) Function block_rss_plus::instance_allow_multiple is not documented
(#123) Function block_rss_plus::has_config is not documented
(#127) Function block_rss_plus::instance_allow_config is not documented
(#193) Function block_rss_plus::get_item_html is not documented
(#18) No one-line description found in phpdocs for file
(#134) Phpdocs for function block_rss_plus::get_feed_html has incomplete parameters list
(#266) Phpdocs for function block_rss_plus::format_title has incomplete parameters list
(#24) Invalid phpdocs tag @sourcecode used
(#22) Package rss_plus is not valid
blocks/rss_plus/db/access.php
(#31) File-level phpdocs block is not found
blocks/rss_plus/edit_form.php
(#2) Empty line found after PHP open tag
(#34) Function block_rss_plus_edit_form::specific_definition is not documented
(#30) Invalid phpdocs tag @sourcecode used
(#21) Package moodlecore is not valid
blocks/rss_plus/editfeed.php
(#2) Empty line found after PHP open tag
(#31) Class feed_edit_form is not documented
(#37) Function feed_edit_form::__construct is not documented
(#43) Function feed_edit_form::definition is not documented
(#73) Function feed_edit_form::definition_after_data is not documented
(#81) Function feed_edit_form::validation is not documented
(#102) Function feed_edit_form::get_data is not documented
(#32) Variable feed_edit_form::$isadding is not documented
(#33) Variable feed_edit_form::$caneditshared is not documented
(#34) Variable feed_edit_form::$title is not documented
(#35) Variable feed_edit_form::$description is not documented
(#127) Phpdocs for function feed_edit_form::autodiscover_feed_url has incomplete parameters list
(#21) Package moodlecore is not valid
blocks/rss_plus/lang/en/block_rss_plus.php
(#2) Empty line found after PHP open tag
blocks/rss_plus/managefeeds.php
(#2) Empty line found after PHP open tag
(#21) Package moodlecore is not valid
blocks/rss_plus/settings.php
(#2) Empty line found after PHP open tag
(#3) File-level phpdocs block is not found
blocks/rss_plus/version.php
(#17) File-level phpdocs block does not have @copyright tag
(#19) Package block is not valid
blocks/rss_plus/viewfeed.php
(#2) Empty line found after PHP open tag
(#21) Package moodlecore is not valid

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]