Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(112 errors, 105 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/progressanalytics/block_progressanalytics.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#30) Opening brace must not be followed by a blank line
(#45) Short array syntax must be used to define arrays
(#52) There should be a comma after the last array item in a multi-line array.
(#89) Short array syntax must be used to define arrays
(#114) global $PAGE cannot be used in block classes. Use $this->page.
(#139) Short array syntax must be used to define arrays
(#147) There should be a comma after the last array item in a multi-line array.
(#154) global $PAGE cannot be used in block classes. Use $this->page.
(#154) Short array syntax must be used to define arrays
blocks/progressanalytics/classes/external/get_course_quiz_metrics.php
(#35) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#40) Opening brace must not be followed by a blank line
(#49) Short array syntax must be used to define arrays
(#61) PHP4 style constructors are not allowed; use "__construct()" instead
(#64) Inline comments must end in full-stops, exclamation marks, or question marks
(#69) Short array syntax must be used to define arrays
(#70) There should be a comma after the last array item in a multi-line array.
(#73) Short array syntax must be used to define arrays
(#85) Whitespace found at end of line
(#92) Short array syntax must be used to define arrays
(#93) Whitespace found at end of line
(#101) Short array syntax must be used to define arrays
(#102) Short array syntax must be used to define arrays
(#105) There should be a comma after the last array item in a multi-line array.
(#107) Short array syntax must be used to define arrays
(#108) Short array syntax must be used to define arrays
(#112) There should be a comma after the last array item in a multi-line array.
(#113) There should be a comma after the last array item in a multi-line array.
(#119) Short array syntax must be used to define arrays
(#150) Short array syntax must be used to define arrays
(#153) There should be a comma after the last array item in a multi-line array.
(#159) Short array syntax must be used to define arrays
(#161) There should be a comma after the last array item in a multi-line array.
(#178) Short array syntax must be used to define arrays
(#180) Whitespace found at end of line
(#184) Whitespace found at end of line
(#187) Whitespace found at end of line
(#190) Whitespace found at end of line
(#194) Whitespace found at end of line
(#198) Short array syntax must be used to define arrays
(#202) There should be a comma after the last array item in a multi-line array.
(#206) Inline comments must end in full-stops, exclamation marks, or question marks
(#208) Whitespace found at end of line
(#209) Inline comments must end in full-stops, exclamation marks, or question marks
(#210) Short array syntax must be used to define arrays
(#211) Whitespace found at end of line
(#214) Short array syntax must be used to define arrays
(#218) There should be a comma after the last array item in a multi-line array.
(#221) Inline comments must end in full-stops, exclamation marks, or question marks
(#222) Short array syntax must be used to define arrays
(#226) There should be a comma after the last array item in a multi-line array.
(#236) Expected 1 space after FUNCTION keyword; 0 found
(#264) Inline comments must end in full-stops, exclamation marks, or question marks
(#268) Whitespace found at end of line
(#274) Inline comments must end in full-stops, exclamation marks, or question marks
(#280) Whitespace found at end of line
(#289) Whitespace found at end of line
(#293) Whitespace found at end of line
(#294) Short array syntax must be used to define arrays
(#295) Short array syntax must be used to define arrays
(#296) Whitespace found at end of line
(#298) Short array syntax must be used to define arrays
(#299) Whitespace found at end of line
(#302) Whitespace found at end of line
(#314) Inline comments must end in full-stops, exclamation marks, or question marks
(#316) Short array syntax must be used to define arrays
(#317) Whitespace found at end of line
(#322) Inline comments must end in full-stops, exclamation marks, or question marks
(#328) Whitespace found at end of line
(#335) Whitespace found at end of line
(#337) Whitespace found at end of line
(#338) Short array syntax must be used to define arrays
(#341) There should be a comma after the last array item in a multi-line array.
(#362) Whitespace found at end of line
(#365) Whitespace found at end of line
(#371) Whitespace found at end of line
(#382) Short array syntax must be used to define arrays
(#384) Short array syntax must be used to define arrays
(#392) Short array syntax must be used to define arrays
(#398) Only one argument is allowed per line in a multi-line function call
(#398) Only one argument is allowed per line in a multi-line function call
(#401) Short array syntax must be used to define arrays
blocks/progressanalytics/classes/observer.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#34) Opening brace must not be followed by a blank line
(#65) Inline comments must end in full-stops, exclamation marks, or question marks
(#81) Inline comments must end in full-stops, exclamation marks, or question marks
blocks/progressanalytics/classes/privacy/provider.php
(#33) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) The interface names in a "class implements" statement should be ordered alphabetically. Expected: \core_privacy\local\metadata\provider, \core_privacy\local\request\data_provider; Found: \core_privacy\local\request\data_provider, \core_privacy\local\metadata\provider
(#40) Opening brace must not be followed by a blank line
blocks/progressanalytics/db/access.php
(#27) Short array syntax must be used to define arrays
(#29) Short array syntax must be used to define arrays
(#32) Short array syntax must be used to define arrays
(#33) There should be a comma after the last array item in a multi-line array.
(#37) Short array syntax must be used to define arrays
(#41) Short array syntax must be used to define arrays
(#43) There should be a comma after the last array item in a multi-line array.
(#45) There should be a comma after the last array item in a multi-line array.
(#48) Short array syntax must be used to define arrays
(#51) Short array syntax must be used to define arrays
(#55) There should be a comma after the last array item in a multi-line array.
(#59) Short array syntax must be used to define arrays
(#62) Short array syntax must be used to define arrays
(#64) There should be a comma after the last array item in a multi-line array.
blocks/progressanalytics/db/caches.php
(#27) Short array syntax must be used to define arrays
(#28) Short array syntax must be used to define arrays
(#34) Short array syntax must be used to define arrays
blocks/progressanalytics/db/events.php
(#27) Short array syntax must be used to define arrays
(#29) Short array syntax must be used to define arrays
(#34) Short array syntax must be used to define arrays
(#39) Short array syntax must be used to define arrays
(#44) Short array syntax must be used to define arrays
blocks/progressanalytics/db/services.php
(#27) Short array syntax must be used to define arrays
(#29) Short array syntax must be used to define arrays
(#41) Short array syntax must be used to define arrays
(#42) Short array syntax must be used to define arrays
(#43) Short array syntax must be used to define arrays
(#48) There should be a comma after the last array item in a multi-line array.
blocks/progressanalytics/edit_form.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#30) Opening brace must not be followed by a blank line
blocks/progressanalytics/lang/en/block_progressanalytics.php
(#33) Unexpected comment found. Auto-fixing will not work after this comment
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
(#34) The string key "loading" is not in the correct order, it should be before "progressanalytics:viewall"
(#35) The string key "errorloadingdata" is not in the correct order, it should be before "loading"
(#39) The string key "comparison" is not in the correct order, it should be before "results"
(#41) Unexpected comment found. Auto-fixing will not work after this comment
(#41) Inline comments must end in full-stops, exclamation marks, or question marks
(#44) The string key "comparisonchartlabel" is not in the correct order, it should be before "resultschartlabel"
(#46) Unexpected comment found. Auto-fixing will not work after this comment
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) Unexpected comment found. Auto-fixing will not work after this comment
(#50) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) The string key "config_title" is not in the correct order, it should be before "privacy:metadata:core_cache"
(#52) The string key "config_includehidden" is not in the correct order, it should be before "config_title"
(#54) The string key "config_cacheinterval" is not in the correct order, it should be before "config_includehidden_desc"
(#58) The string key "config_charttype" is not in the correct order, it should be before "config_minparticipants_desc"
(#61) The string key "config_charttype_bar" is not in the correct order, it should be before "config_charttype_line"
(#64) The string key "config_progressmodules" is not in the correct order, it should be before "config_showpercentile_desc"
(#69) The string key "config_minutes_1" is not in the correct order, it should be before "config_resultslimit_desc"
(#72) The string key "config_minutes_10" is not in the correct order, it should be before "config_minutes_5"
(#78) The string key "config_participants_10" is not in the correct order, it should be before "config_participants_5"
(#82) The string key "defaultmod_assign" is not in the correct order, it should be before "defaultmod_quiz"
(#84) Unexpected comment found. Auto-fixing will not work after this comment
(#84) Inline comments must end in full-stops, exclamation marks, or question marks
(#85) The string key "blocktitle" is not in the correct order, it should be before "defaultmod_assign"
(#91) The string key "showcomparison" is not in the correct order, it should be before "showresults_desc"
(#94) Unexpected comment found. Auto-fixing will not work after this comment
(#94) Inline comments must end in full-stops, exclamation marks, or question marks
(#95) The string key "showall" is not in the correct order, it should be before "showcomparison_desc"
(#98) Unexpected comment found. Auto-fixing will not work after this comment
(#98) Inline comments must end in full-stops, exclamation marks, or question marks
(#99) The string key "js_notstarted" is not in the correct order, it should be before "showless"
(#100) The string key "js_completed" is not in the correct order, it should be before "js_notstarted"
(#105) The string key "js_myaverage" is not in the correct order, it should be before "js_quizzes"
(#106) The string key "js_courseaverage" is not in the correct order, it should be before "js_myaverage"
(#107) The string key "js_comparison_pending" is not in the correct order, it should be before "js_courseaverage"
(#112) The string key "progress_summary" is not in the correct order, it should be before "progress_tooltip_remaining"
(#114) The string key "results_dataset_label" is not in the correct order, it should be before "results_empty_message"
(#116) The string key "results_summary" is not in the correct order, it should be before "results_tooltip"
(#117) The string key "comparison_tooltip" is not in the correct order, it should be before "results_summary"
(#118) The string key "comparison_summary_with_percentile" is not in the correct order, it should be before "comparison_tooltip"
(#121) Unexpected comment found. Auto-fixing will not work after this comment
(#121) Inline comments must end in full-stops, exclamation marks, or question marks
(#122) The string key "cachedef_usermetrics" is not in the correct order, it should be before "comparison_summary_without_percentile"
(#123) The string key "cachedef_coursemetrics" is not in the correct order, it should be before "cachedef_usermetrics"
blocks/progressanalytics/lang/es/block_progressanalytics.php
(#33) Unexpected comment found. Auto-fixing will not work after this comment
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
(#34) The string key "loading" is not in the correct order, it should be before "progressanalytics:viewall"
(#35) The string key "errorloadingdata" is not in the correct order, it should be before "loading"
(#39) The string key "comparison" is not in the correct order, it should be before "results"
(#41) Unexpected comment found. Auto-fixing will not work after this comment
(#41) Inline comments must end in full-stops, exclamation marks, or question marks
(#44) The string key "comparisonchartlabel" is not in the correct order, it should be before "resultschartlabel"
(#46) Unexpected comment found. Auto-fixing will not work after this comment
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#50) Unexpected comment found. Auto-fixing will not work after this comment
(#50) Inline comments must end in full-stops, exclamation marks, or question marks
(#51) The string key "config_title" is not in the correct order, it should be before "privacy:metadata:core_cache"
(#52) The string key "config_includehidden" is not in the correct order, it should be before "config_title"
(#54) The string key "config_cacheinterval" is not in the correct order, it should be before "config_includehidden_desc"
(#58) The string key "config_charttype" is not in the correct order, it should be before "config_minparticipants_desc"
(#61) The string key "config_charttype_bar" is not in the correct order, it should be before "config_charttype_line"
(#64) The string key "config_progressmodules" is not in the correct order, it should be before "config_showpercentile_desc"
(#69) The string key "config_minutes_1" is not in the correct order, it should be before "config_resultslimit_desc"
(#72) The string key "config_minutes_10" is not in the correct order, it should be before "config_minutes_5"
(#78) The string key "config_participants_10" is not in the correct order, it should be before "config_participants_5"
(#82) The string key "defaultmod_assign" is not in the correct order, it should be before "defaultmod_quiz"
(#84) Unexpected comment found. Auto-fixing will not work after this comment
(#84) Inline comments must end in full-stops, exclamation marks, or question marks
(#85) The string key "blocktitle" is not in the correct order, it should be before "defaultmod_assign"
(#91) The string key "showcomparison" is not in the correct order, it should be before "showresults_desc"
(#94) Unexpected comment found. Auto-fixing will not work after this comment
(#94) Inline comments must end in full-stops, exclamation marks, or question marks
(#95) The string key "showall" is not in the correct order, it should be before "showcomparison_desc"
(#98) Unexpected comment found. Auto-fixing will not work after this comment
(#98) Inline comments must end in full-stops, exclamation marks, or question marks
(#99) The string key "js_notstarted" is not in the correct order, it should be before "showless"
(#100) The string key "js_completed" is not in the correct order, it should be before "js_notstarted"
(#105) The string key "js_myaverage" is not in the correct order, it should be before "js_quizzes"
(#106) The string key "js_courseaverage" is not in the correct order, it should be before "js_myaverage"
(#107) The string key "js_comparison_pending" is not in the correct order, it should be before "js_courseaverage"
(#112) The string key "progress_summary" is not in the correct order, it should be before "progress_tooltip_remaining"
(#114) The string key "results_dataset_label" is not in the correct order, it should be before "results_empty_message"
(#116) The string key "results_summary" is not in the correct order, it should be before "results_tooltip"
(#117) The string key "comparison_tooltip" is not in the correct order, it should be before "results_summary"
(#118) The string key "comparison_summary_with_percentile" is not in the correct order, it should be before "comparison_tooltip"
(#121) Unexpected comment found. Auto-fixing will not work after this comment
(#121) Inline comments must end in full-stops, exclamation marks, or question marks
(#122) The string key "cachedef_usermetrics" is not in the correct order, it should be before "comparison_summary_without_percentile"
(#123) The string key "cachedef_coursemetrics" is not in the correct order, it should be before "cachedef_usermetrics"
blocks/progressanalytics/settings.php
(#27) Blank line found at start of control structure
(#28) Whitespace found at end of line
(#43) Short array syntax must be used to define arrays
(#50) There should be a comma after the last array item in a multi-line array.
(#60) Short array syntax must be used to define arrays
(#65) There should be a comma after the last array item in a multi-line array.
(#98) Short array syntax must be used to define arrays
(#100) There should be a comma after the last array item in a multi-line array.

Javascript coding style problems

(0 errors, 4 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/progressanalytics/amd/src/charts.js
(#58) Each then() should return a value or throw (promise/always-return)
(#78) There should be no space after '{'. (@babel/object-curly-spacing)
(#78) There should be no space before '}'. (@babel/object-curly-spacing)
(#82) Each then() should return a value or throw (promise/always-return)

CSS problems

(2 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

blocks/progressanalytics/styles.css
(#61) Unexpected !important (declaration-no-important)
(#67) Unexpected !important (declaration-no-important)

PHPDocs style problems

(4 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/progressanalytics/block_progressanalytics.php
(#159) Phpdocs for function block_progressanalytics::instance_config_save has incomplete parameters list
blocks/progressanalytics/classes/external/get_course_quiz_metrics.php
(#284) Phpdocs for function get_course_quiz_metrics::calculate_course_metrics has incomplete parameters list
(#345) Phpdocs for function get_course_quiz_metrics::normalize_grade has incomplete parameters list
(#355) Phpdocs for function get_course_quiz_metrics::calculate_percentile has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]