Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(121 errors, 77 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/progressanalytics/block_progressanalytics.php
(#25) Missing docblock for class block_progressanalytics
(#25) Opening brace must not be followed by a blank line
(#40) Short array syntax must be used to define arrays
(#47) There should be a comma after the last array item in a multi-line array.
(#84) Short array syntax must be used to define arrays
(#109) global $PAGE cannot be used in block classes. Use $this->page.
(#134) Short array syntax must be used to define arrays
(#142) There should be a comma after the last array item in a multi-line array.
(#149) global $PAGE cannot be used in block classes. Use $this->page.
(#149) Short array syntax must be used to define arrays
blocks/progressanalytics/classes/external/get_course_quiz_metrics.php
(#35) Inline comments must end in full-stops, exclamation marks, or question marks
(#36) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) Missing docblock for class get_course_quiz_metrics
(#38) Opening brace must not be followed by a blank line
(#47) Short array syntax must be used to define arrays
(#59) PHP4 style constructors are not allowed; use "__construct()" instead
(#62) Inline comments must end in full-stops, exclamation marks, or question marks
(#67) Short array syntax must be used to define arrays
(#68) There should be a comma after the last array item in a multi-line array.
(#71) Short array syntax must be used to define arrays
(#83) Whitespace found at end of line
(#90) Short array syntax must be used to define arrays
(#91) Whitespace found at end of line
(#99) Short array syntax must be used to define arrays
(#100) Short array syntax must be used to define arrays
(#103) There should be a comma after the last array item in a multi-line array.
(#105) Short array syntax must be used to define arrays
(#106) Short array syntax must be used to define arrays
(#110) There should be a comma after the last array item in a multi-line array.
(#111) There should be a comma after the last array item in a multi-line array.
(#117) Short array syntax must be used to define arrays
(#148) Short array syntax must be used to define arrays
(#151) There should be a comma after the last array item in a multi-line array.
(#157) Short array syntax must be used to define arrays
(#159) There should be a comma after the last array item in a multi-line array.
(#176) Short array syntax must be used to define arrays
(#178) Whitespace found at end of line
(#182) Whitespace found at end of line
(#185) Whitespace found at end of line
(#188) Whitespace found at end of line
(#192) Whitespace found at end of line
(#196) Short array syntax must be used to define arrays
(#200) There should be a comma after the last array item in a multi-line array.
(#204) Inline comments must end in full-stops, exclamation marks, or question marks
(#206) Whitespace found at end of line
(#207) Inline comments must end in full-stops, exclamation marks, or question marks
(#208) Short array syntax must be used to define arrays
(#209) Whitespace found at end of line
(#212) Short array syntax must be used to define arrays
(#216) There should be a comma after the last array item in a multi-line array.
(#219) Inline comments must end in full-stops, exclamation marks, or question marks
(#220) Short array syntax must be used to define arrays
(#224) There should be a comma after the last array item in a multi-line array.
(#234) Expected 1 space after FUNCTION keyword; 0 found
(#262) Inline comments must end in full-stops, exclamation marks, or question marks
(#266) Whitespace found at end of line
(#272) Inline comments must end in full-stops, exclamation marks, or question marks
(#278) Whitespace found at end of line
(#287) Whitespace found at end of line
(#291) Whitespace found at end of line
(#292) Short array syntax must be used to define arrays
(#293) Short array syntax must be used to define arrays
(#294) Whitespace found at end of line
(#296) Short array syntax must be used to define arrays
(#297) Whitespace found at end of line
(#300) Whitespace found at end of line
(#312) Inline comments must end in full-stops, exclamation marks, or question marks
(#314) Short array syntax must be used to define arrays
(#315) Whitespace found at end of line
(#320) Inline comments must end in full-stops, exclamation marks, or question marks
(#326) Whitespace found at end of line
(#333) Whitespace found at end of line
(#335) Whitespace found at end of line
(#336) Short array syntax must be used to define arrays
(#339) There should be a comma after the last array item in a multi-line array.
(#360) Whitespace found at end of line
(#363) Whitespace found at end of line
(#369) Whitespace found at end of line
(#380) Short array syntax must be used to define arrays
(#382) Short array syntax must be used to define arrays
(#390) Short array syntax must be used to define arrays
(#396) Only one argument is allowed per line in a multi-line function call
(#396) Only one argument is allowed per line in a multi-line function call
(#399) Short array syntax must be used to define arrays
blocks/progressanalytics/classes/observer.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#34) Opening brace must not be followed by a blank line
(#65) Inline comments must end in full-stops, exclamation marks, or question marks
(#81) Inline comments must end in full-stops, exclamation marks, or question marks
(#86) Expected 1 newline at end of file; 0 found
blocks/progressanalytics/classes/privacy/provider.php
(#36) The interface names in a "class implements" statement should be ordered alphabetically. Expected: \core_privacy\local\metadata\provider, \core_privacy\local\request\data_provider; Found: \core_privacy\local\request\data_provider, \core_privacy\local\metadata\provider
(#38) Opening brace must not be followed by a blank line
(#113) Expected 1 newline at end of file; 0 found
blocks/progressanalytics/db/access.php
(#27) Short array syntax must be used to define arrays
(#29) Short array syntax must be used to define arrays
(#32) Short array syntax must be used to define arrays
(#33) There should be a comma after the last array item in a multi-line array.
(#37) Short array syntax must be used to define arrays
(#41) Short array syntax must be used to define arrays
(#43) There should be a comma after the last array item in a multi-line array.
(#45) There should be a comma after the last array item in a multi-line array.
(#48) Short array syntax must be used to define arrays
(#51) Short array syntax must be used to define arrays
(#55) There should be a comma after the last array item in a multi-line array.
(#59) Short array syntax must be used to define arrays
(#62) Short array syntax must be used to define arrays
(#64) There should be a comma after the last array item in a multi-line array.
(#67) Expected 1 newline at end of file; 0 found
blocks/progressanalytics/db/caches.php
(#27) Short array syntax must be used to define arrays
(#28) Short array syntax must be used to define arrays
(#34) Short array syntax must be used to define arrays
(#40) Expected 1 newline at end of file; 0 found
blocks/progressanalytics/db/events.php
(#27) Short array syntax must be used to define arrays
(#29) Short array syntax must be used to define arrays
(#34) Short array syntax must be used to define arrays
(#39) Short array syntax must be used to define arrays
(#44) Short array syntax must be used to define arrays
(#49) Expected 1 newline at end of file; 0 found
blocks/progressanalytics/db/services.php
(#27) Short array syntax must be used to define arrays
(#29) Short array syntax must be used to define arrays
(#41) Short array syntax must be used to define arrays
(#42) Short array syntax must be used to define arrays
(#43) Short array syntax must be used to define arrays
(#48) There should be a comma after the last array item in a multi-line array.
(#49) Expected 1 newline at end of file; 0 found
blocks/progressanalytics/edit_form.php
(#28) Opening brace must not be followed by a blank line
(#61) Expected 1 newline at end of file; 0 found
blocks/progressanalytics/lang/en/block_progressanalytics.php
(#31) Unexpected comment found. Auto-fixing will not work after this comment
(#31) Inline comments must end in full-stops, exclamation marks, or question marks
(#32) The string key "loading" is not in the correct order, it should be before "progressanalytics:viewall"
(#33) The string key "errorloadingdata" is not in the correct order, it should be before "loading"
(#37) The string key "comparison" is not in the correct order, it should be before "results"
(#39) Unexpected comment found. Auto-fixing will not work after this comment
(#39) Inline comments must end in full-stops, exclamation marks, or question marks
(#42) The string key "comparisonchartlabel" is not in the correct order, it should be before "resultschartlabel"
(#44) Unexpected comment found. Auto-fixing will not work after this comment
(#44) Inline comments must end in full-stops, exclamation marks, or question marks
(#48) Unexpected comment found. Auto-fixing will not work after this comment
(#48) Inline comments must end in full-stops, exclamation marks, or question marks
(#49) The string key "config_title" is not in the correct order, it should be before "privacy:metadata:core_cache"
(#50) The string key "config_includehidden" is not in the correct order, it should be before "config_title"
(#52) The string key "config_cacheinterval" is not in the correct order, it should be before "config_includehidden_desc"
(#56) The string key "config_charttype" is not in the correct order, it should be before "config_minparticipants_desc"
(#59) The string key "config_charttype_bar" is not in the correct order, it should be before "config_charttype_line"
(#62) The string key "config_progressmodules" is not in the correct order, it should be before "config_showpercentile_desc"
(#67) Unexpected comment found. Auto-fixing will not work after this comment
(#67) Inline comments must end in full-stops, exclamation marks, or question marks
(#68) The string key "blocktitle" is not in the correct order, it should be before "config_resultslimit_desc"
(#74) The string key "showcomparison" is not in the correct order, it should be before "showresults_desc"
(#77) Unexpected comment found. Auto-fixing will not work after this comment
(#77) Inline comments must end in full-stops, exclamation marks, or question marks
(#78) The string key "showall" is not in the correct order, it should be before "showcomparison_desc"
(#81) Unexpected comment found. Auto-fixing will not work after this comment
(#81) Inline comments must end in full-stops, exclamation marks, or question marks
(#82) The string key "js_notstarted" is not in the correct order, it should be before "showless"
(#83) The string key "js_completed" is not in the correct order, it should be before "js_notstarted"
(#88) The string key "js_myaverage" is not in the correct order, it should be before "js_quizzes"
(#89) The string key "js_courseaverage" is not in the correct order, it should be before "js_myaverage"
(#90) The string key "js_comparison_pending" is not in the correct order, it should be before "js_courseaverage"
blocks/progressanalytics/lang/es/block_progressanalytics.php
(#31) Unexpected comment found. Auto-fixing will not work after this comment
(#31) Inline comments must end in full-stops, exclamation marks, or question marks
(#32) The string key "loading" is not in the correct order, it should be before "progressanalytics:viewall"
(#33) The string key "errorloadingdata" is not in the correct order, it should be before "loading"
(#37) The string key "comparison" is not in the correct order, it should be before "results"
(#39) Unexpected comment found. Auto-fixing will not work after this comment
(#39) Inline comments must end in full-stops, exclamation marks, or question marks
(#42) The string key "comparisonchartlabel" is not in the correct order, it should be before "resultschartlabel"
(#44) Unexpected comment found. Auto-fixing will not work after this comment
(#44) Inline comments must end in full-stops, exclamation marks, or question marks
(#48) Unexpected comment found. Auto-fixing will not work after this comment
(#48) Inline comments must end in full-stops, exclamation marks, or question marks
(#49) The string key "config_title" is not in the correct order, it should be before "privacy:metadata:core_cache"
(#50) The string key "config_includehidden" is not in the correct order, it should be before "config_title"
(#52) The string key "config_cacheinterval" is not in the correct order, it should be before "config_includehidden_desc"
(#56) The string key "config_charttype" is not in the correct order, it should be before "config_minparticipants_desc"
(#59) The string key "config_charttype_bar" is not in the correct order, it should be before "config_charttype_line"
(#62) The string key "config_progressmodules" is not in the correct order, it should be before "config_showpercentile_desc"
(#67) Unexpected comment found. Auto-fixing will not work after this comment
(#67) Inline comments must end in full-stops, exclamation marks, or question marks
(#68) The string key "blocktitle" is not in the correct order, it should be before "config_resultslimit_desc"
(#74) The string key "showcomparison" is not in the correct order, it should be before "showresults_desc"
(#77) Unexpected comment found. Auto-fixing will not work after this comment
(#77) Inline comments must end in full-stops, exclamation marks, or question marks
(#78) The string key "showall" is not in the correct order, it should be before "showcomparison_desc"
(#81) Unexpected comment found. Auto-fixing will not work after this comment
(#81) Inline comments must end in full-stops, exclamation marks, or question marks
(#82) The string key "js_notstarted" is not in the correct order, it should be before "showless"
(#83) The string key "js_completed" is not in the correct order, it should be before "js_notstarted"
(#88) The string key "js_myaverage" is not in the correct order, it should be before "js_quizzes"
(#89) The string key "js_courseaverage" is not in the correct order, it should be before "js_myaverage"
(#90) The string key "js_comparison_pending" is not in the correct order, it should be before "js_courseaverage"
blocks/progressanalytics/settings.php
(#27) Blank line found at start of control structure
(#28) Whitespace found at end of line
(#43) Short array syntax must be used to define arrays
(#50) There should be a comma after the last array item in a multi-line array.
(#60) Short array syntax must be used to define arrays
(#65) There should be a comma after the last array item in a multi-line array.
(#98) Short array syntax must be used to define arrays
(#100) There should be a comma after the last array item in a multi-line array.

Javascript coding style problems

(0 errors, 3 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/progressanalytics/amd/src/charts.js
(#49) There should be no space after '{'. (@babel/object-curly-spacing)
(#49) There should be no space before '}'. (@babel/object-curly-spacing)
(#53) Each then() should return a value or throw (promise/always-return)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(4 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/progressanalytics/block_progressanalytics.php
(#154) Phpdocs for function block_progressanalytics::instance_config_save has incomplete parameters list
blocks/progressanalytics/classes/external/get_course_quiz_metrics.php
(#282) Phpdocs for function get_course_quiz_metrics::calculate_course_metrics has incomplete parameters list
(#343) Phpdocs for function get_course_quiz_metrics::normalize_grade has incomplete parameters list
(#353) Phpdocs for function get_course_quiz_metrics::calculate_percentile has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

blocks/progressanalytics/amd/build/charts.min.js
Uncommitted change detected.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 1 warnings)

This section shows problems detected in mustache templates [More info]

blocks/progressanalytics/templates/main.mustache
(#1) HTML Validation error, line 97: Element “style” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (></div><style>.prog)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]