Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(369 errors, 161 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/panopto/SSO.php
(#27) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#40) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#40) Expected 1 space after "as"; 2 found
(#52) Whitespace found at end of line
(#116) Line exceeds 132 characters; contains 136 characters
blocks/panopto/block_panopto.php
(#106) Line exceeds 132 characters; contains 174 characters
(#107) Expected 1 space before comment text but found 2; use block comment if you need indentation
(#129) global $PAGE cannot be used in block classes. Use $this->page.
(#144) global $PAGE cannot be used in block classes. Use $this->page.
blocks/panopto/build_category_structure.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#127) Line indented incorrectly; expected at least 8 spaces, found 7
(#127) Whitespace found at end of line
blocks/panopto/classes/admin/trim_configtext.php
(#46) Possible useless method overriding detected
blocks/panopto/classes/categorytasks.php
(#28) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#47) Whitespace found at end of line
blocks/panopto/classes/panopto_build_category_structure_form.php
(#23) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/classes/panopto_provision_form.php
(#23) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/classes/panopto_rename_all_folders_form.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/classes/panopto_unprovision_form.php
(#42) Whitespace found at end of line
(#43) Inline comments must end in full-stops, exclamation marks, or question marks
blocks/panopto/classes/panopto_upgrade_all_folders_form.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/classes/privacy/provider.php
(#2) The opening <?php tag must be followed by exactly one newline.
(#5) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#8) Whitespace found at end of line
(#10) Closing brace must be on a line by itself
(#12) Duplicate interface name "block_panopto\privacy\my_userlist" found; first defined in /var/lib/jenkins/git_repositories/prechecker/blocks/panopto/classes/privacy/provider.php on line 10
(#12) Closing brace must be on a line by itself
(#13) Whitespace found at end of line
(#16) Closing brace must be on a line by itself
(#18) Duplicate interface name "block_panopto\privacy\my_userlist_provider" found; first defined in /var/lib/jenkins/git_repositories/prechecker/blocks/panopto/classes/privacy/provider.php on line 16
(#18) Closing brace must be on a line by itself
(#22) Closing brace must be on a line by itself
(#24) Duplicate interface name "block_panopto\privacy\my_userdataprovider" found; first defined in /var/lib/jenkins/git_repositories/prechecker/blocks/panopto/classes/privacy/provider.php on line 22
(#24) Closing brace must be on a line by itself
(#27) Whitespace found at end of line
(#35) Whitespace found at end of line
(#54) Whitespace found at end of line
(#57) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#68) Whitespace found at end of line
(#79) Whitespace found at end of line
(#100) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#107) Inline comments must start with a capital letter, digit or 3-dots sequence
(#110) Whitespace found at end of line
(#123) Whitespace found at end of line
(#127) Whitespace found at end of line
(#139) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#145) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#146) Inline comments must start with a capital letter, digit or 3-dots sequence
(#150) Inline comments must end in full-stops, exclamation marks, or question marks
(#152) Whitespace found at end of line
(#163) Whitespace found at end of line
(#179) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#184) Inline comments must start with a capital letter, digit or 3-dots sequence
(#188) Inline comments must end in full-stops, exclamation marks, or question marks
(#190) Whitespace found at end of line
(#200) Whitespace found at end of line
(#217) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#218) Inline comments must start with a capital letter, digit or 3-dots sequence
(#222) Inline comments must end in full-stops, exclamation marks, or question marks
(#224) Whitespace found at end of line
blocks/panopto/classes/rollingsync.php
(#30) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#109) Inline comments must end in full-stops, exclamation marks, or question marks
(#249) Line exceeds 132 characters; contains 150 characters
blocks/panopto/classes/task/ensure_category.php
(#17) Line exceeds 132 characters; contains 141 characters
(#30) Line exceeds 132 characters; contains 139 characters
(#43) Whitespace found at end of line
(#53) Whitespace found at end of line
(#62) The use of function print_r() is forbidden
blocks/panopto/classes/task/provision_course.php
(#63) The use of function print_r() is forbidden
blocks/panopto/classes/task/sync_user.php
(#53) The use of function print_r() is forbidden
blocks/panopto/classes/task/sync_user_login.php
(#46) Whitespace found at end of line
(#52) Whitespace found at end of line
(#62) The use of function print_r() is forbidden
blocks/panopto/db/upgrade.php
(#248) Line exceeds 132 characters; contains 134 characters
(#250) Line exceeds 132 characters; contains 135 characters
(#251) Line exceeds 132 characters; contains 140 characters
(#252) Line exceeds 132 characters; contains 133 characters
(#253) Line exceeds 132 characters; contains 135 characters
(#271) Line exceeds 132 characters; contains 137 characters
(#282) Line exceeds 132 characters; contains 142 characters
(#287) Line exceeds 132 characters; contains 137 characters
(#289) Line exceeds 132 characters; contains 135 characters
(#297) Whitespace found at end of line
(#314) Whitespace found at end of line
blocks/panopto/edit_form.php
(#64) Line exceeds maximum limit of 180 characters; contains 186 characters
blocks/panopto/lib/block_panopto_bulk_lib.php
(#18) Whitespace found at end of line
(#21) Whitespace found at end of line
(#55) Whitespace found at end of line
(#60) Whitespace found at end of line
(#71) Whitespace found at end of line
(#76) Whitespace found at end of line
(#79) Whitespace found at end of line
(#80) Whitespace found at end of line
(#89) Expected "while (...) {\n"; found "while(...) {\n"
(#92) Inline comments must end in full-stops, exclamation marks, or question marks
(#93) Whitespace found at end of line
(#94) Whitespace found at end of line
(#95) Whitespace found at end of line
(#96) Whitespace found at end of line
(#98) Whitespace found at end of line
(#106) Whitespace found at end of line
(#129) Whitespace found at end of line
(#131) Whitespace found at end of line
(#133) Whitespace found at end of line
(#149) Whitespace found at end of line
(#151) Whitespace found at end of line
(#153) Inline comments must start with a capital letter, digit or 3-dots sequence
(#161) Inline comments must start with a capital letter, digit or 3-dots sequence
(#167) Whitespace found at end of line
(#180) Inline comments must start with a capital letter, digit or 3-dots sequence
(#195) Whitespace found at end of line
(#197) Whitespace found at end of line
(#198) Whitespace found at end of line
(#200) Whitespace found at end of line
(#201) Whitespace found at end of line
(#277) Whitespace found at end of line
(#293) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#295) Whitespace found at end of line
(#304) No space found before comment text; expected "// Recreate the default role mappings that were deleted by the above line." but found "//Recreate the default role mappings that were deleted by the above line."
(#314) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#323) Whitespace found at end of line
(#326) Line exceeds 132 characters; contains 144 characters
(#327) Line exceeds 132 characters; contains 151 characters
(#330) Line exceeds 132 characters; contains 138 characters
(#352) Whitespace found at end of line
(#359) Inline comments must end in full-stops, exclamation marks, or question marks
(#362) Expected "if (...) {\n"; found "if(...) {\n"
(#367) Whitespace found at end of line
(#368) Whitespace found at end of line
(#375) Line exceeds 132 characters; contains 137 characters
(#376) Whitespace found at end of line
(#377) Whitespace found at end of line
(#383) Inline comments must end in full-stops, exclamation marks, or question marks
(#390) Inline comments must start with a capital letter, digit or 3-dots sequence
(#390) Whitespace found at end of line
blocks/panopto/lib/block_panopto_lib.php
(#108) Inline comments must end in full-stops, exclamation marks, or question marks
(#172) Inline comments must end in full-stops, exclamation marks, or question marks
(#205) Inline comments must end in full-stops, exclamation marks, or question marks
(#240) Whitespace found at end of line
(#305) Inline comments must end in full-stops, exclamation marks, or question marks
(#306) Variable "retVal" must be all lower-case
(#310) Inline comments must end in full-stops, exclamation marks, or question marks
(#311) Variable "retVal" must be all lower-case
(#314) Variable "retVal" must be all lower-case
(#323) Inline comments must end in full-stops, exclamation marks, or question marks
(#324) Variable "retVal" must be all lower-case
(#327) Inline comments must end in full-stops, exclamation marks, or question marks
(#328) Variable "retVal" must be all lower-case
(#331) Variable "retVal" must be all lower-case
(#342) Expected 1 space before "=>"; 0 found
(#342) Expected 1 space after "=>"; 0 found
(#342) Expected 1 space before "=>"; 0 found
(#342) Expected 1 space after "=>"; 0 found
(#342) Line exceeds 132 characters; contains 134 characters
(#346) Whitespace found at end of line
(#358) Whitespace found at end of line
(#359) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#369) Whitespace found at end of line
(#370) Whitespace found at end of line
blocks/panopto/lib/cli/build_category_structure_cli.php
(#18) Whitespace found at end of line
(#26) Whitespace found at end of line
(#30) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#51) Whitespace found at end of line
(#52) Whitespace found at end of line
blocks/panopto/lib/cli/remove_all_panopto_adhoc_tasks.php
(#25) Whitespace found at end of line
(#29) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/lib/cli/rename_all_folders_cli.php
(#27) Whitespace found at end of line
(#31) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/lib/cli/upgrade_all_folders_cli.php
(#27) Whitespace found at end of line
(#31) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/lib/panopto_auth_soap_client.php
(#35) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#79) Line exceeds 132 characters; contains 140 characters
(#96) The use of function print_r() is forbidden
(#125) The use of function print_r() is forbidden
blocks/panopto/lib/panopto_category_data.php
(#28) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#81) Whitespace found at end of line
(#85) Line exceeds maximum limit of 180 characters; contains 198 characters
(#92) Line exceeds 132 characters; contains 136 characters
(#121) Whitespace found at end of line
(#122) Must use "self::" for local static member reference
(#122) Whitespace found at end of line
(#176) Whitespace found at end of line
(#177) Whitespace found at end of line
(#193) Line exceeds 132 characters; contains 144 characters
(#193) Whitespace found at end of line
(#204) Must use "self::" for local static member reference
(#212) Whitespace found at end of line
(#213) Expected "} else {\n"; found "} \n else {\n"
(#218) Whitespace found at end of line
(#231) Whitespace found at end of line
(#237) Whitespace found at end of line
(#244) Whitespace found at end of line
(#248) Whitespace found at end of line
(#251) Expected "while (...) {\n"; found "while(...) {\n"
(#255) Whitespace found at end of line
(#265) Line exceeds 132 characters; contains 157 characters
(#265) Inline comments must start with a capital letter, digit or 3-dots sequence
(#275) Line indented incorrectly; expected at least 20 spaces, found 18
(#284) The use of function print_r() is forbidden
(#300) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#303) Inline comments must end in full-stops, exclamation marks, or question marks
(#312) Inline comments must start with a capital letter, digit or 3-dots sequence
(#313) Expected 1 space before comment text but found 2; use block comment if you need indentation
(#317) Must use "self::" for local static member reference
(#335) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#340) Must use "self::" for local static member reference
(#342) Line indented incorrectly; expected 16 spaces, found 12
(#343) Line indented incorrectly; expected at least 20 spaces, found 16
(#344) Line indented incorrectly; expected 16 spaces, found 12
(#345) Line indented incorrectly; expected at least 20 spaces, found 16
(#346) Line indented incorrectly; expected 16 spaces, found 12
(#347) Whitespace found at end of line
(#348) Expected "} else {\n"; found "} \n else {\n"
(#349) Inline comments must end in full-stops, exclamation marks, or question marks
(#354) Expected "foreach (...) {\n"; found "foreach(...) {\n"
(#366) Whitespace found at end of line
(#368) Whitespace found at end of line
(#372) Whitespace found at end of line
blocks/panopto/lib/panopto_data.php
(#28) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#95) Whitespace found at end of line
(#110) Line exceeds 132 characters; contains 152 characters
(#115) Whitespace found at end of line
(#132) Whitespace found at end of line
(#161) Line exceeds 132 characters; contains 134 characters
(#277) Line exceeds 132 characters; contains 160 characters
(#281) Line exceeds 132 characters; contains 137 characters
(#363) Whitespace found at end of line
(#364) Inline comments must start with a capital letter, digit or 3-dots sequence
(#364) Inline comments must end in full-stops, exclamation marks, or question marks
(#367) Expected 1 space after "="; 2 found
(#369) Expected "if (...) {\n"; found "if(...) {\n"
(#369) TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
(#371) Expected "if (...) {\n"; found "if(...) {\n"
(#371) TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
(#374) Expected "} else if (...) {\n"; found "} else if(...) {\n"
(#374) Expected "if (...) {\n"; found "if(...) {\n"
(#374) TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
(#380) Inline comments must start with a capital letter, digit or 3-dots sequence
(#387) Inline comments must start with a capital letter, digit or 3-dots sequence
(#388) Line exceeds 132 characters; contains 177 characters
(#441) Whitespace found at end of line
(#444) Whitespace found at end of line
(#445) Whitespace found at end of line
(#463) The use of function print_r() is forbidden
(#471) Line indented incorrectly; expected 4 spaces, found 5
(#471) Closing brace indented incorrectly; expected 4 spaces, found 5
(#487) Line exceeds 132 characters; contains 147 characters
(#498) Whitespace found at end of line
(#499) Expected "} else if (...) {\n"; found "} \n else if (...) {\n"
(#499) Whitespace found at end of line
(#500) Whitespace found at end of line
(#506) Whitespace found at end of line
(#507) Whitespace found at end of line
(#531) Whitespace found at end of line
(#547) Line indented incorrectly; expected at least 8 spaces, found 7
(#548) Line indented incorrectly; expected at least 8 spaces, found 7
(#613) Line exceeds 132 characters; contains 138 characters
(#682) Whitespace found at end of line
(#703) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#722) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#759) Line exceeds 132 characters; contains 151 characters
(#761) Line exceeds 132 characters; contains 146 characters
(#910) Whitespace found at end of line
(#930) Whitespace found at end of line
(#938) Whitespace found at end of line
(#956) Line exceeds 132 characters; contains 144 characters
(#1287) Whitespace found at end of line
(#1288) Whitespace found at end of line
(#1293) Line exceeds 132 characters; contains 141 characters
(#1302) Line exceeds 132 characters; contains 140 characters
(#1302) Inline comments must end in full-stops, exclamation marks, or question marks
(#1303) Line exceeds 132 characters; contains 154 characters
(#1349) Inline comments must end in full-stops, exclamation marks, or question marks
(#1350) Expected 1 space before "=>"; 0 found
(#1350) Expected 1 space after "=>"; 0 found
(#1350) Expected 1 space before "=>"; 0 found
(#1350) Expected 1 space after "=>"; 0 found
(#1350) Expected 1 space before "=>"; 0 found
(#1350) Expected 1 space after "=>"; 0 found
(#1350) Line exceeds 132 characters; contains 149 characters
(#1355) Inline comments must end in full-stops, exclamation marks, or question marks
(#1435) Line indented incorrectly; expected at least 8 spaces, found 4
(#1460) Whitespace found at end of line
(#1464) The use of function error_log() is forbidden
(#1468) Line exceeds maximum limit of 180 characters; contains 257 characters
blocks/panopto/lib/panopto_session_soap_client.php
(#71) Line exceeds 132 characters; contains 150 characters
(#91) Line exceeds 132 characters; contains 153 characters
(#96) Whitespace found at end of line
(#117) Whitespace found at end of line
(#118) Whitespace found at end of line
(#121) Whitespace found at end of line
(#123) Whitespace found at end of line
(#132) Whitespace found at end of line
(#137) Line exceeds 132 characters; contains 140 characters
(#143) Whitespace found at end of line
(#167) Line exceeds 132 characters; contains 143 characters
(#173) Whitespace found at end of line
(#211) Whitespace found at end of line
(#242) Line exceeds 132 characters; contains 136 characters
(#248) Whitespace found at end of line
(#271) Whitespace found at end of line
(#297) Whitespace found at end of line
(#299) Whitespace found at end of line
(#301) Whitespace found at end of line
(#381) Whitespace found at end of line
(#383) Whitespace found at end of line
(#385) Whitespace found at end of line
(#466) Whitespace found at end of line
(#476) Line exceeds 132 characters; contains 150 characters
(#514) Whitespace found at end of line
(#521) Whitespace found at end of line
(#529) Line exceeds 132 characters; contains 134 characters
(#535) Whitespace found at end of line
(#541) Whitespace found at end of line
(#542) Whitespace found at end of line
(#556) Whitespace found at end of line
(#562) Whitespace found at end of line
(#563) Whitespace found at end of line
(#594) Whitespace found at end of line
(#594) Functions must not contain multiple empty lines in a row; found 3 empty lines
(#595) Whitespace found at end of line
(#605) Whitespace found at end of line
(#608) The use of function print_r() is forbidden
blocks/panopto/lib/panopto_timeout_soap_client.php
(#29) Member variable "socket_timeout" must not contain underscores.
(#30) Member variable "connect_timeout" must not contain underscores.
(#32) Method name "PanoptoTimeoutSoapClient::__setConnectionTimeout" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
(#32) method name "PanoptoTimeoutSoapClient::__setConnectionTimeout" is invalid; only PHP magic methods should be prefixed with a double underscore
(#32) Variable "connect_timeout" must not contain underscores.
(#33) Opening brace should be on the same line as the declaration
(#34) Variable "connect_timeout" must not contain underscores.
(#34) Variable "connect_timeout" must not contain underscores.
(#36) Expected "if (...) {\n"; found "if (...)\n {\n"
(#36) Variable "connect_timeout" must not contain underscores.
(#36) Variable "connect_timeout" must not contain underscores.
(#41) Variable "connect_timeout" must not contain underscores.
(#44) Method name "PanoptoTimeoutSoapClient::__setSocketTimeout" is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
(#44) method name "PanoptoTimeoutSoapClient::__setSocketTimeout" is invalid; only PHP magic methods should be prefixed with a double underscore
(#44) Variable "socket_timeout" must not contain underscores.
(#45) Opening brace should be on the same line as the declaration
(#46) Variable "socket_timeout" must not contain underscores.
(#46) Variable "socket_timeout" must not contain underscores.
(#48) Expected "if (...) {\n"; found "if (...)\n {\n"
(#48) Variable "socket_timeout" must not contain underscores.
(#48) Variable "socket_timeout" must not contain underscores.
(#53) Variable "socket_timeout" must not contain underscores.
(#56) method name "PanoptoTimeoutSoapClient::__doRequest" is invalid; only PHP magic methods should be prefixed with a double underscore
(#56) Variable "one_way" must not contain underscores.
(#56) TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
(#57) Opening brace should be on the same line as the declaration
(#59) Expected "if (...) {\n"; found "if (...)\n {\n"
(#61) Inline comments must end in full-stops, exclamation marks, or question marks
(#62) Variable "one_way" must not contain underscores.
(#64) Expected "} else {\n"; found "}\n else\n {\n"
(#69) TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
(#70) TRUE, FALSE and NULL must be lowercase; expected "true" but found "TRUE"
(#71) TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE"
(#80) Expected "if (...) {\n"; found "if(...) {\n"
(#83) Whitespace found at end of line
(#83) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#84) Whitespace found at end of line
(#93) Expected "if (...) {\n"; found "if (...)\n {\n"
(#93) Variable "one_way" must not contain underscores.
blocks/panopto/lib/panopto_user_soap_client.php
(#80) Line exceeds 132 characters; contains 150 characters
(#113) The use of function print_r() is forbidden
(#139) The use of function print_r() is forbidden
(#157) Whitespace found at end of line
(#192) The use of function print_r() is forbidden
(#228) The use of function print_r() is forbidden
(#249) Whitespace found at end of line
(#256) The use of function print_r() is forbidden
blocks/panopto/panopto_content.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#40) Whitespace found at end of line
(#42) Whitespace found at end of line
(#52) Whitespace found at end of line
(#53) Whitespace found at end of line
(#57) Whitespace found at end of line
(#63) Expected "try {\n...} catch (...) {\n"; found "try {\n...} catch (...) {\n"
(#81) Line exceeds 132 characters; contains 148 characters
(#109) Whitespace found at end of line
(#110) Expected "} else if (...) {\n"; found "} \n else if (...) { \n"
(#110) Whitespace found at end of line
(#111) Whitespace found at end of line
(#113) Whitespace found at end of line
(#114) Expected "} else {\n"; found "} \n else {\n"
(#127) Inline comments must end in full-stops, exclamation marks, or question marks
(#231) Line exceeds 132 characters; contains 147 characters
(#232) Line exceeds 132 characters; contains 138 characters
blocks/panopto/provision_course.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#158) Line exceeds 132 characters; contains 136 characters
(#161) Line exceeds 132 characters; contains 168 characters
blocks/panopto/provision_course_internal.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#54) Inline comments must start with a capital letter, digit or 3-dots sequence
blocks/panopto/reinitialize_imports.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#62) Variable "NO_COURSE_EXISTS" must be all lower-case
(#62) Variable "NO_COURSE_EXISTS" must not contain underscores.
(#63) Variable "INVALID_PANOPTO_DATA" must be all lower-case
(#63) Variable "INVALID_PANOPTO_DATA" must not contain underscores.
(#87) Variable "NO_COURSE_EXISTS" must be all lower-case
(#87) Variable "NO_COURSE_EXISTS" must not contain underscores.
(#87) Variable "INVALID_PANOPTO_DATA" must be all lower-case
(#87) Variable "INVALID_PANOPTO_DATA" must not contain underscores.
(#87) Line exceeds 132 characters; contains 136 characters
(#96) Variable "NO_COURSE_EXISTS" must be all lower-case
(#96) Variable "NO_COURSE_EXISTS" must not contain underscores.
(#97) Variable "INVALID_PANOPTO_DATA" must be all lower-case
(#97) Variable "INVALID_PANOPTO_DATA" must not contain underscores.
blocks/panopto/rename_all_folders.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/settings.php
(#27) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#138) Inline comments must end in full-stops, exclamation marks, or question marks
(#149) Inline comments must end in full-stops, exclamation marks, or question marks
(#318) Whitespace found at end of line
(#329) Line exceeds 132 characters; contains 133 characters
blocks/panopto/unprovision_course.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#104) Whitespace found at end of line
blocks/panopto/unprovision_course_internal.php
(#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/upgrade_all_folders.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#69) Inline comments must start with a capital letter, digit or 3-dots sequence
(#69) Whitespace found at end of line
blocks/panopto/views/bulk_rename_single_failed.html.php
(#18) Whitespace found at end of line
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/views/bulk_rename_single_success.html.php
(#18) Whitespace found at end of line
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/views/bulk_task_access_error.html.php
(#18) Whitespace found at end of line
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/views/bulk_task_progress_bar.html.php
(#18) Whitespace found at end of line
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/views/bulk_task_rename_warning.html.php
(#18) Whitespace found at end of line
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/views/bulk_task_reprovision_warning.html.php
(#18) Whitespace found at end of line
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/views/bulk_task_version_error.html.php
(#18) Whitespace found at end of line
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/views/ensure_category_branch_failed.html.php
(#18) Whitespace found at end of line
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#26) Line exceeds 132 characters; contains 139 characters
(#26) Line exceeds 132 characters; contains 139 characters
(#26) Line exceeds 132 characters; contains 139 characters
(#26) Line exceeds 132 characters; contains 139 characters
(#26) Line exceeds 132 characters; contains 139 characters
(#26) Line exceeds 132 characters; contains 139 characters
(#26) Line exceeds 132 characters; contains 139 characters
blocks/panopto/views/ensure_category_branch_start.html.php
(#18) Whitespace found at end of line
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#36) Line indented incorrectly; expected at least 16 spaces, found 12
(#40) Line indented incorrectly; expected at least 16 spaces, found 12
(#42) A closing tag is not permitted at the end of a PHP file
blocks/panopto/views/ensure_category_branch_success.html.php
(#18) Whitespace found at end of line
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
blocks/panopto/views/imported_course.html.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#45) Line indented incorrectly; expected at least 20 spaces, found 16
(#55) Line indented incorrectly; expected at least 24 spaces, found 20
(#61) Line indented incorrectly; expected at least 24 spaces, found 20
(#66) Variable "NO_COURSE_EXISTS" must be all lower-case
(#66) Variable "NO_COURSE_EXISTS" must not contain underscores.
blocks/panopto/views/provisioned_course.html.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#41) Line indented incorrectly; expected at least 20 spaces, found 16
(#42) Whitespace found at end of line
(#43) Expected "} else if (...) {\n"; found "} \n else if (...) {\n"
(#53) Line indented incorrectly; expected at least 20 spaces, found 16
(#54) Whitespace found at end of line
(#55) Expected "} else if (...) {\n"; found "} \n else if (...) {\n"
(#65) Line indented incorrectly; expected at least 20 spaces, found 16
(#67) Expected "} else {\n"; found "}\n else {\n"
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#73) Line exceeds 132 characters; contains 135 characters
(#76) Expected "if (...) {\n"; found "if(...) { ?>\n"
(#86) Line indented incorrectly; expected 24 spaces, found 28
(#88) Line indented incorrectly; expected 24 spaces, found 28
(#90) Line indented incorrectly; expected 24 spaces, found 28
(#96) Line indented incorrectly; expected 24 spaces, found 28
(#98) Line indented incorrectly; expected 24 spaces, found 28
(#100) Line indented incorrectly; expected 24 spaces, found 28
(#106) Line indented incorrectly; expected 24 spaces, found 28
(#108) Line indented incorrectly; expected 24 spaces, found 28
(#110) Line indented incorrectly; expected 24 spaces, found 28
(#120) Line indented incorrectly; expected at least 20 spaces, found 16
blocks/panopto/views/unprovisioned_course.html.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#30) Whitespace found at end of line
(#40) Line indented incorrectly; expected at least 16 spaces, found 12
(#40) Whitespace found at end of line
(#44) Line indented incorrectly; expected at least 16 spaces, found 12

Javascript coding style problems

(1 errors, 2 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/panopto/yui/asyncload/asyncload.js
(#1) 'YUI' is not defined. (no-undef)
(#4) Identifier 'block_panopto' is not in camel case. (camelcase)
(#41) Expected space(s) after "catch". (keyword-spacing)

CSS problems

(19 errors, 3 warnings)

This section shows CSS problems detected by stylelint [More info]

blocks/panopto/styles.css
(#1) Expected single space before "{" (block-opening-brace-space-before)
(#8) Expected single space before "{" (block-opening-brace-space-before)
(#13) Expected single space before "{" (block-opening-brace-space-before)
(#19) Expected single space before "{" (block-opening-brace-space-before)
(#24) Expected single space before "{" (block-opening-brace-space-before)
(#32) Expected single space before "{" (block-opening-brace-space-before)
(#37) Expected single space before "{" (block-opening-brace-space-before)
(#42) Expected single space before "{" (block-opening-brace-space-before)
(#47) Expected single space before "{" (block-opening-brace-space-before)
(#53) Expected single space before "{" (block-opening-brace-space-before)
(#59) Expected single space before "{" (block-opening-brace-space-before)
(#64) Expected single space before "{" (block-opening-brace-space-before)
(#69) Expected single space before "{" (block-opening-brace-space-before)
(#74) Expected single space before "{" (block-opening-brace-space-before)
(#79) Expected single space before "{" (block-opening-brace-space-before)
(#85) Expected single space before "{" (block-opening-brace-space-before)
(#93) Expected single space before "{" (block-opening-brace-space-before)
(#3) Expected "#C0C0C0" to be "#c0c0c0" (color-hex-case)
(#61) Expected "#F0F0F0" to be "#f0f0f0" (color-hex-case)
(#96) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#97) Unexpected unit (length-zero-no-unit)
(#84) Unexpected whitespace at end of line (no-eol-whitespace)

PHPDocs style problems

(82 errors, 1 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/panopto/build_category_structure.php
(#69) Phpdocs for function build_category_structure has incomplete parameters list
blocks/panopto/classes/categorytasks.php
(#44) Phpdocs for function block_panopto_categorytasks::coursecategorycreated has incomplete parameters list
blocks/panopto/classes/panopto_build_category_structure_form.php
(#25) Class panopto_build_category_structure_form is not documented
blocks/panopto/classes/panopto_provision_form.php
(#25) Class panopto_provision_form is not documented
blocks/panopto/classes/panopto_rename_all_folders_form.php
(#26) Class panopto_rename_all_folders_form is not documented
blocks/panopto/classes/panopto_unprovision_form.php
(#16) Package is not specified for class panopto_unprovision_form. It is also not specified in file-level phpdocs
blocks/panopto/classes/panopto_upgrade_all_folders_form.php
(#26) Class panopto_upgrade_all_folders_form is not documented
blocks/panopto/classes/privacy/provider.php
(#27) Package is not specified for class provider. It is also not specified in file-level phpdocs
(#2) Empty line found after PHP open tag
(#3) File-level phpdocs block is not found
(#27) Class provider is not documented
(#36) Function provider::get_metadata is not documented
(#204) Phpdocs for function provider::delete_data_for_all_users_in_context has incomplete parameters list
blocks/panopto/classes/rollingsync.php
(#173) Phpdocs for function block_panopto_rollingsync::roleassigned has incomplete parameters list
(#199) Phpdocs for function block_panopto_rollingsync::roleunassigned has incomplete parameters list
blocks/panopto/lib/block_panopto_bulk_lib.php
(#35) Function panopto_update_task_progress is not documented
(#86) Function panopto_bulk_update_progress_bar is not documented
(#17) No one-line description found in phpdocs for file
(#53) Phpdocs for function panopto_handle_bulk_throttle has incomplete parameters list
(#67) Phpdocs for function panopto_bulk_display_access_error has incomplete parameters list
(#104) Phpdocs for function panopto_bulk_process_folders has incomplete parameters list
(#127) Phpdocs for function panopto_bulk_reprovision_callback has incomplete parameters list
(#147) Phpdocs for function panopto_bulk_rename_callback has incomplete parameters list
(#193) Phpdocs for function panopto_bulk_sanitize_and_get_mappings has incomplete parameters list
(#355) Phpdocs for function panopto_rename_all_folders has incomplete parameters list
(#379) Phpdocs for function panopto_upgrade_all_folders has incomplete parameters list
blocks/panopto/lib/block_panopto_lib.php
(#33) Function panopto_alert_user is not documented
(#126) Function panopto_get_configured_panopto_servers is not documented
(#334) Function panopto_get_all_roles_at_context_and_contextlevel is not documented
(#103) Phpdocs for function panopto_generate_wsdl_service_params has incomplete parameters list
(#277) Phpdocs for function panopto_instantiate_auth_soap_client has incomplete parameters list
blocks/panopto/lib/cli/build_category_structure_cli.php
(#17) No one-line description found in phpdocs for file
(#54) Phpdocs for function build_panopto_category_structure has incomplete parameters list
blocks/panopto/lib/cli/remove_all_panopto_adhoc_tasks.php
(#46) Function remove_panopto_adhoc_tasks is not documented
blocks/panopto/lib/cli/rename_all_folders_cli.php
(#17) No one-line description found in phpdocs for file
blocks/panopto/lib/cli/upgrade_all_folders_cli.php
(#17) No one-line description found in phpdocs for file
blocks/panopto/lib/panopto_auth_soap_client.php
(#40) Class panopto_auth_soap_client is not documented
blocks/panopto/lib/panopto_category_data.php
(#289) Function panopto_category_data::save_category_data_to_table is not documented
(#328) Function panopto_category_data::build_category_structure is not documented
(#362) Function panopto_category_data::update_category_row is not documented
(#92) Phpdocs for function panopto_category_data::__construct has incomplete parameters list
(#171) Phpdocs for function panopto_category_data::get_panopto_category_id has incomplete parameters list
(#192) Phpdocs for function panopto_category_data::ensure_category_branch has incomplete parameters list
blocks/panopto/lib/panopto_data.php
(#152) Function panopto_data::remove_all_panopto_adhoc_tasks is not documented
(#551) Function panopto_data::get_new_folder_name is not documented
(#1286) Function panopto_data::has_valid_panopto is not documented
(#1410) Function panopto_data::unset_course_role_permissions is not documented
(#1426) Function panopto_data::is_server_alive is not documented
(#1449) Function panopto_data::print_log is not documented
(#1478) Function panopto_data::print_log_verbose is not documented
(#120) There is no description in phpdocs for function getpossiblefoldernamestyles
(#130) There is no description in phpdocs for function getpossibleprovisiontypes
(#140) There is no description in phpdocs for function getpossiblessosynctypes
(#215) Phpdocs for function panopto_data::get_role_from_context has incomplete parameters list
(#277) Phpdocs for function panopto_data::ensure_user_manager has incomplete parameters list
(#299) Phpdocs for function panopto_data::provision_course has incomplete parameters list
(#734) Phpdocs for function panopto_data::sync_external_user has incomplete parameters list
(#874) Phpdocs for function panopto_data::get_session_list has incomplete parameters list
(#1113) Phpdocs for function panopto_data::set_course_foldermap has incomplete parameters list
(#1236) Phpdocs for function panopto_data::delete_panopto_relation has incomplete parameters list
blocks/panopto/lib/panopto_session_soap_client.php
(#39) Class panopto_session_soap_client is not documented
(#95) Function panopto_session_soap_client::add_folder is not documented
(#122) Function panopto_session_soap_client::unprovision_external_course is not documented
(#142) Function panopto_session_soap_client::provision_external_course_with_roles is not documented
(#172) Function panopto_session_soap_client::set_external_course_access_for_roles is not documented
(#210) Function panopto_session_soap_client::set_copied_external_course_access_for_roles is not documented
(#247) Function panopto_session_soap_client::get_folders_by_id is not documented
(#270) Function panopto_session_soap_client::get_folders_by_external_id is not documented
(#465) Function panopto_session_soap_client::get_session_list is not documented
(#513) Function panopto_session_soap_client::ensure_category_branch is not documented
(#534) Function panopto_session_soap_client::update_folder_parent is not documented
(#555) Function panopto_session_soap_client::update_folder_name is not documented
(#577) Function panopto_session_soap_client::get_recorder_download_urls is not documented
(#591) Function panopto_session_soap_client::handle_error is not documented
blocks/panopto/lib/panopto_timeout_soap_client.php
(#27) Class PanoptoTimeoutSoapClient is not documented
(#32) Function PanoptoTimeoutSoapClient::__setConnectionTimeout is not documented
(#44) Function PanoptoTimeoutSoapClient::__setSocketTimeout is not documented
(#56) Function PanoptoTimeoutSoapClient::__doRequest is not documented
(#29) Variable PanoptoTimeoutSoapClient::$socket_timeout is not documented
(#30) Variable PanoptoTimeoutSoapClient::$connect_timeout is not documented
blocks/panopto/lib/panopto_user_soap_client.php
(#39) Class panopto_user_soap_client is not documented
blocks/panopto/reinitialize_imports.php
(#32) Class panopto_reinitialize_imports_form is not documented
(#59) Function reinitialize_all_imports is not documented

Update savepoints problems

(0 errors, 1 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

blocks/panopto/db/upgrade.php
Detected fewer 'if' blocks (8) than 'savepoint' calls (9). Repeated savepoints?

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]