Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(40 errors, 13 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/opencast/addvideo.php
(#59) Line exceeds 132 characters; contains 134 characters
blocks/opencast/backup/moodle2/restore_opencast_block_task.class.php
(#80) Line exceeds 132 characters; contains 156 characters
(#127) Inline comments must end in full-stops, exclamation marks, or question marks
blocks/opencast/backup/moodle2/settings/block_backup_setting.class.php
(#54) Inline comments must start with a capital letter, digit or 3-dots sequence
(#54) Inline comments must end in full-stops, exclamation marks, or question marks
blocks/opencast/backup/moodle2/settings/block_restore_setting.class.php
(#36) Closing brace must be on a line by itself
blocks/opencast/changevisibility.php
(#102) Line exceeds 132 characters; contains 143 characters
blocks/opencast/classes/admin_form.php
(#82) Expected 1 space after "="; 3 found
(#83) Expected 1 space after "="; 4 found
(#103) Expected 1 space after "="; 3 found
(#104) Expected 1 space after "="; 4 found
blocks/opencast/classes/local/apibridge.php
(#227) Line indented incorrectly; expected 12 spaces, found 16
(#230) Line indented incorrectly; expected 12 spaces, found 16
(#232) Line indented incorrectly; expected 12 spaces, found 16
(#234) Line indented incorrectly; expected 12 spaces, found 16
(#237) Line indented incorrectly; expected 12 spaces, found 16
(#364) Expected "try {\n...} catch (...) {\n"; found "try {\n...} catch (...){\n"
(#472) Expected 1 space before "="; 0 found
(#489) Space found before semicolon; expected "'/';" but found "'/' ;"
(#1003) Closing brace must be on a line by itself
(#1004) Closing brace must be on a line by itself
(#1005) Closing brace must be on a line by itself
(#1063) Inline control structures are not allowed
(#1105) Expected "if (...) {\n"; found "if (...){\n"
blocks/opencast/classes/local/flexible_table.php
(#43) Visibility must be declared on method "print_nothing_to_display"
blocks/opencast/classes/local/visibility_form.php
(#65) Expected 1 space before "="; 0 found
(#65) Expected 1 space after "="; 0 found
blocks/opencast/classes/task/process_duplicate_event.php
(#73) Whitespace found at end of line
(#73) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#86) No space found before comment text; expected "// Should not happen as seriesid is checked during restore." but found "//Should not happen as seriesid is checked during restore."
blocks/opencast/index.php
(#190) Line exceeds 132 characters; contains 146 characters
blocks/opencast/renderer.php
(#214) Line exceeds 132 characters; contains 133 characters
(#292) Line exceeds 132 characters; contains 133 characters
(#317) Expected 1 space before "="; 0 found
(#318) Expected 1 space before "="; 0 found
(#322) Expected 1 space before "="; 0 found
blocks/opencast/tests/backup_test.php
(#76) Line exceeds 132 characters; contains 149 characters
blocks/opencast/tests/delete_file_test.php
(#76) Variable "draftid_editor" must not contain underscores.
(#77) Variable "draftid_editor" must not contain underscores.
(#78) Variable "draftid_editor" must not contain underscores.
(#84) Variable "draftid_editor" must not contain underscores.
(#85) Variable "draftid_editor" must not contain underscores.
(#86) Variable "draftid_editor" must not contain underscores.
(#92) Inline comments must end in full-stops, exclamation marks, or question marks
(#95) Inline comments must end in full-stops, exclamation marks, or question marks
(#99) Variable "draftid_editor" must not contain underscores.
(#100) Variable "draftid_editor" must not contain underscores.
(#101) Variable "draftid_editor" must not contain underscores.
(#135) Variable "draftid_editor" must not contain underscores.
(#136) Variable "draftid_editor" must not contain underscores.
(#137) Variable "draftid_editor" must not contain underscores.
(#153) Inline comments must end in full-stops, exclamation marks, or question marks
blocks/opencast/tests/privacy_test.php
(#482) Functions must not contain multiple empty lines in a row; found 2 empty lines

Javascript coding style problems

(3 errors, 97 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/opencast/tests/fixtures/get_course_videos.js
(#1) Line 1 exceeds the maximum line length of 132. (max-len)
(#1) Expected an assignment or function call and instead saw an expression. (no-unused-expressions)
(#1) Missing space before value for key 'identifier'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'creator'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'presenter'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'created'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'is_part_of'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'subjects'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'start'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'description'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'language'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'source'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'title'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'processing_state'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'duration'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'license'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'archive_version'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'contributor'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'series'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'rights'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'has_previews'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'location'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'rightsholder'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'publication_status'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'status'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'identifier'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'creator'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'presenter'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'created'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'is_part_of'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'subjects'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'start'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'description'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'language'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'source'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'title'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'processing_state'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'duration'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'license'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'archive_version'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'contributor'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'series'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'rights'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'has_previews'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'location'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'rightsholder'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'publication_status'. (key-spacing)
(#1) A space is required after ','. (comma-spacing)
(#1) Missing space before value for key 'status'. (key-spacing)
(#1) Missing semicolon. (semi)

CSS problems

(7 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

blocks/opencast/styles.css
(#33) Expected single space before "{" (block-opening-brace-space-before)
(#2) Expected a trailing semicolon (declaration-block-trailing-semicolon)
(#34) Expected a trailing semicolon (declaration-block-trailing-semicolon)
(#38) Expected a trailing semicolon (declaration-block-trailing-semicolon)
(#34) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#38) Expected single space after ":" with a single-line declaration (declaration-colon-space-after)
(#38) Expected indentation of 4 spaces (indentation)

PHPDocs style problems

(127 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/opencast/addvideo.php
(#19) Invalid inline phpdocs tag @package found
blocks/opencast/backup/moodle2/backup_opencast_stepslib.php
(#39) Function backup_opencast_block_structure_step::define_structure is not documented
blocks/opencast/backup/moodle2/restore_opencast_block_task.class.php
(#31) Class restore_opencast_block_task is not documented
blocks/opencast/backup/moodle2/restore_opencast_stepslib.php
(#40) Variable restore_opencast_block_structure_step::$backupeventids is not documented
(#41) Variable restore_opencast_block_structure_step::$missingeventids is not documented
(#42) Variable restore_opencast_block_structure_step::$seriesid is not documented
blocks/opencast/block_opencast.php
(#26) Class block_opencast is not documented
(#28) Function block_opencast::init is not documented
(#32) Function block_opencast::applicable_formats is not documented
(#36) Function block_opencast::instance_allow_multiple is not documented
(#40) Function block_opencast::has_config is not documented
(#44) Function block_opencast::get_content is not documented
blocks/opencast/classes/admin_form.php
(#35) Class admin_form is not documented
(#36) Function admin_form::definition is not documented
blocks/opencast/classes/event/upload_failed.php
(#28) Class upload_failed is not documented
blocks/opencast/classes/event/upload_succeeded.php
(#28) Class upload_succeeded is not documented
blocks/opencast/classes/groupaccess.php
(#17) File-level phpdocs block is not found
(#28) Class groupaccess is not documented
(#28) Package is not specified for class groupaccess. It is also not specified in file-level phpdocs
(#23) Package tool_opencast is not valid
blocks/opencast/classes/local/addvideo_form.php
(#34) Class addvideo_form is not documented
(#36) Function addvideo_form::definition is not documented
blocks/opencast/classes/local/apibridge.php
(#40) Class apibridge is not documented
(#48) Function apibridge::__construct is not documented
(#242) Function apibridge::get_opencast_video is not documented
(#42) Variable apibridge::$config is not documented
(#44) Variable apibridge::$workflows is not documented
(#46) Variable apibridge::$testing is not documented
(#921) There is no description in phpdocs for function change_visibility
(#213) Phpdocs for function apibridge::extend_video_status has incomplete parameters list
(#481) Phpdocs for function apibridge::get_pattern_for_group_placeholder has incomplete parameters list
(#494) Phpdocs for function apibridge::get_default_seriestitle has incomplete parameters list
(#506) Phpdocs for function apibridge::create_course_series has incomplete parameters list
(#592) Phpdocs for function apibridge::update_course_series has incomplete parameters list
(#653) Phpdocs for function apibridge::unset_course_series has incomplete parameters list
(#665) Phpdocs for function apibridge::ensure_series_is_valid has incomplete parameters list
(#711) Phpdocs for function apibridge::create_event has incomplete parameters list
(#778) Phpdocs for function apibridge::ensure_event_exists has incomplete parameters list
(#855) Phpdocs for function apibridge::can_delete_acl_group_assignment has incomplete parameters list
(#922) Phpdocs for function apibridge::change_visibility has incomplete parameters list
(#1081) Phpdocs for function apibridge::is_event_visible has incomplete parameters list
(#1166) Phpdocs for function apibridge::start_workflow has incomplete parameters list
(#1215) Phpdocs for function apibridge::check_if_workflow_exists has incomplete parameters list
(#1292) Phpdocs for function apibridge::can_delete_event_assignment has incomplete parameters list
(#56) Not recommended phpdocs tag @staticvar used
blocks/opencast/classes/local/createseries_form.php
(#34) Class createseries_form is not documented
(#36) Function createseries_form::definition is not documented
blocks/opencast/classes/local/editseries_form.php
(#32) Class editseries_form is not documented
(#34) Function editseries_form::definition is not documented
blocks/opencast/classes/local/event.php
(#29) Class event is not documented
(#42) Function event::add_meta_data is not documented
(#31) Variable event::$acl is not documented
(#32) Variable event::$metadatafields is not documented
(#33) Variable event::$presentation is not documented
(#110) Phpdocs for function event::has_acl has incomplete parameters list
(#122) Phpdocs for function event::remove_acl has incomplete parameters list
(#214) Phpdocs for function event::create_duplication_task has incomplete parameters list
blocks/opencast/classes/local/file_system_filedir.php
(#17) No one-line description found in phpdocs for file
(#32) No one-line description found in phpdocs for class file_system_filedir
blocks/opencast/classes/local/notifications.php
(#41) Phpdocs for function notifications::send_message has incomplete parameters list
(#99) Phpdocs for function notifications::notify_missing_events has incomplete parameters list
blocks/opencast/classes/local/upload_helper.php
(#31) Class upload_helper is not documented
(#43) Function upload_helper::__construct is not documented
(#47) Function upload_helper::get_status_string is not documented
(#208) Function upload_helper::upload_failed is not documented
(#41) Variable upload_helper::$apibridge is not documented
(#33) Constant upload_helper::OC_FILEAREA is not documented
(#34) Constant upload_helper::STATUS_READY_TO_UPLOAD is not documented
(#35) Constant upload_helper::STATUS_CREATING_GROUP is not documented
(#36) Constant upload_helper::STATUS_CREATING_SERIES is not documented
(#37) Constant upload_helper::STATUS_CREATING_EVENT is not documented
(#38) Constant upload_helper::STATUS_UPLOADED is not documented
(#39) Constant upload_helper::STATUS_TRANSFERRED is not documented
(#17) No one-line description found in phpdocs for file
(#95) Phpdocs for function upload_helper::save_upload_jobs has incomplete parameters list
blocks/opencast/classes/local/visibility_form.php
(#36) Class visibility_form is not documented
(#38) Function visibility_form::definition is not documented
blocks/opencast/classes/opencast_state_exception.php
(#17) File-level phpdocs block is not found
(#23) No one-line description found in phpdocs for class opencast_state_exception
(#29) Incorrect path for phpdocs tag @group detected
(#28) Category is not valid
blocks/opencast/classes/privacy/provider.php
(#47) Phpdocs for function provider::get_metadata has incomplete parameters list
blocks/opencast/classes/task/process_delete_cron.php
(#27) Class process_delete_cron is not documented
(#29) Function process_delete_cron::get_name is not documented
(#33) Function process_delete_cron::execute is not documented
(#17) No one-line description found in phpdocs for file
blocks/opencast/classes/task/process_upload_cron.php
(#25) Class process_upload_cron is not documented
(#27) Function process_upload_cron::get_name is not documented
(#31) Function process_upload_cron::execute is not documented
(#17) No one-line description found in phpdocs for file
blocks/opencast/createseries.php
(#19) Invalid inline phpdocs tag @package found
blocks/opencast/db/upgrade.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @copyright tag
(#18) Package blocks_opencast is not valid
blocks/opencast/editseries.php
(#19) Invalid inline phpdocs tag @package found
blocks/opencast/renderer.php
(#35) Constant block_opencast_renderer::VISIBLE is not documented
(#36) Constant block_opencast_renderer::MIXED_VISIBLITY is not documented
(#37) Constant block_opencast_renderer::HIDDEN is not documented
(#38) Constant block_opencast_renderer::GROUP is not documented
(#83) Phpdocs for function block_opencast_renderer::render_block_content has incomplete parameters list
(#159) Phpdocs for function block_opencast_renderer::render_upload_jobs has incomplete parameters list
(#193) Phpdocs for function block_opencast_renderer::render_delete_acl_group_assignment_icon has incomplete parameters list
(#209) Phpdocs for function block_opencast_renderer::render_change_visibility_icon has incomplete parameters list
(#288) Phpdocs for function block_opencast_renderer::render_delete_event_icon has incomplete parameters list
(#30) Package block_customcomments is not valid
blocks/opencast/tests/backup_test.php
(#56) Function block_opencast_backup_testcase::get_backup_filepath is not documented
(#61) Function block_opencast_backup_testcase::get_backup_filename is not documented
(#152) Function block_opencast_backup_testcase::check_task_fail_with_error is not documented
(#70) Phpdocs for function block_opencast_backup_testcase::backup_course has incomplete parameters list
(#98) Phpdocs for function block_opencast_backup_testcase::restore_course has incomplete parameters list
(#131) Phpdocs for function block_opencast_backup_testcase::execute_adhoc_task has incomplete parameters list
(#43) Phpdocs for variable block_opencast_backup_testcase::$apiurl does not contain @var or incorrect
blocks/opencast/tests/generator/lib.php
(#24) Class block_opencast_generator is not documented
(#26) Function block_opencast_generator::create_file is not documented
(#17) No one-line description found in phpdocs for file
blocks/opencast/tests/helper/apibridge_testable.php
(#17) File-level phpdocs block is not found
(#21) Class block_opencast_apibridge_testable is not documented
(#196) Function block_opencast_apibridge_testable::get_course_series is not documented
(#206) Function block_opencast_apibridge_testable::check_if_workflow_exists is not documented
(#210) Function block_opencast_apibridge_testable::start_workflow is not documented
(#26) Constant block_opencast_apibridge_testable::DUPLICATE_WORKFLOW is not documented
(#21) Package is not specified for class block_opencast_apibridge_testable. It is also not specified in file-level phpdocs
blocks/opencast/tests/roles_test.php
(#28) Class block_opencast_roles_testcase is not documented
(#17) No one-line description found in phpdocs for file
blocks/opencast/tests/upload_test.php
(#26) Class block_opencast_upload_testcase is not documented
(#28) Variable block_opencast_upload_testcase::$apiurl is not documented
(#29) Variable block_opencast_upload_testcase::$apiusername is not documented
(#30) Variable block_opencast_upload_testcase::$apipassword is not documented
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]