Comments

• 

  Davo Smith

  Tue, 16 June 2020, 12:56 AM

  Checks suggest this is still working fine with Moodle 3.9.
• 

  Aysenur Kazokoglu

  Thu, 24 Sept 2020, 8:37 PM

  hi,
  
  in our moodle with adaptable as theme, the plugin isn't working properly. as i understand the readme file correctly, we have to change the file renderers.php from the theme folder. in this file the lines connected to the footer are:
  
  public function get_footer_blocks($layoutrow = 'footerlayoutrow') {
  global $PAGE, $OUTPUT;
  $fields = array();
  $blockcount = 0;
  $style = '';
  
  if (!$this->get_footer_visibility()) {
  return '';
  }
  
  $output = '

  ' . $OUTPUT->course_footer() . '

  ';
  
  for ($i = 1; $i <= 3; $i++) {
  $footerrow = $layoutrow . $i;
  $footerrow = $PAGE->theme->settings->$footerrow;
  if ($footerrow != '0-0-0-0') {
  $fields[] = $footerrow;
  }
  }
  
  foreach ($fields as $field) {
  $output .= '

  ';
  $vals = explode('-', $field);
  foreach ($vals as $val) {
  if ($val > 0) {
  $blockcount ++;
  $footerheader = 'footer' . $blockcount . 'header';
  $footercontent = 'footer' . $blockcount . 'content';
  if (!empty($PAGE->theme->settings->$footercontent)) {
  $output .= '

  ';
  if (!empty($PAGE->theme->settings->$footerheader)) {
  $output .= '

  ';
  $output .= $OUTPUT->get_setting($footerheader, 'format_text');
  $output .= '

  ';
  }
  $output .= $OUTPUT->get_setting($footercontent, 'format_html');
  $output .= '

  ';
  }
  }
  }
  $output .= '

  ';
  }
  $output .= '

  ';
  return $output;
  }
  
  which line do we need to change to put these lines:
  
  require_once($CFG->dirroot.'/blocks/navbuttons/footer.php');
  $output = draw_navbuttons().$this->container_end_all(true);
  
  thanks for any support!
• 

  Davo Smith

  Thu, 24 Sept 2020, 9:58 PM

  As stated in the README, you need to change the line $this->container_end_all(true). I don't know where that occurs in theme_adaptable, but it will be in a function called footer(), not get_footer_blocks(). If there is no footer() function in theme_adaptable, then you need to make the change to the core version of footer() instead.
• 

  Aysenur Kazokoglu

  Thu, 24 Sept 2020, 11:37 PM

  in the renderers.php, there is the line $output = $this->container_end_all(true); in the function public function footer() {global $CFG;
  i have to replace $output = $this->container_end_all(true); with $output = draw_navbuttons().$this->container_end_all(true);
  where do i have to add? require_once($CFG->dirroot.'/blocks/navbuttons/footer.php');
  is this correct?
  
• 

  Davo Smith

  Thu, 24 Sept 2020, 11:39 PM

  As it says in the instructions, replace the line:
  $output = $this->container_end_all(true);
  
  With the lines:
  
  require_once($CFG->dirroot.'/blocks/navbuttons/footer.php');
  $output = draw_navbuttons().$this->container_end_all(true);
  
  
• 

  Aysenur Kazokoglu

  Fri, 25 Sept 2020, 3:49 PM

  hi davo, thanks, the navigation buttons are now available, but what do we need to do to remove the default navigation, next activity, previous activity. currently we have a double navigation displayed.
• 

  Davo Smith

  Fri, 25 Sept 2020, 3:51 PM

  I cannot offer any advice about removing the default navigation - that is something you'll have to post on the forums or figure out for yourself (my plugin long predates the default navigation, so I've never looked into it).
• 

  Aysenur Kazokoglu

  Fri, 25 Sept 2020, 4:20 PM

  ok, thanks
• 

  Christian Wig

  Fri, 2 Oct 2020, 4:08 AM

  This seems like a great plugin!
  
  But I have one question: Is there a way to DISABLE the rendering with the navigation buttons on a SPECIFIC page? I have a problem with the embed_question plugin, which generates an embedded page based upon a quiz question. Then the buttons are rendered twice, both for the embedded page and 'real' page. And the buttons for the embedded pages do not work as wanted, as they change the contents only of the embedded section.
• 

  Davo Smith

  Fri, 2 Oct 2020, 3:30 PM

  Christian, there aren't currently any settings for disabling the navigation buttons on a specific page. You can turn them off for an activity type, or you can set them to only show once the activity is marked as 'complete' (for a quiz, you can set them to only show once an attempt has been submitted, if that helps at all).
  
  It is probably fairly straightforward to add a specific exception to not show using embed_question, but I've not tried that plugin, so I would need to find some time to try it out and see what happens (in the meantime, I'm happy to accept a simple patch that solves this problem, if you are able to look at the code in blocks/navbuttons/footer.php).
• 

  Christian Wig

  Sun, 4 Oct 2020, 7:44 PM

  Thanks for your reply, Davo! I think your navigation buttons make the user interface so much simpler, so I am (more!) willing to drop the use of embedded questions.
  
  But I really like the embedded question plugin as well, as it allows to just use ONE question from the question bank to reinforce the learning on a specific page, without the somewhat complex user interface of running a quiz (several steps: starting the quiz, submitting the quiz, confirming that you want to submit etc.).
  
  A problem vs. the navigation buttons is that the embedded question (to my knowledge!) does not 'behave' like a quiz or any other activity type, so it is not possible to use the functionality for behavior of the navigation buttons for specific activity types. It 'just' generates portions of a web page.
  
  I have access to the blocks/navbuttons/footer.php code, but adjusting this code is far beyond my competence in PHP. And regarding the embed_question plugin, I really do not know how use the tags that it generates in order to NOT generate nav buttons for this kind of (sub-)pages.
  
  In the HTML code the plugin generates an iframe with recognizable contents, like
• 

  Christian Wig

  Sun, 4 Oct 2020, 7:49 PM

  ... one more try to give you relevant portions of the iframe code generated by the embed_question plugin:
  iframe class="filter_embedquestion-iframe" ..."" title="Embedded question" src="https://.../filter/embedquestion/showquestion.php?...
• 

  Davo Smith

  Sun, 4 Oct 2020, 8:33 PM

  Hi Christian - I've pushed a quick fix that should solve the problem (it certainly stops the buttons from appearing on embedded questions with my local install of Moodle). Please can you install the version from the 'Source control URL', above?
• 

  Christian Wig

  Sun, 4 Oct 2020, 9:31 PM

  What a fantastic service, Davo! And on a Sunday. Now the buttons work perfectly, also on a page with embedded questions. Thanks x1000!
• 

  Ezzeddin Hamed

  Thu, 6 Jan 2022, 5:07 PM

  I installed it on Moodle 3.11.4, but once the database is updated Moodle did not work and responded with a message that it is under upgrading. At this moment, I had to remove navbuttons manually.
  
  The readme file says that this version does not need to have core changes.