Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(29 errors, 37 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/my_external_backup_restore_courses/backup_external_courses_helper.class.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#181) File must end with a newline character
blocks/my_external_backup_restore_courses/block_my_external_backup_restore_courses.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#41) global $PAGE cannot be used in block classes. Use $this->page.
(#42) global $PAGE cannot be used in block classes. Use $this->page.
(#65) File must end with a newline character
blocks/my_external_backup_restore_courses/classes/privacy/provider.php
(#35) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#51) Opening brace should be on the same line as the declaration for class provider
blocks/my_external_backup_restore_courses/classes/task/backup_restore_task.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/my_external_backup_restore_courses/cli/install_server.php
(#46) Line exceeds 132 characters; contains 147 characters
blocks/my_external_backup_restore_courses/db/access.php
(#80) File must end with a newline character
blocks/my_external_backup_restore_courses/db/messages.php
(#45) File must end with a newline character
blocks/my_external_backup_restore_courses/db/services.php
(#61) File must end with a newline character
blocks/my_external_backup_restore_courses/db/tasks.php
(#38) File must end with a newline character
blocks/my_external_backup_restore_courses/db/upgrade.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#41) Expected "if (...) {\n"; found "if(...){\n"
(#49) Functions must not contain multiple empty lines in a row; found 3 empty lines
(#51) Whitespace found at end of line
blocks/my_external_backup_restore_courses/index.php
(#64) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#77) This comment is 47% valid code; is this commented out code?
(#87) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#385) Commas (,) must be followed by white space.
(#395) Expected "if (...) {\n"; found "if(...) {\n"
(#408) Expected "if (...) {\n"; found "if(...) {\n"
blocks/my_external_backup_restore_courses/locallib.php
(#30) Expected 1 space before opening brace; found 0
(#64) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#368) Expected 1 space before opening brace; found 0
(#376) Expected "if (...) {\n"; found "if(...){\n"
(#379) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#388) Expected 1 space before opening brace; found 0
(#403) Expected 1 space before opening brace; found 0
(#545) Expected 1 space before opening brace; found 0
(#588) Expected "if (...) {\n"; found "if(...){\n"
(#589) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#870) Expected 1 space before opening brace; found 0
(#883) Method name "_get" should not be prefixed with an underscore to indicate visibility
(#981) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
blocks/my_external_backup_restore_courses/tests/externallib_test.php
(#34) Inline comments must start with a capital letter, digit or 3-dots sequence
(#34) Inline comments must end in full-stops, exclamation marks, or question marks
(#34) This comment is 64% valid code; is this commented out code?
(#34) No space found before comment text; expected "// require_once($CFG->dirroot . '/backup/util/includes/restore_includes.php');" but found "//require_once($CFG->dirroot . '/backup/util/includes/restore_includes.php');"
(#37) PHPUnit testcase name "block_my_external_backup_restore_courses_externallib_testcase" does not match file name "externallib_test"
(#37) PHPUnit class "block_my_external_backup_restore_courses_externallib_testcase" does not have any namespace. It is recommended to add it to the "block_my_external_backup_restore_courses" namespace, using more levels if needed, in order to match the code being tested
(#49) Test method test_get_courses() is missing any coverage information, own or at class level
(#49) Expected 1 space before opening brace; found 0
(#62) Test method test_get_courses_zip() is missing any coverage information, own or at class level
(#62) Expected 1 space before opening brace; found 0
(#79) Test method test_restore_course() is missing any coverage information, own or at class level
(#79) Expected 1 space before opening brace; found 0
(#112) Line exceeds 132 characters; contains 149 characters
(#113) Line exceeds 132 characters; contains 147 characters
(#115) Inline comments must end in full-stops, exclamation marks, or question marks
(#148) Inline comments must end in full-stops, exclamation marks, or question marks
(#159) Inline comments must start with a capital letter, digit or 3-dots sequence
(#159) Inline comments must end in full-stops, exclamation marks, or question marks
(#160) Line exceeds 132 characters; contains 161 characters
(#178) File must end with a newline character
blocks/my_external_backup_restore_courses/tests/generator/lib.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/my_external_backup_restore_courses/tests/privacy_provider_test.php
(#41) PHPUnit testcase name "block_my_external_backup_restore_courses_privacy_testcase" does not match file name "privacy_provider_test"
(#41) PHPUnit class "block_my_external_backup_restore_courses_privacy_testcase" does not have any namespace. It is recommended to add it to the "block_my_external_backup_restore_courses" namespace, using more levels if needed, in order to match the code being tested
(#48) Test method test_user_contextlist() is missing any coverage information, own or at class level
(#69) Test method test_export_context_data_for_user() is missing any coverage information, own or at class level
(#104) Test method test_export_all_data_for_user() is missing any coverage information, own or at class level
(#140) Test method test_delete_data_for_all_users_in_context() is missing any coverage information, own or at class level
(#173) Test method test_delete_data_for_all_users() is missing any coverage information, own or at class level
(#210) Test method test_delete_data_for_user() is missing any coverage information, own or at class level

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(144 errors, 1 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/my_external_backup_restore_courses/backup_external_courses_helper.class.php
(#30) Package is not specified for class backup_external_courses_helper. It is also not specified in file-level phpdocs
(#20) Package is not valid
(#30) Class backup_external_courses_helper is not documented
(#47) Variable backup_external_courses_helper::$courseid is not documented
(#48) Variable backup_external_courses_helper::$userid is not documented
(#49) Variable backup_external_courses_helper::$filename is not documented
(#50) Variable backup_external_courses_helper::$filerecordid is not documented
(#87) There is no description in phpdocs for function launch_automated_backup_delete
(#52) Phpdocs for function backup_external_courses_helper::run_external_backup has incomplete parameters list
(#88) Phpdocs for function backup_external_courses_helper::launch_automated_backup_delete has incomplete parameters list
(#55) Not recommended phpdocs tag @global used
(#162) Inline phpdocs tag {@link self::BACKUP_STATUS_OK} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/my_external_backup_restore_courses/block_my_external_backup_restore_courses.php
(#31) Package is not specified for class block_my_external_backup_restore_courses. It is also not specified in file-level phpdocs
(#20) Package is not valid
(#31) Class block_my_external_backup_restore_courses is not documented
(#32) Function block_my_external_backup_restore_courses::init is not documented
(#36) Function block_my_external_backup_restore_courses::has_config is not documented
(#40) Function block_my_external_backup_restore_courses::get_content is not documented
(#60) Function block_my_external_backup_restore_courses::applicable_formats is not documented
blocks/my_external_backup_restore_courses/classes/privacy/provider.php
(#20) Package repository_flickr is not valid
(#268) Phpdocs for function provider::validate_contextlist_contexts has incomplete parameters list
blocks/my_external_backup_restore_courses/classes/task/backup_restore_task.php
(#31) Package is not specified for class backup_restore_task. It is also not specified in file-level phpdocs
(#20) Package is not valid
(#31) Class backup_restore_task is not documented
(#32) Function backup_restore_task::get_name is not documented
(#37) Function backup_restore_task::execute is not documented
blocks/my_external_backup_restore_courses/cli/install_server.php
(#16) No one-line description found in phpdocs for file
(#16) File-level phpdocs block does not have @copyright tag
blocks/my_external_backup_restore_courses/db/access.php
(#20) Package is not valid
blocks/my_external_backup_restore_courses/db/messages.php
(#20) Package is not valid
blocks/my_external_backup_restore_courses/db/services.php
(#20) Package is not valid
blocks/my_external_backup_restore_courses/db/tasks.php
(#20) Package is not valid
blocks/my_external_backup_restore_courses/db/upgrade.php
(#27) Package is not specified for function xmldb_block_my_external_backup_restore_courses_upgrade. It is also not specified in file-level phpdocs
(#20) Package is not valid
(#27) Function xmldb_block_my_external_backup_restore_courses_upgrade is not documented
blocks/my_external_backup_restore_courses/externallib.php
(#31) Package is not specified for class block_my_external_backup_restore_courses_external. It is also not specified in file-level phpdocs
(#20) Package is not valid
(#31) Class block_my_external_backup_restore_courses_external is not documented
(#32) Function block_my_external_backup_restore_courses_external::get_courses_zip is not documented
(#68) Function block_my_external_backup_restore_courses_external::get_courses_zip_parameters is not documented
(#77) Function block_my_external_backup_restore_courses_external::get_courses_zip_returns is not documented
(#86) Function block_my_external_backup_restore_courses_external::get_courses is not documented
(#127) Function block_my_external_backup_restore_courses_external::get_courses_parameters is not documented
(#136) Function block_my_external_backup_restore_courses_external::get_courses_returns is not documented
blocks/my_external_backup_restore_courses/get_user_backup_course_webservice.php
(#20) Package is not valid
blocks/my_external_backup_restore_courses/index.php
(#20) Package is not valid
blocks/my_external_backup_restore_courses/lang/en/block_my_external_backup_restore_courses.php
(#20) Package is not valid
blocks/my_external_backup_restore_courses/lang/fr/block_my_external_backup_restore_courses.php
(#20) Package is not valid
blocks/my_external_backup_restore_courses/locallib.php
(#30) Package is not specified for class block_my_external_backup_restore_courses_tools. It is also not specified in file-level phpdocs
(#393) Package is not specified for class block_my_external_backup_restore_courses_invalid_username_exception. It is also not specified in file-level phpdocs
(#403) Package is not specified for class block_my_external_backup_restore_courses_task_helper. It is also not specified in file-level phpdocs
(#545) Package is not specified for class block_my_external_backup_restore_courses_task. It is also not specified in file-level phpdocs
(#870) Package is not specified for class block_my_external_backup_restore_courses_task_error. It is also not specified in file-level phpdocs
(#943) Package is not specified for class block_my_external_backup_restore_courses_task_error_list. It is also not specified in file-level phpdocs
(#20) Package is not valid
(#30) Class block_my_external_backup_restore_courses_tools is not documented
(#393) Class block_my_external_backup_restore_courses_invalid_username_exception is not documented
(#403) Class block_my_external_backup_restore_courses_task_helper is not documented
(#545) Class block_my_external_backup_restore_courses_task is not documented
(#870) Class block_my_external_backup_restore_courses_task_error is not documented
(#943) Class block_my_external_backup_restore_courses_task_error_list is not documented
(#38) Function block_my_external_backup_restore_courses_tools::del_tree is not documented
(#46) Function block_my_external_backup_restore_courses_tools::enrol_get_courses_with_role is not documented
(#69) Function block_my_external_backup_restore_courses_tools::external_backup_course_sitename is not documented
(#83) Function block_my_external_backup_restore_courses_tools::get_all_users_courses is not documented
(#201) Function block_my_external_backup_restore_courses_tools::print_content is not documented
(#216) Function block_my_external_backup_restore_courses_tools::rest_call_external_courses_client is not documented
(#245) Function block_my_external_backup_restore_courses_tools::get_formatted_concerned_roles_shortname is not documented
(#259) Function block_my_external_backup_restore_courses_tools::get_concerned_roles_shortname is not documented
(#266) Function block_my_external_backup_restore_courses_tools::format_string_list_for_sql is not documented
(#274) Function block_my_external_backup_restore_courses_tools::external_course_restored_or_on_way_by_other_users is not documented
(#287) Function block_my_external_backup_restore_courses_tools::get_other_users_for_course_restored_or_on_way_by_other_users is not documented
(#311) Function block_my_external_backup_restore_courses_tools::array_contains_object_with_properties is not documented
(#320) Function block_my_external_backup_restore_courses_tools::install_webservice_moodle_server is not documented
(#368) Function block_my_external_backup_restore_courses_tools::get_external_moodles_url_token is not documented
(#388) Function block_my_external_backup_restore_courses_tools::get_external_moodle_token is not documented
(#406) Function block_my_external_backup_restore_courses_task_helper::run_automated_backup_restore is not documented
(#535) Function block_my_external_backup_restore_courses_task_helper::retrieve_tasks is not documented
(#548) Function block_my_external_backup_restore_courses_task::__construct is not documented
(#552) Function block_my_external_backup_restore_courses_task::enrol_editingteacher is not documented
(#558) Function block_my_external_backup_restore_courses_task::retrieve_external_moodle_name is not documented
(#573) Function block_my_external_backup_restore_courses_task::download_external_backup_courses is not documented
(#597) Function block_my_external_backup_restore_courses_task::restore_course_from_backup_file is not documented
(#699) Function block_my_external_backup_restore_courses_task::download_backup_course is not documented
(#740) Function block_my_external_backup_restore_courses_task::change_task_status is not documented
(#747) Function block_my_external_backup_restore_courses_task::set_local_courseid is not documented
(#753) Function block_my_external_backup_restore_courses_task::get_username is not documented
(#761) Function block_my_external_backup_restore_courses_task::get_user is not documented
(#766) Function block_my_external_backup_restore_courses_task::get_manual_enrol is not documented
(#786) Function block_my_external_backup_restore_courses_task::enrol_user is not documented
(#789) Function block_my_external_backup_restore_courses_task::get_errors is not documented
(#792) Function block_my_external_backup_restore_courses_task::get_lang_object is not documented
(#820) Function block_my_external_backup_restore_courses_task::notify_success is not documented
(#865) Function block_my_external_backup_restore_courses_task::add_error is not documented
(#883) Function block_my_external_backup_restore_courses_task_error::_get is not documented
(#887) Function block_my_external_backup_restore_courses_task_error::__construct is not documented
(#901) Function block_my_external_backup_restore_courses_task_error::get_user is not documented
(#913) Function block_my_external_backup_restore_courses_task_error::get_lang_object is not documented
(#946) Function block_my_external_backup_restore_courses_task_error_list::add_error is not documented
(#949) Function block_my_external_backup_restore_courses_task_error_list::add_errors is not documented
(#952) Function block_my_external_backup_restore_courses_task_error_list::has_errors is not documented
(#955) Function block_my_external_backup_restore_courses_task_error_list::format_error_for_admin is not documented
(#970) Function block_my_external_backup_restore_courses_task_error_list::notify_errors is not documented
(#546) Variable block_my_external_backup_restore_courses_task::$task is not documented
(#547) Variable block_my_external_backup_restore_courses_task::$taskerrors is not documented
(#872) Variable block_my_external_backup_restore_courses_task_error::$externalcourseid is not documented
(#873) Variable block_my_external_backup_restore_courses_task_error::$externalmoodleurl is not documented
(#874) Variable block_my_external_backup_restore_courses_task_error::$externalmoodlesitename is not documented
(#875) Variable block_my_external_backup_restore_courses_task_error::$courseid is not documented
(#876) Variable block_my_external_backup_restore_courses_task_error::$message is not documented
(#877) Variable block_my_external_backup_restore_courses_task_error::$usernameorid is not documented
(#878) Variable block_my_external_backup_restore_courses_task_error::$user is not documented
(#879) Variable block_my_external_backup_restore_courses_task_error::$externalcoursename is not documented
(#880) Variable block_my_external_backup_restore_courses_task_error::$internalcategoryname is not documented
(#881) Variable block_my_external_backup_restore_courses_task_error::$defaultcategoryname is not documented
(#945) Variable block_my_external_backup_restore_courses_task_error_list::$taskerrors is not documented
(#31) Constant block_my_external_backup_restore_courses_tools::STATUS_SCHEDULED is not documented
(#32) Constant block_my_external_backup_restore_courses_tools::STATUS_INPROGRESS is not documented
(#33) Constant block_my_external_backup_restore_courses_tools::STATUS_PERFORMED is not documented
(#34) Constant block_my_external_backup_restore_courses_tools::STATUS_ERROR is not documented
(#35) Constant block_my_external_backup_restore_courses_tools::BLOCK_MY_EXTERNAL_BACKUP_RESTORE_COURSES_ROLE is not documented
(#36) Constant block_my_external_backup_restore_courses_tools::BLOCK_MY_EXTERNAL_BACKUP_RESTORE_COURSES_DEFAULT_USER is not documented
(#404) Constant block_my_external_backup_restore_courses_task_helper::BACKUP_FILENAME is not documented
(#405) Constant block_my_external_backup_restore_courses_task_helper::BACKUP_TEMPDIRNAME is not documented
blocks/my_external_backup_restore_courses/settings.php
(#20) Package is not valid
blocks/my_external_backup_restore_courses/tests/externallib_test.php
(#19) Package blocks_my_external_backup_restore_courses is not valid
(#37) Class block_my_external_backup_restore_courses_externallib_testcase is not documented
(#38) Variable block_my_external_backup_restore_courses_externallib_testcase::$datagenerator is not documented
(#39) Variable block_my_external_backup_restore_courses_externallib_testcase::$course1 is not documented
(#40) Variable block_my_external_backup_restore_courses_externallib_testcase::$course2 is not documented
(#41) Variable block_my_external_backup_restore_courses_externallib_testcase::$defaultcategory is not documented
(#42) Variable block_my_external_backup_restore_courses_externallib_testcase::$coursecategory is not documented
(#43) Variable block_my_external_backup_restore_courses_externallib_testcase::$editingteacheruser is not documented
(#44) Variable block_my_external_backup_restore_courses_externallib_testcase::$studentuser is not documented
(#45) Variable block_my_external_backup_restore_courses_externallib_testcase::$wsuser is not documented
(#46) Variable block_my_external_backup_restore_courses_externallib_testcase::$wsrole is not documented
(#139) There is no description in phpdocs for function restore_course
(#140) Phpdocs for function block_my_external_backup_restore_courses_externallib_testcase::restore_course has incomplete parameters list
blocks/my_external_backup_restore_courses/tests/generator/lib.php
(#20) Package block_user_session is not valid
(#30) Class block_my_external_backup_restore_courses_generator is not documented
(#32) Function block_my_external_backup_restore_courses_generator::create_backup_restore_entry is not documented
(#50) Function block_my_external_backup_restore_courses_generator::update_backup_restore_entry is not documented
blocks/my_external_backup_restore_courses/tests/privacy_provider_test.php
(#20) Package blocks_my_external_backup_restore_courses is not valid
(#18) Inline phpdocs tag {@link workshopform_accumulative_privacy_provider_testcase} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/my_external_backup_restore_courses/version.php
(#20) Package is not valid

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 2 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]

blocks/my_external_backup_restore_courses/db/upgrade.php
Database modifications (new tables or columns) detected in the patch without any change to some important areas.
No changes detected to backup and restore, that may affect storage and transportability, please verify!

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]