Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(132 errors, 215 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/motrain/block_motrain.php
(#120) There should be a comma after the last array item in a multi-line array.
blocks/motrain/classes/addons.php
(#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/client.php
(#76) Missing docblock for function add_coins
(#76) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $reason.
(#80) There should be a comma after the last array item in a multi-line array.
(#89) Missing docblock for function complete_redemption
(#93) Missing docblock for function create_player
(#97) Missing docblock for function create_webhook
(#101) Missing docblock for function delete_webhook
(#105) Missing docblock for function get_account
(#109) Missing docblock for function get_account_branding
(#113) Missing docblock for function get_account_levels
(#117) Missing docblock for function get_balance
(#122) Missing docblock for function get_item
(#127) Missing docblock for function get_player
(#131) Missing docblock for function get_player_by_email
(#139) Missing docblock for function get_player_by_email_in_account
(#147) Missing docblock for function get_player_purchases_count
(#152) Missing docblock for function get_player_redemptions
(#160) Missing docblock for function get_redemption
(#165) Missing docblock for function get_store_login_url
(#174) Missing docblock for function get_team
(#178) Missing docblock for function get_teams
(#182) Missing docblock for function is_account_leaderboard_enabled
(#194) Missing docblock for function is_team_leaderboard_enabled
(#206) Missing docblock for function set_player_team
(#210) Missing docblock for function update_player
(#214) Missing docblock for function update_webhook
(#218) Missing docblock for function delete
(#222) Missing docblock for function head
(#226) Missing docblock for function get
(#230) Missing docblock for function patch
(#234) Missing docblock for function post
(#238) Missing docblock for function put
(#242) Missing docblock for function decode_json_response
(#250) Missing docblock for function request
(#261) Missing docblock for function request_advanced
(#275) There should be a comma after the last array item in a multi-line array.
(#320) Missing docblock for function set_is_totara
(#324) Missing docblock for function set_observer
blocks/motrain/classes/event/coins_earned.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/external.php
(#114) There should be a comma after the last array item in a multi-line array.
(#168) There should be a comma after the last array item in a multi-line array.
(#185) There should be a comma after the last array item in a multi-line array.
(#193) There should be a comma after the last array item in a multi-line array.
(#278) There should be a comma after the last array item in a multi-line array.
(#388) There should be a comma after the last array item in a multi-line array.
blocks/motrain/classes/local/api_error.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/local/award/award.php
(#34) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#92) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $reason.
(#150) There should be a comma after the last array item in a multi-line array.
(#180) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $reason.
(#218) There should be a comma after the last array item in a multi-line array.
(#232) There should be a comma after the last array item in a multi-line array.
blocks/motrain/classes/local/balance_proxy.php
(#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#122) There should be a comma after the last array item in a multi-line array.
blocks/motrain/classes/local/client_exception.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/local/collection_strategy.php
(#38) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/local/completion_coins_calculator.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#222) There should be a comma after the last array item in a multi-line array.
(#223) There should be a comma after the last array item in a multi-line array.
(#260) There should be a comma after the last array item in a multi-line array.
blocks/motrain/classes/local/level_proxy.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/local/message_dealer.php
(#32) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#44) Missing docblock for constant message_dealer::TYPE_REDEMPTION_REQUEST_ACCEPTED
(#45) Missing docblock for constant message_dealer::TYPE_REDEMPTION_SELF_COMPLETED
(#46) Missing docblock for constant message_dealer::TYPE_REDEMPTION_SHIPPING_ORDER_SUBMITTED
(#47) Missing docblock for constant message_dealer::TYPE_REDEMPTION_VOUCHER_CLAIMED
(#48) Missing docblock for constant message_dealer::TYPE_USER_AUCTION_WON
(#49) Missing docblock for constant message_dealer::TYPE_USER_MANUAL_AWARD
(#50) Missing docblock for constant message_dealer::TYPE_USER_RAFFLE_WON
(#51) Missing docblock for constant message_dealer::TYPE_USER_SWEEPSTAKES_WON
(#71) There should be a comma after the last array item in a multi-line array.
(#76) There should be a comma after the last array item in a multi-line array.
(#87) There should be a comma after the last array item in a multi-line array.
(#92) There should be a comma after the last array item in a multi-line array.
(#103) There should be a comma after the last array item in a multi-line array.
(#104) There should be a comma after the last array item in a multi-line array.
(#114) There should be a comma after the last array item in a multi-line array.
(#119) There should be a comma after the last array item in a multi-line array.
(#120) There should be a comma after the last array item in a multi-line array.
(#130) There should be a comma after the last array item in a multi-line array.
(#141) There should be a comma after the last array item in a multi-line array.
(#146) There should be a comma after the last array item in a multi-line array.
(#157) There should be a comma after the last array item in a multi-line array.
(#168) There should be a comma after the last array item in a multi-line array.
(#257) Line exceeds 132 characters; contains 137 characters
(#274) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $data.
(#299) There should be a comma after the last array item in a multi-line array.
(#394) There should be a comma after the last array item in a multi-line array.
blocks/motrain/classes/local/metadata_reader.php
(#32) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/local/player_mapper.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#215) Expected 1 space after "="; 2 found
blocks/motrain/classes/local/program_coins_calculator.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#163) There should be a comma after the last array item in a multi-line array.
blocks/motrain/classes/local/purchase_proxy.php
(#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/local/reason/lang_reason.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#53) Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $args.
blocks/motrain/classes/local/setting/static_content.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/local/team_resolver.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#92) There should be a comma after the last array item in a multi-line array.
(#122) There should be a comma after the last array item in a multi-line array.
(#156) There should be a comma after the last array item in a multi-line array.
blocks/motrain/classes/local/user_pusher.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/local/user_utils.php
(#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/local/webhook/processor.php
(#32) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#110) There should be a comma after the last array item in a multi-line array.
(#161) There should be a comma after the last array item in a multi-line array.
(#174) There should be a comma after the last array item in a multi-line array.
blocks/motrain/classes/manager.php
(#47) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#172) Expected 1 space before "/"; 0 found
(#172) Expected 1 space after "/"; 0 found
(#174) Expected 1 space before "/"; 0 found
(#174) Expected 1 space after "/"; 0 found
(#265) Missing docblock for function get_global_team_association
(#440) Missing docblock for function has_team_associations
(#730) There should be a comma after the last array item in a multi-line array.
(#757) There should be a comma after the last array item in a multi-line array.
blocks/motrain/classes/output/players_mapping_table.php
(#74) There should be a comma after the last array item in a multi-line array.
blocks/motrain/classes/privacy/provider.php
(#88) Method name "_get_metadata" should not be prefixed with an underscore to indicate visibility
(#105) There should be a comma after the last array item in a multi-line array.
(#134) Method name "_get_contexts_for_userid" should not be prefixed with an underscore to indicate visibility
(#167) Method name "_export_user_data" should not be prefixed with an underscore to indicate visibility
(#202) There should be a comma after the last array item in a multi-line array.
(#232) There should be a comma after the last array item in a multi-line array.
(#242) Method name "_delete_data_for_all_users_in_context" should not be prefixed with an underscore to indicate visibility
(#257) Method name "_delete_data_for_user" should not be prefixed with an underscore to indicate visibility
blocks/motrain/classes/renderer.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/task/adhoc_process_bulk_completion_import.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/task/adhoc_queue_cohort_members_for_push.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/task/adhoc_update_webhook.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/classes/task/users_push.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/cli/export_strings.php
(#56) There should be a comma after the last array item in a multi-line array.
(#93) There should be a comma after the last array item in a multi-line array.
blocks/motrain/cli/import_strings.php
(#59) There should be a comma after the last array item in a multi-line array.
(#147) Missing docblock for function block_motrain_cli_get_lang_header
blocks/motrain/cli/lib.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/motrain/db/access.php
(#34) Short array syntax must be used to define arrays
(#35) There should be a comma after the last array item in a multi-line array.
(#37) There should be a comma after the last array item in a multi-line array.
(#41) Short array syntax must be used to define arrays
(#44) Short array syntax must be used to define arrays
(#45) There should be a comma after the last array item in a multi-line array.
(#47) There should be a comma after the last array item in a multi-line array.
(#62) There should be a comma after the last array item in a multi-line array.
(#71) There should be a comma after the last array item in a multi-line array.
(#75) Short array syntax must be used to define arrays
(#78) Short array syntax must be used to define arrays
(#78) There should be a comma after the last array item in a multi-line array.
(#82) Short array syntax must be used to define arrays
(#85) Short array syntax must be used to define arrays
(#86) There should be a comma after the last array item in a multi-line array.
(#88) There should be a comma after the last array item in a multi-line array.
blocks/motrain/db/caches.php
(#29) Short array syntax must be used to define arrays
(#35) Short array syntax must be used to define arrays
(#38) There should be a comma after the last array item in a multi-line array.
(#40) Short array syntax must be used to define arrays
(#42) There should be a comma after the last array item in a multi-line array.
(#44) Short array syntax must be used to define arrays
(#47) There should be a comma after the last array item in a multi-line array.
(#49) Short array syntax must be used to define arrays
blocks/motrain/db/events.php
(#32) There should be a comma after the last array item in a multi-line array.
blocks/motrain/db/services.php
(#41) There should be a comma after the last array item in a multi-line array.
(#48) There should be a comma after the last array item in a multi-line array.
(#55) There should be a comma after the last array item in a multi-line array.
blocks/motrain/db/tasks.php
(#36) There should be a comma after the last array item in a multi-line array.
blocks/motrain/db/upgrade.php
(#138) Short array syntax must be used to define arrays
(#141) Short array syntax must be used to define arrays
blocks/motrain/lang/ca/block_motrain.php
(#213) The use of backticks in strings is not recommended
(#214) The use of backticks in strings is not recommended
(#215) The use of backticks in strings is not recommended
(#216) The use of backticks in strings is not recommended
(#217) The use of backticks in strings is not recommended
(#218) The use of backticks in strings is not recommended
(#219) The use of backticks in strings is not recommended
(#233) The use of backticks in strings is not recommended
(#234) The use of backticks in strings is not recommended
(#235) The use of backticks in strings is not recommended
(#236) The use of backticks in strings is not recommended
blocks/motrain/lang/en/block_motrain.php
(#29) The string key "accountid" is not in the correct order, it should be before "accountid_desc"
(#34) The string key "addon" is not in the correct order, it should be before "addprogramellipsis"
(#37) The string key "addonstate" is not in the correct order, it should be before "addonstate_desc"
(#39) The string key "adminscanearn" is not in the correct order, it should be before "adminscanearn_desc"
(#41) The string key "apihost" is not in the correct order, it should be before "apihost_desc"
(#43) The string key "apikey" is not in the correct order, it should be before "apikey_desc"
(#45) The string key "areyousurerefreshallinteam" is not in the correct order, it should be before "areyousurerefreshandpushallinteam"
(#47) The string key "autopush" is not in the correct order, it should be before "autopush_help"
(#52) The string key "cachedef_coins" is not in the correct order, it should be before "cachepurged"
(#58) The string key "cohort" is not in the correct order, it should be before "cohort_help"
(#62) The string key "coinsimage" is not in the correct order, it should be before "coinsimage_help"
(#67) The string key "configaccentcolor" is not in the correct order, it should be before "connect"
(#72) The string key "configfootercontent" is not in the correct order, it should be before "configfootercontent_help"
(#85) The string key "enableaddon" is not in the correct order, it should be before "enableaddon_help"
(#97) The string key "isenabled" is not in the correct order, it should be before "isenabled_desc"
(#99) The string key "ispaused" is not in the correct order, it should be before "ispaused_help"
(#109) The string key "metadatacache" is not in the correct order, it should be before "metadatacache_help"
(#111) The string key "messageprovider:notification" is not in the correct order, it should be before "metadatasyncdisabled"
(#122) The string key "motrainemaillookup" is not in the correct order, it should be before "motrainidlookup"
(#123) The string key "motrainaddons" is not in the correct order, it should be before "motrainemaillookup"
(#146) The string key "playermapping" is not in the correct order, it should be before "playermappingintro"
(#149) The string key "pendingorders" is not in the correct order, it should be before "pleasewait"
(#155) The string key "pluginispaused" is not in the correct order, it should be before "programcompletion"
(#161) The string key "privacy:metadata:coinsgained" is not in the correct order, it should be before "privacy:metadata:coinsgained:reason"
(#163) The string key "privacy:metadata:log:contextid" is not in the correct order, it should be before "privacy:metadata:log:userid"
(#164) The string key "privacy:metadata:log:coins" is not in the correct order, it should be before "privacy:metadata:log:contextid"
(#165) The string key "privacy:metadata:log:actionname" is not in the correct order, it should be before "privacy:metadata:log:coins"
(#166) The string key "privacy:metadata:log:actionhash" is not in the correct order, it should be before "privacy:metadata:log:actionname"
(#168) The string key "privacy:metadata:log:timebroadcasted" is not in the correct order, it should be before "privacy:metadata:log:timecreated"
(#169) The string key "privacy:metadata:log:broadcasterror" is not in the correct order, it should be before "privacy:metadata:log:timebroadcasted"
(#170) The string key "privacy:metadata:log" is not in the correct order, it should be before "privacy:metadata:log:broadcasterror"
(#172) The string key "privacy:metadata:playermap:accountid" is not in the correct order, it should be before "privacy:metadata:playermap:userid"
(#174) The string key "privacy:metadata:playermap:blocked" is not in the correct order, it should be before "privacy:metadata:playermap:playerid"
(#176) The string key "privacy:metadata:playermap" is not in the correct order, it should be before "privacy:metadata:playermap:blockedreason"
(#179) The string key "privacy:metadata:remoteplayer:email" is not in the correct order, it should be before "privacy:metadata:remoteplayer:lastname"
(#180) The string key "privacy:metadata:remoteplayer" is not in the correct order, it should be before "privacy:metadata:remoteplayer:email"
(#182) The string key "privacy:metadata:userspush" is not in the correct order, it should be before "privacy:metadata:userspush:userid"
(#206) The string key "team" is not in the correct order, it should be before "team_help"
(#218) The string key "templatecontent" is not in the correct order, it should be before "templatesaved"
(#224) The use of backticks in strings is not recommended
(#225) The use of backticks in strings is not recommended
(#226) The use of backticks in strings is not recommended
(#227) The use of backticks in strings is not recommended
(#228) The use of backticks in strings is not recommended
(#229) The use of backticks in strings is not recommended
(#230) The use of backticks in strings is not recommended
(#238) The use of backticks in strings is not recommended
(#239) The use of backticks in strings is not recommended
(#240) The use of backticks in strings is not recommended
(#241) The use of backticks in strings is not recommended
(#253) The string key "therearexusersinmultipleteams" is not in the correct order, it should be before "tickets"
(#259) The string key "usecohorts" is not in the correct order, it should be before "usecohorts_help"
(#262) The string key "userecommended" is not in the correct order, it should be before "useridoremail"
blocks/motrain/lang/es/block_motrain.php
(#213) The use of backticks in strings is not recommended
(#214) The use of backticks in strings is not recommended
(#215) The use of backticks in strings is not recommended
(#216) The use of backticks in strings is not recommended
(#217) The use of backticks in strings is not recommended
(#218) The use of backticks in strings is not recommended
(#219) The use of backticks in strings is not recommended
(#233) The use of backticks in strings is not recommended
(#234) The use of backticks in strings is not recommended
(#235) The use of backticks in strings is not recommended
(#236) The use of backticks in strings is not recommended
blocks/motrain/lang/es_ar/block_motrain.php
(#213) The use of backticks in strings is not recommended
(#214) The use of backticks in strings is not recommended
(#215) The use of backticks in strings is not recommended
(#216) The use of backticks in strings is not recommended
(#217) The use of backticks in strings is not recommended
(#218) The use of backticks in strings is not recommended
(#219) The use of backticks in strings is not recommended
(#233) The use of backticks in strings is not recommended
(#234) The use of backticks in strings is not recommended
(#235) The use of backticks in strings is not recommended
(#236) The use of backticks in strings is not recommended
blocks/motrain/lang/es_cl/block_motrain.php
(#213) The use of backticks in strings is not recommended
(#214) The use of backticks in strings is not recommended
(#215) The use of backticks in strings is not recommended
(#216) The use of backticks in strings is not recommended
(#217) The use of backticks in strings is not recommended
(#218) The use of backticks in strings is not recommended
(#219) The use of backticks in strings is not recommended
(#233) The use of backticks in strings is not recommended
(#234) The use of backticks in strings is not recommended
(#235) The use of backticks in strings is not recommended
(#236) The use of backticks in strings is not recommended
blocks/motrain/lang/es_co/block_motrain.php
(#213) The use of backticks in strings is not recommended
(#214) The use of backticks in strings is not recommended
(#215) The use of backticks in strings is not recommended
(#216) The use of backticks in strings is not recommended
(#217) The use of backticks in strings is not recommended
(#218) The use of backticks in strings is not recommended
(#219) The use of backticks in strings is not recommended
(#233) The use of backticks in strings is not recommended
(#234) The use of backticks in strings is not recommended
(#235) The use of backticks in strings is not recommended
(#236) The use of backticks in strings is not recommended
blocks/motrain/lang/es_mx/block_motrain.php
(#213) The use of backticks in strings is not recommended
(#214) The use of backticks in strings is not recommended
(#215) The use of backticks in strings is not recommended
(#216) The use of backticks in strings is not recommended
(#217) The use of backticks in strings is not recommended
(#218) The use of backticks in strings is not recommended
(#219) The use of backticks in strings is not recommended
(#233) The use of backticks in strings is not recommended
(#234) The use of backticks in strings is not recommended
(#235) The use of backticks in strings is not recommended
(#236) The use of backticks in strings is not recommended
blocks/motrain/lang/es_pe/block_motrain.php
(#213) The use of backticks in strings is not recommended
(#214) The use of backticks in strings is not recommended
(#215) The use of backticks in strings is not recommended
(#216) The use of backticks in strings is not recommended
(#217) The use of backticks in strings is not recommended
(#218) The use of backticks in strings is not recommended
(#219) The use of backticks in strings is not recommended
(#233) The use of backticks in strings is not recommended
(#234) The use of backticks in strings is not recommended
(#235) The use of backticks in strings is not recommended
(#236) The use of backticks in strings is not recommended
blocks/motrain/lang/es_ve/block_motrain.php
(#213) The use of backticks in strings is not recommended
(#214) The use of backticks in strings is not recommended
(#215) The use of backticks in strings is not recommended
(#216) The use of backticks in strings is not recommended
(#217) The use of backticks in strings is not recommended
(#218) The use of backticks in strings is not recommended
(#219) The use of backticks in strings is not recommended
(#233) The use of backticks in strings is not recommended
(#234) The use of backticks in strings is not recommended
(#235) The use of backticks in strings is not recommended
(#236) The use of backticks in strings is not recommended
blocks/motrain/lib.php
(#110) Line exceeds 132 characters; contains 133 characters
blocks/motrain/settings_config.php
(#65) There should be a comma after the last array item in a multi-line array.
(#124) Logical operator "and" is prohibited; use "&&" instead
(#174) There should be a comma after the last array item in a multi-line array.
blocks/motrain/settings_message_templates.php
(#209) There should be a comma after the last array item in a multi-line array.
(#228) There should be a comma after the last array item in a multi-line array.
blocks/motrain/settings_players.php
(#141) There should be a comma after the last array item in a multi-line array.
(#150) There should be a comma after the last array item in a multi-line array.
blocks/motrain/settings_rules.php
(#56) There should be a comma after the last array item in a multi-line array.
(#71) There should be a comma after the last array item in a multi-line array.
(#107) There should be a comma after the last array item in a multi-line array.
blocks/motrain/settings_teams.php
(#197) Inline comments must start with a capital letter, digit or 3-dots sequence
(#197) Inline comments must end in full-stops, exclamation marks, or question marks
(#197) This comment is 65% valid code; is this commented out code?
blocks/motrain/tests/privacy_provider_test.php
(#45) Testcase block_motrain_privacy_provider_testcase should be declared as abstract.
(#45) PHPUnit testcase name "block_motrain_privacy_provider_testcase" does not match file name "privacy_provider_test"
(#45) PHPUnit class "block_motrain_privacy_provider_testcase" does not have any namespace. It is recommended to add it to the "block_motrain" namespace, using more levels if needed, in order to match the code being tested
(#47) Test method test_get_metadata() is missing any coverage information, own or at class level
(#47) Test method test_get_metadata() is missing a return type
(#56) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level
(#56) Test method test_get_contexts_for_userid() is missing a return type
(#61) The use of function extract() is forbidden
(#74) Test method test_get_users_in_context() is missing any coverage information, own or at class level
(#74) Test method test_get_users_in_context() is missing a return type
(#82) The use of function extract() is forbidden
(#101) Test method test_delete_data_for_all_users_in_context() is missing any coverage information, own or at class level
(#101) Test method test_delete_data_for_all_users_in_context() is missing a return type
(#108) The use of function extract() is forbidden
(#136) Test method test_delete_data_for_user() is missing any coverage information, own or at class level
(#136) Test method test_delete_data_for_user() is missing a return type
(#143) The use of function extract() is forbidden
(#201) Test method test_delete_data_for_users() is missing any coverage information, own or at class level
(#201) Test method test_delete_data_for_users() is missing a return type
(#211) The use of function extract() is forbidden
(#259) Test method test_extract_user_data() is missing any coverage information, own or at class level
(#259) Test method test_extract_user_data() is missing a return type
(#264) The use of function extract() is forbidden
blocks/motrain/webhook.php
(#29) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.

Javascript coding style problems

(0 errors, 3 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/motrain/amd/src/dialogue-base.js
(#39) Expected catch,fail,always() or return (promise/catch-or-return)
(#39) Each then() should return a value or throw (promise/always-return)
(#154) Expected catch,fail,always() or return (promise/catch-or-return)

CSS problems

(0 errors, 1 warnings)

This section shows CSS problems detected by stylelint [More info]

blocks/motrain/styles.css
(#259) Unexpected unit (length-zero-no-unit)

PHPDocs style problems

(38 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/motrain/classes/external.php
(#68) Phpdocs for function external::award_coins has incomplete parameters list
(#118) Phpdocs for function external::get_activities_with_completion has incomplete parameters list
(#198) Phpdocs for function external::save_completion_rules has incomplete parameters list
(#397) Phpdocs for function external::save_program_rules has incomplete parameters list
blocks/motrain/classes/local/balance_proxy.php
(#51) Phpdocs for function balance_proxy::__construct has incomplete parameters list
(#61) Phpdocs for function balance_proxy::get_brava_allowance has incomplete parameters list
(#71) Phpdocs for function balance_proxy::get_brava_given has incomplete parameters list
(#81) Phpdocs for function balance_proxy::get_balance has incomplete parameters list
(#91) Phpdocs for function balance_proxy::get_tickets has incomplete parameters list
(#101) Phpdocs for function balance_proxy::get_total_earned has incomplete parameters list
blocks/motrain/classes/local/collection_strategy.php
(#62) Phpdocs for function collection_strategy::__construct has incomplete parameters list
(#216) Phpdocs for function collection_strategy::get_event_target_user has incomplete parameters list
blocks/motrain/classes/local/completion_coins_calculator.php
(#94) Phpdocs for function completion_coins_calculator::get_course_rule has incomplete parameters list
(#122) Phpdocs for function completion_coins_calculator::get_module_default has incomplete parameters list
blocks/motrain/classes/local/helper.php
(#43) Inline phpdocs tag {@link self::format_string_unescaped} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/motrain/classes/local/level_proxy.php
(#48) Phpdocs for function level_proxy::__construct has incomplete parameters list
(#57) Phpdocs for function level_proxy::get_level has incomplete parameters list
blocks/motrain/classes/local/message_dealer.php
(#308) Phpdocs for function message_dealer::get_default_template has incomplete parameters list
blocks/motrain/classes/local/metadata_reader.php
(#173) Phpdocs for function metadata_reader::get_team has incomplete parameters list
(#194) Phpdocs for function metadata_reader::has_brava_enabled_in_account has incomplete parameters list
(#233) Phpdocs for function metadata_reader::has_tickets_enabled_in_account has incomplete parameters list
blocks/motrain/classes/local/player_mapper.php
(#55) Phpdocs for function player_mapper::__construct has incomplete parameters list
blocks/motrain/classes/local/program_coins_calculator.php
(#76) Phpdocs for function program_coins_calculator::get_program_rule has incomplete parameters list
blocks/motrain/classes/local/purchase_proxy.php
(#51) Phpdocs for function purchase_proxy::__construct has incomplete parameters list
(#61) Phpdocs for function purchase_proxy::count_awaiting_redemption has incomplete parameters list
(#83) Phpdocs for function purchase_proxy::fetch_awaiting_redemption_count has incomplete parameters list
blocks/motrain/classes/local/setting/static_content.php
(#47) Phpdocs for function static_content::__construct has incomplete parameters list
blocks/motrain/classes/local/user_utils.php
(#74) Inline phpdocs tag {@link self::unalias_picture_fields()} with incorrect contents found. It must match {@link [valid URL] [description (optional)]} or {@see [valid FQSEN] [description (optional)]}
blocks/motrain/classes/manager.php
(#115) Phpdocs for function manager::can_manage has incomplete parameters list
(#124) Phpdocs for function manager::can_view has incomplete parameters list
(#155) Phpdocs for function manager::calculate_tickets_auto_earned_from_coins has incomplete parameters list
(#415) Phpdocs for function manager::has_leaderboard_access has incomplete parameters list
(#545) Phpdocs for function manager::is_player has incomplete parameters list
blocks/motrain/classes/observer.php
(#140) Phpdocs for function observer::totara_bulk_course_completionimport has incomplete parameters list
blocks/motrain/classes/renderer.php
(#45) Phpdocs for function block_motrain_renderer::coin_amount has incomplete parameters list
(#108) Phpdocs for function block_motrain_renderer::level has incomplete parameters list
(#165) Phpdocs for function block_motrain_renderer::navigation_for_managers has incomplete parameters list
blocks/motrain/cli/lib.php
(#61) Phpdocs for function block_motrain_cli_has_language has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 23 warnings)

This section shows problems detected in mustache templates [More info]

blocks/motrain/templates/block.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 2: Element “style” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (ad><body><style>.bloc)
(#1) HTML Validation error, line 16: Attribute “strokelinecap” not allowed on element “path” at this point. (> <path d="M18 6V10" stroke="#DFA53A" strokeLinecap="square" /> )
(#1) HTML Validation error, line 18: Attribute “strokelinecap” not allowed on element “path” at this point. (> <path d="M8 6V10" stroke="#DFA53A" strokeLinecap="square" /> <)
blocks/motrain/templates/heading.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation info, line 3: Empty heading. (ing"> <h3 style="margin: 0"></h3>)
blocks/motrain/templates/icon-coins.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 4: Attribute “strokelinecap” not allowed on element “path” at this point. (> <path d="M18 6V10" stroke="#DFA53A" strokeLinecap="square" /> )
(#1) HTML Validation error, line 6: Attribute “strokelinecap” not allowed on element “path” at this point. (> <path d="M8 6V10" stroke="#DFA53A" strokeLinecap="square" /> <)
blocks/motrain/templates/icon-pending-orders.mustache
(#1) Example context missing (@template section not found.)
blocks/motrain/templates/icon-tickets.mustache
(#1) Example context missing (@template section not found.)
blocks/motrain/templates/nav-icon-dashboard.mustache
(#1) Example context missing (@template section not found.)
blocks/motrain/templates/nav-icon-info.mustache
(#1) Example context missing (@template section not found.)
blocks/motrain/templates/nav-icon-leaderboard.mustache
(#1) Example context missing (@template section not found.)
blocks/motrain/templates/nav-icon-settings.mustache
(#1) Example context missing (@template section not found.)
blocks/motrain/templates/settings_page.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 2: Bad value “” for attribute “action” on element “form”: Must be non-empty. (ad><body><form action="" method="post" id="adminsettings"> <)
blocks/motrain/templates/wallet-balance.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 6: Attribute “strokelinecap” not allowed on element “path” at this point. (> <path d="M18 6V10" stroke="#DFA53A" strokeLinecap="square" /> )
(#1) HTML Validation error, line 8: Attribute “strokelinecap” not allowed on element “path” at this point. (> <path d="M8 6V10" stroke="#DFA53A" strokeLinecap="square" /> <)
blocks/motrain/templates/wallet-ticket-balance.mustache
(#1) Example context missing (@template section not found.)
blocks/motrain/templates/wallet.mustache
(#1) Example context missing (@template section not found.)
(#1) HTML Validation error, line 2: Element “style” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (ad><body><style> .)
(#1) HTML Validation error, line 29: Bad value “” for attribute “src” on element “img”: Must be non-empty. (> <img src="" alt="((+coins%2C+block_motrain+))"> <)

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]