Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(52 errors, 30 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/course_list_advanced/block_course_list_advanced.php
(#34) Opening brace should be on the same line as the declaration for class block_course_list_advanced
(#95) Inline comments must start with a capital letter, digit or 3-dots sequence
(#95) Inline comments must end in full-stops, exclamation marks, or question marks
(#95) Whitespace found at end of line
(#101) Whitespace found at end of line
(#102) Inline comments must start with a capital letter, digit or 3-dots sequence
(#113) Variable "editingteacher_roleid" must not contain underscores.
(#114) Variable "noneditingteacher_roleid" must not contain underscores.
(#115) Variable "student_roleid" must not contain underscores.
(#116) Variable "guest_roleid" must not contain underscores.
(#118) Variable "is_editingteacher" must not contain underscores.
(#118) Variable "editingteacher_roleid" must not contain underscores.
(#119) Variable "is_noneditingteacher" must not contain underscores.
(#119) Variable "noneditingteacher_roleid" must not contain underscores.
(#119) Line exceeds 132 characters; contains 139 characters
(#120) Variable "is_student" must not contain underscores.
(#120) Variable "student_roleid" must not contain underscores.
(#121) Variable "is_guest" must not contain underscores.
(#121) Variable "guest_roleid" must not contain underscores.
(#148) Variable "is_editingteacher" must not contain underscores.
(#156) Variable "is_student" must not contain underscores.
(#164) Variable "is_noneditingteacher" must not contain underscores.
(#172) Variable "is_guest" must not contain underscores.
(#192) Line exceeds 132 characters; contains 146 characters
(#201) Line exceeds maximum limit of 180 characters; contains 189 characters
(#206) Line exceeds 132 characters; contains 143 characters
(#209) Variable "is_editingteacher" must not contain underscores.
(#210) Line exceeds maximum limit of 180 characters; contains 271 characters
(#213) Variable "is_student" must not contain underscores.
(#214) Line exceeds maximum limit of 180 characters; contains 203 characters
(#217) Variable "is_noneditingteacher" must not contain underscores.
(#232) Variable "is_guest" must not contain underscores.
(#233) Line exceeds maximum limit of 180 characters; contains 199 characters
(#238) Line exceeds maximum limit of 180 characters; contains 257 characters
(#246) Line exceeds 132 characters; contains 134 characters
(#253) Line exceeds 132 characters; contains 148 characters
(#256) Line exceeds 132 characters; contains 152 characters
(#256) Whitespace found at end of line
(#259) Line exceeds 132 characters; contains 178 characters
(#259) Whitespace found at end of line
(#262) Line exceeds 132 characters; contains 146 characters
(#262) Whitespace found at end of line
(#264) Inline comments must start with a capital letter, digit or 3-dots sequence
(#265) Inline comments must end in full-stops, exclamation marks, or question marks
(#268) Space found before semicolon; expected ");" but found ") ;"
(#269) Line exceeds 132 characters; contains 155 characters
(#269) Whitespace found at end of line
(#298) Line exceeds 132 characters; contains 135 characters
(#308) This comment is 50% valid code; is this commented out code?
(#318) Line exceeds 132 characters; contains 139 characters
(#325) Line exceeds 132 characters; contains 169 characters
(#357) Line exceeds 132 characters; contains 146 characters
(#450) Whitespace found at end of line
(#451) Whitespace found at end of line
(#452) Whitespace found at end of line
blocks/course_list_advanced/classes/confighandler.php
(#18) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#22) Opening brace should be on the same line as the declaration for class confighandler
blocks/course_list_advanced/classes/htmlhelper.php
(#18) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#22) Opening brace should be on the same line as the declaration for class htmlhelper
(#23) Line indented incorrectly; expected at least 4 spaces, found 3
(#24) Expected 4 space(s) before asterisk; 5 found
(#25) Expected 4 space(s) before asterisk; 5 found
(#26) Expected 4 space(s) before asterisk; 5 found
(#27) Expected 4 space(s) before asterisk; 5 found
(#28) Expected 4 space(s) before asterisk; 5 found
(#28) Whitespace found at end of line
(#29) Expected 4 space(s) before asterisk; 5 found
(#31) Expected 1 space before opening brace; found 0
(#33) Line indented incorrectly; expected 8 spaces, found 9
(#35) Line indented incorrectly; expected 8 spaces, found 9
(#42) Whitespace found at end of line
(#43) Whitespace found at end of line
blocks/course_list_advanced/classes/privacy/provider.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/course_list_advanced/tests/confighandler_test.php
(#20) PHPUnit class "block_course_list_advanced\core_confighandler_testcase\core_confighandler_testcase", with namespace "block_course_list_advanced\core_confighandler_testcase", currently located at "tests/" directory, does not match its expected location at "tests/core_confighandler_testcase"
(#21) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#26) PHPUnit testcase name "core_confighandler_testcase" does not match file name "confighandler_test"
(#27) Opening brace should be on the same line as the declaration for class core_confighandler_testcase
(#29) Test method test_adminview_default_false() is missing any coverage information, own or at class level
(#43) Test method test_adminview_default_true() is missing any coverage information, own or at class level
(#54) Test method test_adminview_irgendwas() is missing any coverage information, own or at class level
(#63) Test method test_adminview_empty() is missing any coverage information, own or at class level
(#72) Test method test_adminview_unset() is missing any coverage information, own or at class level

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(19 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/course_list_advanced/block_course_list_advanced.php
(#33) Class block_course_list_advanced is not documented
(#35) Function block_course_list_advanced::init is not documented
(#39) Function block_course_list_advanced::has_config is not documented
(#43) Function block_course_list_advanced::get_content is not documented
(#335) Function block_course_list_advanced::get_remote_courses is not documented
(#427) There is no description in phpdocs for function getallcoursesbyselect
(#437) There is no description in phpdocs for function createroleindicator
(#449) There is no description in phpdocs for function has_user_role_with_roleid_in_context
(#438) Phpdocs for function block_course_list_advanced::createroleindicator has incomplete parameters list
(#134) Invalid inline phpdocs tag @todo found
blocks/course_list_advanced/classes/confighandler.php
(#21) Package is not specified for class confighandler. It is also not specified in file-level phpdocs
(#21) Class confighandler is not documented
(#58) Function confighandler::__construct is not documented
blocks/course_list_advanced/classes/htmlhelper.php
(#21) Package is not specified for class htmlhelper. It is also not specified in file-level phpdocs
(#21) Class htmlhelper is not documented
(#23) There is no description in phpdocs for function generate_role_block
blocks/course_list_advanced/settings.php
(#20) Package block_course_list is not valid
blocks/course_list_advanced/tests/confighandler_test.php
(#26) Package is not specified for class core_confighandler_testcase. It is also not specified in file-level phpdocs
(#26) Class core_confighandler_testcase is not documented

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]