Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(5 errors, 0 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/course_checker/block_course_checker.php
(#53) global $PAGE cannot be used in block classes. Use $this->page.
(#97) global $PAGE cannot be used in block classes. Use $this->page.
(#100) global $PAGE cannot be used in block classes. Use $this->page.
(#151) global $PAGE cannot be used in block classes. Use $this->page.
(#185) global $PAGE cannot be used in block classes. Use $this->page.

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(191 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/course_checker/block_course_checker.php
(#33) Class block_course_checker is not documented
(#34) There is no description in phpdocs for function init
(#42) There is no description in phpdocs for function instance_create
(#49) There is no description in phpdocs for function get_content
(#134) There is no description in phpdocs for function has_config
(#192) There is no description in phpdocs for function applicable_formats
(#144) Phpdocs for function block_course_checker::render_block has incomplete parameters list
(#35) Invalid phpdocs tag @inheritdoc used
blocks/course_checker/classes/admin/admin_setting_courseid_selector.php
(#29) Class admin_setting_courseid_selector is not documented
(#31) There is no description in phpdocs for function validate
(#31) Phpdocs for function admin_setting_courseid_selector::validate has incomplete parameters list
(#32) Invalid phpdocs tag @inheritDoc used
blocks/course_checker/classes/admin/admin_setting_domainwhitelist.php
(#32) Class admin_setting_domainwhitelist is not documented
(#47) There is no description in phpdocs for function validate
(#38) Phpdocs for function admin_setting_domainwhitelist::is_valid_domain_name has incomplete parameters list
(#47) Phpdocs for function admin_setting_domainwhitelist::validate has incomplete parameters list
(#48) Invalid phpdocs tag @inheritDoc used
blocks/course_checker/classes/admin/admin_setting_restrictedint.php
(#30) Class admin_setting_restrictedint is not documented
(#17) No one-line description found in phpdocs for file
(#45) There is no description in phpdocs for function set_required
(#52) There is no description in phpdocs for function is_required
(#59) There is no description in phpdocs for function validate
(#102) There is no description in phpdocs for function set_maximum
(#112) There is no description in phpdocs for function set_minimum
(#59) Phpdocs for function admin_setting_restrictedint::validate has incomplete parameters list
(#60) Invalid phpdocs tag @inheritDoc used
blocks/course_checker/classes/check_result.php
(#31) Class check_result is not documented
(#93) There is no description in phpdocs for function set_details
(#103) There is no description in phpdocs for function add_detail
(#113) There is no description in phpdocs for function set_link
(#123) There is no description in phpdocs for function set_successful
(#133) There is no description in phpdocs for function set_timestamp
(#151) There is no description in phpdocs for function export_for_template
(#104) Phpdocs for function check_result::add_detail has incomplete parameters list
(#151) Phpdocs for function check_result::export_for_template has incomplete parameters list
(#152) Invalid phpdocs tag @inheritDoc used
blocks/course_checker/classes/checkers/checker_attendance/checker.php
(#36) Class checker is not documented
(#128) Function checker::get_attendance_sessions is not documented
(#143) Function checker::get_modulename_constant is not documented
(#40) Constant checker::MOD_TYPE_ATTENDANCE is not documented
(#17) No one-line description found in phpdocs for file
blocks/course_checker/classes/checkers/checker_groups/checker.php
(#35) Class checker is not documented
(#38) Constant checker::MOD_TYPE_ASSIGN is not documented
(#17) No one-line description found in phpdocs for file
blocks/course_checker/classes/checkers/checker_link/checker.php
(#34) Class checker is not documented
(#40) Constant checker::TIMEOUT_SETTING is not documented
(#41) Constant checker::CONNECT_TIMEOUT_SETTING is not documented
(#42) Constant checker::TIMEOUT_DEFAULT is not documented
(#43) Constant checker::CONNECT_TIMEOUT_DEFAULT is not documented
(#44) Constant checker::WHITELIST_SETTING is not documented
(#45) Constant checker::WHITELIST_HEADING is not documented
(#46) Constant checker::WHITELIST_DEFAULT is not documented
blocks/course_checker/classes/checkers/checker_referencesettings/checker.php
(#35) Class checker is not documented
(#41) Constant checker::REFERENCE_COURSE is not documented
(#42) Constant checker::REFERENCE_COURSE_DEFAULT is not documented
(#43) Constant checker::REFERENCE_COURSE_SETTINGS is not documented
(#44) Constant checker::REFERENCE_COURSE_SETTINGS_DEFAULT is not documented
(#149) There is no description in phpdocs for function get_comparison_string
(#163) There is no description in phpdocs for function get_link_to_course_edit_page
(#150) Phpdocs for function checker::get_comparison_string has incomplete parameters list
(#164) Phpdocs for function checker::get_link_to_course_edit_page has incomplete parameters list
blocks/course_checker/classes/checkers/checker_subheadings/checker.php
(#35) Class checker is not documented
(#42) Constant checker::MOD_TYPE_LABEL is not documented
(#43) Constant checker::FIRST_ITEM_HTML_TAG is not documented
(#44) Constant checker::WHITELIST_SETTING is not documented
(#45) Constant checker::WHITELIST_HEADING is not documented
(#46) Constant checker::WHITELIST_DEFAULT is not documented
(#161) There is no description in phpdocs for function get_link_to_modedit_page
(#177) There is no description in phpdocs for function get_target
(#187) There is no description in phpdocs for function add_general_error
(#188) Phpdocs for function checker::add_general_error has incomplete parameters list
blocks/course_checker/classes/event_persister.php
(#32) Class event_persister is not documented
(#95) Function event_persister::set_last_activity_event is not documented
(#33) Constant event_persister::TABLENAME is not documented
(#50) Phpdocs for function event_persister::course_module_event_trigger has incomplete parameters list
blocks/course_checker/classes/event_result.php
(#33) Class event_result is not documented
(#16) No one-line description found in phpdocs for file
(#71) There is no description in phpdocs for function get_mod_property
(#92) There is no description in phpdocs for function get_link
(#99) There is no description in phpdocs for function get_name
(#106) There is no description in phpdocs for function get_timestamp
(#141) There is no description in phpdocs for function export_for_template
(#141) Phpdocs for function event_result::export_for_template has incomplete parameters list
(#93) Invalid phpdocs tag @inheritDoc used
(#100) Invalid phpdocs tag @inheritDoc used
(#107) Invalid phpdocs tag @inheritDoc used
(#142) Invalid phpdocs tag @inheritDoc used
blocks/course_checker/classes/global_plugin_renderer.php
(#92) Function global_plugin_renderer::get_external_link_icon is not documented
(#36) Constant global_plugin_renderer::DEBUG is not documented
(#16) No one-line description found in phpdocs for file
(#64) There is no description in phpdocs for function get_success_icon
(#71) There is no description in phpdocs for function get_failed_icon
(#78) There is no description in phpdocs for function get_ignored_icon
(#85) There is no description in phpdocs for function get_link_icon
(#190) There is no description in phpdocs for function rerun
(#99) Phpdocs for function global_plugin_renderer::render_for_page has incomplete parameters list
(#176) Phpdocs for function global_plugin_renderer::debug has incomplete parameters list
blocks/course_checker/classes/model/check_manager_interface.php
(#28) Package block_course_checker\model is not valid
(#16) No one-line description found in phpdocs for file
(#31) There is no description in phpdocs for function run_checks
(#32) Phpdocs for function run_checks has incomplete parameters list
blocks/course_checker/classes/model/check_manager_persister_interface.php
(#30) Package block_course_checker\model is not valid
(#16) No one-line description found in phpdocs for file
(#34) There is no description in phpdocs for function save_checks
(#43) There is no description in phpdocs for function load_last_checks
blocks/course_checker/classes/model/check_plugin_interface.php
(#16) No one-line description found in phpdocs for file
(#30) There is no description in phpdocs for function run
blocks/course_checker/classes/model/check_result_interface.php
(#16) No one-line description found in phpdocs for file
blocks/course_checker/classes/model/event_persister_interface.php
(#16) No one-line description found in phpdocs for file
blocks/course_checker/classes/model/event_result_interface.php
(#16) No one-line description found in phpdocs for file
blocks/course_checker/classes/output/block_renderer.php
(#29) Class block_renderer is not documented
(#30) There is no description in phpdocs for function renderer
(#39) There is no description in phpdocs for function renderer_human_check_form
(#31) Phpdocs for function block_renderer::renderer has incomplete parameters list
(#40) Phpdocs for function block_renderer::renderer_human_check_form has incomplete parameters list
blocks/course_checker/classes/output/date_picker_input.php
(#31) Class date_picker_input is not documented
(#40) There is no description in phpdocs for function tohtmlwriter
blocks/course_checker/classes/output/footer_renderer.php
(#29) Class footer_renderer is not documented
(#30) Function footer_renderer::renderer is not documented
blocks/course_checker/classes/output/page_renderer.php
(#29) Class page_renderer is not documented
(#30) Function page_renderer::renderer is not documented
blocks/course_checker/classes/plugin_manager.php
(#33) Class plugin_manager is not documented
(#35) Constant plugin_manager::IMMEDIATE_RUN is not documented
(#37) Constant plugin_manager::IMMEDIATE_SAVE_AFTER_RUN is not documented
(#39) Constant plugin_manager::DISPLAY_LAST_CHECK_RESULT_IF_DISABLED is not documented
(#42) Constant plugin_manager::PLUGIN_FILE is not documented
(#44) Constant plugin_manager::PLUGIN_OUTPUT_FILE is not documented
(#46) Constant plugin_manager::DEPENDENCY_FILE is not documented
(#48) Constant plugin_manager::PLUGIN_INTERFACE is not documented
(#50) Constant plugin_manager::PLUGIN_CLASS is not documented
(#52) Constant plugin_manager::PLUGIN_OUTPUT_CLASS is not documented
(#16) No one-line description found in phpdocs for file
(#211) There is no description in phpdocs for function run_checks
(#277) There is no description in phpdocs for function run_single_check
(#300) There is no description in phpdocs for function get_checker_status
(#308) There is no description in phpdocs for function get_checker_hidden
(#316) There is no description in phpdocs for function are_checkers_enabled
(#337) There is no description in phpdocs for function default_render
(#212) Phpdocs for function plugin_manager::run_checks has incomplete parameters list
(#278) Phpdocs for function plugin_manager::run_single_check has incomplete parameters list
blocks/course_checker/classes/result_persister.php
(#29) Class result_persister is not documented
(#16) No one-line description found in phpdocs for file
(#62) There is no description in phpdocs for function encode
(#83) There is no description in phpdocs for function decode
(#105) There is no description in phpdocs for function save_checks
(#144) There is no description in phpdocs for function save_human_review
(#163) There is no description in phpdocs for function load_last_checks
(#191) There is no description in phpdocs for function set_last_activity_edition
(#63) Phpdocs for function result_persister::encode has incomplete parameters list
(#84) Phpdocs for function result_persister::decode has incomplete parameters list
(#106) Phpdocs for function result_persister::save_checks has incomplete parameters list
blocks/course_checker/classes/run_checker_task.php
(#36) Class run_checker_task is not documented
blocks/course_checker/classes/task_helper.php
(#33) Class task_helper is not documented
(#159) There is no description in phpdocs for function notify_checkfinished
blocks/course_checker/db/access.php
(#17) File-level phpdocs block does not have @license tag
blocks/course_checker/db/events.php
(#16) No one-line description found in phpdocs for file
blocks/course_checker/locallib.php
(#34) Phpdocs for function block_course_checker_get_dependency_info has incomplete parameters list
blocks/course_checker/tests/checker_attendance_test.php
(#42) There is no description in phpdocs for function init
(#63) There is no description in phpdocs for function test_if_there_is_no_attendance_activity_in_the_course
(#78) There is no description in phpdocs for function test_if_there_is_more_then_one_attendance_activity
(#99) There is no description in phpdocs for function test_if_there_are_sessions_in_the_attendance_activity
(#117) There is no description in phpdocs for function test_if_there_is_a_attendance_activity_but_no_sessions
(#133) There is no description in phpdocs for function create_new_attendance_activity
(#151) There is no description in phpdocs for function create_new_attendance_session
(#134) Phpdocs for function block_course_checker_attendance_testcase::create_new_attendance_activity has incomplete parameters list
(#152) Phpdocs for function block_course_checker_attendance_testcase::create_new_attendance_session has incomplete parameters list
(#64) Invalid phpdocs tag @test used
(#65) Invalid phpdocs tag @depends used
(#79) Invalid phpdocs tag @test used
(#80) Invalid phpdocs tag @depends used
(#100) Invalid phpdocs tag @test used
(#101) Invalid phpdocs tag @depends used
(#118) Invalid phpdocs tag @test used
(#119) Invalid phpdocs tag @depends used
blocks/course_checker/tests/checker_groups_test.php
(#42) There is no description in phpdocs for function init
(#55) There is no description in phpdocs for function test_when_the_group_mode_is_deactivated
(#72) There is no description in phpdocs for function test_when_the_grouping_id_is_not_set_but_the_group_mode_is_activated
(#89) There is no description in phpdocs for function test_when_the_grouping_does_not_exist
(#106) There is no description in phpdocs for function test_when_the_grouping_has_less_than_two_groups
(#125) There is no description in phpdocs for function test_when_the_grouping_has_more_than_one_group
(#145) There is no description in phpdocs for function create_new_assignment_activity
(#165) There is no description in phpdocs for function create_a_new_grouping_in_course
(#173) There is no description in phpdocs for function create_new_groups_in_grouping
(#193) There is no description in phpdocs for function run_groupschecker
(#174) Phpdocs for function block_course_checker_groups_testcase::create_new_groups_in_grouping has incomplete parameters list
(#194) Phpdocs for function block_course_checker_groups_testcase::run_groupschecker has incomplete parameters list
(#56) Invalid phpdocs tag @test used
(#73) Invalid phpdocs tag @test used
(#90) Invalid phpdocs tag @test used
(#107) Invalid phpdocs tag @test used
(#126) Invalid phpdocs tag @test used

Update savepoints problems

(4 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

blocks/course_checker/db/upgrade.php
Detected more 'if' blocks (2) than 'savepoint' calls (0)
Wrong order in versions: 2019071002 and 2019050800
version 2019071002 is missing corresponding savepoint call
version 2019050800 is missing corresponding savepoint call

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 24 warnings)

This section shows problems detected in mustache templates [More info]

blocks/course_checker/templates/check_block.mustache
(#1) HTML Validation error, line 3: Stray start tag “tr”. (d><body><tr> <)
(#1) HTML Validation error, line 4: Stray start tag “td”. (<tr> <td class="col checker"> )
(#1) HTML Validation error, line 8: Stray end tag “td”. ( </a> </td> <)
(#1) HTML Validation error, line 9: Stray start tag “td”. (</td> <td class="col result"> )
(#1) HTML Validation error, line 11: Stray end tag “td”. (></i> </td> <)
(#1) HTML Validation error, line 12: Stray start tag “td”. (</td> <td class="col rerun"> )
(#1) HTML Validation error, line 14: Stray end tag “td”. (/div> </td></tr>)
(#1) HTML Validation error, line 15: Stray end tag “tr”. ( </td></tr></bo)
blocks/course_checker/templates/check_result.mustache
(#1) HTML Validation error, line 3: Stray start tag “tr”. (d><body><tr id="result-checker_link"> )
(#1) HTML Validation error, line 4: Stray start tag “th”. (nk"> <th scope="col" colspan="3" class="col message "> )
(#1) HTML Validation error, line 10: Stray end tag “th”. (pan> </th></tr>)
(#1) HTML Validation error, line 11: Stray end tag “tr”. ( </th></tr><tr)
(#1) HTML Validation error, line 14: Stray start tag “tr”. (></tr><tr > <)
(#1) HTML Validation error, line 15: Stray start tag “td”. (<tr > <td class="col result"> )
(#1) HTML Validation error, line 17: Stray end tag “td”. (></i> </td> <)
(#1) HTML Validation error, line 18: Stray start tag “td”. (</td> <td class="col link"> )
(#1) HTML Validation error, line 20: Stray end tag “td”. (></a> </td> <)
(#1) HTML Validation error, line 21: Stray start tag “td”. (</td> <td class="col message"> )
(#1) HTML Validation error, line 22: Element “div” not allowed as child of element “span” in this context. (Suppressing further errors from this subtree.) ( <span><div>Activi)
(#1) HTML Validation error, line 23: Stray end tag “td”. (></a> </td></tr)
(#1) HTML Validation error, line 24: Stray end tag “tr”. ( </td></tr></bo)
blocks/course_checker/templates/footer.mustache
(#1) HTML Validation error, line 9: Attribute “placeholder” is only allowed when the input type is “email”, “number”, “password”, “search”, “tel”, “text”, or “url”. ( <input class="btn btn-secondary btn-block" type="submit" placeholder="Update human review"> )
blocks/course_checker/templates/human_check_form.mustache
(#1) HTML Validation error, line 5: Bad value “” for attribute “action” on element “form”: Must be non-empty. (</label><form method="post" action=""> )
(#1) HTML Validation error, line 14: Attribute “placeholder” is only allowed when the input type is “email”, “number”, “password”, “search”, “tel”, “text”, or “url”. (> <input class="btn btn-secondary btn-block" type="submit" placeholder="[[humancheck_update,block_course_checker]]"/> <)