Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(1 errors, 44 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

public/blocks/clampmail/classes/alternate.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
public/blocks/clampmail/classes/email.php
(#232) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
public/blocks/clampmail/classes/email_form.php
(#268) Line exceeds 132 characters; contains 133 characters
public/blocks/clampmail/config.php
(#34) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
public/blocks/clampmail/email.php
(#36) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#40) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#48) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#53) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
public/blocks/clampmail/emaillog.php
(#44) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#49) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#59) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#63) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#94) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#118) Line exceeds 132 characters; contains 134 characters
public/blocks/clampmail/lang/en/block_clampmail.php
(#64) The string key "alternate" is not in the correct order, it should be before "alternate_waiting"
(#110) The string key "not_valid" is not in the correct order, it should be before "not_valid_user"
(#116) The string key "prepend_class" is not in the correct order, it should be before "prepend_class_desc"
(#129) The string key "receipt" is not in the correct order, it should be before "receipt_help"
public/blocks/clampmail/signature.php
(#36) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
public/blocks/clampmail/tests/privacy_test.php
(#34) Unit test privacy_test should be declared as final.
(#34) PHPUnit class "privacy_test" does not have any namespace. It is recommended to add it to the "block_clampmail" namespace, using more levels if needed, in order to match the code being tested
(#41) The setUp() method in unit tests must always call to parent::setUp().
(#124) Missing docblock for function insert_message in testcase
(#143) Missing docblock for function insert_signature in testcase
(#158) Missing docblock for function delete_data_for_context in testcase
(#163) Missing docblock for function delete_data_for_user in testcase
(#179) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level
(#179) Test method test_get_contexts_for_userid() is missing a return type
(#209) Test method test_get_users_in_context() is missing any coverage information, own or at class level
(#209) Test method test_get_users_in_context() is missing a return type
(#248) Test method test_user_with_no_data() is missing any coverage information, own or at class level
(#248) Test method test_user_with_no_data() is missing a return type
(#279) Test method test_export_user_data() is missing any coverage information, own or at class level
(#279) Test method test_export_user_data() is missing a return type
(#315) Test method test_delete_user_data() is missing any coverage information, own or at class level
(#315) Test method test_delete_user_data() is missing a return type
(#344) Test method test_delete_all_data() is missing any coverage information, own or at class level
(#344) Test method test_delete_all_data() is missing a return type
(#391) Test method test_delete_data_for_users() is missing any coverage information, own or at class level
(#391) Test method test_delete_data_for_users() is missing a return type
(#415) Line exceeds 132 characters; contains 133 characters
public/blocks/clampmail/tests/upgradelib_test.php
(#37) Unit test upgradelib_test should be declared as final.
(#37) PHPUnit class "upgradelib_test" does not have any namespace. It is recommended to add it to the "block_clampmail" namespace, using more levels if needed, in order to match the code being tested
(#38) Test method test_upgradelib() is missing any coverage information, own or at class level
(#38) Test method test_upgradelib() is missing a return type

Javascript coding style problems

(24 errors, 7 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

public/blocks/clampmail/js/selection.js
(#3) '$' is not defined. (no-undef)
(#4) Identifier 'clampmail_changer' is not in camel case. (camelcase)
(#4) Identifier 'clear_selections' is not in camel case. (camelcase)
(#8) Identifier 'clear_selections' is not in camel case. (camelcase)
(#11) '$' is not defined. (no-undef)
(#13) '$' is not defined. (no-undef)
(#15) Identifier 'clampmail_changer' is not in camel case. (camelcase)
(#17) '$' is not defined. (no-undef)
(#19) '$' is not defined. (no-undef)
(#20) '$' is not defined. (no-undef)
(#21) '$' is not defined. (no-undef)
(#21) Expected to return a value at the end of function. (consistent-return)
(#22) Identifier 'in_list' is not in camel case. (camelcase)
(#23) '$' is not defined. (no-undef)
(#24) '$' is not defined. (no-undef)
(#25) Identifier 'in_list' is not in camel case. (camelcase)
(#30) '$' is not defined. (no-undef)
(#33) '$' is not defined. (no-undef)
(#34) '$' is not defined. (no-undef)
(#42) '$' is not defined. (no-undef)
(#43) '$' is not defined. (no-undef)
(#46) '$' is not defined. (no-undef)
(#47) '$' is not defined. (no-undef)
(#48) '$' is not defined. (no-undef)
(#49) '$' is not defined. (no-undef)
(#50) '$' is not defined. (no-undef)
(#51) '$' is not defined. (no-undef)
(#52) '$' is not defined. (no-undef)
(#55) '$' is not defined. (no-undef)
(#57) '$' is not defined. (no-undef)
(#58) '$' is not defined. (no-undef)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]