Prechecker results: error


Overview

(0 errors, 0 warnings)

This section shows the general problems detected when processing the code [More info]


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(77 errors, 245 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/clampmail/alternate.php
(#32) Short array syntax must be used to define arrays
(#44) Short array syntax must be used to define arrays
(#51) Short array syntax must be used to define arrays
blocks/clampmail/block_clampmail.php
(#46) Short array syntax must be used to define arrays
blocks/clampmail/classes/alternate.php
(#29) Missing docblock for interface clampmail_alternate_actions
(#77) Short array syntax must be used to define arrays
(#78) Short array syntax must be used to define arrays
(#91) Short array syntax must be used to define arrays
(#104) Short array syntax must be used to define arrays
(#120) Short array syntax must be used to define arrays
(#121) There should be a comma after the last array item in a multi-line array.
(#138) Short array syntax must be used to define arrays
(#140) Short array syntax must be used to define arrays
(#158) Short array syntax must be used to define arrays
(#162) There should be a comma after the last array item in a multi-line array.
(#174) Short array syntax must be used to define arrays
(#175) There should be a comma after the last array item in a multi-line array.
(#217) Short array syntax must be used to define arrays
(#219) There should be a comma after the last array item in a multi-line array.
(#242) Short array syntax must be used to define arrays
(#245) Short array syntax must be used to define arrays
(#246) There should be a comma after the last array item in a multi-line array.
(#247) There should be a comma after the last array item in a multi-line array.
(#274) Short array syntax must be used to define arrays
(#275) There should be a comma after the last array item in a multi-line array.
(#284) Short array syntax must be used to define arrays
(#285) There should be a comma after the last array item in a multi-line array.
(#309) Short array syntax must be used to define arrays
(#310) There should be a comma after the last array item in a multi-line array.
(#332) Short array syntax must be used to define arrays
(#342) Short array syntax must be used to define arrays
(#345) There should be a comma after the last array item in a multi-line array.
(#348) Short array syntax must be used to define arrays
(#351) Short array syntax must be used to define arrays
(#353) There should be a comma after the last array item in a multi-line array.
(#357) Short array syntax must be used to define arrays
(#358) There should be a comma after the last array item in a multi-line array.
(#363) Short array syntax must be used to define arrays
(#364) There should be a comma after the last array item in a multi-line array.
(#369) Short array syntax must be used to define arrays
(#372) Short array syntax must be used to define arrays
(#372) There should be a comma after the last array item in a multi-line array.
(#380) Short array syntax must be used to define arrays
blocks/clampmail/classes/alternate_form.php
(#62) Short array syntax must be used to define arrays
(#64) There should be a comma after the last array item in a multi-line array.
(#67) Short array syntax must be used to define arrays
blocks/clampmail/classes/config.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#48) Short array syntax must be used to define arrays
(#56) Short array syntax must be used to define arrays
(#72) Short array syntax must be used to define arrays
(#76) There should be a comma after the last array item in a multi-line array.
(#89) Short array syntax must be used to define arrays
blocks/clampmail/classes/config_form.php
(#46) Short array syntax must be used to define arrays
(#48) There should be a comma after the last array item in a multi-line array.
(#64) Short array syntax must be used to define arrays
(#67) There should be a comma after the last array item in a multi-line array.
(#73) Short array syntax must be used to define arrays
(#78) Short array syntax must be used to define arrays
blocks/clampmail/classes/email.php
(#64) Short array syntax must be used to define arrays
(#125) Short array syntax must be used to define arrays
(#166) Short array syntax must be used to define arrays
(#224) Short array syntax must be used to define arrays
(#227) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#230) Short array syntax must be used to define arrays
(#231) Short array syntax must be used to define arrays
(#237) Short array syntax must be used to define arrays
(#238) Short array syntax must be used to define arrays
(#239) Short array syntax must be used to define arrays
(#242) There should be a comma after the last array item in a multi-line array.
(#272) Short array syntax must be used to define arrays
(#276) Short array syntax must be used to define arrays
(#279) Short array syntax must be used to define arrays
(#286) Short array syntax must be used to define arrays
(#293) Short array syntax must be used to define arrays
(#305) Short array syntax must be used to define arrays
(#311) Short array syntax must be used to define arrays
blocks/clampmail/classes/email_form.php
(#72) Short array syntax must be used to define arrays
(#100) Short array syntax must be used to define arrays
(#103) There should be a comma after the last array item in a multi-line array.
(#145) Short array syntax must be used to define arrays
(#150) Short array syntax must be used to define arrays
(#150) Short array syntax must be used to define arrays
(#151) There should be a comma after the last array item in a multi-line array.
(#162) Short array syntax must be used to define arrays
(#168) Short array syntax must be used to define arrays
(#170) Short array syntax must be used to define arrays
(#171) Short array syntax must be used to define arrays
(#175) Short array syntax must be used to define arrays
(#179) Short array syntax must be used to define arrays
(#180) Short array syntax must be used to define arrays
(#184) Short array syntax must be used to define arrays
(#185) There should be a comma after the last array item in a multi-line array.
(#204) Short array syntax must be used to define arrays
(#207) Short array syntax must be used to define arrays
(#210) Short array syntax must be used to define arrays
(#213) Short array syntax must be used to define arrays
(#216) Short array syntax must be used to define arrays
(#219) Short array syntax must be used to define arrays
(#220) Short array syntax must be used to define arrays
(#225) Short array syntax must be used to define arrays
(#232) Short array syntax must be used to define arrays
(#241) Short array syntax must be used to define arrays
(#242) There should be a comma after the last array item in a multi-line array.
(#254) Short array syntax must be used to define arrays
(#257) Short array syntax must be used to define arrays
(#259) There should be a comma after the last array item in a multi-line array.
(#262) Short array syntax must be used to define arrays
(#266) Short array syntax must be used to define arrays
(#271) Short array syntax must be used to define arrays
blocks/clampmail/classes/event/alternate_email_added.php
(#68) Short array syntax must be used to define arrays
(#69) There should be a comma after the last array item in a multi-line array.
blocks/clampmail/classes/groups.php
(#51) Short array syntax must be used to define arrays
(#62) Short array syntax must be used to define arrays
blocks/clampmail/classes/navigation.php
(#44) Short array syntax must be used to define arrays
(#53) Short array syntax must be used to define arrays
(#54) Short array syntax must be used to define arrays
(#55) Short array syntax must be used to define arrays
(#56) Short array syntax must be used to define arrays
(#61) Short array syntax must be used to define arrays
(#66) Short array syntax must be used to define arrays
(#80) Short array syntax must be used to define arrays
(#90) Short array syntax must be used to define arrays
(#94) Short array syntax must be used to define arrays
(#98) Short array syntax must be used to define arrays
(#102) Short array syntax must be used to define arrays
(#104) There should be a comma after the last array item in a multi-line array.
(#110) Short array syntax must be used to define arrays
(#118) Short array syntax must be used to define arrays
(#136) Short array syntax must be used to define arrays
blocks/clampmail/classes/privacy/provider.php
(#30) Import statements must not begin with a leading backslash
(#31) Import statements must not begin with a leading backslash
(#32) Import statements must not begin with a leading backslash
(#33) Import statements must not begin with a leading backslash
(#34) Import statements must not begin with a leading backslash
(#35) Import statements must not begin with a leading backslash
(#36) Import statements must not begin with a leading backslash
(#38) Missing docblock for interface my_userlist
(#63) Method name "_get_metadata" should not be prefixed with an underscore to indicate visibility
(#105) Method name "_get_contexts_for_userid" should not be prefixed with an underscore to indicate visibility
(#122) There should be a comma after the last array item in a multi-line array.
(#126) Short array syntax must be used to define arrays
(#175) Short array syntax must be used to define arrays
(#195) Short array syntax must be used to define arrays
(#196) Short array syntax must be used to define arrays
(#213) Method name "_export_user_data" should not be prefixed with an underscore to indicate visibility
(#239) Short array syntax must be used to define arrays
(#250) Short array syntax must be used to define arrays
(#294) Method name "_delete_data_for_all_users_in_context" should not be prefixed with an underscore to indicate visibility
(#311) Method name "_delete_data_for_user" should not be prefixed with an underscore to indicate visibility
(#337) Short array syntax must be used to define arrays
(#364) Short array syntax must be used to define arrays
(#369) Short array syntax must be used to define arrays
(#392) Short array syntax must be used to define arrays
(#398) Short array syntax must be used to define arrays
(#401) Short array syntax must be used to define arrays
blocks/clampmail/classes/signature.php
(#44) Short array syntax must be used to define arrays
blocks/clampmail/classes/signature_form.php
(#59) Short array syntax must be used to define arrays
(#62) There should be a comma after the last array item in a multi-line array.
(#65) Short array syntax must be used to define arrays
blocks/clampmail/classes/users.php
(#57) Short array syntax must be used to define arrays
(#88) Short array syntax must be used to define arrays
(#109) Short array syntax must be used to define arrays
(#113) Short array syntax must be used to define arrays
blocks/clampmail/config.php
(#33) Short array syntax must be used to define arrays
(#34) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#46) Short array syntax must be used to define arrays
(#49) Short array syntax must be used to define arrays
(#61) Short array syntax must be used to define arrays
(#63) There should be a comma after the last array item in a multi-line array.
blocks/clampmail/db/access.php
(#27) Short array syntax must be used to define arrays
(#29) Short array syntax must be used to define arrays
(#32) Short array syntax must be used to define arrays
(#34) There should be a comma after the last array item in a multi-line array.
(#36) There should be a comma after the last array item in a multi-line array.
(#38) Short array syntax must be used to define arrays
(#41) Short array syntax must be used to define arrays
(#45) There should be a comma after the last array item in a multi-line array.
(#46) There should be a comma after the last array item in a multi-line array.
(#48) Short array syntax must be used to define arrays
(#51) Short array syntax must be used to define arrays
(#55) There should be a comma after the last array item in a multi-line array.
(#56) There should be a comma after the last array item in a multi-line array.
(#58) Short array syntax must be used to define arrays
(#61) Short array syntax must be used to define arrays
(#63) There should be a comma after the last array item in a multi-line array.
(#64) There should be a comma after the last array item in a multi-line array.
(#66) Short array syntax must be used to define arrays
(#69) Short array syntax must be used to define arrays
(#71) There should be a comma after the last array item in a multi-line array.
(#73) Short array syntax must be used to define arrays
(#76) Short array syntax must be used to define arrays
(#78) There should be a comma after the last array item in a multi-line array.
(#80) There should be a comma after the last array item in a multi-line array.
(#81) There should be a comma after the last array item in a multi-line array.
blocks/clampmail/db/upgradelib.php
(#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/clampmail/email.php
(#35) Short array syntax must be used to define arrays
(#36) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#39) Logical operator "and" is prohibited; use "&&" instead
(#39) Short array syntax must be used to define arrays
(#40) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#43) Logical operator "and" is prohibited; use "&&" instead
(#48) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#53) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#59) Short array syntax must be used to define arrays
(#61) Short array syntax must be used to define arrays
(#73) Short array syntax must be used to define arrays
(#119) Short array syntax must be used to define arrays
(#131) Short array syntax must be used to define arrays
(#132) There should be a comma after the last array item in a multi-line array.
(#140) Short array syntax must be used to define arrays
(#145) There should be a comma after the last array item in a multi-line array.
(#151) Short array syntax must be used to define arrays
(#152) Short array syntax must be used to define arrays
(#165) Short array syntax must be used to define arrays
(#174) There should be a comma after the last array item in a multi-line array.
(#204) Logical operator "and" is prohibited; use "&&" instead
(#218) Logical operator "and" is prohibited; use "&&" instead
(#238) Logical operator "and" is prohibited; use "&&" instead
(#304) Short array syntax must be used to define arrays
(#318) Short array syntax must be used to define arrays
(#329) Short array syntax must be used to define arrays
blocks/clampmail/emaillog.php
(#34) Short array syntax must be used to define arrays
(#43) Short array syntax must be used to define arrays
(#44) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#48) Logical operator "and" is prohibited; use "&&" instead
(#49) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#54) Short array syntax must be used to define arrays
(#58) Logical operator "and" is prohibited; use "&&" instead
(#59) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#62) Logical operator "and" is prohibited; use "&&" instead
(#63) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#71) Short array syntax must be used to define arrays
(#75) Short array syntax must be used to define arrays
(#81) Short array syntax must be used to define arrays
(#88) Short array syntax must be used to define arrays
(#90) There should be a comma after the last array item in a multi-line array.
(#94) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#104) Logical operator "and" is prohibited; use "&&" instead
(#105) Short array syntax must be used to define arrays
(#117) Line exceeds 132 characters; contains 134 characters
(#121) Short array syntax must be used to define arrays
(#126) Short array syntax must be used to define arrays
(#128) There should be a comma after the last array item in a multi-line array.
(#131) Short array syntax must be used to define arrays
blocks/clampmail/lang/en/block_clampmail.php
(#64) The string key "alternate" is not in the correct order, it should be before "alternate_waiting"
(#110) The string key "not_valid" is not in the correct order, it should be before "not_valid_user"
(#116) The string key "prepend_class" is not in the correct order, it should be before "prepend_class_desc"
(#129) The string key "receipt" is not in the correct order, it should be before "receipt_help"
blocks/clampmail/lib.php
(#40) Short array syntax must be used to define arrays
(#44) There should be a comma after the last array item in a multi-line array.
(#66) Short array syntax must be used to define arrays
blocks/clampmail/settings.php
(#30) Short array syntax must be used to define arrays
(#34) Short array syntax must be used to define arrays
(#57) Short array syntax must be used to define arrays
(#60) There should be a comma after the last array item in a multi-line array.
(#70) Short array syntax must be used to define arrays
blocks/clampmail/signature.php
(#31) Short array syntax must be used to define arrays
(#35) Short array syntax must be used to define arrays
(#36) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
(#40) Short array syntax must be used to define arrays
(#50) Short array syntax must be used to define arrays
(#51) Short array syntax must be used to define arrays
(#56) Short array syntax must be used to define arrays
(#77) Short array syntax must be used to define arrays
(#78) There should be a comma after the last array item in a multi-line array.
(#95) Short array syntax must be used to define arrays
(#102) Short array syntax must be used to define arrays
(#103) There should be a comma after the last array item in a multi-line array.
(#109) Short array syntax must be used to define arrays
(#123) Short array syntax must be used to define arrays
(#138) Short array syntax must be used to define arrays
(#159) Short array syntax must be used to define arrays
(#162) There should be a comma after the last array item in a multi-line array.
(#164) Short array syntax must be used to define arrays
(#166) There should be a comma after the last array item in a multi-line array.
(#172) Short array syntax must be used to define arrays
blocks/clampmail/tests/privacy_test.php
(#1) No one-line description found in phpdocs for docblock of file privacy_test.php
(#23) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#25) Import statements must not begin with a leading backslash
(#27) Testcase block_clampmail_privacy_testcase should be declared as abstract.
(#27) PHPUnit testcase name "block_clampmail_privacy_testcase" does not match file name "privacy_test"
(#27) PHPUnit class "block_clampmail_privacy_testcase" does not have any namespace. It is recommended to add it to the "block_clampmail" namespace, using more levels if needed, in order to match the code being tested
(#27) Missing docblock for class block_clampmail_privacy_testcase
(#36) Short array syntax must be used to define arrays
(#41) Short array syntax must be used to define arrays
(#49) Short array syntax must be used to define arrays
(#57) Short array syntax must be used to define arrays
(#65) Short array syntax must be used to define arrays
(#66) There should be a comma after the last array item in a multi-line array.
(#70) Short array syntax must be used to define arrays
(#71) There should be a comma after the last array item in a multi-line array.
(#75) Short array syntax must be used to define arrays
(#79) Short array syntax must be used to define arrays
(#79) Line exceeds 132 characters; contains 133 characters
(#106) Short array syntax must be used to define arrays
(#107) Short array syntax must be used to define arrays
(#112) Missing docblock for function insert_message in testcase
(#131) Missing docblock for function insert_signature in testcase
(#146) Missing docblock for function delete_data_for_context in testcase
(#151) Missing docblock for function delete_data_for_user in testcase
(#167) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level
(#167) Test method test_get_contexts_for_userid() is missing a return type
(#197) Test method test_get_users_in_context() is missing any coverage information, own or at class level
(#197) Test method test_get_users_in_context() is missing a return type
(#236) Test method test_user_with_no_data() is missing any coverage information, own or at class level
(#236) Test method test_user_with_no_data() is missing a return type
(#267) Test method test_export_user_data() is missing any coverage information, own or at class level
(#267) Test method test_export_user_data() is missing a return type
(#303) Test method test_delete_user_data() is missing any coverage information, own or at class level
(#303) Test method test_delete_user_data() is missing a return type
(#332) Test method test_delete_all_data() is missing any coverage information, own or at class level
(#332) Test method test_delete_all_data() is missing a return type
(#379) Test method test_delete_data_for_users() is missing any coverage information, own or at class level
(#379) Test method test_delete_data_for_users() is missing a return type
(#403) Line exceeds 132 characters; contains 133 characters
blocks/clampmail/tests/upgradelib_test.php
(#1) No one-line description found in phpdocs for docblock of file upgradelib_test.php
(#28) Testcase block_clampmail_upgradelib_testcase should be declared as abstract.
(#28) PHPUnit testcase name "block_clampmail_upgradelib_testcase" does not match file name "upgradelib_test"
(#28) PHPUnit class "block_clampmail_upgradelib_testcase" does not have any namespace. It is recommended to add it to the "block_clampmail" namespace, using more levels if needed, in order to match the code being tested
(#28) Missing docblock for class block_clampmail_upgradelib_testcase
(#29) Test method test_upgradelib() is missing any coverage information, own or at class level
(#29) Test method test_upgradelib() is missing a return type

Javascript coding style problems

(24 errors, 7 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/clampmail/js/selection.js
(#3) '$' is not defined. (no-undef)
(#4) Identifier 'clampmail_changer' is not in camel case. (camelcase)
(#4) Identifier 'clear_selections' is not in camel case. (camelcase)
(#8) Identifier 'clear_selections' is not in camel case. (camelcase)
(#11) '$' is not defined. (no-undef)
(#13) '$' is not defined. (no-undef)
(#15) Identifier 'clampmail_changer' is not in camel case. (camelcase)
(#17) '$' is not defined. (no-undef)
(#19) '$' is not defined. (no-undef)
(#20) '$' is not defined. (no-undef)
(#21) '$' is not defined. (no-undef)
(#21) Expected to return a value at the end of function. (consistent-return)
(#22) Identifier 'in_list' is not in camel case. (camelcase)
(#23) '$' is not defined. (no-undef)
(#24) '$' is not defined. (no-undef)
(#25) Identifier 'in_list' is not in camel case. (camelcase)
(#30) '$' is not defined. (no-undef)
(#33) '$' is not defined. (no-undef)
(#34) '$' is not defined. (no-undef)
(#42) '$' is not defined. (no-undef)
(#43) '$' is not defined. (no-undef)
(#46) '$' is not defined. (no-undef)
(#47) '$' is not defined. (no-undef)
(#48) '$' is not defined. (no-undef)
(#49) '$' is not defined. (no-undef)
(#50) '$' is not defined. (no-undef)
(#51) '$' is not defined. (no-undef)
(#52) '$' is not defined. (no-undef)
(#55) '$' is not defined. (no-undef)
(#57) '$' is not defined. (no-undef)
(#58) '$' is not defined. (no-undef)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(0 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]


Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]