PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(0 errors, 55 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/clampmail/alt_lib.php: (#171) Logical operator "or" is prohibited; use "||" instead
blocks/clampmail/classes/config.php: (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/clampmail/classes/event/alternate_email_added.php: (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/clampmail/classes/groups.php: (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/clampmail/classes/navigation.php: (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/clampmail/classes/privacy/provider.php: (#44) Duplicate interface name "block_clampmail\privacy\my_userlist" found; first defined in /var/lib/jenkins/git_repositories/prechecker/blocks/clampmail/classes/privacy/provider.php on line 40; (#71) Method name "_get_metadata" should not be prefixed with an underscore to indicate visibility; (#113) Method name "_get_contexts_for_userid" should not be prefixed with an underscore to indicate visibility; (#221) Method name "_export_user_data" should not be prefixed with an underscore to indicate visibility; (#302) Method name "_delete_data_for_all_users_in_context" should not be prefixed with an underscore to indicate visibility; (#319) Method name "_delete_data_for_user" should not be prefixed with an underscore to indicate visibility
blocks/clampmail/classes/users.php: (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#109) Inline comments must end in full-stops, exclamation marks, or question marks
blocks/clampmail/config.php: (#34) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
blocks/clampmail/db/upgrade.php: (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/clampmail/db/upgradelib.php: (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/clampmail/email.php: (#37) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead; (#40) Logical operator "and" is prohibited; use "&&" instead; (#41) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead; (#44) Logical operator "and" is prohibited; use "&&" instead; (#49) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead; (#54) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead; (#205) Logical operator "and" is prohibited; use "&&" instead; (#219) Logical operator "and" is prohibited; use "&&" instead; (#239) Logical operator "and" is prohibited; use "&&" instead
blocks/clampmail/emaillog.php: (#45) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead; (#49) Logical operator "and" is prohibited; use "&&" instead; (#50) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead; (#59) Logical operator "and" is prohibited; use "&&" instead; (#60) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead; (#63) Logical operator "and" is prohibited; use "&&" instead; (#64) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead; (#94) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead; (#103) Logical operator "and" is prohibited; use "&&" instead; (#116) Line exceeds 132 characters; contains 134 characters
blocks/clampmail/lib.php: (#25) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#199) Logical operator "and" is prohibited; use "&&" instead; (#239) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
blocks/clampmail/signature.php: (#36) Logical operator "and" is prohibited; use "&&" instead; (#37) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
blocks/clampmail/tests/privacy_test.php: (#23) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#27) PHPUnit testcase name "block_clampmail_privacy_testcase" does not match file name "privacy_test"; (#27) PHPUnit class "block_clampmail_privacy_testcase" does not have any namespace. It is recommended to add it to the "block_clampmail" namespace, using more levels if needed, in order to match the code being tested; (#79) Line exceeds 132 characters; contains 133 characters; (#167) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level; (#197) Test method test_get_users_in_context() is missing any coverage information, own or at class level; (#236) Test method test_user_with_no_data() is missing any coverage information, own or at class level; (#267) Test method test_export_user_data() is missing any coverage information, own or at class level; (#303) Test method test_delete_user_data() is missing any coverage information, own or at class level; (#332) Test method test_delete_all_data() is missing any coverage information, own or at class level; (#379) Test method test_delete_data_for_users() is missing any coverage information, own or at class level; (#403) Line exceeds 132 characters; contains 133 characters
blocks/clampmail/tests/upgradelib_test.php: (#28) PHPUnit testcase name "block_clampmail_upgradelib_testcase" does not match file name "upgradelib_test"; (#28) PHPUnit class "block_clampmail_upgradelib_testcase" does not have any namespace. It is recommended to add it to the "block_clampmail" namespace, using more levels if needed, in order to match the code being tested; (#29) Test method test_upgradelib() is missing any coverage information, own or at class level

Javascript coding style problems

(24 errors, 7 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/clampmail/js/selection.js: (#3) '$' is not defined. (no-undef); (#4) Identifier 'clampmail_changer' is not in camel case. (camelcase); (#4) Identifier 'clear_selections' is not in camel case. (camelcase); (#8) Identifier 'clear_selections' is not in camel case. (camelcase); (#11) '$' is not defined. (no-undef); (#13) '$' is not defined. (no-undef); (#15) Identifier 'clampmail_changer' is not in camel case. (camelcase); (#17) '$' is not defined. (no-undef); (#19) '$' is not defined. (no-undef); (#20) '$' is not defined. (no-undef); (#21) '$' is not defined. (no-undef); (#21) Expected to return a value at the end of function. (consistent-return); (#22) Identifier 'in_list' is not in camel case. (camelcase); (#23) '$' is not defined. (no-undef); (#24) '$' is not defined. (no-undef); (#25) Identifier 'in_list' is not in camel case. (camelcase); (#30) '$' is not defined. (no-undef); (#33) '$' is not defined. (no-undef); (#34) '$' is not defined. (no-undef); (#42) '$' is not defined. (no-undef); (#43) '$' is not defined. (no-undef); (#46) '$' is not defined. (no-undef); (#47) '$' is not defined. (no-undef); (#48) '$' is not defined. (no-undef); (#49) '$' is not defined. (no-undef); (#50) '$' is not defined. (no-undef); (#51) '$' is not defined. (no-undef); (#52) '$' is not defined. (no-undef); (#55) '$' is not defined. (no-undef); (#57) '$' is not defined. (no-undef); (#58) '$' is not defined. (no-undef)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

PHPDocs style problems

(4 errors, 4 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/clampmail/tests/privacy_test.php: (#27) Class block_clampmail_privacy_testcase is not documented; (#112) Function block_clampmail_privacy_testcase::insert_message is not documented; (#131) Function block_clampmail_privacy_testcase::insert_signature is not documented; (#146) Function block_clampmail_privacy_testcase::delete_data_for_context is not documented; (#151) Function block_clampmail_privacy_testcase::delete_data_for_user is not documented; (#17) No one-line description found in phpdocs for file
blocks/clampmail/tests/upgradelib_test.php: (#28) Class block_clampmail_upgradelib_testcase is not documented; (#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]