Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(67 errors, 34 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

blocks/assignment_review/block_assignment_review.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#43) Whitespace found at end of line
(#45) Whitespace found at end of line
(#54) global $PAGE cannot be used in block classes. Use $this->page.
(#55) Whitespace found at end of line
(#56) global $PAGE cannot be used in block classes. Use $this->page.
(#57) Whitespace found at end of line
(#60) Whitespace found at end of line
(#70) global $PAGE cannot be used in block classes. Use $this->page.
(#99) Inline comments must start with a capital letter, digit or 3-dots sequence
(#100) Expected "if (...) {\n"; found "if(...) {\n"
(#101) global $PAGE cannot be used in block classes. Use $this->page.
(#108) global $PAGE cannot be used in block classes. Use $this->page.
(#115) Inline comments must end in full-stops, exclamation marks, or question marks
(#118) Inline comments must end in full-stops, exclamation marks, or question marks
(#135) Inline comments must start with a capital letter, digit or 3-dots sequence
(#135) This comment is 53% valid code; is this commented out code?
(#135) Line indented incorrectly; expected at least 16 spaces, found 0
(#135) Expected 1 space before comment text but found 16; use block comment if you need indentation
(#136) Line indented incorrectly; expected at least 16 spaces, found 0
(#136) Expected 1 space before comment text but found 16; use block comment if you need indentation
(#137) Line indented incorrectly; expected at least 16 spaces, found 0
(#137) Expected 1 space before comment text but found 20; use block comment if you need indentation
(#138) Line indented incorrectly; expected at least 16 spaces, found 0
(#138) Expected 1 space before comment text but found 20; use block comment if you need indentation
(#139) Line indented incorrectly; expected at least 16 spaces, found 0
(#139) Expected 1 space before comment text but found 16; use block comment if you need indentation
(#142) Whitespace found at end of line within string
(#147) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#149) Inline comments must end in full-stops, exclamation marks, or question marks
(#150) global $PAGE cannot be used in block classes. Use $this->page.
(#156) Inline comments must start with a capital letter, digit or 3-dots sequence
(#161) global $PAGE cannot be used in block classes. Use $this->page.
(#175) Inline comments must end in full-stops, exclamation marks, or question marks
(#187) Whitespace found at end of line within string
(#194) global $PAGE cannot be used in block classes. Use $this->page.
(#195) global $PAGE cannot be used in block classes. Use $this->page.
blocks/assignment_review/classes/comment.php
(#18) Expected 1 space(s) before asterisk; 0 found
(#19) Expected 1 space(s) before asterisk; 0 found
(#20) Expected 1 space(s) before asterisk; 0 found
(#21) Expected 1 space(s) before asterisk; 0 found
(#22) Expected 1 space(s) before asterisk; 0 found
(#23) Expected 1 space(s) before asterisk; 0 found
(#24) Expected 1 space(s) before asterisk; 0 found
(#30) Expected 1 space(s) before asterisk; 0 found
(#31) Expected 1 space(s) before asterisk; 0 found
(#32) Expected 1 space(s) before asterisk; 0 found
(#36) Expected 1 space(s) before asterisk; 0 found
(#45) Expected 1 space before "=>"; 0 found
(#45) Expected 1 space after "=>"; 0 found
(#48) File must end with a newline character
blocks/assignment_review/classes/privacy/provider.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#56) Method name "_get_metadata" should not be prefixed with an underscore to indicate visibility
(#67) Method name "_get_contexts_for_userid" should not be prefixed with an underscore to indicate visibility
(#79) Functions must not contain multiple empty lines in a row; found 2 empty lines
(#89) Method name "_export_user_data" should not be prefixed with an underscore to indicate visibility
(#109) Method name "_delete_data_for_all_users_in_context" should not be prefixed with an underscore to indicate visibility
(#122) Method name "_delete_data_for_user" should not be prefixed with an underscore to indicate visibility
blocks/assignment_review/db/access.php
(#29) Whitespace found at end of line
blocks/assignment_review/db/install.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/assignment_review/db/uninstall.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
blocks/assignment_review/db/upgrade.php
(#47) Inline comments must end in full-stops, exclamation marks, or question marks
(#48) Whitespace found at end of line
(#54) Functions must not contain multiple empty lines in a row; found 2 empty lines
blocks/assignment_review/db/upgradelib.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#39) Inline comments must end in full-stops, exclamation marks, or question marks
blocks/assignment_review/edit_form.php
(#57) Whitespace found at end of line
(#68) Line exceeds 132 characters; contains 143 characters
blocks/assignment_review/lib.php
(#42) Inline comments must end in full-stops, exclamation marks, or question marks
(#49) Inline comments must start with a capital letter, digit or 3-dots sequence
(#50) Line indented incorrectly; expected at least 4 spaces, found 0
(#50) Expected 1 space before comment text but found 4; use block comment if you need indentation
(#51) Line indented incorrectly; expected at least 4 spaces, found 0
(#51) Expected 1 space before comment text but found 8; use block comment if you need indentation
(#52) Inline comments must end in full-stops, exclamation marks, or question marks
(#52) Line indented incorrectly; expected at least 4 spaces, found 0
(#52) Expected 1 space before comment text but found 4; use block comment if you need indentation
(#60) Inline comments must start with a capital letter, digit or 3-dots sequence
(#62) Inline comments must start with a capital letter, digit or 3-dots sequence
(#93) Variable "comment_param" must not contain underscores.
(#94) Variable "comment_param" must not contain underscores.
(#97) Variable "comment_param" must not contain underscores.
(#113) Expected 1 space before "=>"; 0 found
(#113) Expected 1 space after "=>"; 0 found
(#113) Expected 1 space before "=>"; 0 found
(#113) Expected 1 space after "=>"; 0 found
blocks/assignment_review/settings.php
(#45) Expected 1 space before "="; 0 found
(#45) Expected 1 space after "="; 0 found
(#46) Line exceeds 132 characters; contains 146 characters
(#48) Line exceeds 132 characters; contains 136 characters
(#67) Expected 1 space before "="; 0 found
(#67) Expected 1 space after "="; 0 found
(#68) Line exceeds 132 characters; contains 144 characters
(#70) Line exceeds 132 characters; contains 134 characters
(#82) Line exceeds 132 characters; contains 133 characters
(#84) Whitespace found at end of line
(#85) Line exceeds 132 characters; contains 143 characters
(#88) Line exceeds 132 characters; contains 149 characters
(#91) File must end with a newline character
blocks/assignment_review/tests/privacy_test.php
(#49) PHPUnit testcase name "block_assignment_review_privacy_testcase" does not match file name "privacy_test"
(#49) PHPUnit class "block_assignment_review_privacy_testcase" does not have any namespace. It is recommended to add it to the "block_assignment_review" namespace, using more levels if needed, in order to match the code being tested

Javascript coding style problems

(15 errors, 8 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

blocks/assignment_review/script.js
(#26) '$' is not defined. (no-undef)
(#27) '$' is not defined. (no-undef)
(#30) '$' is not defined. (no-undef)
(#32) '$' is not defined. (no-undef)
(#35) More than 2 blank lines not allowed. (no-multiple-empty-lines)
(#37) '$' is not defined. (no-undef)
(#41) Expected space or tab after '//' in comment. (spaced-comment)
(#43) '$' is not defined. (no-undef)
(#48) '$' is not defined. (no-undef)
(#48) There should be no space before this paren. (space-in-parens)
(#51) More than 2 blank lines not allowed. (no-multiple-empty-lines)
(#52) '$' is not defined. (no-undef)
(#53) '$' is not defined. (no-undef)
(#56) More than 2 blank lines not allowed. (no-multiple-empty-lines)
(#57) '$' is not defined. (no-undef)
(#59) '$' is not defined. (no-undef)
(#60) '$' is not defined. (no-undef)
(#67) '$' is not defined. (no-undef)
(#67) Operator '+' must be spaced. (space-infix-ops)
(#67) Operator '+' must be spaced. (space-infix-ops)
(#67) A space is required after ','. (comma-spacing)
(#70) '$' is not defined. (no-undef)
(#74) Missing semicolon. (semi)

CSS problems

(3 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

blocks/assignment_review/styles.css
(#15) Expected newline after "{" (block-opening-brace-newline-after)
(#12) Expected a trailing semicolon (declaration-block-trailing-semicolon)
(#15) Unexpected whitespace at end of line (no-eol-whitespace)

PHPDocs style problems

(6 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

blocks/assignment_review/edit_form.php
(#36) Phpdocs for function block_assignment_review_edit_form::specific_definition has incomplete parameters list
blocks/assignment_review/lib.php
(#81) Package block_comments is not valid
(#106) Package block_comments is not valid
(#119) Package block_comments is not valid
(#31) Phpdocs for function block_assignment_review_pluginfile has incomplete parameters list
(#122) Phpdocs for function block_assignment_review_comment_display has incomplete parameters list

Update savepoints problems

(2 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

blocks/assignment_review/db/upgrade.php
Detected more 'if' blocks (1) than 'savepoint' calls (0)
version 2018101902 is missing corresponding savepoint call

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]