Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(7 errors, 7 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

availability/condition/gps/classes/button.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#37) Expected 1 space before opening brace; found 2
availability/condition/gps/classes/condition.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) Inline comments must end in full-stops, exclamation marks, or question marks
(#65) Line exceeds 132 characters; contains 140 characters
(#127) Expected "if (...) {\n"; found "if(...) {\n"
(#131) Usage of ELSEIF not allowed; use ELSE IF instead
(#163) Expected 1 space before "/"; 0 found
(#163) Expected 1 space after "/"; 0 found
(#165) Commas (,) must be followed by white space.
availability/condition/gps/classes/frontend.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#33) Inline comments must end in full-stops, exclamation marks, or question marks
availability/condition/gps/classes/privacy/provider.php
(#1) End of line character is invalid; expected "\n" but found "\r\n"
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.

Javascript coding style problems

(5 errors, 37 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

availability/condition/gps/yui/src/form/js/form.js
(#1) Identifier 'availability_gps' is not in camel case. (camelcase)
(#3) There should be no space after '['. (array-bracket-spacing)
(#8) Unexpected console statement. (no-console)
(#24) There should be no space after this paren. (space-in-parens)
(#24) There should be no space before this paren. (space-in-parens)
(#24) There should be no space after this paren. (space-in-parens)
(#24) There should be no space before this paren. (space-in-parens)
(#25) There should be no space after this paren. (space-in-parens)
(#25) There should be no space before this paren. (space-in-parens)
(#25) There should be no space after this paren. (space-in-parens)
(#25) There should be no space before this paren. (space-in-parens)
(#36) 'M.str' is restricted from being used. Use AMD module "core/str" or M.util.get_string() (no-restricted-properties)
(#56) This line has a length of 140. Maximum allowed is 132. (max-len)
(#58) Multiple spaces found before 'strings'. (no-multi-spaces)
(#58) There should be no space after this paren. (space-in-parens)
(#65) This line has a length of 162. Maximum allowed is 132. (max-len)
(#69) This line has a length of 164. Maximum allowed is 132. (max-len)
(#74) 'options' is already defined. (no-redeclare)
(#77) Operator '+' must be spaced. (space-infix-ops)
(#77) Operator '+' must be spaced. (space-infix-ops)
(#77) Operator '+' must be spaced. (space-infix-ops)
(#77) Operator '+' must be spaced. (space-infix-ops)
(#77) Operator '+' must be spaced. (space-infix-ops)
(#77) Operator '+' must be spaced. (space-infix-ops)
(#77) Operator '+' must be spaced. (space-infix-ops)
(#77) Operator '+' must be spaced. (space-infix-ops)
(#77) Operator '+' must be spaced. (space-infix-ops)
(#79) Operator '?' must be spaced. (space-infix-ops)
(#79) Operator ':' must be spaced. (space-infix-ops)
(#96) Comments should not begin with a lowercase character. (capitalized-comments)
(#96) Expected space or tab after '//' in comment. (spaced-comment)
(#97) This line has a length of 137. Maximum allowed is 132. (max-len)
(#112) Statement inside of curly braces should be on next line. (brace-style)
(#112) Requires a space before '}'. (block-spacing)
(#112) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#117) Statement inside of curly braces should be on next line. (brace-style)
(#117) Requires a space before '}'. (block-spacing)
(#117) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#123) Statement inside of curly braces should be on next line. (brace-style)
(#123) Requires a space before '}'. (block-spacing)
(#123) Closing curly brace should be on the same line as opening curly brace or on the line after the previous block. (brace-style)
(#138) Expected space(s) after "for". (keyword-spacing)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(21 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

availability/condition/gps/classes/button.php
(#38) Function button::render is not documented
availability/condition/gps/classes/condition.php
(#44) Function condition::__construct is not documented
(#86) Function condition::save is not documented
(#101) Function condition::is_available is not documented
(#151) Function condition::get_description is not documented
(#178) Function condition::get_debug_string is not documented
(#38) Variable condition::$accuracy is not documented
(#39) Variable condition::$longitude is not documented
(#40) Variable condition::$latitude is not documented
(#41) Variable condition::$persistent is not documented
(#42) Variable condition::$reveal is not documented
availability/condition/gps/classes/frontend.php
(#28) Class frontend is not documented
(#29) Function frontend::get_javascript_strings is not documented
(#41) Function frontend::get_javascript_init_params is not documented
(#47) Function frontend::allow_add is not documented
availability/condition/gps/classes/privacy/provider.php
(#29) Class provider is not documented
(#30) Function provider::get_metadata is not documented
(#17) No one-line description found in phpdocs for file
availability/condition/gps/lang/de/availability_gps.php
(#17) No one-line description found in phpdocs for file
availability/condition/gps/lang/en/availability_gps.php
(#17) No one-line description found in phpdocs for file
availability/condition/gps/version.php
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "eslint:yui" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]