PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(68 errors, 35 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- auth/shibboleth_link/auth.php
- (#56) Visibility must be declared on method "loginpage_hook"
- (#61) Expected 6 space(s) before asterisk; 5 found
- (#62) Expected 6 space(s) before asterisk; 5 found
- (#63) Expected 6 space(s) before asterisk; 5 found
- (#64) Visibility must be declared on method "logoutpage_hook"
- (#77) Visibility must be declared on method "user_login"
- (#78) Line indented incorrectly; expected at least 8 spaces, found 7
- auth/shibboleth_link/classes/lib.php
- (#29) Member variable "ACTION_CREATE" must be all lower-case
- (#29) Member variable "ACTION_CREATE" must not contain underscores.
- (#30) Member variable "ACTION_LINK_OTHER" must be all lower-case
- (#30) Member variable "ACTION_LINK_OTHER" must not contain underscores.
- (#31) Member variable "ACTION_LINK_CURRENT" must be all lower-case
- (#31) Member variable "ACTION_LINK_CURRENT" must not contain underscores.
- (#37) Must use "self::" for local static member reference
- (#56) Inline comments must end in full-stops, exclamation marks, or question marks
- (#59) Inline comments must end in full-stops, exclamation marks, or question marks
- (#59) 3 slashes comments are not allowed; use "// Comment." instead
- (#63) Inline comments must end in full-stops, exclamation marks, or question marks
- (#63) 3 slashes comments are not allowed; use "// Comment." instead
- (#64) Inline comments must end in full-stops, exclamation marks, or question marks
- (#64) 3 slashes comments are not allowed; use "// Comment." instead
- (#67) Inline comments must end in full-stops, exclamation marks, or question marks
- (#67) 3 slashes comments are not allowed; use "// Comment." instead
- (#68) Line exceeds 132 characters; contains 175 characters
- (#77) AS keyword must be lowercase; expected "as" but found "AS"
- (#84) Inline control structures are not allowed
- (#85) Inline control structures are not allowed
- (#92) Inline control structures are not allowed
- (#93) Inline control structures are not allowed
- (#175) Inline control structures are not allowed
- (#177) Line exceeds 132 characters; contains 135 characters
- auth/shibboleth_link/classes/privacy/provider.php
- (#1) End of line character is invalid; expected "\n" but found "\r\n"
- auth/shibboleth_link/index.php
- (#2) The opening <?php tag must be followed by exactly one newline.
- (#3) Inline comments must end in full-stops, exclamation marks, or question marks
- (#5) Inline comments must end in full-stops, exclamation marks, or question marks
- (#7) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
- (#25) Variable "ACTION_CREATE" must be all lower-case
- (#25) Variable "ACTION_CREATE" must not contain underscores.
- (#25) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#47) Variable "ACTION_LINK_OTHER" must be all lower-case
- (#47) Variable "ACTION_LINK_OTHER" must not contain underscores.
- (#47) Line exceeds 132 characters; contains 172 characters
- (#65) Line exceeds 132 characters; contains 151 characters
- (#84) Variable "ACTION_LINK_CURRENT" must be all lower-case
- (#84) Variable "ACTION_LINK_CURRENT" must not contain underscores.
- (#84) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#92) Variable "ACTION_LINK_CURRENT" must be all lower-case
- (#92) Variable "ACTION_LINK_CURRENT" must not contain underscores.
- (#92) Line exceeds 132 characters; contains 178 characters
- (#97) Variable "ACTION_LINK_OTHER" must be all lower-case
- (#97) Variable "ACTION_LINK_OTHER" must not contain underscores.
- (#97) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#104) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#106) Variable "ACTION_LINK_CURRENT" must be all lower-case
- (#106) Variable "ACTION_LINK_CURRENT" must not contain underscores.
- (#106) Line exceeds 132 characters; contains 174 characters
- (#117) Inline comments must end in full-stops, exclamation marks, or question marks
- (#119) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
- (#120) Line indented incorrectly; expected 0 spaces, found 1
- (#120) Closing brace indented incorrectly; expected 0 spaces, found 1
- (#122) Inline comments must end in full-stops, exclamation marks, or question marks
- (#122) 3 slashes comments are not allowed; use "// Comment." instead
- (#123) Inline comments must end in full-stops, exclamation marks, or question marks
- (#125) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#175) Expected "foreach (...) {\n"; found "foreach(...) {\n"
- (#175) AS keyword must be lowercase; expected "as" but found "AS"
- (#209) Inline comments must end in full-stops, exclamation marks, or question marks
- (#210) Usage of ELSEIF not allowed; use ELSE IF instead
- (#211) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
- (#211) Line exceeds maximum limit of 180 characters; contains 239 characters
- (#213) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
- auth/shibboleth_link/login.php
- (#2) The opening <?php tag must be followed by exactly one newline.
- (#3) Inline comments must end in full-stops, exclamation marks, or question marks
- (#4) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
- (#13) Variable "session_has_timed_out" must not contain underscores.
- (#16) Variable "session_has_timed_out" must not contain underscores.
- (#66) Inline control structures are not allowed
- (#68) This comment is 62% valid code; is this commented out code?
- (#82) Line indented incorrectly; expected 0 spaces, found 4
- (#84) Line indented incorrectly; expected 4 spaces, found 8
- (#86) Line indented incorrectly; expected 4 spaces, found 8
- (#87) Line indented incorrectly; expected 0 spaces, found 4
- (#90) Line indented incorrectly; expected 0 spaces, found 4
- (#98) Line indented incorrectly; expected 0 spaces, found 4
- (#104) Line indented incorrectly; expected 0 spaces, found 4
- (#106) Line indented incorrectly; expected 0 spaces, found 4
- (#107) Line indented incorrectly; expected 4 spaces, found 8
- (#109) Line indented incorrectly; expected 4 spaces, found 8
- (#110) Line indented incorrectly; expected 0 spaces, found 4
- (#121) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#121) This comment is 50% valid code; is this commented out code?
- (#121) No space found before comment text; expected "// 'loginname' => $config->login_name ?? null," but found "//'loginname' => $config->login_name ?? null,"
- (#134) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#134) Line indented incorrectly; expected at least 4 spaces, found 0
- (#134) No space found before comment text; expected "// }" but found "//}"
- (#135) Line indented incorrectly; expected at least 4 spaces, found 0
- (#135) Inline control structures are not allowed
- auth/shibboleth_link/logout.php
- (#2) The opening <?php tag must be followed by exactly one newline.
- (#9) Inline comments must end in full-stops, exclamation marks, or question marks
- (#13) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
- (#20) Inline comments must end in full-stops, exclamation marks, or question marks
- (#136) function name "LogoutNotification" must be lower-case letters only
- auth/shibboleth_link/settings.php
- (#21) Expected 1 space(s) before asterisk; 0 found
Javascript coding style problems
(0 errors, 0 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
CSS problems
(0 errors, 0 warnings)
This section shows CSS problems detected by stylelint [More info]
PHPDocs style problems
(35 errors, 3 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- auth/shibboleth_link/auth.php
- (#17) No one-line description found in phpdocs for file
- auth/shibboleth_link/classes/lib.php
- (#28) Class lib is not documented
- (#35) Function lib::check_hooks is not documented
- (#29) Variable lib::$ACTION_CREATE is not documented
- (#30) Variable lib::$ACTION_LINK_OTHER is not documented
- (#31) Variable lib::$ACTION_LINK_CURRENT is not documented
- (#33) Variable lib::$datahash is not documented
- (#59) Found comment starting with three or more slashes
- (#63) Found comment starting with three or more slashes
- (#64) Found comment starting with three or more slashes
- (#67) Found comment starting with three or more slashes
- (#17) No one-line description found in phpdocs for file
- (#48) Phpdocs for function lib::check_login has incomplete parameters list
- (#87) Phpdocs for function lib::datahash has incomplete parameters list
- (#130) Phpdocs for function lib::link_data_store_cache has incomplete parameters list
- (#140) Phpdocs for function lib::link_get has incomplete parameters list
- (#162) Phpdocs for function lib::link_log_used has incomplete parameters list
- (#169) Phpdocs for function lib::link_store has incomplete parameters list
- auth/shibboleth_link/classes/privacy/provider.php
- (#18) Package local_edumessenger is not valid
- (#29) Class provider is not documented
- (#31) Function provider::get_metadata is not documented
- (#17) No one-line description found in phpdocs for file
- auth/shibboleth_link/db/access.php
- (#17) No one-line description found in phpdocs for file
- auth/shibboleth_link/db/caches.php
- (#17) No one-line description found in phpdocs for file
- auth/shibboleth_link/db/upgrade.php
- (#26) Function xmldb_auth_shibboleth_link_upgrade is not documented
- (#17) No one-line description found in phpdocs for file
- auth/shibboleth_link/index.php
- (#2) Empty line found after PHP open tag
- (#7) File-level phpdocs block is not found
- (#122) Found comment starting with three or more slashes
- auth/shibboleth_link/lang/de/auth_shibboleth_link.php
- (#17) No one-line description found in phpdocs for file
- auth/shibboleth_link/lang/en/auth_shibboleth_link.php
- (#17) No one-line description found in phpdocs for file
- auth/shibboleth_link/login.php
- (#2) Empty line found after PHP open tag
- (#4) File-level phpdocs block is not found
- auth/shibboleth_link/logout.php
- (#130) Package is not specified for function LogoutNotification. It is also not specified in file-level phpdocs
- (#2) Empty line found after PHP open tag
- (#13) File-level phpdocs block is not found
- auth/shibboleth_link/settings.php
- (#17) No one-line description found in phpdocs for file
- auth/shibboleth_link/version.php
- (#17) No one-line description found in phpdocs for file
Update savepoints problems
(0 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
grunt changes
(0 errors, 0 warnings)
This section shows files built by grunt and not commited [More info]
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(0 errors, 2 warnings)
This section shows problems detected in mustache templates [More info]
- auth/shibboleth_link/templates/alert.mustache
- (#1) Example context missing (@template section not found.)
- auth/shibboleth_link/templates/link_or_create.mustache
- (#1) Example context missing (@template section not found.)
Gherkin .feature problems
(0 errors, 0 warnings)
This section shows problems detected in behat .feature files [More info]