PHP coding style problems

(95 errors, 27 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/samlidp/auth.php: (#36) Member variable "simplesamlAutoloadPhp" must be all lower-case; (#54) Expected 0 spaces after "loginpage_hook"; 1 found; (#57) Logical operator "and" is prohibited; use "&&" instead; (#58) Perl-style comments are not allowed; use "// Comment." instead; (#59) Perl-style comments are not allowed; use "// Comment." instead; (#66) Perl-style comments are not allowed; use "// Comment." instead; (#78) Expected 0 spaces after "set_cookie"; 1 found; (#81) Variable "sspConfig" must be all lower-case; (#82) Variable "sspAuthsources" must be all lower-case; (#83) Variable "cookieName" must be all lower-case; (#83) Variable "sspAuthsources" must be all lower-case; (#85) Variable "cookieName" must be all lower-case; (#85) Variable "cookieName" must be all lower-case; (#85) Variable "cookieName" must be all lower-case; (#86) Variable "sspConfig" must be all lower-case; (#87) Variable "cookieName" must be all lower-case; (#87) Variable "sspConfig" must be all lower-case; (#87) Line exceeds 132 characters; contains 149 characters; (#104) Expected 0 spaces after "user_authenticated_hook"; 1 found; (#112) Perl-style comments are not allowed; use "// Comment." instead; (#114) Perl-style comments are not allowed; use "// Comment." instead; (#129) Variable "sspConfig" must be all lower-case; (#130) Variable "sspAuthsources" must be all lower-case; (#131) Variable "cookieName" must be all lower-case; (#131) Variable "sspAuthsources" must be all lower-case; (#132) Variable "cookieName" must be all lower-case; (#132) Variable "cookieName" must be all lower-case; (#132) Variable "cookieName" must be all lower-case; (#134) Variable "cookieName" must be all lower-case; (#134) Variable "sspConfig" must be all lower-case; (#163) Expected 0 spaces after "report_misconfigured_authsouces"; 1 found; (#164) Line exceeds 132 characters; contains 150 characters; (#174) Expected 0 spaces after "report_missing_autoload"; 1 found; (#175) Line exceeds 132 characters; contains 138 characters
auth/samlidp/classes/privacy/provider.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#44) There must not be a space before the colon in a return type declaration; (#48) Inline comments must end in full-stops, exclamation marks, or question marks; (#49) Short array syntax must be used to define arrays; (#51) This comment is 67% valid code; is this commented out code?; (#51) Line indented incorrectly; expected at least 8 spaces, found 0; (#51) Perl-style comments are not allowed; use "// Comment." instead; (#58) This comment is 67% valid code; is this commented out code?; (#58) Line indented incorrectly; expected at least 8 spaces, found 0; (#58) Perl-style comments are not allowed; use "// Comment." instead; (#85) This comment is 67% valid code; is this commented out code?; (#85) Line indented incorrectly; expected at least 8 spaces, found 0; (#85) Perl-style comments are not allowed; use "// Comment." instead; (#104) Short array syntax must be used to define arrays; (#106) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4 and removed in PHP 8.0. Found: $exportedfields{'profile_field_'.$profilefield->shortname}; (#122) There must not be a space before the colon in a return type declaration
auth/samlidp/logout.php: (#25) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#32) Inline comments must start with a capital letter, digit or 3-dots sequence; (#32) Inline comments must end in full-stops, exclamation marks, or question marks; (#40) Inline comments must start with a capital letter, digit or 3-dots sequence; (#40) Inline comments must end in full-stops, exclamation marks, or question marks; (#45) Inline comments must start with a capital letter, digit or 3-dots sequence; (#45) Inline comments must end in full-stops, exclamation marks, or question marks
auth/samlidp/moodle/public/resume.php: (#25) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
auth/samlidp/moodle/src/Auth/Source/External.php: (#26) Perl-style comments are not allowed; use "// Comment." instead; (#38) Perl-style comments are not allowed; use "// Comment." instead; (#52) Line exceeds maximum limit of 180 characters; contains 192 characters; (#52) Perl-style comments are not allowed; use "// Comment." instead; (#54) Variable "ssp_config" must not contain underscores.; (#55) Variable "ssp_config" must not contain underscores.; (#56) Variable "ssp_config" must not contain underscores.; (#60) Expected 0 spaces after "authenticate"; 1 found; (#63) Perl-style comments are not allowed; use "// Comment." instead; (#67) Perl-style comments are not allowed; use "// Comment." instead; (#69) Variable "state_id" must not contain underscores.; (#70) Variable "return_to" must not contain underscores.; (#70) Short array syntax must be used to define arrays; (#70) Variable "state_id" must not contain underscores.; (#71) Variable "auth_page" must not contain underscores.; (#71) Variable "return_to" must not contain underscores.; (#72) Variable "httpUtils" must be all lower-case; (#73) Variable "httpUtils" must be all lower-case; (#73) Variable "auth_page" must not contain underscores.; (#73) Short array syntax must be used to define arrays; (#73) Variable "return_to" must not contain underscores.; (#81) Variable "state_id" must not contain underscores.; (#83) Variable "state_id" must not contain underscores.; (#85) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"; (#94) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"; (#100) Perl-style comments are not allowed; use "// Comment." instead; (#103) Private method name "External::getUser" must be in lower-case letters only; (#106) Variable "str_cookie" must not contain underscores.; (#107) Line exceeds 132 characters; contains 177 characters; (#107) Perl-style comments are not allowed; use "// Comment." instead; (#108) Perl-style comments are not allowed; use "// Comment." instead; (#109) Variable "arr_cookie" must not contain underscores.; (#109) Variable "str_cookie" must not contain underscores.; (#111) Variable "arr_cookie" must not contain underscores.; (#111) Variable "arr_cookie" must not contain underscores.; (#112) Variable "arr_cookie" must not contain underscores.; (#112) Variable "arr_cookie" must not contain underscores.; (#114) Perl-style comments are not allowed; use "// Comment." instead; (#115) Variable "arr_cookie" must not contain underscores.; (#115) Variable "arr_cookie" must not contain underscores.; (#115) Line exceeds 132 characters; contains 133 characters; (#116) Variable "arr_cookie" must not contain underscores.; (#123) Perl-style comments are not allowed; use "// Comment." instead; (#129) Perl-style comments are not allowed; use "// Comment." instead; (#147) Perl-style comments are not allowed; use "// Comment." instead; (#148) Short array syntax must be used to define arrays; (#149) Variable "profile_fields" must not contain underscores.; (#151) Perl-style comments are not allowed; use "// Comment." instead; (#152) Perl-style comments are not allowed; use "// Comment." instead; (#157) Perl-style comments are not allowed; use "// Comment." instead; (#159) Short array syntax must be used to define arrays; (#161) Variable "profile_fields" must not contain underscores.; (#162) Short array syntax must be used to define arrays; (#167) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"; (#169) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"; (#172) Expected 0 spaces after "logout"; 1 found; (#182) Variable "logout_url" must not contain underscores.; (#184) Variable "logout_url" must not contain underscores.; (#187) Variable "httpUtils" must be all lower-case; (#188) Variable "httpUtils" must be all lower-case; (#188) Variable "logout_url" must not contain underscores.
auth/samlidp/settings.php: (#29) Inline comments must end in full-stops, exclamation marks, or question marks; (#34) Inline comments must start with a capital letter, digit or 3-dots sequence; (#34) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

Prechecker results: error

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

grunt changes

shifter problems

Mustache template problems

Gherkin .feature problems