PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(79 errors, 53 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/samlidp/auth.php: (#36) Member variable "simplesamlAutoloadPhp" must be all lower-case; (#58) Perl-style comments are not allowed; use "// Comment." instead; (#59) Perl-style comments are not allowed; use "// Comment." instead; (#66) Perl-style comments are not allowed; use "// Comment." instead; (#81) Variable "sspConfig" must be all lower-case; (#82) Variable "sspAuthsources" must be all lower-case; (#83) Variable "cookieName" must be all lower-case; (#83) Variable "sspAuthsources" must be all lower-case; (#85) Variable "cookieName" must be all lower-case; (#85) Variable "cookieName" must be all lower-case; (#85) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $cookieName{'cookie_name'}; (#85) Variable "cookieName" must be all lower-case; (#85) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $cookieName{'cookie_name'}; (#86) Variable "sspConfig" must be all lower-case; (#87) Variable "cookieName" must be all lower-case; (#87) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $cookieName{'cookie_name'}; (#87) Variable "sspConfig" must be all lower-case; (#87) Line exceeds 132 characters; contains 149 characters; (#112) Perl-style comments are not allowed; use "// Comment." instead; (#114) Perl-style comments are not allowed; use "// Comment." instead; (#129) Variable "sspConfig" must be all lower-case; (#130) Variable "sspAuthsources" must be all lower-case; (#131) Variable "cookieName" must be all lower-case; (#131) Variable "sspAuthsources" must be all lower-case; (#132) Variable "cookieName" must be all lower-case; (#132) Variable "cookieName" must be all lower-case; (#132) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $cookieName{'cookie_name'}; (#132) Variable "cookieName" must be all lower-case; (#132) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $cookieName{'cookie_name'}; (#134) Variable "cookieName" must be all lower-case; (#134) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $cookieName{'cookie_name'}; (#134) Variable "sspConfig" must be all lower-case; (#164) Line exceeds 132 characters; contains 150 characters; (#175) Line exceeds 132 characters; contains 138 characters
auth/samlidp/classes/privacy/provider.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#48) Inline comments must end in full-stops, exclamation marks, or question marks; (#51) This comment is 67% valid code; is this commented out code?; (#51) Line indented incorrectly; expected at least 8 spaces, found 0; (#51) Perl-style comments are not allowed; use "// Comment." instead; (#58) This comment is 67% valid code; is this commented out code?; (#58) Line indented incorrectly; expected at least 8 spaces, found 0; (#58) Perl-style comments are not allowed; use "// Comment." instead; (#85) This comment is 67% valid code; is this commented out code?; (#85) Line indented incorrectly; expected at least 8 spaces, found 0; (#85) Perl-style comments are not allowed; use "// Comment." instead; (#106) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $exportedfields{'profile_field_'.$profilefield->shortname}
auth/samlidp/logout.php: (#25) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#32) Inline comments must start with a capital letter, digit or 3-dots sequence; (#32) Inline comments must end in full-stops, exclamation marks, or question marks; (#40) Inline comments must start with a capital letter, digit or 3-dots sequence; (#40) Inline comments must end in full-stops, exclamation marks, or question marks; (#45) Inline comments must start with a capital letter, digit or 3-dots sequence; (#45) Inline comments must end in full-stops, exclamation marks, or question marks
auth/samlidp/moodle/lib/Auth/Source/External.php: (#25) Perl-style comments are not allowed; use "// Comment." instead; (#37) Perl-style comments are not allowed; use "// Comment." instead; (#48) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $config{'cookie_name'}; (#49) Line exceeds 132 characters; contains 170 characters; (#49) Perl-style comments are not allowed; use "// Comment." instead; (#51) Variable "ssp_config" must not contain underscores.; (#52) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $config{'cookie_path'}; (#52) Variable "ssp_config" must not contain underscores.; (#53) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $config{'cookie_salt'}; (#53) Variable "ssp_config" must not contain underscores.; (#60) Perl-style comments are not allowed; use "// Comment." instead; (#64) Perl-style comments are not allowed; use "// Comment." instead; (#66) Variable "state_id" must not contain underscores.; (#67) Variable "return_to" must not contain underscores.; (#67) Variable "state_id" must not contain underscores.; (#68) Variable "auth_page" must not contain underscores.; (#68) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'login_url'}; (#68) Variable "return_to" must not contain underscores.; (#69) Variable "auth_page" must not contain underscores.; (#69) Variable "return_to" must not contain underscores.; (#77) Variable "state_id" must not contain underscores.; (#79) Variable "state_id" must not contain underscores.; (#81) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"; (#90) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"; (#96) Perl-style comments are not allowed; use "// Comment." instead; (#99) Private method name "sspmod_moodle_Auth_Source_External::getUser" must be in lower-case letters only; (#101) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $_COOKIE{$this->config{'cookie_name'}}; (#101) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'cookie_name'}; (#101) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $_COOKIE{$this->config{'cookie_name'}}; (#101) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'cookie_name'}; (#102) Variable "str_cookie" must not contain underscores.; (#102) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $_COOKIE{$this->config{'cookie_name'}}; (#102) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'cookie_name'}; (#103) Line exceeds 132 characters; contains 177 characters; (#103) Perl-style comments are not allowed; use "// Comment." instead; (#104) Perl-style comments are not allowed; use "// Comment." instead; (#105) Variable "arr_cookie" must not contain underscores.; (#105) Variable "str_cookie" must not contain underscores.; (#107) Variable "arr_cookie" must not contain underscores.; (#107) Variable "arr_cookie" must not contain underscores.; (#108) Variable "arr_cookie" must not contain underscores.; (#108) Variable "arr_cookie" must not contain underscores.; (#110) Perl-style comments are not allowed; use "// Comment." instead; (#111) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'cookie_salt'}; (#111) Variable "arr_cookie" must not contain underscores.; (#111) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'cookie_salt'}; (#111) Variable "arr_cookie" must not contain underscores.; (#111) Line exceeds 132 characters; contains 133 characters; (#112) Variable "arr_cookie" must not contain underscores.; (#119) Perl-style comments are not allowed; use "// Comment." instead; (#120) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $_COOKIE{$this->config{'cookie_name'}}; (#120) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'cookie_name'}; (#121) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'cookie_name'}; (#121) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'cookie_path'}; (#125) Perl-style comments are not allowed; use "// Comment." instead; (#129) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'moodle_coderoot'}; (#130) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'moodle_coderoot'}; (#143) Perl-style comments are not allowed; use "// Comment." instead; (#145) Variable "profile_fields" must not contain underscores.; (#147) Perl-style comments are not allowed; use "// Comment." instead; (#148) Perl-style comments are not allowed; use "// Comment." instead; (#153) Perl-style comments are not allowed; use "// Comment." instead; (#155) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $userattr{$param}; (#157) Variable "profile_fields" must not contain underscores.; (#158) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $userattr{'profile_field_'.$param}; (#163) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"; (#165) TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"; (#173) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $_COOKIE{$this->config{'cookie_name'}}; (#173) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'cookie_name'}; (#174) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'cookie_name'}; (#174) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'cookie_path'}; (#178) Variable "logout_url" must not contain underscores.; (#178) Curly brace syntax for accessing array elements and string offsets has been deprecated in PHP 7.4. Found: $this->config{'logout_url'}; (#180) Variable "logout_url" must not contain underscores.; (#183) Variable "logout_url" must not contain underscores.
auth/samlidp/moodle/www/resume.php: (#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
auth/samlidp/settings.php: (#29) Inline comments must end in full-stops, exclamation marks, or question marks; (#34) Inline comments must start with a capital letter, digit or 3-dots sequence; (#34) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 0 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

Prechecker results: error

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

Missing changes in external functions or backup support for new detected tables or columns

grunt changes

shifter problems

Mustache template problems

Gherkin .feature problems