Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(157 errors, 36 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/saml2sso/auth.php
(#61) Member variable "stringMapping" must be all lower-case
(#73) Variable "componentName" must be all lower-case
(#74) Variable "legacyComponentName" must be all lower-case
(#75) Variable "componentName" must be all lower-case
(#75) Variable "legacyComponentName" must be all lower-case
(#76) Variable "stringMapping" must be all lower-case
(#82) Private method name "auth_plugin_saml2sso::getSSPauth" must be in lower-case letters only
(#83) "require_once" must be immediately followed by an open parenthesis
(#87) Whitespace found at end of line
(#97) Inline comments must end in full-stops, exclamation marks, or question marks
(#118) Variable "urlLogout" must be all lower-case
(#118) Line exceeds 132 characters; contains 165 characters
(#120) Inline comments must end in full-stops, exclamation marks, or question marks
(#124) Variable "urlLogout" must be all lower-case
(#124) Variable "urlLogout" must be all lower-case
(#129) Variable "urlLogout" must be all lower-case
(#147) Inline comments must end in full-stops, exclamation marks, or question marks
(#151) Expected "} else if (...) {\n"; found "}\n else if (...) {\n"
(#154) Expected "} else {\n"; found "}\n else {\n"
(#155) Space found before semicolon; expected "{;" but found "{ ;"
(#159) Inline comments must end in full-stops, exclamation marks, or question marks
(#161) Inline comments must end in full-stops, exclamation marks, or question marks
(#162) Line exceeds maximum limit of 180 characters; contains 309 characters
(#163) Inline comments must end in full-stops, exclamation marks, or question marks
(#164) Line exceeds maximum limit of 180 characters; contains 293 characters
(#172) Spaces must be used to indent lines; tabs are not allowed
(#172) Tab found within whitespace
(#172) Line indented incorrectly; expected at least 8 spaces, found 7
(#175) Inline comments must end in full-stops, exclamation marks, or question marks
(#180) Inline comments must end in full-stops, exclamation marks, or question marks
(#182) Inline comments must end in full-stops, exclamation marks, or question marks
(#186) Inline comments must end in full-stops, exclamation marks, or question marks
(#186) No space found before comment text; expected "// If autocreate is not allowed, show error" but found "//If autocreate is not allowed, show error"
(#191) Inline comments must end in full-stops, exclamation marks, or question marks
(#198) Inline comments must end in full-stops, exclamation marks, or question marks
(#203) Whitespace found at end of line
(#229) Inline comments must start with a capital letter, digit or 3-dots sequence
(#229) Inline comments must end in full-stops, exclamation marks, or question marks
(#232) Inline comments must start with a capital letter, digit or 3-dots sequence
(#232) Inline comments must end in full-stops, exclamation marks, or question marks
(#272) Visibility must be declared on method "user_login"
(#286) Visibility must be declared on method "user_update_password"
(#291) Whitespace found at end of line
(#294) Visibility must be declared on method "prevent_local_passwords"
(#303) Visibility must be declared on method "is_internal"
(#313) Visibility must be declared on method "can_change_password"
(#323) Visibility must be declared on method "change_password_url"
(#332) Visibility must be declared on method "can_reset_password"
(#341) Visibility must be declared on method "can_be_manually_set"
(#348) Visibility must be declared on method "can_edit_profile"
(#351) Whitespace found at end of line
(#363) Variable "samlLogout" must be all lower-case
(#369) Variable "samlLogout" must be all lower-case
(#373) Whitespace found at end of line
(#393) Spaces must be used to indent lines; tabs are not allowed
(#393) Tab found within whitespace
(#393) Line indented incorrectly; expected at least 8 spaces, found 2
(#398) "require" must be immediately followed by an open parenthesis
(#399) "include" must be immediately followed by an open parenthesis
(#401) Line exceeds maximum limit of 180 characters; contains 209 characters
(#401) Spaces must be used for alignment; tabs are not allowed
(#401) Tab found within whitespace
(#401) Whitespace found at end of line
(#403) Whitespace found at end of line
auth/saml2sso/lang/en/auth_saml2sso.php
(#29) Inline comments must start with a capital letter, digit or 3-dots sequence
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
(#29) No space found before comment text; expected "// label config strings" but found "//label config strings"
(#46) Inline comments must start with a capital letter, digit or 3-dots sequence
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) No space found before comment text; expected "// _help config strings" but found "//_help config strings"
(#57) Space found before semicolon; expected "'Field from Identity Provider containing the user first name';" but found "'Field from Identity Provider containing the user first name' ;"
(#61) Inline comments must start with a capital letter, digit or 3-dots sequence
(#61) Inline comments must end in full-stops, exclamation marks, or question marks
(#61) No space found before comment text; expected "// error config strings" but found "//error config strings"
auth/saml2sso/lang/it/auth_saml2sso.php
(#29) Inline comments must start with a capital letter, digit or 3-dots sequence
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
(#29) No space found before comment text; expected "// label config strings" but found "//label config strings"
(#46) Inline comments must start with a capital letter, digit or 3-dots sequence
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) No space found before comment text; expected "// _help config strings" but found "//_help config strings"
(#58) Space found before semicolon; expected "'Attributo dell\'asserzione restituita dall\'IdP contenente il nome';" but found "'Attributo dell\'asserzione restituita dall\'IdP contenente il nome' ;"
(#62) Inline comments must start with a capital letter, digit or 3-dots sequence
(#62) Inline comments must end in full-stops, exclamation marks, or question marks
(#62) No space found before comment text; expected "// error config strings" but found "//error config strings"
auth/saml2sso/lang/pt_br/auth_saml2sso.php
(#29) Inline comments must start with a capital letter, digit or 3-dots sequence
(#29) Inline comments must end in full-stops, exclamation marks, or question marks
(#29) No space found before comment text; expected "// label config strings" but found "//label config strings"
(#46) Inline comments must start with a capital letter, digit or 3-dots sequence
(#46) Inline comments must end in full-stops, exclamation marks, or question marks
(#46) No space found before comment text; expected "// _help config strings" but found "//_help config strings"
(#61) Inline comments must start with a capital letter, digit or 3-dots sequence
(#61) Inline comments must end in full-stops, exclamation marks, or question marks
(#61) No space found before comment text; expected "// error config strings" but found "//error config strings"
auth/saml2sso/settings.php
(#28) Whitespace found at end of line
(#32) Whitespace found at end of line
(#33) Whitespace found at end of line
(#38) Variable "field_setting" must not contain underscores.
(#40) Variable "field_setting" must not contain underscores.
(#41) Variable "field_setting" must not contain underscores.
(#41) Whitespace found at end of line
(#42) Variable "field_setting" must not contain underscores.
(#49) Whitespace found at end of line
(#50) Variable "field_setting" must not contain underscores.
(#52) Variable "field_setting" must not contain underscores.
(#52) Whitespace found at end of line
(#53) Variable "field_setting" must not contain underscores.
(#53) Whitespace found at end of line
(#54) Variable "field_setting" must not contain underscores.
(#54) Whitespace found at end of line
(#55) Whitespace found at end of line
(#59) Whitespace found at end of line
(#60) Variable "field_setting" must not contain underscores.
(#62) Variable "field_setting" must not contain underscores.
(#62) Whitespace found at end of line
(#63) Variable "field_setting" must not contain underscores.
(#63) Whitespace found at end of line
(#64) Variable "field_setting" must not contain underscores.
(#64) Whitespace found at end of line
(#65) Whitespace found at end of line
(#69) Whitespace found at end of line
(#70) Variable "field_setting" must not contain underscores.
(#72) Variable "field_setting" must not contain underscores.
(#73) Variable "field_setting" must not contain underscores.
(#73) Whitespace found at end of line
(#74) Variable "field_setting" must not contain underscores.
(#81) Whitespace found at end of line
(#82) Variable "field_setting" must not contain underscores.
(#89) Variable "field_setting" must not contain underscores.
(#89) Whitespace found at end of line
(#90) Variable "field_setting" must not contain underscores.
(#90) Whitespace found at end of line
(#91) Variable "field_setting" must not contain underscores.
(#91) Whitespace found at end of line
(#92) Whitespace found at end of line
(#95) Whitespace found at end of line
(#96) Whitespace found at end of line
(#97) Variable "field_setting" must not contain underscores.
(#99) Variable "field_setting" must not contain underscores.
(#99) Whitespace found at end of line
(#100) Variable "field_setting" must not contain underscores.
(#100) Whitespace found at end of line
(#101) Variable "field_setting" must not contain underscores.
(#101) Whitespace found at end of line
(#102) Whitespace found at end of line
(#106) Whitespace found at end of line
(#107) Variable "field_setting" must not contain underscores.
(#109) Variable "field_setting" must not contain underscores.
(#110) Variable "field_setting" must not contain underscores.
(#110) Whitespace found at end of line
(#111) Variable "field_setting" must not contain underscores.
(#118) Whitespace found at end of line
(#119) Variable "field_setting" must not contain underscores.
(#121) Variable "field_setting" must not contain underscores.
(#122) Variable "field_setting" must not contain underscores.
(#122) Whitespace found at end of line
(#123) Variable "field_setting" must not contain underscores.
(#130) Whitespace found at end of line
(#131) Variable "field_setting" must not contain underscores.
(#133) Variable "field_setting" must not contain underscores.
(#133) Whitespace found at end of line
(#134) Variable "field_setting" must not contain underscores.
(#134) Whitespace found at end of line
(#135) Variable "field_setting" must not contain underscores.
(#135) Whitespace found at end of line
(#136) Whitespace found at end of line
(#140) Whitespace found at end of line
(#141) Variable "field_setting" must not contain underscores.
(#143) Variable "field_setting" must not contain underscores.
(#143) Whitespace found at end of line
(#144) Variable "field_setting" must not contain underscores.
(#144) Whitespace found at end of line
(#145) Variable "field_setting" must not contain underscores.
(#145) Whitespace found at end of line
(#146) Whitespace found at end of line
(#150) Whitespace found at end of line
(#151) Variable "field_setting" must not contain underscores.
(#153) Variable "field_setting" must not contain underscores.
(#154) Variable "field_setting" must not contain underscores.
(#154) Whitespace found at end of line
(#155) Variable "field_setting" must not contain underscores.
(#162) Whitespace found at end of line
(#163) Variable "field_setting" must not contain underscores.
(#165) Variable "field_setting" must not contain underscores.
(#166) Variable "field_setting" must not contain underscores.
(#166) Whitespace found at end of line
(#167) Variable "field_setting" must not contain underscores.
(#174) Whitespace found at end of line
(#178) Whitespace found at end of line
(#179) Whitespace found at end of line
(#180) Whitespace found at end of line
(#181) Whitespace found at end of line
(#182) Whitespace found at end of line
auth/saml2sso/version.php
(#28) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(16 errors, 9 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

auth/saml2sso/auth.php
(#35) Constant auth_plugin_saml2sso::COMPONENT_NAME is not documented
(#36) Constant auth_plugin_saml2sso::LEGACY_COMPONENT_NAME is not documented
(#17) No one-line description found in phpdocs for file
(#28) No one-line description found in phpdocs for class auth_plugin_saml2sso
(#88) There is no description in phpdocs for function loginpage_hook
(#290) There is no description in phpdocs for function prevent_local_passwords
(#345) There is no description in phpdocs for function can_edit_profile
(#352) There is no description in phpdocs for function error_page
(#88) Phpdocs for function auth_plugin_saml2sso::loginpage_hook has incomplete parameters list
(#240) Phpdocs for function auth_plugin_saml2sso::do_login has incomplete parameters list
(#345) Phpdocs for function auth_plugin_saml2sso::can_edit_profile has incomplete parameters list
(#356) Phpdocs for function auth_plugin_saml2sso::error_page has incomplete parameters list
(#17) File-level phpdocs block does not have @copyright tag
(#28) Class auth_plugin_saml2sso does not have @copyright tag
(#28) Class auth_plugin_saml2sso does not have @license tag
(#89) Not recommended phpdocs tag @global used
(#134) Not recommended phpdocs tag @global used
(#134) Not recommended phpdocs tag @global used
(#134) Not recommended phpdocs tag @global used
(#238) Not recommended phpdocs tag @global used
(#238) Not recommended phpdocs tag @global used
(#353) Not recommended phpdocs tag @global used
(#353) Not recommended phpdocs tag @global used
(#353) Not recommended phpdocs tag @global used
auth/saml2sso/version.php
(#17) File-level phpdocs block does not have @copyright tag

Update savepoints problems

(1 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

auth/saml2sso/db/upgrade.php
version 2017020700 has wrong savepoint call with version 2018011400

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]