Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(37 errors, 26 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/saml2sso/auth.php
(#61) Member variable "stringMapping" must be all lower-case
(#73) Variable "componentName" must be all lower-case
(#74) Variable "legacyComponentName" must be all lower-case
(#75) Variable "componentName" must be all lower-case
(#75) Variable "legacyComponentName" must be all lower-case
(#76) Variable "stringMapping" must be all lower-case
(#88) Inline comments must end in full-stops, exclamation marks, or question marks
(#109) Variable "urlLogout" must be all lower-case
(#109) Line exceeds 132 characters; contains 165 characters
(#111) Inline comments must end in full-stops, exclamation marks, or question marks
(#117) Variable "urlLogout" must be all lower-case
(#117) Variable "urlLogout" must be all lower-case
(#122) Variable "urlLogout" must be all lower-case
(#141) Inline comments must end in full-stops, exclamation marks, or question marks
(#142) Line exceeds maximum limit of 180 characters; contains 185 characters
(#145) Inline comments must end in full-stops, exclamation marks, or question marks
(#147) Inline comments must end in full-stops, exclamation marks, or question marks
(#148) Line exceeds maximum limit of 180 characters; contains 280 characters
(#149) Inline comments must end in full-stops, exclamation marks, or question marks
(#150) Line exceeds maximum limit of 180 characters; contains 264 characters
(#152) Line exceeds 132 characters; contains 136 characters
(#153) Line exceeds 132 characters; contains 134 characters
(#158) Spaces must be used to indent lines; tabs are not allowed
(#158) Tab found within whitespace
(#158) Line indented incorrectly; expected at least 8 spaces, found 7
(#161) Inline comments must end in full-stops, exclamation marks, or question marks
(#166) Inline comments must end in full-stops, exclamation marks, or question marks
(#168) Inline comments must end in full-stops, exclamation marks, or question marks
(#172) Inline comments must end in full-stops, exclamation marks, or question marks
(#172) No space found before comment text; expected "// If autocreate is not allowed, show error" but found "//If autocreate is not allowed, show error"
(#177) Inline comments must end in full-stops, exclamation marks, or question marks
(#184) Inline comments must end in full-stops, exclamation marks, or question marks
(#208) Inline comments must start with a capital letter, digit or 3-dots sequence
(#208) Inline comments must end in full-stops, exclamation marks, or question marks
(#211) Inline comments must start with a capital letter, digit or 3-dots sequence
(#211) Inline comments must end in full-stops, exclamation marks, or question marks
(#251) Visibility must be declared on method "user_login"
(#265) Visibility must be declared on method "user_update_password"
(#270) Whitespace found at end of line
(#273) Visibility must be declared on method "prevent_local_passwords"
(#282) Visibility must be declared on method "is_internal"
(#292) Visibility must be declared on method "can_change_password"
(#302) Visibility must be declared on method "change_password_url"
(#311) Visibility must be declared on method "can_reset_password"
(#320) Visibility must be declared on method "can_be_manually_set"
(#327) Visibility must be declared on method "can_edit_profile"
(#339) Visibility must be declared on method "config_form"
(#339) Variable "user_fields" must not contain underscores.
(#348) Visibility must be declared on method "process_config"
(#350) Variable "not_empty_fields" must not contain underscores.
(#352) Variable "not_empty_fields" must not contain underscores.
(#355) Line exceeds 132 characters; contains 150 characters
(#357) Inline comments must start with a capital letter, digit or 3-dots sequence
(#358) Inline comments must end in full-stops, exclamation marks, or question marks
(#367) Line exceeds 132 characters; contains 142 characters
(#371) Line exceeds 132 characters; contains 142 characters
(#375) Line exceeds 132 characters; contains 142 characters
(#393) Variable "samlLogout" must be all lower-case
(#399) Variable "samlLogout" must be all lower-case
auth/saml2sso/lang/en/auth_saml2sso.php
(#47) Inline doc block comments are not allowed; use "// Comment." instead
(#60) Space found before semicolon; expected "'Field from IdP containing the user first name';" but found "'Field from IdP containing the user first name' ;"
auth/saml2sso/lang/pt_br/auth_saml2sso.php
(#47) Inline doc block comments are not allowed; use "// Comment." instead
auth/saml2sso/version.php
(#28) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(18 errors, 9 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

auth/saml2sso/auth.php
(#35) Constant auth_plugin_saml2sso::COMPONENT_NAME is not documented
(#36) Constant auth_plugin_saml2sso::LEGACY_COMPONENT_NAME is not documented
(#17) No one-line description found in phpdocs for file
(#28) No one-line description found in phpdocs for class auth_plugin_saml2sso
(#79) There is no description in phpdocs for function loginpage_hook
(#269) There is no description in phpdocs for function prevent_local_passwords
(#324) There is no description in phpdocs for function can_edit_profile
(#380) There is no description in phpdocs for function error_page
(#79) Phpdocs for function auth_plugin_saml2sso::loginpage_hook has incomplete parameters list
(#219) Phpdocs for function auth_plugin_saml2sso::do_login has incomplete parameters list
(#324) Phpdocs for function auth_plugin_saml2sso::can_edit_profile has incomplete parameters list
(#337) Phpdocs for function auth_plugin_saml2sso::config_form has incomplete parameters list
(#345) Phpdocs for function auth_plugin_saml2sso::process_config has incomplete parameters list
(#384) Phpdocs for function auth_plugin_saml2sso::error_page has incomplete parameters list
(#17) File-level phpdocs block does not have @copyright tag
(#28) Class auth_plugin_saml2sso does not have @copyright tag
(#28) Class auth_plugin_saml2sso does not have @license tag
(#80) Not recommended phpdocs tag @global used
(#127) Not recommended phpdocs tag @global used
(#127) Not recommended phpdocs tag @global used
(#127) Not recommended phpdocs tag @global used
(#217) Not recommended phpdocs tag @global used
(#217) Not recommended phpdocs tag @global used
(#381) Not recommended phpdocs tag @global used
(#381) Not recommended phpdocs tag @global used
(#381) Not recommended phpdocs tag @global used
auth/saml2sso/version.php
(#17) File-level phpdocs block does not have @copyright tag

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]