PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(245 errors, 73 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/saml2sso/auth.php: (#39) Inline comments must start with a capital letter, digit or 3-dots sequence; (#39) Inline comments must end in full-stops, exclamation marks, or question marks; (#39) This comment is 100% valid code; is this commented out code?; (#39) No space found before comment text; expected "// 'auth_saml2sso';" but found "//'auth_saml2sso';"; (#62) Inline comments must end in full-stops, exclamation marks, or question marks; (#81) Variable "componentName" must be all lower-case; (#82) Variable "legacyComponentName" must be all lower-case; (#83) Variable "componentName" must be all lower-case; (#83) Variable "legacyComponentName" must be all lower-case; (#85) Inline comments must end in full-stops, exclamation marks, or question marks; (#96) "require_once" must be immediately followed by an open parenthesis; (#102) Inline comments must end in full-stops, exclamation marks, or question marks; (#112) Visibility must be declared on method "loginpage_idp_list"; (#116) Variable "button_path" must not contain underscores.; (#118) Expected "} else {\n"; found "}\n else {\n"; (#119) Variable "button_path" must not contain underscores.; (#119) Expected 1 space after "="; 2 found; (#121) Variable "button_name" must not contain underscores.; (#123) Variable "button_name" must not contain underscores.; (#128) Variable "button_name" must not contain underscores.; (#129) Variable "button_path" must not contain underscores.; (#133) Variable "username_attribute" must not contain underscores.; (#144) Variable "username_attribute" must not contain underscores.; (#145) Variable "username_attribute" must not contain underscores.; (#158) Visibility must be declared on method "get_userinfo"; (#167) Inline comments must end in full-stops, exclamation marks, or question marks; (#174) Expected 1 space before "=>"; 0 found; (#174) Expected 1 space after "=>"; 0 found; (#174) Expected 1 space before "=>"; 0 found; (#174) Expected 1 space after "=>"; 0 found; (#175) Inline comments must end in full-stops, exclamation marks, or question marks; (#179) Inline comments must end in full-stops, exclamation marks, or question marks; (#186) Inline comments must end in full-stops, exclamation marks, or question marks; (#187) Expected "if (...) {\n"; found "if (...){\n"; (#190) Expected "} else {\n"; found "}\n else {\n"; (#208) Inline comments must end in full-stops, exclamation marks, or question marks; (#214) Inline comments must end in full-stops, exclamation marks, or question marks; (#216) Expected 1 space before "="; 0 found; (#216) Expected 1 space after "="; 0 found; (#220) Inline comments must end in full-stops, exclamation marks, or question marks; (#240) Inline comments must end in full-stops, exclamation marks, or question marks; (#244) The constant "FILTER_FLAG_SCHEME_REQUIRED" is deprecated since PHP 7.3; (#244) Line exceeds 132 characters; contains 165 characters; (#246) Inline comments must end in full-stops, exclamation marks, or question marks; (#271) Inline doc block comments are not allowed; use "// Comment." instead; (#283) Inline comments must start with a capital letter, digit or 3-dots sequence; (#284) Inline comments must end in full-stops, exclamation marks, or question marks; (#286) Inline doc block comments are not allowed; use "// Comment." instead; (#291) Inline comments must end in full-stops, exclamation marks, or question marks; (#292) Line exceeds maximum limit of 180 characters; contains 309 characters; (#293) Inline comments must end in full-stops, exclamation marks, or question marks; (#294) Line exceeds maximum limit of 180 characters; contains 293 characters; (#300) Inline doc block comments are not allowed; use "// Comment." instead; (#304) Whitespace found at end of line; (#308) Inline comments must end in full-stops, exclamation marks, or question marks; (#320) Inline comments must end in full-stops, exclamation marks, or question marks; (#322) Inline comments must end in full-stops, exclamation marks, or question marks; (#326) Inline comments must end in full-stops, exclamation marks, or question marks; (#326) No space found before comment text; expected "// If autocreate is not allowed, show error" but found "//If autocreate is not allowed, show error"; (#331) Inline doc block comments are not allowed; use "// Comment." instead; (#342) Inline comments must start with a capital letter, digit or 3-dots sequence; (#342) Inline comments must end in full-stops, exclamation marks, or question marks; (#345) Inline comments must start with a capital letter, digit or 3-dots sequence; (#345) Inline comments must end in full-stops, exclamation marks, or question marks; (#405) Whitespace found at end of line; (#486) Variable "samlLogout" must be all lower-case; (#495) Variable "samlLogout" must be all lower-case; (#519) Line exceeds maximum limit of 180 characters; contains 231 characters; (#524) "require" must be immediately followed by an open parenthesis; (#532) "include" must be immediately followed by an open parenthesis; (#534) Line exceeds maximum limit of 180 characters; contains 207 characters; (#556) Expected "} else {\n"; found "}\n else {\n"; (#573) Expected 1 space before "=>"; 0 found; (#573) Expected 1 space after "=>"; 0 found; (#573) Line exceeds 132 characters; contains 135 characters; (#574) Line exceeds 132 characters; contains 133 characters; (#579) Expected "} else {\n"; found "}\n else {\n"; (#580) Line exceeds 132 characters; contains 133 characters
auth/saml2sso/classes/event/not_searchable.php: (#2) Line 1 of the opening comment must start "// This file is part of".; (#2) Line 2 of the opening comment must start "//".; (#3) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".; (#3) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".; (#3) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".; (#3) Line 6 of the opening comment must start "// (at your option) any later version.".; (#3) Line 7 of the opening comment must start "//".; (#4) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".; (#4) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".; (#4) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".; (#5) Line 11 of the opening comment must start "// GNU General Public License for more details.".; (#5) Line 12 of the opening comment must start "//".; (#5) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".; (#5) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".; (#12) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
auth/saml2sso/classes/event/user_migrated.php: (#2) Line 1 of the opening comment must start "// This file is part of".; (#2) Line 2 of the opening comment must start "//".; (#3) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".; (#3) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".; (#3) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".; (#3) Line 6 of the opening comment must start "// (at your option) any later version.".; (#3) Line 7 of the opening comment must start "//".; (#4) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".; (#4) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".; (#4) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".; (#5) Line 11 of the opening comment must start "// GNU General Public License for more details.".; (#5) Line 12 of the opening comment must start "//".; (#5) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".; (#5) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".; (#12) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
auth/saml2sso/classes/privacy/provider.php: (#2) Line 1 of the opening comment must start "// This file is part of".; (#2) Line 2 of the opening comment must start "//".; (#3) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".; (#3) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".; (#3) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".; (#3) Line 6 of the opening comment must start "// (at your option) any later version.".; (#3) Line 7 of the opening comment must start "//".; (#4) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".; (#4) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".; (#4) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".; (#5) Line 11 of the opening comment must start "// GNU General Public License for more details.".; (#5) Line 12 of the opening comment must start "//".; (#5) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".; (#5) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".
auth/saml2sso/classes/task/sync_users.php: (#15) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".; (#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.; (#53) Expected "} else {\n"; found "}\n else {\n"; (#74) Usage of ELSEIF not allowed; use ELSE IF instead; (#77) Expected "} else {\n"; found "}\n else {\n"
auth/saml2sso/db/install.php: (#25) Expected MOODLE_INTERNAL check or config.php inclusion
auth/saml2sso/db/upgrade.php: (#56) Inline comments must end in full-stops, exclamation marks, or question marks; (#69) Variable "show_tackeover_page" must not contain underscores.; (#70) Variable "show_tackeover_page" must not contain underscores.
auth/saml2sso/lang/en/auth_saml2sso.php: (#29) Inline comments must start with a capital letter, digit or 3-dots sequence; (#29) Inline comments must end in full-stops, exclamation marks, or question marks; (#29) No space found before comment text; expected "// label config strings" but found "//label config strings"; (#49) Inline comments must start with a capital letter, digit or 3-dots sequence; (#49) Inline comments must end in full-stops, exclamation marks, or question marks; (#49) No space found before comment text; expected "// _help config strings" but found "//_help config strings"; (#64) Space found before semicolon; expected "'deprecated, use an authproc Field from Identity Provider containing the user first name';" but found "'deprecated, use an authproc Field from Identity Provider containing the user first name' ;"; (#68) Inline comments must start with a capital letter, digit or 3-dots sequence; (#68) Inline comments must end in full-stops, exclamation marks, or question marks; (#68) No space found before comment text; expected "// error config strings" but found "//error config strings"
auth/saml2sso/lang/it/auth_saml2sso.php: (#29) Inline comments must start with a capital letter, digit or 3-dots sequence; (#29) Inline comments must end in full-stops, exclamation marks, or question marks; (#29) No space found before comment text; expected "// label config strings" but found "//label config strings"; (#49) Inline comments must start with a capital letter, digit or 3-dots sequence; (#49) Inline comments must end in full-stops, exclamation marks, or question marks; (#49) No space found before comment text; expected "// _help config strings" but found "//_help config strings"; (#64) Space found before semicolon; expected "'deprecato, usare una authproc Attributo ricevuto dall\'IdP contenente il nome';" but found "'deprecato, usare una authproc Attributo ricevuto dall\'IdP contenente il nome' ;"; (#68) Inline comments must start with a capital letter, digit or 3-dots sequence; (#68) Inline comments must end in full-stops, exclamation marks, or question marks; (#68) No space found before comment text; expected "// error config strings" but found "//error config strings"; (#94) Whitespace found at end of line within string
auth/saml2sso/lang/pt_br/auth_saml2sso.php: (#1) End of line character is invalid; expected "\n" but found "\r\n"; (#29) Inline comments must start with a capital letter, digit or 3-dots sequence; (#29) Inline comments must end in full-stops, exclamation marks, or question marks; (#29) No space found before comment text; expected "// label config strings" but found "//label config strings"; (#46) Inline comments must start with a capital letter, digit or 3-dots sequence; (#46) Inline comments must end in full-stops, exclamation marks, or question marks; (#46) No space found before comment text; expected "// _help config strings" but found "//_help config strings"; (#61) Inline comments must start with a capital letter, digit or 3-dots sequence; (#61) Inline comments must end in full-stops, exclamation marks, or question marks; (#61) No space found before comment text; expected "// error config strings" but found "//error config strings"
auth/saml2sso/locallib.php: (#2) Line 1 of the opening comment must start "// This file is part of".; (#2) Line 2 of the opening comment must start "//".; (#3) Line 3 of the opening comment must start "// Moodle is free software: you can redistribute it and/or modify".; (#3) Line 4 of the opening comment must start "// it under the terms of the GNU General Public License as published by".; (#3) Line 5 of the opening comment must start "// the Free Software Foundation, either version 3 of the License, or".; (#3) Line 6 of the opening comment must start "// (at your option) any later version.".; (#3) Line 7 of the opening comment must start "//".; (#4) Line 8 of the opening comment must start "// Moodle is distributed in the hope that it will be useful,".; (#4) Line 9 of the opening comment must start "// but WITHOUT ANY WARRANTY; without even the implied warranty of".; (#4) Line 10 of the opening comment must start "// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the".; (#5) Line 11 of the opening comment must start "// GNU General Public License for more details.".; (#5) Line 12 of the opening comment must start "//".; (#5) Line 13 of the opening comment must start "// You should have received a copy of the GNU General Public License".; (#5) Line 14 of the opening comment must start "// along with Moodle. If not, see <http://www.gnu.org/licenses/>.".; (#18) Whitespace found at end of line; (#19) Inline comments must end in full-stops, exclamation marks, or question marks; (#36) "require_once" must be immediately followed by an open parenthesis; (#62) Inline comments must end in full-stops, exclamation marks, or question marks; (#66) Inline comments must end in full-stops, exclamation marks, or question marks; (#76) Inline comments must start with a capital letter, digit or 3-dots sequence; (#76) Inline comments must end in full-stops, exclamation marks, or question marks; (#76) This comment is 45% valid code; is this commented out code?; (#76) No space found before comment text; expected "// 'Unknown plugin "' . $auth . '" (' . get_string('ajaxxusersfound', 'enrol', $count) . ')';" but found "//'Unknown plugin "' . $auth . '" (' . get_string('ajaxxusersfound', 'enrol', $count) . ')';"; (#82) Inline comments must start with a capital letter, digit or 3-dots sequence; (#82) Inline comments must end in full-stops, exclamation marks, or question marks; (#82) This comment is 52% valid code; is this commented out code?; (#82) No space found before comment text; expected "// $authplugin->get_title() . ' (' . get_string('ajaxxusersfound', 'enrol', $count) . ')';" but found "//$authplugin->get_title() . ' (' . get_string('ajaxxusersfound', 'enrol', $count) . ')';"; (#96) Whitespace found at end of line; (#97) Variable "known_plugins" must not contain underscores.; (#98) Variable "known_plugins" must not contain underscores.; (#99) Inline comments must end in full-stops, exclamation marks, or question marks; (#104) Expected 1 space before "=>"; 0 found; (#104) Expected 1 space after "=>"; 0 found; (#104) Expected 1 space before "=>"; 0 found; (#104) Expected 1 space after "=>"; 0 found
auth/saml2sso/settings.php: (#28) Inline comments must start with a capital letter, digit or 3-dots sequence; (#28) Inline comments must end in full-stops, exclamation marks, or question marks; (#28) This comment is 45% valid code; is this commented out code?; (#58) Variable "field_setting" must not contain underscores.; (#59) Variable "field_setting" must not contain underscores.; (#60) Variable "field_setting" must not contain underscores.; (#61) Variable "field_setting" must not contain underscores.; (#64) Whitespace found at end of line; (#65) Inline comments must end in full-stops, exclamation marks, or question marks; (#66) Variable "field_setting" must not contain underscores.; (#68) Variable "field_setting" must not contain underscores.; (#69) Variable "field_setting" must not contain underscores.; (#70) Variable "field_setting" must not contain underscores.; (#78) Variable "field_setting" must not contain underscores.; (#80) Variable "field_setting" must not contain underscores.; (#80) Whitespace found at end of line; (#81) Variable "field_setting" must not contain underscores.; (#81) Whitespace found at end of line; (#82) Variable "field_setting" must not contain underscores.; (#82) Whitespace found at end of line; (#83) Whitespace found at end of line; (#87) Whitespace found at end of line; (#88) Variable "field_setting" must not contain underscores.; (#90) Variable "field_setting" must not contain underscores.; (#91) Variable "field_setting" must not contain underscores.; (#92) Variable "field_setting" must not contain underscores.; (#100) Variable "field_setting" must not contain underscores.; (#102) Variable "field_setting" must not contain underscores.; (#103) Variable "field_setting" must not contain underscores.; (#103) Whitespace found at end of line; (#104) Variable "field_setting" must not contain underscores.; (#111) Whitespace found at end of line; (#112) Variable "field_setting" must not contain underscores.; (#119) Variable "field_setting" must not contain underscores.; (#119) Whitespace found at end of line; (#120) Variable "field_setting" must not contain underscores.; (#120) Whitespace found at end of line; (#121) Variable "field_setting" must not contain underscores.; (#121) Whitespace found at end of line; (#122) Whitespace found at end of line; (#125) Whitespace found at end of line; (#126) Whitespace found at end of line; (#127) Variable "field_setting" must not contain underscores.; (#129) Variable "field_setting" must not contain underscores.; (#129) Whitespace found at end of line; (#130) Variable "field_setting" must not contain underscores.; (#130) Whitespace found at end of line; (#131) Variable "field_setting" must not contain underscores.; (#131) Whitespace found at end of line; (#132) Whitespace found at end of line; (#136) Whitespace found at end of line; (#137) Inline comments must end in full-stops, exclamation marks, or question marks; (#142) Variable "field_setting" must not contain underscores.; (#144) Variable "field_setting" must not contain underscores.; (#145) Variable "field_setting" must not contain underscores.; (#146) Variable "field_setting" must not contain underscores.; (#152) Variable "field_setting" must not contain underscores.; (#154) Variable "field_setting" must not contain underscores.; (#155) Variable "field_setting" must not contain underscores.; (#156) Variable "field_setting" must not contain underscores.; (#164) Variable "field_setting" must not contain underscores.; (#166) Variable "field_setting" must not contain underscores.; (#167) Variable "field_setting" must not contain underscores.; (#168) Variable "field_setting" must not contain underscores.; (#176) Inline comments must end in full-stops, exclamation marks, or question marks; (#196) Whitespace found at end of line; (#197) Variable "field_setting" must not contain underscores.; (#199) Expected "foreach (...) {\n"; found "foreach(...) {\n"; (#204) Variable "field_setting" must not contain underscores.; (#205) Variable "field_setting" must not contain underscores.; (#206) Variable "field_setting" must not contain underscores.; (#212) Variable "field_setting" must not contain underscores.; (#214) Variable "field_setting" must not contain underscores.; (#215) Variable "field_setting" must not contain underscores.; (#216) Variable "field_setting" must not contain underscores.; (#222) Variable "field_setting" must not contain underscores.; (#224) Variable "field_setting" must not contain underscores.; (#225) Variable "field_setting" must not contain underscores.; (#226) Variable "field_setting" must not contain underscores.; (#231) Whitespace found at end of line; (#235) Variable "field_setting" must not contain underscores.; (#237) Variable "field_setting" must not contain underscores.; (#237) Whitespace found at end of line; (#238) Variable "field_setting" must not contain underscores.; (#238) Whitespace found at end of line; (#239) Variable "field_setting" must not contain underscores.; (#239) Whitespace found at end of line; (#240) Whitespace found at end of line; (#244) Whitespace found at end of line; (#245) Variable "field_setting" must not contain underscores.; (#247) Variable "field_setting" must not contain underscores.; (#248) Variable "field_setting" must not contain underscores.; (#249) Variable "field_setting" must not contain underscores.; (#255) Variable "field_setting" must not contain underscores.; (#257) Variable "field_setting" must not contain underscores.; (#257) Whitespace found at end of line; (#258) Variable "field_setting" must not contain underscores.; (#258) Whitespace found at end of line; (#259) Variable "field_setting" must not contain underscores.; (#259) Whitespace found at end of line; (#260) Whitespace found at end of line; (#265) Variable "field_setting" must not contain underscores.; (#267) Variable "field_setting" must not contain underscores.; (#268) Variable "field_setting" must not contain underscores.; (#268) Whitespace found at end of line; (#269) Variable "field_setting" must not contain underscores.; (#276) Whitespace found at end of line; (#277) Variable "field_setting" must not contain underscores.; (#279) Variable "field_setting" must not contain underscores.; (#280) Variable "field_setting" must not contain underscores.; (#280) Whitespace found at end of line; (#281) Variable "field_setting" must not contain underscores.; (#288) Whitespace found at end of line; (#292) Line exceeds 132 characters; contains 178 characters
auth/saml2sso/takeover.php: (#58) Expected "} else {\n"; found "}\n else {\n"; (#66) Inline comments must start with a capital letter, digit or 3-dots sequence; (#66) Inline comments must end in full-stops, exclamation marks, or question marks; (#66) This comment is 67% valid code; is this commented out code?; (#66) Line indented incorrectly; expected at least 8 spaces, found 0; (#66) Expected 1 space before comment text but found 8; use block comment if you need indentation
auth/saml2sso/version.php: (#29) Inline comments must end in full-stops, exclamation marks, or question marks

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

Update savepoints problems

(1 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

auth/saml2sso/db/upgrade.php: version 2017020700 has wrong savepoint call with version 2018011400

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Prechecker results: error

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

grunt changes

shifter problems

Mustache template problems