Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(0 errors, 100 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/saml2/autologin.php
(#25) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#34) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
auth/saml2/classes/auth.php
(#228) Line exceeds 132 characters; contains 144 characters
auth/saml2/classes/testing/generator.php
(#19) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/saml2/classes/testing/tests_generator.php
(#19) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/saml2/config/authsources.php
(#42) Line exceeds 132 characters; contains 135 characters
auth/saml2/tests/auth_test.php
(#87) Inline comments must end in full-stops, exclamation marks, or question marks
auth/saml2/tests/autoloader_test.php
(#34) PHPUnit testcase name "auth_saml2_autoloader_test" does not match file name "autoloader_test"
(#34) PHPUnit class "auth_saml2_autoloader_test" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#35) Test method test_it_loads_classes() is missing any coverage information, own or at class level
auth/saml2/tests/form_regenerate_test.php
(#32) PHPUnit testcase name "auth_saml2_form_regenerate_testcase" does not match file name "form_regenerate_test"
(#32) PHPUnit class "auth_saml2_form_regenerate_testcase" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#33) Test method test_regenerate_certificate_form() is missing any coverage information, own or at class level
auth/saml2/tests/generator_test.php
(#29) PHPUnit testcase name "generator_testcase" does not match file name "generator_test"
(#29) PHPUnit class "generator_testcase" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#44) Inline comments must end in full-stops, exclamation marks, or question marks
(#106) Line exceeds 132 characters; contains 136 characters
(#108) Line exceeds 132 characters; contains 139 characters
auth/saml2/tests/group_rule_test.php
(#33) PHPUnit testcase name "auth_saml2_group_rule_test_testcase" does not match file name "group_rule_test"
(#33) PHPUnit class "auth_saml2_group_rule_test_testcase" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#38) Test method test_get_list() is missing any coverage information, own or at class level
auth/saml2/tests/locallib_test.php
(#37) PHPUnit testcase name "auth_saml2_locallib_testcase" does not match file name "locallib_test"
(#37) PHPUnit class "auth_saml2_locallib_testcase" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#41) Test method test_it_can_initialise_more_than_once() is missing any coverage information, own or at class level
(#60) Test method test_auth_saml2_sp_metadata() is missing any coverage information, own or at class level
(#88) Test method test_setup_no_cert_generate_if_locked() is missing any coverage information, own or at class level
(#118) Test method test_create_certificates_if_locked() is missing any coverage information, own or at class level
auth/saml2/tests/metadata_fetcher_test.php
(#34) PHPUnit testcase name "auth_saml2_metadata_fetcher_testcase" does not match file name "metadata_fetcher_test"
(#34) PHPUnit class "auth_saml2_metadata_fetcher_testcase" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#55) Test method test_fetch_metadata_404() is missing any coverage information, own or at class level
(#68) Test method test_fetch_metadata_success() is missing any coverage information, own or at class level
(#78) Test method test_fetch_metadata_curlerrorno() is missing any coverage information, own or at class level
(#107) Test method test_fetch_metadata_nohttpstatus() is missing any coverage information, own or at class level
(#134) Test method test_fetch_metadata_override_ssl_options() is missing any coverage information, own or at class level
auth/saml2/tests/metadata_parser_test.php
(#34) PHPUnit testcase name "auth_saml2_metadata_parser_testcase" does not match file name "metadata_parser_test"
(#34) PHPUnit class "auth_saml2_metadata_parser_testcase" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#36) Test method test_parse_metadata() is missing any coverage information, own or at class level
(#48) Test method test_parse_metadata_fail() is missing any coverage information, own or at class level
auth/saml2/tests/metadata_refresh_test.php
(#35) PHPUnit testcase name "auth_saml2_metadata_refresh_testcase" does not match file name "metadata_refresh_test"
(#35) PHPUnit class "auth_saml2_metadata_refresh_testcase" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#57) Test method test_metadata_refresh_disabled() is missing any coverage information, own or at class level
(#67) Test method test_metadata_refresh_idpmetadata_non_url() is missing any coverage information, own or at class level
(#81) Test method test_metadata_refresh_idpmetadata_notconfigured() is missing any coverage information, own or at class level
(#94) Test method test_metadata_refresh_fetch_fails() is missing any coverage information, own or at class level
(#115) Test method test_metadata_refresh_parse_fails() is missing any coverage information, own or at class level
(#136) Test method test_metadata_refresh_parse_no_entityid() is missing any coverage information, own or at class level
(#159) Test method test_metadata_refresh_parse_no_idpname() is missing any coverage information, own or at class level
(#188) Test method test_metadata_refresh_write_fails() is missing any coverage information, own or at class level
auth/saml2/tests/metadata_writer_test.php
(#34) PHPUnit testcase name "auth_saml2_metadata_writer_testcase" does not match file name "metadata_writer_test"
(#34) PHPUnit class "auth_saml2_metadata_writer_testcase" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#36) Test method test_write_default_path() is missing any coverage information, own or at class level
(#50) Test method test_write_empty_filename() is missing any coverage information, own or at class level
(#59) Test method test_write_non_dataroot_path() is missing any coverage information, own or at class level
(#79) Test method test_write_trailing_slash() is missing any coverage information, own or at class level
auth/saml2/tests/redis_store_test.php
(#34) PHPUnit testcase name "auth_saml2_redis_store_testcase" does not match file name "redis_store_test"
(#34) PHPUnit class "auth_saml2_redis_store_testcase" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#56) Test method test_set_with_expire() is missing any coverage information, own or at class level
(#67) Test method test_set_no_expire() is missing any coverage information, own or at class level
(#77) Test method test_get_key_exists() is missing any coverage information, own or at class level
(#86) Test method test_get_key_not_exists() is missing any coverage information, own or at class level
(#92) Test method test_delete() is missing any coverage information, own or at class level
(#102) Test method test_delete_key_not_exists() is missing any coverage information, own or at class level
(#107) Test method test_bootstrap_redis() is missing any coverage information, own or at class level
auth/saml2/tests/saml2_sitedata_test.php
(#28) PHPUnit testcase name "auth_saml2_sitedata_test" does not match file name "saml2_sitedata_test"
(#28) PHPUnit class "auth_saml2_sitedata_test" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#29) Test method test_it_creates_the_directory_if_it_does_not_exist() is missing any coverage information, own or at class level
(#45) Test method test_it_emits_an_event_when_saml_certificate_regenerated() is missing any coverage information, own or at class level
auth/saml2/tests/setting_idpmetadata_test.php
(#31) PHPUnit class "setting_idpmetadata_test" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#47) Test method test_it_validates_the_xml() is missing any coverage information, own or at class level
(#54) Test method test_it_saves_all_idp_information() is missing any coverage information, own or at class level
(#82) Test method test_it_saves_all_idps_information_from_single_xml() is missing any coverage information, own or at class level
(#114) Test method test_it_allows_empty_values() is missing any coverage information, own or at class level
(#120) Test method test_it_gets_idp_data_for_xml() is missing any coverage information, own or at class level
(#127) Test method test_it_gets_idp_data_for_two_urls() is missing any coverage information, own or at class level
(#135) Test method test_it_returns_error_if_metadata_url_is_not_valid() is missing any coverage information, own or at class level
auth/saml2/tests/simplesamlphp_upgrade_test.php
(#30) PHPUnit testcase name "auth_saml2_simplesamlphp_upgrade_testcase" does not match file name "simplesamlphp_upgrade_test"
(#30) PHPUnit class "auth_saml2_simplesamlphp_upgrade_testcase" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#35) Test method test_remove_composer_files_from_compiled_extlib_simplesamlphp() is missing any coverage information, own or at class level
(#58) Test method test_remove_phpmailer_from_autoloaded_files() is missing any coverage information, own or at class level
auth/saml2/tests/ssl_algorithm_test.php
(#26) PHPUnit testcase name "auth_saml2_ssl_algorithms_test" does not match file name "ssl_algorithm_test"
(#26) PHPUnit class "auth_saml2_ssl_algorithms_test" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#27) Test method test_default_saml_signature_algorithm_is_valid_saml_signature_algorithm() is missing any coverage information, own or at class level
(#32) Test method test_sha256_is_valid_saml_signature_algorithm() is missing any coverage information, own or at class level
(#37) Test method test_sha256_is_matching_digest_algorithm_for_default_saml_algorithm() is missing any coverage information, own or at class level
(#42) Test method test_sha256_is_matching_digest_algorithm_for_garbage_algorithm() is missing any coverage information, own or at class level
auth/saml2/tests/user_extractor_test.php
(#36) PHPUnit testcase name "auth_saml2_user_extractor_test" does not match file name "user_extractor_test"
(#36) PHPUnit class "auth_saml2_user_extractor_test" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#71) Test method test_get_user_by_field_from_user_table() is missing any coverage information, own or at class level
(#95) Test method test_get_user_by_field_from_user_table_when_multiple_users_found() is missing any coverage information, own or at class level
(#109) Test method test_get_user_by_custom_profile_field() is missing any coverage information, own or at class level
(#158) Test method test_get_user_case_insensitive() is missing any coverage information, own or at class level
(#162) Inline comments must end in full-stops, exclamation marks, or question marks
(#193) Test method test_get_user_by_custom_profile_field_when_multiple_users_found() is missing any coverage information, own or at class level
auth/saml2/tests/user_fields_test.php
(#36) PHPUnit testcase name "auth_saml2_user_fields_test" does not match file name "user_fields_test"
(#36) PHPUnit class "auth_saml2_user_fields_test" does not have any namespace. It is recommended to add it to the "auth_saml2" namespace, using more levels if needed, in order to match the code being tested
(#71) Test method test_constants() is missing any coverage information, own or at class level
(#86) Test method test_get_supported_fields_without_profile_fields() is missing any coverage information, own or at class level
(#100) Test method test_get_supported_fields_with_profile_fields() is missing any coverage information, own or at class level
(#154) Test method test_is_custom_profile_field() is missing any coverage information, own or at class level
(#179) Test method test_get_short_name() is missing any coverage information, own or at class level

Javascript coding style problems

(0 errors, 1 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

auth/saml2/sp/resources/post.js
(#5) Unexpected space before function parentheses. (space-before-function-paren)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]


PHPDocs style problems

(156 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

auth/saml2/classes/admin/saml2_settings.php
(#33) Constant saml2_settings::OPTION_DUAL_LOGIN_NO is not documented
(#35) Constant saml2_settings::OPTION_DUAL_LOGIN_YES is not documented
(#37) Constant saml2_settings::OPTION_DUAL_LOGIN_PASSIVE is not documented
(#39) Constant saml2_settings::OPTION_MULTI_IDP_DISPLAY_DROPDOWN is not documented
(#41) Constant saml2_settings::OPTION_MULTI_IDP_DISPLAY_BUTTONS is not documented
(#43) Constant saml2_settings::OPTION_FLAGGED_LOGIN_MESSAGE is not documented
(#45) Constant saml2_settings::OPTION_FLAGGED_LOGIN_REDIRECT is not documented
(#47) Constant saml2_settings::OPTION_AUTO_LOGIN_NO is not documented
(#49) Constant saml2_settings::OPTION_AUTO_LOGIN_SESSION is not documented
(#51) Constant saml2_settings::OPTION_AUTO_LOGIN_COOKIE is not documented
(#53) Constant saml2_settings::OPTION_TOLOWER_EXACT is not documented
(#55) Constant saml2_settings::OPTION_TOLOWER_LOWER_CASE is not documented
(#57) Constant saml2_settings::OPTION_TOLOWER_CASE_INSENSITIVE is not documented
(#17) No one-line description found in phpdocs for file
(#26) No one-line description found in phpdocs for class saml2_settings
auth/saml2/classes/admin/setting_button.php
(#57) Phpdocs for function setting_button::output_html has incomplete parameters list
auth/saml2/classes/admin/setting_idpmetadata.php
(#46) Function setting_idpmetadata::__construct is not documented
(#106) Function setting_idpmetadata::process_idp_metadata is not documented
(#121) Function setting_idpmetadata::process_idp_xml is not documented
(#171) Function setting_idpmetadata::remove_old_idps is not documented
(#249) Function setting_idpmetadata::save_idp_metadata_xml is not documented
(#17) No one-line description found in phpdocs for file
(#82) There is no description in phpdocs for function process_all_idps_metadata
(#181) There is no description in phpdocs for function get_idps_data
(#211) There is no description in phpdocs for function get_idp_xml_path
(#240) There is no description in phpdocs for function find_all_idp_sso_descriptors
(#182) Phpdocs for function setting_idpmetadata::get_idps_data has incomplete parameters list
(#212) Phpdocs for function setting_idpmetadata::get_idp_xml_path has incomplete parameters list
auth/saml2/classes/admin/setting_idpmetadata_exception.php
(#28) Class setting_idpmetadata_exception is not documented
(#17) No one-line description found in phpdocs for file
auth/saml2/classes/admin/setting_textonly.php
(#36) Phpdocs for function setting_textonly::output_html has incomplete parameters list
auth/saml2/classes/api.php
(#33) Inline phpdocs tag {@see saml2-logout.php} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
auth/saml2/classes/auth.php
(#140) Function auth::get_saml2_directory is not documented
(#149) Function auth::get_file is not documented
(#153) Function auth::get_file_sp_metadata_file is not documented
(#1128) Function auth::can_be_manually_set is not documented
(#157) There is no description in phpdocs for function get_file_idp_metadata_file
(#581) Phpdocs for function auth::saml_login_complete has incomplete parameters list
(#849) Phpdocs for function auth::simplify_attr has incomplete parameters list
(#873) Phpdocs for function auth::update_user_profile_fields has incomplete parameters list
(#965) Phpdocs for function auth::is_email_taken has incomplete parameters list
(#1062) Phpdocs for function auth::user_login has incomplete parameters list
(#1182) Phpdocs for function auth::execute_callback has incomplete parameters list
(#338) Inline phpdocs tag {@see login.php} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
auth/saml2/classes/event/cert_regenerated.php
(#17) File-level phpdocs block does not have @copyright tag
auth/saml2/classes/form/selectidp_buttons.php
(#73) Function selectidp_buttons::get_idpbutton is not documented
auth/saml2/classes/idp_data.php
(#28) Package is not specified for class idp_data. It is also not specified in file-level phpdocs
(#28) Class idp_data is not documented
(#51) Function idp_data::get_rawxml is not documented
(#55) Function idp_data::set_rawxml is not documented
(#29) Variable idp_data::$idpname is not documented
(#31) Variable idp_data::$idpurl is not documented
(#33) Variable idp_data::$idpicon is not documented
(#35) Variable idp_data::$rawxml is not documented
(#40) Phpdocs for function idp_data::__construct has incomplete parameters list
auth/saml2/classes/idp_parser.php
(#27) Class idp_parser is not documented
(#77) Function idp_parser::parse_xml is not documented
(#83) Function idp_parser::parse_urls is not documented
(#42) Phpdocs for function idp_parser::parse has incomplete parameters list
(#57) Phpdocs for function idp_parser::check_xml has incomplete parameters list
auth/saml2/classes/metadata_fetcher.php
(#54) There is no description in phpdocs for function fetch
(#101) There is no description in phpdocs for function get_curlinfo
(#108) There is no description in phpdocs for function get_curlerrorno
(#115) There is no description in phpdocs for function get_curlerror
(#55) Phpdocs for function metadata_fetcher::fetch has incomplete parameters list
auth/saml2/classes/metadata_parser.php
(#45) There is no description in phpdocs for function parse
(#71) There is no description in phpdocs for function get_entityid
(#78) There is no description in phpdocs for function get_idpdefaultname
auth/saml2/classes/metadata_writer.php
(#53) There is no description in phpdocs for function write
auth/saml2/classes/redis_store.php
(#51) Function redis_store::__construct is not documented
(#62) There is no description in phpdocs for function set
(#72) There is no description in phpdocs for function get
(#86) There is no description in phpdocs for function delete
(#126) There is no description in phpdocs for function make_key
(#135) There is no description in phpdocs for function get_set_options
auth/saml2/classes/ssl_algorithms.php
(#30) Class ssl_algorithms is not documented
(#34) Function ssl_algorithms::get_default_saml_signature_algorithm is not documented
(#42) Function ssl_algorithms::get_valid_saml_signature_algorithms is not documented
(#54) Function ssl_algorithms::convert_signature_algorithm_to_digest_alg_format is not documented
(#17) No one-line description found in phpdocs for file
auth/saml2/classes/task/metadata_refresh.php
(#67) Function metadata_refresh::get_name is not documented
(#71) Function metadata_refresh::execute is not documented
(#104) There is no description in phpdocs for function set_fetcher
(#111) There is no description in phpdocs for function set_parser
(#118) There is no description in phpdocs for function set_writer
(#125) There is no description in phpdocs for function set_idpmetadata
auth/saml2/classes/test/mock_settings.php
(#42) Function mock_settings::add is not documented
(#17) No one-line description found in phpdocs for file
(#32) No one-line description found in phpdocs for class mock_settings
auth/saml2/classes/testing/generator.php
(#33) Package is not specified for class generator. It is also not specified in file-level phpdocs
(#33) Class generator is not documented
auth/saml2/classes/testing/tests_generator.php
(#33) Package is not specified for function reset. It is also not specified in file-level phpdocs
(#42) Package is not specified for function create_idp_entity. It is also not specified in file-level phpdocs
(#28) Not recommended phpdocs tag @internal used
auth/saml2/classes/user_extractor.php
(#45) Inline phpdocs tag {@link $USER} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
auth/saml2/lib.php
(#17) No one-line description found in phpdocs for file
auth/saml2/locallib.php
(#455) Phpdocs for function auth_saml2_process_regenerate_form has incomplete parameters list
(#493) Phpdocs for function auth_saml2_admin_nav has incomplete parameters list
auth/saml2/tests/auth_test.php
(#86) Function auth_test::get_generator is not documented
(#1003) Phpdocs for function auth_test::test_is_access_allowed_for_member_not_configured has incomplete parameters list
(#1037) Phpdocs for function auth_test::test_is_access_allowed_for_member_blocked_empty has incomplete parameters list
(#1068) Phpdocs for function auth_test::test_is_access_allowed_for_member_allowed_empty has incomplete parameters list
(#1098) Phpdocs for function auth_test::test_is_access_allowed_for_member_allowed_and_blocked has incomplete parameters list
(#1129) Phpdocs for function auth_test::test_is_access_allowed_for_member_allowed_and_blocked_with_allowed_priority has incomplete parameters list
(#1156) Phpdocs for function auth_test::test_update_custom_user_profile_fields has incomplete parameters list
(#1216) Phpdocs for function auth_test::test_missing_user_custom_profile_fields has incomplete parameters list
(#1262) Phpdocs for function auth_test::test_invalid_map_user_profile_fields has incomplete parameters list
auth/saml2/tests/autoloader_test.php
(#17) No one-line description found in phpdocs for file
(#28) No one-line description found in phpdocs for class auth_saml2_autoloader_test
auth/saml2/tests/behat/behat_auth_saml2.php
(#114) Function behat_auth_saml2::apply_defaults is not documented
(#144) Function behat_auth_saml2::initialise_saml2 is not documented
(#321) Function behat_auth_saml2::visit_saml2_login_page is not documented
(#325) Function behat_auth_saml2::reset_saml2_session is not documented
(#330) Function behat_auth_saml2::reset_moodle_session is not documented
(#335) Function behat_auth_saml2::execute is not documented
(#17) No one-line description found in phpdocs for file
(#35) No one-line description found in phpdocs for class behat_auth_saml2
(#43) There is no description in phpdocs for function theAuthenticationPluginIsEnabledAuth_saml
(#61) There is no description in phpdocs for function iGoToTheLoginPageAuth_saml
(#78) There is no description in phpdocs for function iGoToTheLoginPageWithAuth_saml
(#85) There is no description in phpdocs for function iAmAnAdministratorAuth_saml
(#92) There is no description in phpdocs for function iGoToTheSamlsettingsPageAuth_saml
(#100) There is no description in phpdocs for function iChangeTheSettingToAuth_saml
(#107) There is no description in phpdocs for function theSettingShouldBeAuth_saml
(#149) There is no description in phpdocs for function theSamlsettingIsSetToAuth_saml
(#43) Phpdocs for function behat_auth_saml2::theAuthenticationPluginIsEnabledAuth_saml has incomplete parameters list
(#61) Phpdocs for function behat_auth_saml2::iGoToTheLoginPageAuth_saml has incomplete parameters list
(#78) Phpdocs for function behat_auth_saml2::iGoToTheLoginPageWithAuth_saml has incomplete parameters list
(#100) Phpdocs for function behat_auth_saml2::iChangeTheSettingToAuth_saml has incomplete parameters list
(#107) Phpdocs for function behat_auth_saml2::theSettingShouldBeAuth_saml has incomplete parameters list
(#149) Phpdocs for function behat_auth_saml2::theSamlsettingIsSetToAuth_saml has incomplete parameters list
(#240) Phpdocs for function behat_auth_saml2::the_mock_saml_idp_allows_login_with_the_following_attributes has incomplete parameters list
(#301) Phpdocs for function behat_auth_saml2::the_cookie_is_set_to has incomplete parameters list
(#311) Phpdocs for function behat_auth_saml2::the_cookie_is_removed has incomplete parameters list
(#22) Invalid phpdocs tag @codingStandardsIgnoreFile used
(#40) Invalid phpdocs tag @SuppressWarnings(public) used
auth/saml2/tests/fixtures/mockidp/slo.php
(#17) No one-line description found in phpdocs for file
auth/saml2/tests/fixtures/mockidp/sso.php
(#17) No one-line description found in phpdocs for file
auth/saml2/tests/form_regenerate_test.php
(#17) File-level phpdocs block does not have @copyright tag
auth/saml2/tests/generator_test.php
(#43) Function generator_testcase::get_generator is not documented
auth/saml2/tests/metadata_parser_test.php
(#46) There is no description in phpdocs for function test_parse_metadata_fail
auth/saml2/tests/metadata_refresh_test.php
(#91) There is no description in phpdocs for function test_metadata_refresh_fetch_fails
(#112) There is no description in phpdocs for function test_metadata_refresh_parse_fails
(#185) There is no description in phpdocs for function test_metadata_refresh_write_fails
(#92) Invalid phpdocs tag @expectedException used
(#113) Invalid phpdocs tag @expectedException used
(#186) Invalid phpdocs tag @expectedException used
auth/saml2/tests/metadata_writer_test.php
(#48) There is no description in phpdocs for function test_write_empty_filename
auth/saml2/tests/saml2_sitedata_test.php
(#28) Class auth_saml2_sitedata_test is not documented
(#17) No one-line description found in phpdocs for file
auth/saml2/tests/setting_idpmetadata_test.php
(#31) Class setting_idpmetadata_test is not documented
(#40) Function setting_idpmetadata_test::get_test_metadata_url is not documented
(#17) No one-line description found in phpdocs for file
(#149) There is no description in phpdocs for function validate_idp_data_array
(#162) Not recommended phpdocs tag @static used
auth/saml2/tests/simplesamlphp_upgrade_test.php
(#17) File-level phpdocs block does not have @copyright tag
auth/saml2/tests/ssl_algorithm_test.php
(#26) Class auth_saml2_ssl_algorithms_test is not documented
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


Missing changes in external functions or backup support for new detected tables or columns

(0 errors, 3 warnings)

This section shows potential problems detected when there are new database structures added in a patch and it is detected that nothing has been changed related with external functions (to be used by WS) or backup and restore. It must be checked that everything is correct and nothing is being missed in those areas. [More info]

auth/saml2/db/upgrade.php
Database modifications (new tables or columns) detected in the patch without any change to some important areas.
No changes detected to external functions, that may affect apps and other web service integrations, please verify!
No changes detected to backup and restore, that may affect storage and transportability, please verify!

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]


shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]