PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(4 errors, 5 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/saml2/autologin.php: (#25) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#34) Function print_error() has been deprecated; use throw new moodle_exception() (using lang strings only if meant to be shown to final user)() instead
auth/saml2/classes/form/selectidp_buttons.php: (#61) Line exceeds 132 characters; contains 137 characters
auth/saml2/classes/group_rule.php: (#135) File must end with a newline character
auth/saml2/classes/metadata_parser.php: (#86) File must end with a newline character
auth/saml2/classes/metadata_writer.php: (#75) File must end with a newline character
auth/saml2/classes/privacy/provider.php: (#50) Method name "_get_reason" should not be prefixed with an underscore to indicate visibility
auth/saml2/tests/auth_test.php: (#231) Inline comments must end in full-stops, exclamation marks, or question marks
auth/saml2/tests/metadata_writer_test.php: (#94) File must end with a newline character

Javascript coding style problems

(0 errors, 1 warnings)

This section shows the coding style problems detected in the code by eslint [More info]

auth/saml2/sp/resources/post.js: (#5) Unexpected space before function parentheses. (space-before-function-paren)

CSS problems

(0 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

PHPDocs style problems

(145 errors, 1 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

auth/saml2/classes/admin/saml2_settings.php: (#35) Constant saml2_settings::OPTION_DUAL_LOGIN_NO is not documented; (#37) Constant saml2_settings::OPTION_DUAL_LOGIN_YES is not documented; (#39) Constant saml2_settings::OPTION_DUAL_LOGIN_PASSIVE is not documented; (#41) Constant saml2_settings::OPTION_MULTI_IDP_DISPLAY_DROPDOWN is not documented; (#43) Constant saml2_settings::OPTION_MULTI_IDP_DISPLAY_BUTTONS is not documented; (#45) Constant saml2_settings::OPTION_FLAGGED_LOGIN_MESSAGE is not documented; (#47) Constant saml2_settings::OPTION_FLAGGED_LOGIN_REDIRECT is not documented; (#49) Constant saml2_settings::OPTION_AUTO_LOGIN_NO is not documented; (#51) Constant saml2_settings::OPTION_AUTO_LOGIN_SESSION is not documented; (#53) Constant saml2_settings::OPTION_AUTO_LOGIN_COOKIE is not documented; (#17) No one-line description found in phpdocs for file; (#28) No one-line description found in phpdocs for class saml2_settings
auth/saml2/classes/admin/setting_button.php: (#57) Phpdocs for function setting_button::output_html has incomplete parameters list
auth/saml2/classes/admin/setting_idpmetadata.php: (#46) Function setting_idpmetadata::__construct is not documented; (#106) Function setting_idpmetadata::process_idp_metadata is not documented; (#121) Function setting_idpmetadata::process_idp_xml is not documented; (#171) Function setting_idpmetadata::remove_old_idps is not documented; (#249) Function setting_idpmetadata::save_idp_metadata_xml is not documented; (#17) No one-line description found in phpdocs for file; (#82) There is no description in phpdocs for function process_all_idps_metadata; (#181) There is no description in phpdocs for function get_idps_data; (#211) There is no description in phpdocs for function get_idp_xml_path; (#240) There is no description in phpdocs for function find_all_idp_sso_descriptors; (#182) Phpdocs for function setting_idpmetadata::get_idps_data has incomplete parameters list; (#212) Phpdocs for function setting_idpmetadata::get_idp_xml_path has incomplete parameters list
auth/saml2/classes/admin/setting_idpmetadata_exception.php: (#30) Class setting_idpmetadata_exception is not documented; (#17) No one-line description found in phpdocs for file
auth/saml2/classes/admin/setting_textonly.php: (#38) Phpdocs for function setting_textonly::output_html has incomplete parameters list
auth/saml2/classes/api.php: (#35) Inline phpdocs tag {@see saml2-logout.php} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
auth/saml2/classes/auth.php: (#133) Function auth::get_saml2_directory is not documented; (#142) Function auth::get_file is not documented; (#146) Function auth::get_file_sp_metadata_file is not documented; (#1071) Function auth::can_be_manually_set is not documented; (#150) There is no description in phpdocs for function get_file_idp_metadata_file; (#566) Phpdocs for function auth::saml_login_complete has incomplete parameters list; (#822) Phpdocs for function auth::simplify_attr has incomplete parameters list; (#846) Phpdocs for function auth::update_user_profile_fields has incomplete parameters list; (#928) Phpdocs for function auth::is_email_taken has incomplete parameters list; (#1019) Phpdocs for function auth::user_login has incomplete parameters list; (#1125) Phpdocs for function auth::execute_callback has incomplete parameters list; (#324) Inline phpdocs tag {@see login.php} with incorrect contents found. It must match {@link valid URL} or {@see valid FQSEN}
auth/saml2/classes/event/cert_regenerated.php: (#17) File-level phpdocs block does not have @copyright tag
auth/saml2/classes/form/selectidp_buttons.php: (#72) Function selectidp_buttons::get_idpbutton is not documented
auth/saml2/classes/idp_data.php: (#30) Package is not specified for class idp_data. It is also not specified in file-level phpdocs; (#30) Class idp_data is not documented; (#53) Function idp_data::get_rawxml is not documented; (#57) Function idp_data::set_rawxml is not documented; (#31) Variable idp_data::$idpname is not documented; (#33) Variable idp_data::$idpurl is not documented; (#35) Variable idp_data::$idpicon is not documented; (#37) Variable idp_data::$rawxml is not documented; (#42) Phpdocs for function idp_data::__construct has incomplete parameters list
auth/saml2/classes/idp_parser.php: (#29) Class idp_parser is not documented; (#79) Function idp_parser::parse_xml is not documented; (#85) Function idp_parser::parse_urls is not documented; (#44) Phpdocs for function idp_parser::parse has incomplete parameters list; (#59) Phpdocs for function idp_parser::check_xml has incomplete parameters list
auth/saml2/classes/metadata_fetcher.php: (#54) There is no description in phpdocs for function fetch; (#101) There is no description in phpdocs for function get_curlinfo; (#108) There is no description in phpdocs for function get_curlerrorno; (#115) There is no description in phpdocs for function get_curlerror; (#55) Phpdocs for function metadata_fetcher::fetch has incomplete parameters list
auth/saml2/classes/metadata_parser.php: (#47) There is no description in phpdocs for function parse; (#73) There is no description in phpdocs for function get_entityid; (#80) There is no description in phpdocs for function get_idpdefaultname
auth/saml2/classes/metadata_writer.php: (#55) There is no description in phpdocs for function write
auth/saml2/classes/redis_store.php: (#51) Function redis_store::__construct is not documented; (#62) There is no description in phpdocs for function set; (#72) There is no description in phpdocs for function get; (#86) There is no description in phpdocs for function delete; (#126) There is no description in phpdocs for function make_key; (#135) There is no description in phpdocs for function get_set_options
auth/saml2/classes/ssl_algorithms.php: (#30) Class ssl_algorithms is not documented; (#34) Function ssl_algorithms::get_default_saml_signature_algorithm is not documented; (#42) Function ssl_algorithms::get_valid_saml_signature_algorithms is not documented; (#54) Function ssl_algorithms::convert_signature_algorithm_to_digest_alg_format is not documented; (#17) No one-line description found in phpdocs for file
auth/saml2/classes/task/metadata_refresh.php: (#69) Function metadata_refresh::get_name is not documented; (#73) Function metadata_refresh::execute is not documented; (#106) There is no description in phpdocs for function set_fetcher; (#113) There is no description in phpdocs for function set_parser; (#120) There is no description in phpdocs for function set_writer; (#127) There is no description in phpdocs for function set_idpmetadata
auth/saml2/classes/test/mock_settings.php: (#42) Function mock_settings::add is not documented; (#17) No one-line description found in phpdocs for file; (#32) No one-line description found in phpdocs for class mock_settings
auth/saml2/lib.php: (#17) No one-line description found in phpdocs for file
auth/saml2/locallib.php: (#462) Phpdocs for function auth_saml2_process_regenerate_form has incomplete parameters list; (#500) Phpdocs for function auth_saml2_admin_nav has incomplete parameters list
auth/saml2/tests/auth_test.php: (#867) Phpdocs for function auth_testcase::test_is_access_allowed_for_member_not_configured has incomplete parameters list; (#901) Phpdocs for function auth_testcase::test_is_access_allowed_for_member_blocked_empty has incomplete parameters list; (#932) Phpdocs for function auth_testcase::test_is_access_allowed_for_member_allowed_empty has incomplete parameters list; (#962) Phpdocs for function auth_testcase::test_is_access_allowed_for_member_allowed_and_blocked has incomplete parameters list; (#993) Phpdocs for function auth_testcase::test_is_access_allowed_for_member_allowed_and_blocked_with_allowed_priority has incomplete parameters list; (#1020) Phpdocs for function auth_testcase::test_update_custom_user_profile_fields has incomplete parameters list; (#1080) Phpdocs for function auth_testcase::test_missing_user_custom_profile_fields has incomplete parameters list; (#1126) Phpdocs for function auth_testcase::test_invalid_map_user_profile_fields has incomplete parameters list
auth/saml2/tests/autoloader_test.php: (#17) No one-line description found in phpdocs for file; (#28) No one-line description found in phpdocs for class auth_saml2_autoloader_test
auth/saml2/tests/behat/behat_auth_saml2.php: (#114) Function behat_auth_saml2::apply_defaults is not documented; (#144) Function behat_auth_saml2::initialise_saml2 is not documented; (#321) Function behat_auth_saml2::visit_saml2_login_page is not documented; (#325) Function behat_auth_saml2::reset_saml2_session is not documented; (#330) Function behat_auth_saml2::reset_moodle_session is not documented; (#335) Function behat_auth_saml2::execute is not documented; (#17) No one-line description found in phpdocs for file; (#35) No one-line description found in phpdocs for class behat_auth_saml2; (#43) There is no description in phpdocs for function theAuthenticationPluginIsEnabledAuth_saml; (#61) There is no description in phpdocs for function iGoToTheLoginPageAuth_saml; (#78) There is no description in phpdocs for function iGoToTheLoginPageWithAuth_saml; (#85) There is no description in phpdocs for function iAmAnAdministratorAuth_saml; (#92) There is no description in phpdocs for function iGoToTheSamlsettingsPageAuth_saml; (#100) There is no description in phpdocs for function iChangeTheSettingToAuth_saml; (#107) There is no description in phpdocs for function theSettingShouldBeAuth_saml; (#149) There is no description in phpdocs for function theSamlsettingIsSetToAuth_saml; (#43) Phpdocs for function behat_auth_saml2::theAuthenticationPluginIsEnabledAuth_saml has incomplete parameters list; (#61) Phpdocs for function behat_auth_saml2::iGoToTheLoginPageAuth_saml has incomplete parameters list; (#78) Phpdocs for function behat_auth_saml2::iGoToTheLoginPageWithAuth_saml has incomplete parameters list; (#100) Phpdocs for function behat_auth_saml2::iChangeTheSettingToAuth_saml has incomplete parameters list; (#107) Phpdocs for function behat_auth_saml2::theSettingShouldBeAuth_saml has incomplete parameters list; (#149) Phpdocs for function behat_auth_saml2::theSamlsettingIsSetToAuth_saml has incomplete parameters list; (#240) Phpdocs for function behat_auth_saml2::the_mock_saml_idp_allows_login_with_the_following_attributes has incomplete parameters list; (#301) Phpdocs for function behat_auth_saml2::the_cookie_is_set_to has incomplete parameters list; (#311) Phpdocs for function behat_auth_saml2::the_cookie_is_removed has incomplete parameters list; (#22) Invalid phpdocs tag @codingStandardsIgnoreFile used; (#40) Invalid phpdocs tag @SuppressWarnings(public) used
auth/saml2/tests/fixtures/mockidp/slo.php: (#17) No one-line description found in phpdocs for file
auth/saml2/tests/fixtures/mockidp/sso.php: (#17) No one-line description found in phpdocs for file
auth/saml2/tests/form_regenerate_test.php: (#17) File-level phpdocs block does not have @copyright tag
auth/saml2/tests/metadata_parser_test.php: (#48) There is no description in phpdocs for function test_parse_metadata_fail
auth/saml2/tests/metadata_refresh_test.php: (#86) There is no description in phpdocs for function test_metadata_refresh_fetch_fails; (#107) There is no description in phpdocs for function test_metadata_refresh_parse_fails; (#180) There is no description in phpdocs for function test_metadata_refresh_write_fails; (#87) Invalid phpdocs tag @expectedException used; (#108) Invalid phpdocs tag @expectedException used; (#181) Invalid phpdocs tag @expectedException used
auth/saml2/tests/metadata_writer_test.php: (#50) There is no description in phpdocs for function test_write_empty_filename
auth/saml2/tests/saml2_sitedata_test.php: (#28) Class auth_saml2_sitedata_test is not documented; (#17) No one-line description found in phpdocs for file
auth/saml2/tests/setting_idpmetadata_test.php: (#31) Class setting_idpmetadata_test is not documented; (#40) Function setting_idpmetadata_test::get_test_metadata_url is not documented; (#17) No one-line description found in phpdocs for file; (#149) There is no description in phpdocs for function validate_idp_data_array; (#162) Not recommended phpdocs tag @static used
auth/saml2/tests/ssl_algorithm_test.php: (#28) Class auth_saml2_ssl_algorithms_test is not documented; (#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]