PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]

PHP coding style problems

(88 errors, 59 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/oidc/auth.php: (#81) Visibility must be declared on method "can_be_manually_set"
auth/oidc/classes/adminsetting/auth_oidc_admin_setting_iconselect.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#96) Short array syntax must be used to define arrays; (#117) There should be a comma after the last array item in a multi-line array.
auth/oidc/classes/adminsetting/auth_oidc_admin_setting_label.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#36) Missing member variable doc comment
auth/oidc/classes/adminsetting/auth_oidc_admin_setting_loginflow.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#82) There should be a comma after the last array item in a multi-line array.
auth/oidc/classes/adminsetting/auth_oidc_admin_setting_redirecturi.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#36) Missing member variable doc comment
auth/oidc/classes/event/action_failed.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#58) Short array syntax must be used to define arrays
auth/oidc/classes/event/user_authed.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/event/user_connected.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/event/user_created.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/event/user_disconnected.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/event/user_loggedin.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/event/user_rename_attempt.php: (#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#66) File must end with a newline character
auth/oidc/classes/form/application.php: (#92) There should be a comma after the last array item in a multi-line array.; (#152) Inline comments must start with a capital letter, digit or 3-dots sequence; (#194) Visibility must be declared on method "validation"; (#284) File must end with a newline character
auth/oidc/classes/httpclient.php: (#88) Short array syntax must be used to define arrays; (#103) Short array syntax must be used to define arrays
auth/oidc/classes/httpclientinterface.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#42) Short array syntax must be used to define arrays
auth/oidc/classes/jwt.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/loginflow/authcode.php: (#79) There should be a comma after the last array item in a multi-line array.; (#140) Logical operator "and" is prohibited; use "&&" instead; (#190) Short array syntax must be used to define arrays; (#190) Short array syntax must be used to define arrays; (#212) No one-line description found in phpdocs for docblock of function handlecertadminconsentresponse; (#254) There should be a comma after the last array item in a multi-line array.; (#330) There should be a comma after the last array item in a multi-line array.; (#623) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#624) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#665) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#666) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#667) Expected 1 space before comment text but found 2; use block comment if you need indentation; (#791) Short array syntax must be used to define arrays
auth/oidc/classes/loginflow/base.php: (#55) There should be a comma after the last array item in a multi-line array.
auth/oidc/classes/loginflow/rocreds.php: (#125) Short array syntax must be used to define arrays; (#125) Short array syntax must be used to define arrays
auth/oidc/classes/observers.php: (#1) No one-line description found in phpdocs for docblock of file observers.php
auth/oidc/classes/oidcclient.php: (#172) Short array syntax must be used to define arrays; (#172) Short array syntax must be used to define arrays; (#182) There should be a comma after the last array item in a multi-line array.; (#232) Short array syntax must be used to define arrays; (#251) Short array syntax must be used to define arrays; (#251) Short array syntax must be used to define arrays; (#381) There must not be a space before the colon in a return type declaration; (#399) Whitespace found at end of line
auth/oidc/classes/privacy/provider.php: (#30) Import statements must not begin with a leading backslash; (#31) Import statements must not begin with a leading backslash; (#32) Import statements must not begin with a leading backslash; (#33) Import statements must not begin with a leading backslash; (#35) Missing docblock for interface auth_oidc_userlist; (#52) There must not be a space before the colon in a return type declaration; (#96) There must not be a space before the colon in a return type declaration; (#130) There should be a comma after the last array item in a multi-line array.; (#165) There should be a comma after the last array item in a multi-line array.; (#177) There must not be a space before the colon in a return type declaration
auth/oidc/classes/task/cleanup_oidc_state_and_token.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/tests/mockhttpclient.php: (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#72) Short array syntax must be used to define arrays
auth/oidc/classes/tests/mockoidcclient.php: (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#48) Short array syntax must be used to define arrays; (#48) Short array syntax must be used to define arrays
auth/oidc/classes/utils.php: (#31) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#45) Short array syntax must be used to define arrays; (#106) The use of function print_r() is forbidden; (#108) The use of function print_r() is forbidden
auth/oidc/db/access.php: (#35) There should be a comma after the last array item in a multi-line array.; (#41) There should be a comma after the last array item in a multi-line array.; (#47) There should be a comma after the last array item in a multi-line array.
auth/oidc/index.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
auth/oidc/lib.php: (#29) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#32) Missing docblock for constant AUTH_OIDC_IDP_TYPE_MICROSOFT_ENTRA_ID; (#32) CONST keyword must be lowercase; expected "const" but found "CONST"; (#33) Missing docblock for constant AUTH_OIDC_IDP_TYPE_MICROSOFT_IDENTITY_PLATFORM; (#33) CONST keyword must be lowercase; expected "const" but found "CONST"; (#34) Missing docblock for constant AUTH_OIDC_IDP_TYPE_OTHER; (#34) CONST keyword must be lowercase; expected "const" but found "CONST"; (#37) Missing docblock for constant AUTH_OIDC_MICROSOFT_ENDPOINT_VERSION_UNKNOWN; (#37) CONST keyword must be lowercase; expected "const" but found "CONST"; (#38) Missing docblock for constant AUTH_OIDC_MICROSOFT_ENDPOINT_VERSION_1; (#38) CONST keyword must be lowercase; expected "const" but found "CONST"; (#39) Missing docblock for constant AUTH_OIDC_MICROSOFT_ENDPOINT_VERSION_2; (#39) CONST keyword must be lowercase; expected "const" but found "CONST"; (#42) Missing docblock for constant AUTH_OIDC_AUTH_METHOD_SECRET; (#42) CONST keyword must be lowercase; expected "const" but found "CONST"; (#43) Missing docblock for constant AUTH_OIDC_AUTH_METHOD_CERTIFICATE; (#43) CONST keyword must be lowercase; expected "const" but found "CONST"; (#46) Missing docblock for constant AUTH_OIDC_AUTH_CERT_SOURCE_TEXT; (#46) CONST keyword must be lowercase; expected "const" but found "CONST"; (#47) Missing docblock for constant AUTH_OIDC_AUTH_CERT_SOURCE_FILE; (#47) CONST keyword must be lowercase; expected "const" but found "CONST"; (#63) Logical operator "or" is prohibited; use "||" instead; (#410) Short array syntax must be used to define arrays
auth/oidc/logout.php: (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.; (#36) Inline comments must start with a capital letter, digit or 3-dots sequence; (#36) Inline comments must end in full-stops, exclamation marks, or question marks; (#37) Expected "foreach (...) {\n"; found "foreach(...) {\n"
auth/oidc/tests/jwt_test.php: (#36) PHPUnit testcase name "auth_oidc_jwt_testcase" does not match file name "jwt_test"; (#36) PHPUnit class "auth_oidc_jwt_testcase" does not have any namespace. It is recommended to add it to the "auth_oidc" namespace, using more levels if needed, in order to match the code being tested; (#40) There must be a single space between the colon and type in a return type declaration; (#54) There should be a comma after the last array item in a multi-line array.; (#58) There should be a comma after the last array item in a multi-line array.; (#62) There should be a comma after the last array item in a multi-line array.; (#66) There should be a comma after the last array item in a multi-line array.; (#70) There should be a comma after the last array item in a multi-line array.; (#74) There should be a comma after the last array item in a multi-line array.; (#79) There should be a comma after the last array item in a multi-line array.; (#84) There should be a comma after the last array item in a multi-line array.; (#90) There should be a comma after the last array item in a multi-line array.; (#96) There should be a comma after the last array item in a multi-line array.; (#105) There should be a comma after the last array item in a multi-line array.; (#116) Test method test_decode() is missing any coverage information, own or at class level
auth/oidc/tests/oidcclient_test.php: (#36) PHPUnit testcase name "auth_oidc_oidcclient_testcase" does not match file name "oidcclient_test"; (#36) PHPUnit class "auth_oidc_oidcclient_testcase" does not have any namespace. It is recommended to add it to the "auth_oidc" namespace, using more levels if needed, in order to match the code being tested; (#40) There must be a single space between the colon and type in a return type declaration; (#48) Test method test_creds_getters_and_setters() is missing any coverage information, own or at class level; (#61) Commas (,) must be followed by white space.; (#79) There should be a comma after the last array item in a multi-line array.; (#84) There should be a comma after the last array item in a multi-line array.; (#89) There should be a comma after the last array item in a multi-line array.; (#94) There should be a comma after the last array item in a multi-line array.; (#99) There should be a comma after the last array item in a multi-line array.; (#112) Test method test_endpoints_getters_and_setters() is missing any coverage information, own or at class level
auth/oidc/tests/privacy_provider_test.php: (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.; (#28) Import statements must not begin with a leading backslash; (#38) PHPUnit testcase name "auth_oidc_privacy_testcase" does not match file name "privacy_provider_test"; (#38) PHPUnit class "auth_oidc_privacy_testcase" does not have any namespace. It is recommended to add it to the "auth_oidc" namespace, using more levels if needed, in order to match the code being tested; (#42) There must be a single space between the colon and type in a return type declaration; (#51) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level; (#71) Test method test_get_users_in_context() is missing any coverage information, own or at class level; (#104) Test method test_export_user_data() is missing any coverage information, own or at class level; (#119) There should be a comma after the last array item in a multi-line array.; (#126) There should be a comma after the last array item in a multi-line array.; (#136) Test method test_delete_data_for_all_users_in_context() is missing any coverage information, own or at class level; (#167) Test method test_delete_data_for_user() is missing any coverage information, own or at class level; (#199) Test method test_delete_data_for_users() is missing any coverage information, own or at class level; (#265) The static declaration must come after the visibility declaration; (#265) There must not be a space before the colon in a return type declaration; (#290) The static declaration must come after the visibility declaration; (#290) There must not be a space before the colon in a return type declaration

CSS problems

(2 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

auth/oidc/classes/adminsetting/iconselect.css: (#2) Unexpected !important (declaration-no-important); (#3) Unexpected !important (declaration-no-important)

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]

Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]

grunt changes

(0 errors, 0 warnings)

This section shows files built by grunt and not commited [More info]

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]

Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]

Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]

Prechecker results: error

PHP lint problems

PHP coding style problems

Javascript coding style problems

CSS problems

PHPDocs style problems

Update savepoints problems

Third party library modification problems

grunt changes

shifter problems

Mustache template problems

Gherkin .feature problems