PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(16 errors, 40 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- auth/oidc/classes/adminsetting/auth_oidc_admin_setting_iconselect.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/adminsetting/auth_oidc_admin_setting_label.php
- (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/adminsetting/auth_oidc_admin_setting_loginflow.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/adminsetting/auth_oidc_admin_setting_redirecturi.php
- (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/event/action_failed.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/event/user_authed.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/event/user_connected.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/event/user_created.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/event/user_disconnected.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/event/user_loggedin.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/form/application.php
- (#120) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#147) Visibility must be declared on method "validation"
- (#210) File must end with a newline character
- auth/oidc/classes/httpclientinterface.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/jwt.php
- (#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/loginflow/authcode.php
- (#136) Logical operator "and" is prohibited; use "&&" instead
- auth/oidc/classes/task/cleanup_oidc_state_and_token.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/tests/mockhttpclient.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/tests/mockoidcclient.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- auth/oidc/classes/utils.php
- (#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#106) The use of function print_r() is forbidden
- (#108) The use of function print_r() is forbidden
- auth/oidc/index.php
- (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
- auth/oidc/lib.php
- (#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#30) CONST keyword must be lowercase; expected "const" but found "CONST"
- (#31) CONST keyword must be lowercase; expected "const" but found "CONST"
- (#32) CONST keyword must be lowercase; expected "const" but found "CONST"
- (#35) CONST keyword must be lowercase; expected "const" but found "CONST"
- (#36) CONST keyword must be lowercase; expected "const" but found "CONST"
- (#37) CONST keyword must be lowercase; expected "const" but found "CONST"
- (#40) CONST keyword must be lowercase; expected "const" but found "CONST"
- (#41) CONST keyword must be lowercase; expected "const" but found "CONST"
- (#57) Logical operator "or" is prohibited; use "||" instead
- auth/oidc/logout.php
- (#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
- (#36) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#36) Inline comments must end in full-stops, exclamation marks, or question marks
- (#37) Expected "foreach (...) {\n"; found "foreach(...) {\n"
- auth/oidc/tests/jwt_test.php
- (#36) PHPUnit testcase name "auth_oidc_jwt_testcase" does not match file name "jwt_test"
- (#36) PHPUnit class "auth_oidc_jwt_testcase" does not have any namespace. It is recommended to add it to the "auth_oidc" namespace, using more levels if needed, in order to match the code being tested
- (#116) Test method test_decode() is missing any coverage information, own or at class level
- auth/oidc/tests/oidcclient_test.php
- (#36) PHPUnit testcase name "auth_oidc_oidcclient_testcase" does not match file name "oidcclient_test"
- (#36) PHPUnit class "auth_oidc_oidcclient_testcase" does not have any namespace. It is recommended to add it to the "auth_oidc" namespace, using more levels if needed, in order to match the code being tested
- (#48) Test method test_creds_getters_and_setters() is missing any coverage information, own or at class level
- (#61) Commas (,) must be followed by white space.
- (#112) Test method test_endpoints_getters_and_setters() is missing any coverage information, own or at class level
- auth/oidc/tests/privacy_provider_test.php
- (#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
- (#38) PHPUnit testcase name "auth_oidc_privacy_testcase" does not match file name "privacy_provider_test"
- (#38) PHPUnit class "auth_oidc_privacy_testcase" does not have any namespace. It is recommended to add it to the "auth_oidc" namespace, using more levels if needed, in order to match the code being tested
- (#51) Test method test_get_contexts_for_userid() is missing any coverage information, own or at class level
- (#71) Test method test_get_users_in_context() is missing any coverage information, own or at class level
- (#104) Test method test_export_user_data() is missing any coverage information, own or at class level
- (#136) Test method test_delete_data_for_all_users_in_context() is missing any coverage information, own or at class level
- (#167) Test method test_delete_data_for_user() is missing any coverage information, own or at class level
- (#199) Test method test_delete_data_for_users() is missing any coverage information, own or at class level
- (#265) The static declaration must come after the visibility declaration
- (#290) The static declaration must come after the visibility declaration
Javascript coding style problems
(1 errors, 6 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
- auth/oidc/js/module.js
- (#1) Expected space or tab after '/*' in comment. (spaced-comment)
- (#1) 'M' is already defined as a built-in global variable. (no-redeclare)
- (#1) 'sessionStorage' is already defined as a built-in global variable. (no-redeclare)
- (#1) 'sessionStorage' is defined but never used. (no-unused-vars)
- (#3) Identifier 'auth_oidc' is not in camel case. (camelcase)
- (#5) Identifier 'idptype_ms' is not in camel case. (camelcase)
- (#13) Identifier 'idptype_ms' is not in camel case. (camelcase)
CSS problems
(2 errors, 0 warnings)
This section shows CSS problems detected by stylelint [More info]
- auth/oidc/classes/adminsetting/iconselect.css
- (#2) Unexpected !important (declaration-no-important)
- (#3) Unexpected !important (declaration-no-important)
PHPDocs style problems
(24 errors, 0 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- auth/oidc/classes/adminsetting/auth_oidc_admin_setting_label.php
- (#36) Variable auth_oidc_admin_setting_label::$label is not documented
- (#41) Phpdocs for function auth_oidc_admin_setting_label::__construct has incomplete parameters list
- auth/oidc/classes/adminsetting/auth_oidc_admin_setting_redirecturi.php
- (#36) Variable auth_oidc_admin_setting_redirecturi::$url is not documented
- (#41) Phpdocs for function auth_oidc_admin_setting_redirecturi::__construct has incomplete parameters list
- auth/oidc/classes/form/application.php
- (#143) Phpdocs for function application::validation has incomplete parameters list
- auth/oidc/classes/loginflow/authcode.php
- (#203) There is no description in phpdocs for function handlecertadminconsentresponse
- (#479) Phpdocs for function authcode::check_for_matched has incomplete parameters list
- auth/oidc/classes/loginflow/base.php
- (#91) Phpdocs for function base::loginpage_hook has incomplete parameters list
- (#326) Phpdocs for function base::disconnect has incomplete parameters list
- auth/oidc/classes/loginflow/rocreds.php
- (#63) Phpdocs for function rocreds::loginpage_hook has incomplete parameters list
- auth/oidc/classes/observers.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/oidcclient.php
- (#157) Phpdocs for function oidcclient::get_endpoint has incomplete parameters list
- auth/oidc/lib.php
- (#30) Constant AUTH_OIDC_IDP_TYPE_AZURE_AD is not documented
- (#31) Constant AUTH_OIDC_IDP_TYPE_MICROSOFT is not documented
- (#32) Constant AUTH_OIDC_IDP_TYPE_OTHER is not documented
- (#35) Constant AUTH_OIDC_AAD_ENDPOINT_VERSION_UNKNOWN is not documented
- (#36) Constant AUTH_OIDC_AAD_ENDPOINT_VERSION_1 is not documented
- (#37) Constant AUTH_OIDC_AAD_ENDPOINT_VERSION_2 is not documented
- (#40) Constant AUTH_OIDC_AUTH_METHOD_SECRET is not documented
- (#41) Constant AUTH_OIDC_AUTH_METHOD_CERTIFICATE is not documented
- (#46) Phpdocs for function auth_oidc_initialize_customicon has incomplete parameters list
- (#522) Phpdocs for function auth_oidc_determine_endpoint_version has incomplete parameters list
- auth/oidc/tests/jwt_test.php
- (#111) Phpdocs for function auth_oidc_jwt_testcase::test_decode has incomplete parameters list
- auth/oidc/tests/oidcclient_test.php
- (#109) Phpdocs for function auth_oidc_oidcclient_testcase::test_endpoints_getters_and_setters has incomplete parameters list
Update savepoints problems
(0 errors, 0 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
grunt changes
(0 errors, 0 warnings)
This section shows files built by grunt and not commited [More info]
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(0 errors, 0 warnings)
This section shows problems detected in mustache templates [More info]
Gherkin .feature problems
(0 errors, 0 warnings)
This section shows problems detected in behat .feature files [More info]