Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(7 errors, 30 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/oidc/classes/adminsetting/auth_oidc_admin_setting_iconselect.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/adminsetting/auth_oidc_admin_setting_label.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/adminsetting/auth_oidc_admin_setting_loginflow.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/adminsetting/auth_oidc_admin_setting_redirecturi.php
(#30) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/event/action_failed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/event/user_authed.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/event/user_connected.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/event/user_created.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/event/user_disconnected.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/event/user_loggedin.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/httpclientinterface.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/jwt.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/loginflow/authcode.php
(#121) Logical operator "and" is prohibited; use "&&" instead
auth/oidc/classes/task/cleanup_oidc_state_and_token.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/tests/mockhttpclient.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/tests/mockoidcclient.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
auth/oidc/classes/utils.php
(#28) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#108) The use of function print_r() is forbidden
(#110) The use of function print_r() is forbidden
auth/oidc/index.php
(#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
auth/oidc/lib.php
(#27) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#43) Logical operator "or" is prohibited; use "||" instead
auth/oidc/logout.php
(#26) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
(#36) Inline comments must start with a capital letter, digit or 3-dots sequence
(#36) Inline comments must end in full-stops, exclamation marks, or question marks
(#37) Expected "foreach (...) {\n"; found "foreach(...) {\n"
auth/oidc/settings.php
(#113) Expected 1 space after "="; 2 found
auth/oidc/tests/jwt_test.php
(#36) PHPUnit testcase name "auth_oidc_jwt_testcase" does not match file name "jwt_test"
(#36) PHPUnit class "auth_oidc_jwt_testcase" does not have any namespace. It is recommended to add it to the "auth_oidc" namespace, using more levels if needed, in order to match the code being tested
auth/oidc/tests/oidcclient_test.php
(#36) PHPUnit testcase name "auth_oidc_oidcclient_testcase" does not match file name "oidcclient_test"
(#36) PHPUnit class "auth_oidc_oidcclient_testcase" does not have any namespace. It is recommended to add it to the "auth_oidc" namespace, using more levels if needed, in order to match the code being tested
(#61) Commas (,) must be followed by white space.
auth/oidc/tests/privacy_provider_test.php
(#26) Unexpected MOODLE_INTERNAL check. No side effects or multiple artifacts detected.
(#38) PHPUnit testcase name "auth_oidc_privacy_testcase" does not match file name "privacy_provider_test"
(#38) PHPUnit class "auth_oidc_privacy_testcase" does not have any namespace. It is recommended to add it to the "auth_oidc" namespace, using more levels if needed, in order to match the code being tested
(#265) The static declaration must come after the visibility declaration
(#290) The static declaration must come after the visibility declaration

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(2 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

auth/oidc/classes/adminsetting/iconselect.css
(#2) Unexpected !important (declaration-no-important)
(#3) Unexpected !important (declaration-no-important)

PHPDocs style problems

(13 errors, 0 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

auth/oidc/classes/adminsetting/auth_oidc_admin_setting_label.php
(#36) Variable auth_oidc_admin_setting_label::$label is not documented
(#41) Phpdocs for function auth_oidc_admin_setting_label::__construct has incomplete parameters list
auth/oidc/classes/adminsetting/auth_oidc_admin_setting_redirecturi.php
(#36) Variable auth_oidc_admin_setting_redirecturi::$url is not documented
(#41) Phpdocs for function auth_oidc_admin_setting_redirecturi::__construct has incomplete parameters list
auth/oidc/classes/loginflow/authcode.php
(#384) Phpdocs for function authcode::check_for_matched has incomplete parameters list
auth/oidc/classes/loginflow/base.php
(#88) Phpdocs for function base::loginpage_hook has incomplete parameters list
(#268) Phpdocs for function base::disconnect has incomplete parameters list
auth/oidc/classes/loginflow/rocreds.php
(#63) Phpdocs for function rocreds::loginpage_hook has incomplete parameters list
auth/oidc/classes/observers.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/oidcclient.php
(#154) Phpdocs for function oidcclient::get_endpoint has incomplete parameters list
auth/oidc/lib.php
(#32) Phpdocs for function auth_oidc_initialize_customicon has incomplete parameters list
auth/oidc/tests/jwt_test.php
(#111) Phpdocs for function auth_oidc_jwt_testcase::test_decode has incomplete parameters list
auth/oidc/tests/oidcclient_test.php
(#109) Phpdocs for function auth_oidc_oidcclient_testcase::test_endpoints_getters_and_setters has incomplete parameters list

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:css" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]


Gherkin .feature problems

(0 errors, 0 warnings)

This section shows problems detected in behat .feature files [More info]