Prechecker results: error


PHP lint problems

(0 errors, 0 warnings)

This section shows php lint problems in the code detected by php -l [More info]


PHP coding style problems

(18 errors, 30 warnings)

This section shows the coding style problems detected in the code by phpcs [More info]

auth/oidc/auth.php
(#43) Variable "STATEADDITIONALDATA" must be all lower-case
(#46) Variable "STATEADDITIONALDATA" must be all lower-case
(#46) Variable "STATEADDITIONALDATA" must be all lower-case
(#47) Variable "STATEADDITIONALDATA" must be all lower-case
(#94) Inline comments must start with a capital letter, digit or 3-dots sequence
(#95) Inline comments must end in full-stops, exclamation marks, or question marks
auth/oidc/classes/event/action_failed.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/classes/event/user_authed.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/classes/event/user_connected.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/classes/event/user_created.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/classes/event/user_disconnected.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/classes/event/user_loggedin.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/classes/form/adminsetting/iconselect.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
(#90) Line exceeds 132 characters; contains 150 characters
auth/oidc/classes/form/adminsetting/loginflow.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/classes/form/adminsetting/redirecturi.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/classes/httpclient.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
auth/oidc/classes/httpclientinterface.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/classes/jwt.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/classes/loginflow/authcode.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
(#171) Variable "STATEADDITIONALDATA" must be all lower-case
(#201) Variable "STATEADDITIONALDATA" must be all lower-case
(#420) Inline comments must end in full-stops, exclamation marks, or question marks
(#425) Inline comments must end in full-stops, exclamation marks, or question marks
(#441) Expected 1 space before comment text but found 5; use block comment if you need indentation
(#442) Expected 1 space before comment text but found 5; use block comment if you need indentation
auth/oidc/classes/loginflow/base.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion
(#199) Line exceeds 132 characters; contains 139 characters
(#231) Line exceeds 132 characters; contains 133 characters
auth/oidc/classes/loginflow/rocreds.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
(#118) The use of function error_log() is forbidden
auth/oidc/classes/observers.php
(#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
auth/oidc/classes/oidcclient.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/classes/privacy/provider.php
(#31) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
(#32) Closing brace must be on a line by itself
(#34) Duplicate interface name "auth_oidc\privacy\auth_oidc_userlist" found; first defined in /var/lib/jenkins/git_repositories/prechecker/auth/oidc/classes/privacy/provider.php on line 32
(#34) Closing brace must be on a line by itself
auth/oidc/classes/tests/mockhttpclient.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/classes/tests/mockoidcclient.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
(#39) Possible useless method overriding detected
auth/oidc/classes/utils.php
(#29) Expected MOODLE_INTERNAL check or config.php inclusion
(#104) The use of function print_r() is forbidden
(#106) The use of function print_r() is forbidden
auth/oidc/db/events.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
auth/oidc/db/upgrade.php
(#30) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/index.php
(#24) Expected login check (require_login, require_course_login, admin_externalpage_setup) following config inclusion. None found.
auth/oidc/lib.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion
auth/oidc/settings.php
(#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.

Javascript coding style problems

(0 errors, 0 warnings)

This section shows the coding style problems detected in the code by eslint [More info]


CSS problems

(21 errors, 0 warnings)

This section shows CSS problems detected by stylelint [More info]

auth/oidc/classes/form/adminsetting/iconselect.css
(#2) Unexpected !important (declaration-no-important)
(#3) Unexpected !important (declaration-no-important)
auth/oidc/sass/styles.scss
(#2) Expected indentation of 4 spaces (indentation)
(#5) Expected indentation of 4 spaces (indentation)
(#3) Expected indentation of 8 spaces (indentation)
(#4) Expected indentation of 8 spaces (indentation)
(#6) Expected indentation of 4 spaces (indentation)
(#12) Expected indentation of 4 spaces (indentation)
(#7) Expected indentation of 8 spaces (indentation)
(#8) Expected indentation of 8 spaces (indentation)
(#9) Expected indentation of 8 spaces (indentation)
(#11) Expected indentation of 8 spaces (indentation)
(#10) Expected indentation of 12 spaces (indentation)
auth/oidc/styles.css
(#3) Expected newline before "}" (block-closing-brace-newline-before)
(#6) Expected newline before "}" (block-closing-brace-newline-before)
(#8) Expected newline before "}" (block-closing-brace-newline-before)
(#2) Expected indentation of 4 spaces (indentation)
(#3) Expected indentation of 4 spaces (indentation)
(#5) Expected indentation of 4 spaces (indentation)
(#6) Expected indentation of 4 spaces (indentation)
(#7) Expected indentation of 0 spaces (indentation)

PHPDocs style problems

(80 errors, 2 warnings)

This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]

auth/oidc/auth.php
(#17) No one-line description found in phpdocs for file
(#39) Phpdocs for function auth_plugin_oidc::__construct has incomplete parameters list
(#80) Phpdocs for function auth_plugin_oidc::set_httpclient has incomplete parameters list
(#111) Phpdocs for function auth_plugin_oidc::disconnect has incomplete parameters list
(#90) Not recommended phpdocs tag @global used
(#90) Not recommended phpdocs tag @global used
auth/oidc/classes/event/action_failed.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/event/user_authed.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/event/user_connected.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/event/user_created.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/event/user_disconnected.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/event/user_loggedin.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/form/adminsetting/iconselect.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/form/adminsetting/loginflow.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/form/adminsetting/redirecturi.php
(#17) No one-line description found in phpdocs for file
(#34) Phpdocs for function redirecturi::__construct has incomplete parameters list
(#63) Phpdocs for function redirecturi::write_setting has incomplete parameters list
(#72) Phpdocs for function redirecturi::output_html has incomplete parameters list
auth/oidc/classes/form/disconnect.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/httpclient.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/httpclientinterface.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/jwt.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/loginflow/authcode.php
(#17) No one-line description found in phpdocs for file
(#366) Phpdocs for function authcode::check_for_matched has incomplete parameters list
auth/oidc/classes/loginflow/base.php
(#26) Class base is not documented
(#33) Function base::__construct is not documented
(#17) No one-line description found in phpdocs for file
(#78) Phpdocs for function base::loginpage_hook has incomplete parameters list
(#143) Phpdocs for function base::set_httpclient has incomplete parameters list
(#152) Phpdocs for function base::disconnect has incomplete parameters list
(#431) Phpdocs for function base::createtoken has incomplete parameters list
auth/oidc/classes/loginflow/rocreds.php
(#17) No one-line description found in phpdocs for file
(#32) Phpdocs for function rocreds::check_objects has incomplete parameters list
(#55) Phpdocs for function rocreds::loginpage_hook has incomplete parameters list
auth/oidc/classes/observers.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/oidcclient.php
(#118) Function oidcclient::get_endpoint is not documented
(#17) No one-line description found in phpdocs for file
(#57) Phpdocs for function oidcclient::setcreds has incomplete parameters list
(#159) Phpdocs for function oidcclient::getnewstate has incomplete parameters list
(#234) Phpdocs for function oidcclient::tokenrequest has incomplete parameters list
auth/oidc/classes/privacy/provider.php
(#37) Class provider is not documented
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/tests/mockhttpclient.php
(#17) No one-line description found in phpdocs for file
auth/oidc/classes/tests/mockoidcclient.php
(#17) No one-line description found in phpdocs for file
(#36) Phpdocs for function mockoidcclient::getnewstate has incomplete parameters list
auth/oidc/classes/utils.php
(#17) No one-line description found in phpdocs for file
(#34) Phpdocs for function utils::process_json_response has incomplete parameters list
(#113) Phpdocs for function utils::debug has incomplete parameters list
auth/oidc/db/access.php
(#17) No one-line description found in phpdocs for file
auth/oidc/db/events.php
(#17) No one-line description found in phpdocs for file
auth/oidc/db/upgrade.php
(#17) No one-line description found in phpdocs for file
auth/oidc/index.php
(#17) No one-line description found in phpdocs for file
auth/oidc/lang/cs/auth_oidc.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @copyright tag
auth/oidc/lang/de/auth_oidc.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @copyright tag
auth/oidc/lang/en/auth_oidc.php
(#17) No one-line description found in phpdocs for file
auth/oidc/lang/es/auth_oidc.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @copyright tag
auth/oidc/lang/fi/auth_oidc.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @copyright tag
auth/oidc/lang/fr/auth_oidc.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @copyright tag
auth/oidc/lang/it/auth_oidc.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @copyright tag
auth/oidc/lang/ja/auth_oidc.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @copyright tag
auth/oidc/lang/nl/auth_oidc.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @copyright tag
auth/oidc/lang/pl/auth_oidc.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @copyright tag
auth/oidc/lang/pt_br/auth_oidc.php
(#17) No one-line description found in phpdocs for file
(#17) File-level phpdocs block does not have @copyright tag
auth/oidc/lib.php
(#24) Function auth_oidc_initialize_customicon is not documented
(#17) No one-line description found in phpdocs for file
auth/oidc/settings.php
(#17) No one-line description found in phpdocs for file
auth/oidc/tests/jwt_test.php
(#17) No one-line description found in phpdocs for file
(#109) Phpdocs for function auth_oidc_jwt_testcase::test_decode has incomplete parameters list
auth/oidc/tests/oidcclient_test.php
(#17) No one-line description found in phpdocs for file
(#102) Phpdocs for function auth_oidc_oidcclient_testcase::test_endpoints_getters_and_setters has incomplete parameters list
auth/oidc/ucp.php
(#17) No one-line description found in phpdocs for file
auth/oidc/version.php
(#17) No one-line description found in phpdocs for file

Update savepoints problems

(0 errors, 0 warnings)

This section shows problems detected with the handling of upgrade savepoints [More info]


Third party library modification problems

(0 errors, 0 warnings)

This section shows problems detected with the modification of third party libraries [More info]


grunt changes

(1 errors, 1 warnings)

This section shows files built by grunt and not commited [More info]

Problems running grunt
Task "stylelint:scss" failed. Use --force to continue.

shifter problems

(0 errors, 0 warnings)

This section shows problems detected by shifter [More info]


Mustache template problems

(0 errors, 0 warnings)

This section shows problems detected in mustache templates [More info]