PHP lint problems
(0 errors, 0 warnings)
This section shows php lint problems in the code detected by php -l [More info]
PHP coding style problems
(28 errors, 9 warnings)
This section shows the coding style problems detected in the code by phpcs [More info]
- auth/oidc/auth.php
- (#46) Variable "STATEADDITIONALDATA" must be all lower-case
- (#49) Variable "STATEADDITIONALDATA" must be all lower-case
- (#49) Variable "STATEADDITIONALDATA" must be all lower-case
- (#50) Variable "STATEADDITIONALDATA" must be all lower-case
- (#97) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#97) Inline comments must end in full-stops, exclamation marks, or question marks
- (#98) Inline comments must start with a capital letter, digit or 3-dots sequence
- (#98) Inline comments must end in full-stops, exclamation marks, or question marks
- (#106) Expected 5 space(s) before asterisk; 6 found
- (#107) Expected 5 space(s) before asterisk; 6 found
- (#108) Expected 5 space(s) before asterisk; 6 found
- (#109) Expected 5 space(s) before asterisk; 6 found
- (#120) Inline comments must end in full-stops, exclamation marks, or question marks
- auth/oidc/classes/adminsetting/auth_oidc_admin_setting_label.php
- (#82) File must end with a newline character
- auth/oidc/classes/httpclient.php
- (#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
- auth/oidc/classes/loginflow/authcode.php
- (#178) Variable "STATEADDITIONALDATA" must be all lower-case
- (#208) Variable "STATEADDITIONALDATA" must be all lower-case
- (#427) Inline comments must end in full-stops, exclamation marks, or question marks
- (#474) Expected 1 space before comment text but found 5; use block comment if you need indentation
- (#475) Expected 1 space before comment text but found 5; use block comment if you need indentation
- auth/oidc/classes/loginflow/rocreds.php
- (#126) The use of function error_log() is forbidden; use debugging() instead
- auth/oidc/classes/observers.php
- (#26) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
- auth/oidc/classes/oidcclient.php
- (#166) Expected 1 space after "=>"; 2 found
- auth/oidc/classes/privacy/provider.php
- (#31) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
- (#32) Closing brace must be on a line by itself
- (#34) Duplicate interface name "auth_oidc\privacy\auth_oidc_userlist" found; first defined in /var/lib/jenkins/git_repositories/prechecker/auth/oidc/classes/privacy/provider.php on line 32
- (#34) Closing brace must be on a line by itself
- auth/oidc/classes/tests/mockoidcclient.php
- (#39) Possible useless method overriding detected
- auth/oidc/classes/utils.php
- (#104) The use of function print_r() is forbidden
- (#106) The use of function print_r() is forbidden
- (#136) File must end with a newline character
- auth/oidc/db/events.php
- (#24) Expected MOODLE_INTERNAL check or config.php inclusion. Change in global state detected.
- (#31) File must end with a newline character
- auth/oidc/index.php
- (#24) Expected login check (require_login, require_course_login, require_admin, admin_externalpage_setup) following config inclusion. None found.
- auth/oidc/lib.php
- (#259) Functions must not contain multiple empty lines in a row; found 2 empty lines
- auth/oidc/tests/privacy_provider_test.php
- (#265) The static declaration must come after the visibility declaration
- (#290) The static declaration must come after the visibility declaration
Javascript coding style problems
(0 errors, 0 warnings)
This section shows the coding style problems detected in the code by eslint [More info]
CSS problems
(21 errors, 0 warnings)
This section shows CSS problems detected by stylelint [More info]
- auth/oidc/styles.css
- (#3) Expected newline before "}" (block-closing-brace-newline-before)
- (#6) Expected newline before "}" (block-closing-brace-newline-before)
- (#8) Expected newline before "}" (block-closing-brace-newline-before)
- (#2) Expected indentation of 4 spaces (indentation)
- (#3) Expected indentation of 4 spaces (indentation)
- (#5) Expected indentation of 4 spaces (indentation)
- (#6) Expected indentation of 4 spaces (indentation)
- (#7) Expected indentation of 0 spaces (indentation)
- auth/oidc/sass/styles.scss
- (#2) Expected indentation of 4 spaces (indentation)
- (#5) Expected indentation of 4 spaces (indentation)
- (#3) Expected indentation of 8 spaces (indentation)
- (#4) Expected indentation of 8 spaces (indentation)
- (#6) Expected indentation of 4 spaces (indentation)
- (#12) Expected indentation of 4 spaces (indentation)
- (#7) Expected indentation of 8 spaces (indentation)
- (#8) Expected indentation of 8 spaces (indentation)
- (#9) Expected indentation of 8 spaces (indentation)
- (#11) Expected indentation of 8 spaces (indentation)
- (#10) Expected indentation of 12 spaces (indentation)
- auth/oidc/classes/adminsetting/iconselect.css
- (#2) Unexpected !important (declaration-no-important)
- (#3) Unexpected !important (declaration-no-important)
PHPDocs style problems
(80 errors, 2 warnings)
This section shows the phpdocs problems detected in the code by local_moodlecheck [More info]
- auth/oidc/auth.php
- (#17) No one-line description found in phpdocs for file
- (#42) Phpdocs for function auth_plugin_oidc::__construct has incomplete parameters list
- (#83) Phpdocs for function auth_plugin_oidc::set_httpclient has incomplete parameters list
- (#171) Phpdocs for function auth_plugin_oidc::disconnect has incomplete parameters list
- (#93) Not recommended phpdocs tag @global used
- (#93) Not recommended phpdocs tag @global used
- auth/oidc/classes/adminsetting/auth_oidc_admin_setting_iconselect.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/adminsetting/auth_oidc_admin_setting_label.php
- (#33) Package auth_oidc\adminsetting is not valid
- (#36) Variable auth_oidc_admin_setting_label::$label is not documented
- (#17) No one-line description found in phpdocs for file
- (#41) Phpdocs for function auth_oidc_admin_setting_label::__construct has incomplete parameters list
- auth/oidc/classes/adminsetting/auth_oidc_admin_setting_loginflow.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/adminsetting/auth_oidc_admin_setting_redirecturi.php
- (#17) No one-line description found in phpdocs for file
- (#38) Phpdocs for function auth_oidc_admin_setting_redirecturi::__construct has incomplete parameters list
- (#67) Phpdocs for function auth_oidc_admin_setting_redirecturi::write_setting has incomplete parameters list
- (#76) Phpdocs for function auth_oidc_admin_setting_redirecturi::output_html has incomplete parameters list
- auth/oidc/classes/event/action_failed.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/event/user_authed.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/event/user_connected.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/event/user_created.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/event/user_disconnected.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/event/user_loggedin.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/form/disconnect.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/httpclient.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/httpclientinterface.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/jwt.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/loginflow/authcode.php
- (#17) No one-line description found in phpdocs for file
- (#373) Phpdocs for function authcode::check_for_matched has incomplete parameters list
- auth/oidc/classes/loginflow/base.php
- (#31) Class base is not documented
- (#38) Function base::__construct is not documented
- (#17) No one-line description found in phpdocs for file
- (#77) Phpdocs for function base::loginpage_hook has incomplete parameters list
- (#190) Phpdocs for function base::set_httpclient has incomplete parameters list
- (#199) Phpdocs for function base::disconnect has incomplete parameters list
- auth/oidc/classes/loginflow/rocreds.php
- (#17) No one-line description found in phpdocs for file
- (#61) Phpdocs for function rocreds::loginpage_hook has incomplete parameters list
- auth/oidc/classes/observers.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/oidcclient.php
- (#149) Function oidcclient::get_endpoint is not documented
- (#49) Variable oidcclient::$tokenresource is not documented
- (#17) No one-line description found in phpdocs for file
- (#190) Phpdocs for function oidcclient::getnewstate has incomplete parameters list
- auth/oidc/classes/privacy/provider.php
- (#37) Class provider is not documented
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/task/cleanup_oidc_state_and_token.php
- (#32) Class cleanup_oidc_state_and_token is not documented
- auth/oidc/classes/tests/mockhttpclient.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/classes/tests/mockoidcclient.php
- (#17) No one-line description found in phpdocs for file
- (#36) Phpdocs for function mockoidcclient::getnewstate has incomplete parameters list
- auth/oidc/classes/utils.php
- (#17) No one-line description found in phpdocs for file
- (#34) Phpdocs for function utils::process_json_response has incomplete parameters list
- (#113) Phpdocs for function utils::debug has incomplete parameters list
- auth/oidc/db/access.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/db/events.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/db/upgrade.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/index.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/lang/cs/auth_oidc.php
- (#17) No one-line description found in phpdocs for file
- (#17) File-level phpdocs block does not have @copyright tag
- auth/oidc/lang/de/auth_oidc.php
- (#17) No one-line description found in phpdocs for file
- (#17) File-level phpdocs block does not have @copyright tag
- auth/oidc/lang/es/auth_oidc.php
- (#17) No one-line description found in phpdocs for file
- (#17) File-level phpdocs block does not have @copyright tag
- auth/oidc/lang/fi/auth_oidc.php
- (#17) No one-line description found in phpdocs for file
- (#17) File-level phpdocs block does not have @copyright tag
- auth/oidc/lang/fr/auth_oidc.php
- (#17) No one-line description found in phpdocs for file
- (#17) File-level phpdocs block does not have @copyright tag
- auth/oidc/lang/it/auth_oidc.php
- (#17) No one-line description found in phpdocs for file
- (#17) File-level phpdocs block does not have @copyright tag
- auth/oidc/lang/ja/auth_oidc.php
- (#17) No one-line description found in phpdocs for file
- (#17) File-level phpdocs block does not have @copyright tag
- auth/oidc/lang/nl/auth_oidc.php
- (#17) No one-line description found in phpdocs for file
- (#17) File-level phpdocs block does not have @copyright tag
- auth/oidc/lang/pl/auth_oidc.php
- (#17) No one-line description found in phpdocs for file
- (#17) File-level phpdocs block does not have @copyright tag
- auth/oidc/lang/pt_br/auth_oidc.php
- (#17) No one-line description found in phpdocs for file
- (#17) File-level phpdocs block does not have @copyright tag
- auth/oidc/lib.php
- (#27) Function auth_oidc_initialize_customicon is not documented
- (#17) No one-line description found in phpdocs for file
- auth/oidc/tests/jwt_test.php
- (#17) No one-line description found in phpdocs for file
- (#109) Phpdocs for function auth_oidc_jwt_testcase::test_decode has incomplete parameters list
- auth/oidc/tests/oidcclient_test.php
- (#17) No one-line description found in phpdocs for file
- (#102) Phpdocs for function auth_oidc_oidcclient_testcase::test_endpoints_getters_and_setters has incomplete parameters list
- auth/oidc/ucp.php
- (#17) No one-line description found in phpdocs for file
- auth/oidc/version.php
- (#17) No one-line description found in phpdocs for file
Update savepoints problems
(0 errors, 1 warnings)
This section shows problems detected with the handling of upgrade savepoints [More info]
- auth/oidc/db/upgrade.php
- Detected fewer 'if' blocks (2) than 'savepoint' calls (5). Repeated savepoints?
Third party library modification problems
(0 errors, 0 warnings)
This section shows problems detected with the modification of third party libraries [More info]
grunt changes
(1 errors, 1 warnings)
This section shows files built by grunt and not commited [More info]
- Problems running grunt
- Task "stylelint:scss" failed. Use --force to continue.
shifter problems
(0 errors, 0 warnings)
This section shows problems detected by shifter [More info]
Mustache template problems
(0 errors, 0 warnings)
This section shows problems detected in mustache templates [More info]
Gherkin .feature problems
(0 errors, 0 warnings)
This section shows problems detected in behat .feature files [More info]